Received: (at 60369) by debbugs.gnu.org; 31 Jan 2023 22:42:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 31 17:42:31 2023 Received: from localhost ([127.0.0.1]:55273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pMzKh-0008H8-7m for submit <at> debbugs.gnu.org; Tue, 31 Jan 2023 17:42:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1pMzKf-0008Gv-Gc for 60369 <at> debbugs.gnu.org; Tue, 31 Jan 2023 17:42:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1pMzKa-0007Dj-6O; Tue, 31 Jan 2023 17:42:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Bqc/PEssUIhiJ6n2DdIGhoAY0/hvIteMkvNsb8OG2gM=; b=m5aTNeJJRL06uLsHzjtM tRbJIGS5yMFTgB7u9XOM2kniTwx89Jt6a/Qn+0yb4vOpIwKeaiEM3gOzmdMxu2XRNSsGg2AkPu40Z /KqrKnqVx2nOVrKY9b9LJX5sFsoiOMBo7ksdj8Eu49wc2Bk3qBHMlGRAoWOjPSWpA1fZIfaJmDSRo HPNgXCci7fVqQxQ8TfEmB22qHezCBpw7qxD20WTHVgmPH70Vu/cZk01R09miHQ6NMP5+26hXltwxL CEzbnPGtVi1DgptWCAbRNh92TfHgQwahA1CFJAF6iMGEgKA4VhHw3Tc2INrWYJW+QIMPQYw8mn301 Af23Nll3+9KjJg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1pMzKZ-0007OT-P2; Tue, 31 Jan 2023 17:42:24 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Simon Josefsson <simon@HIDDEN> Subject: Re: bug#60369: [PATCH] gnu: Add eweouz. References: <871qok1n2m.fsf@HIDDEN> Date: Tue, 31 Jan 2023 23:42:22 +0100 In-Reply-To: <871qok1n2m.fsf@HIDDEN> (Simon Josefsson's message of "Tue, 27 Dec 2022 23:47:13 +0100") Message-ID: <877cx2s4vl.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60369 Cc: 60369 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi Simon, Simon Josefsson <simon@HIDDEN> skribis: > While the package builds and works for me, I would appreciate a review > so I can learn -- I wrote this without understanding anything of what I > was doing, but merely pattern-matched things against other existing > packages that looked relevant. Let=E2=80=99s see. > From 52b0ad49ef0436346f53bebee4690961fba9cf90 Mon Sep 17 00:00:00 2001 > From: Simon Josefsson <simon@HIDDEN> > Date: Tue, 27 Dec 2022 23:38:33 +0100 > Subject: [PATCH] gnu: Add eweouz. > > * gnu/packages/emacs-xyz.scm (eweouz): New variable. [...] > +(define-public eweouz > + (package > + (name "eweouz") Rather =E2=80=9Cemacs-eweouz=E2=80=9D (info "(guix) Package Naming"). > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f Please add a short comment saying why tests are disabled. > + (modify-phases %standard-phases > + (replace 'bootstrap > + (lambda _ (invoke "autoreconf" "-vif") #t)) Is this needed? The default =E2=80=98bootstrap=E2=80=99 phase does that, r= oughly. You can omit the trailing #t too. > + (synopsis "Emacs interface to Evolution Data Server") > + (description > + "eweouz is an tool for looking up contacts from Evolution Data Serv= er > +from Emacs. It is similar to BBDB, except much, much simpler.") > + (license license:gpl2))) Might be =E2=80=98gpl2+=E2=80=99, unless it explicitly states =E2=80=9Cvers= ion 2 only=E2=80=9D. That=E2=80=99s all I have to say! Overall it=E2=80=99s looking good. :-) Could you send an updated patch? Thanks, Ludo=E2=80=99.
guix-patches@HIDDEN:bug#60369; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 27 Dec 2022 22:47:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 27 17:47:23 2022
Received: from localhost ([127.0.0.1]:56727 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pAIjD-0001Rw-62
for submit <at> debbugs.gnu.org; Tue, 27 Dec 2022 17:47:23 -0500
Received: from lists.gnu.org ([209.51.188.17]:56758)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <simon@HIDDEN>) id 1pAIjB-0001Rn-Pm
for submit <at> debbugs.gnu.org; Tue, 27 Dec 2022 17:47:22 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <simon@HIDDEN>)
id 1pAIjB-0006Ib-Km
for guix-patches@HIDDEN; Tue, 27 Dec 2022 17:47:21 -0500
Received: from uggla.sjd.se ([2001:9b1:8633::107])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <simon@HIDDEN>)
id 1pAIj9-0000Zj-36
for guix-patches@HIDDEN; Tue, 27 Dec 2022 17:47:21 -0500
DKIM-Signature: v=1; a=ed25519-sha256; q=dns/txt; c=relaxed/relaxed;
d=josefsson.org; s=ed2110; h=Content-Type:MIME-Version:Message-ID:Date:
Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:
Content-Description; bh=PZixA49SZBmsXr68IqQeCH8uBZC1BlxGDz8a+5Y+/KI=;
t=1672181238; x=1673390838; b=1P6RoYKW/mo+OKof5/VG2meGTXPBrt+yGY0nO58aO9wW6Hk
GdFS9RwhNf+Q7gSwgvkT4RfXDMboD2uwG0ajyAQ==;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=josefsson.org; s=rsa2110; h=Content-Type:MIME-Version:Message-ID:Date:
Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:
Content-Description; bh=PZixA49SZBmsXr68IqQeCH8uBZC1BlxGDz8a+5Y+/KI=;
t=1672181238; x=1673390838; b=NhotjsCpdl47KXR1fpf9utMaOcKNcStepSSTErMeglD7/cZ
rScdLqxBuLVTYfkZKNxQVd0OcU1RFadDbHxgg5dR0DFkgj2+Yz5BFTuj1SdXMMbop7z7Ty3y5ila9
nxCBTnr1vd86r7aWF0G184YjmIhI8Z6BbQX4cfo/8ZLL38OUdECIzW9cDWtpXE65lRXLYxD/Mfg5g
wqdMhGozfFu6IRAfrfVIJkQtlS4Oq4RSOi8ZcRKZaKe6v1Gq47RlXeLAcfMNsPYVJ+DxlGayH5sMP
IWnShiCZvWTAcsE2XVAxh6hvIUo/wfPcn6UPX3UDpWwGQhzaUuiiFdXOR1gNAuCucGFZUUHsg6Kz4
8TUbB8NryxWELy2/vNFgZVdiAi3eSDhSGHSvjyc1j4iDm/uOU/7/+V2D8NCwdc5Zd2pkGlfEZZks/
hWcAvYvDbGTaOerV7AyAxEeF;
Received: from [2001:9b1:41ac:ff00:67bf:136:16d3:4a37] (port=48878 helo=kaka)
by uggla.sjd.se with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
(envelope-from <simon@HIDDEN>) id 1pAIj4-006KxE-9B
for guix-patches@HIDDEN; Tue, 27 Dec 2022 23:47:14 +0100
X-Hashcash: 1:22:221227:guix-patches@HIDDEN::ToMs607j81OkOtKm:F9L5
From: Simon Josefsson <simon@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add eweouz.
OpenPGP: id=B1D2BD1375BECB784CF4F8C4D73CF638C53C06BE;
url=https://josefsson.org/key-20190320.txt
Date: Tue, 27 Dec 2022 23:47:13 +0100
Message-ID: <871qok1n2m.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
micalg=pgp-sha256; protocol="application/pgp-signature"
Received-SPF: pass client-ip=2001:9b1:8633::107;
envelope-from=simon@HIDDEN; helo=uggla.sjd.se
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="
--=-=-=
Content-Type: text/plain
Hi. This adds a GNOME Evolution Data Server interface to Emacs. Test
it by adding a contact to the EDS address book (e.g., through GNOME
Contacts) and then do 'emacs -q' and M-x eweouz RET and search for parts
of the name of the contact.
While the package builds and works for me, I would appreciate a review
so I can learn -- I wrote this without understanding anything of what I
was doing, but merely pattern-matched things against other existing
packages that looked relevant.
/Simon
--=-=-=
Content-Type: text/x-patch; charset=iso-8859-1
Content-Disposition: inline; filename=0001-gnu-Add-eweouz.patch
Content-Transfer-Encoding: quoted-printable
From=2052b0ad49ef0436346f53bebee4690961fba9cf90 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <simon@HIDDEN>
Date: Tue, 27 Dec 2022 23:38:33 +0100
Subject: [PATCH] gnu: Add eweouz.
* gnu/packages/emacs-xyz.scm (eweouz): New variable.
=2D--
gnu/packages/emacs-xyz.scm | 66 ++++++++++++++++++++++++++++++++++++++
1 file changed, 66 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index fb4c9b70f9..adb0689df1 100644
=2D-- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -119,6 +119,7 @@
;;; Copyright =A9 2022 Nicolas Graves <ngraves@HIDDEN>
;;; Copyright =A9 2022 Thiago Jung Bauermann <bauermann@HIDDEN>
;;; Copyright =A9 2022 Joeke de Graaf <joeke@HIDDEN>
+;;; Copyright =A9 2022 Simon Josefsson <simon@HIDDEN>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -3053,6 +3054,71 @@ (define-public emacs-bbdb-vcard
(BBDB). Version 2.1 vCards are converted into version 3.0 on import.")
(license license:gpl2+))))
=20
+(define-public eweouz
+ (package
+ (name "eweouz")
+ (version "0.12")
+ (source
+ (origin
+ (method url-fetch)
+ ;; README's git://git.err.no/eweouz is gone
+ (uri (string-append "mirror://debian/pool/main/e/eweouz/"
+ "eweouz_" version ".tar.xz"))
+ (file-name (string-append name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "192zl3dyphhvcrvn65bqsrc4h6zks8b747lp6pqbpbmsqy4g4mr8"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f
+ #:modules ((guix build gnu-build-system)
+ ((guix build emacs-build-system) #:prefix emacs:)
+ (guix build utils)
+ (guix build emacs-utils))
+ #:imported-modules (,@%gnu-build-system-modules
+ (guix build emacs-build-system)
+ (guix build emacs-utils))
+ #:configure-flags
+ (list (string-append "--with-lispdir=3D"
+ (emacs:elpa-directory %output)))
+ #:phases
+ (modify-phases %standard-phases
+ (replace 'bootstrap
+ (lambda _ (invoke "autoreconf" "-vif") #t))
+ (add-after 'compress-documentation 'enter-lisp-dir
+ (lambda _ (chdir "lisp/")))
+ (add-after 'enter-lisp-dir 'emacs-patch-variables
+ (lambda* (#:key outputs #:allow-other-keys)
+ (make-file-writable "eweouz.el")
+ (substitute* "eweouz.el"
+ (("\\(setq eweouz-helper-dirs '\\(")
+ (format #f "(setq eweouz-helper-dirs '(~s "
+ (string-append (assoc-ref outputs "out")
+ "/libexec/eweouz"))))))
+ (add-after 'emacs-patch-variables 'emacs-expand-load-path
+ (assoc-ref emacs:%standard-phases 'expand-load-path))
+ (add-after 'emacs-expand-load-path 'emacs-add-install-to-native-l=
oad-path
+ (assoc-ref emacs:%standard-phases 'add-install-to-native-load-p=
ath))
+ (add-after 'emacs-add-install-to-native-load-path 'emacs-install
+ (assoc-ref emacs:%standard-phases 'install))
+ (add-after 'emacs-install 'emacs-build
+ (assoc-ref emacs:%standard-phases 'build))
+ (add-after 'emacs-install 'emacs-make-autoloads
+ (assoc-ref emacs:%standard-phases 'make-autoloads)))))
+ (native-inputs
+ (list autoconf
+ automake
+ emacs-minimal
+ pkg-config))
+ (inputs
+ (list evolution-data-server))
+ (home-page "https://tracker.debian.org/pkg/eweouz")
+ (synopsis "Emacs interface to Evolution Data Server")
+ (description
+ "eweouz is an tool for looking up contacts from Evolution Data Server
+from Emacs. It is similar to BBDB, except much, much simpler.")
+ (license license:gpl2)))
+
(define-public emacs-beacon
(package
(name "emacs-beacon")
=2D-=20
2.38.1
--=-=-=--
--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iIoEARYIADIWIQSjzJyHC50xCrrUzy9RcisI/kdFogUCY6t18RQcc2ltb25Aam9z
ZWZzc29uLm9yZwAKCRBRcisI/kdFoqrmAPsF8U5PZ/etuWm9EKDJZ/8JGa8mCSsr
jZhpxqSqVsHlwAD/UwriKvfe9MkMRB7J2HlZFZ6tU9eLVrickE5Kn0Fi4AM=
=PH9t
-----END PGP SIGNATURE-----
--==-=-=--
Simon Josefsson <simon@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#60369; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.