GNU bug report logs - #60415
Emacs master doesn't build if !HAVE_TREE_SITTER

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60415 in the body.
You can then email your comments to 60415 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: Emacs master doesn't build if !HAVE_TREE_SITTER
Date: Thu, 29 Dec 2022 20:46:32 -0800

[Message part 1 (text/plain, inline)]

On my platform the current Emacs master (commit 
91ae9f3d12885373d38c3e8d693f7dc210f9d471) won't build, failing with:

  ELC      progmodes/typescript-ts-mode.elc

In toplevel form:
progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function 
definition is vo\
id: treesit-query-compile


Full log (compressed) attached, built from Git on Fedora 37 x86-64. The 
best fix isn't immediately obvious to me; adding a declare-function 
doesn't work.

This platform doesn't have the tree-sitter library, so HAVE_TREE_SITTER 
is not defined which means C doesn't define treesit-query-compile.

I will probably just install the tree-sitter library to work around the 
bug, but thought I'd document it. Presumably you can simulate it by 
configuring --without-tree-sitter.

[log.txt.gz (application/gzip, attachment)]

Message #8 received at 60415 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Yuan Fu <casouri <at> gmail.com>, 60415 <at> debbugs.gnu.org
Subject: Re: bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER
Date: Sun, 01 Jan 2023 09:09:26 +0800

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> On my platform the current Emacs master (commit
> 91ae9f3d12885373d38c3e8d693f7dc210f9d471) won't build, failing with:
>
>   ELC      progmodes/typescript-ts-mode.elc
>
> In toplevel form:
> progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function
> definition is vo\
> id: treesit-query-compile
>
>
> Full log (compressed) attached, built from Git on Fedora 37
> x86-64. The best fix isn't immediately obvious to me; adding a
> declare-function doesn't work.
>
> This platform doesn't have the tree-sitter library, so
> HAVE_TREE_SITTER is not defined which means C doesn't define
> treesit-query-compile.
>
> I will probably just install the tree-sitter library to work around
> the bug, but thought I'd document it. Presumably you can simulate it
> by configuring --without-tree-sitter.

Copying in Yuan Fu.

Would people please test their changes on an Emacs *WITHOUT* tree-sitter
before installing them in the future?

Message #11 received at 60415 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, 60415 <at> debbugs.gnu.org
Subject: Re: bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER
Date: Sat, 31 Dec 2022 18:18:39 -0800

> On Dec 31, 2022, at 5:09 PM, Po Lu <luangruo <at> yahoo.com> wrote:
> 
> Paul Eggert <eggert <at> cs.ucla.edu> writes:
> 
>> On my platform the current Emacs master (commit
>> 91ae9f3d12885373d38c3e8d693f7dc210f9d471) won't build, failing with:
>> 
>>   ELC      progmodes/typescript-ts-mode.elc
>> 
>> In toplevel form:
>> progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function
>> definition is vo\
>> id: treesit-query-compile
>> 
>> 
>> Full log (compressed) attached, built from Git on Fedora 37
>> x86-64. The best fix isn't immediately obvious to me; adding a
>> declare-function doesn't work.
>> 
>> This platform doesn't have the tree-sitter library, so
>> HAVE_TREE_SITTER is not defined which means C doesn't define
>> treesit-query-compile.
>> 
>> I will probably just install the tree-sitter library to work around
>> the bug, but thought I'd document it. Presumably you can simulate it
>> by configuring --without-tree-sitter.
> 
> Copying in Yuan Fu.
> 
> Would people please test their changes on an Emacs *WITHOUT* tree-sitter
> before installing them in the future?

Yeah I’ve setup a no-tree-sitter build so I could catch these in the future. Sorry for the inconvenience.

Yuan

Message #16 received at 60415-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>
Cc: Po Lu <luangruo <at> yahoo.com>, 60415-done <at> debbugs.gnu.org,
 Paul Eggert <eggert <at> cs.ucla.edu>
Subject: Re: bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER
Date: Wed, 6 Sep 2023 00:02:09 -0700

Yuan Fu <casouri <at> gmail.com> writes:

>> On Dec 31, 2022, at 5:09 PM, Po Lu <luangruo <at> yahoo.com> wrote:
>>
>> Paul Eggert <eggert <at> cs.ucla.edu> writes:
>>
>>> On my platform the current Emacs master (commit
>>> 91ae9f3d12885373d38c3e8d693f7dc210f9d471) won't build, failing with:
>>>
>>>   ELC      progmodes/typescript-ts-mode.elc
>>>
>>> In toplevel form:
>>> progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function
>>> definition is vo\
>>> id: treesit-query-compile
>>>
>>>
>>> Full log (compressed) attached, built from Git on Fedora 37
>>> x86-64. The best fix isn't immediately obvious to me; adding a
>>> declare-function doesn't work.
>>>
>>> This platform doesn't have the tree-sitter library, so
>>> HAVE_TREE_SITTER is not defined which means C doesn't define
>>> treesit-query-compile.
>>>
>>> I will probably just install the tree-sitter library to work around
>>> the bug, but thought I'd document it. Presumably you can simulate it
>>> by configuring --without-tree-sitter.
>>
>> Copying in Yuan Fu.
>>
>> Would people please test their changes on an Emacs *WITHOUT* tree-sitter
>> before installing them in the future?
>
> Yeah I’ve setup a no-tree-sitter build so I could catch these in the future. Sorry for the inconvenience.

That was 9 months ago.

I'm assuming this has been fixed by now, and that the bug was left open
by accident.  Therefore, I'm closing this bug report.

If anyone is still seeing this, please report back and we can
investigate.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.