X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: casouri@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 03 Jan 2023 11:20:02 +0000
Resent-Message-ID: <handler.60511.B.167274478021547 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: 60511 <at> debbugs.gnu.org
Cc: Yuan Fu <casouri@HIDDEN>
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
X-Debbugs-Original-Xcc: Yuan Fu <casouri@HIDDEN>
Received: via spool by submit <at> debbugs.gnu.org id=B.167274478021547
(code B ref -1); Tue, 03 Jan 2023 11:20:02 +0000
Received: (at submit) by debbugs.gnu.org; 3 Jan 2023 11:19:40 +0000
Received: from localhost ([127.0.0.1]:44799 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pCfKW-0005bS-A8
for submit <at> debbugs.gnu.org; Tue, 03 Jan 2023 06:19:40 -0500
Received: from lists.gnu.org ([209.51.188.17]:60044)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stefankangas@HIDDEN>) id 1pCfKT-0005bI-Qb
for submit <at> debbugs.gnu.org; Tue, 03 Jan 2023 06:19:39 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>)
id 1pCfKM-0005SL-69
for bug-gnu-emacs@HIDDEN; Tue, 03 Jan 2023 06:19:37 -0500
Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>)
id 1pCfKE-0006vK-EJ
for bug-gnu-emacs@HIDDEN; Tue, 03 Jan 2023 06:19:24 -0500
Received: by mail-ot1-x333.google.com with SMTP id
j16-20020a056830271000b0067202045ee9so18885190otu.7
for <bug-gnu-emacs@HIDDEN>; Tue, 03 Jan 2023 03:19:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
:date:message-id:reply-to;
bh=bCWuAkQ5RKuT06ObsMh5bY5uvq9YQrARVGkVVxvuq5Y=;
b=nFdW48Y0YzyJYdCsQlQXjgTorIQ6QxSPRxjOz9MR1OsMINS16bTXYc4HjPB2p1r7g4
Yr0d6ukuO+nmoB2LbUO8pfKhu+Tpf1eCk1A2vK3z/qJjN4SYpuViwt0ajFN6Ks8zrQ9M
5ZDo0ZnYyROulwzxIpwCDFkaJVsAygN6x1wTonc8xN/P/+lg54IPWh3FEz0ujbYpWsW5
ZvIDzgYqultGz+X6H8uYLz88mH1fHYEJpzLF8zDkZjS8DRLrCKlxqtaWqYRO2rBc8IgD
zlAMkotFocDX+Z/xeVaZHyMBr3klurrZB/n5T5fksRI+7m2P6RR/tRIP/thdxwfAbHGW
H79w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=to:subject:message-id:date:mime-version:from:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=bCWuAkQ5RKuT06ObsMh5bY5uvq9YQrARVGkVVxvuq5Y=;
b=Y7EQ8/FFrsiNuSyH3QS/eoqEB0u5qrrDsPhe7dZixiiiRIJ/Zshk7HLmwmqP8uIcC3
lnv9NAIz1vrfYwl5cS9BPMhnZveI9UrQ09IpHTrllaKmovDFGGKvqI6l2uvJssF7qANF
P/Ylgc+upLKFZNLPrgV5WLamv0l0YCWvFC6lduBs5e+loSihqRYwdomW+KLCI4dPJfG4
gWs2quEpPlYUz9PvRsG67RCHey6JOfZD5nRnpWLon9SZOtiSnOFSVKWJK3FtzKr+jYnB
FZr2cyvST/GCRPn28jPOSroWZu9A/yDWcleBAXsUvegvMVOnjUpNn7KCJy0GDRt/4l5O
8SgQ==
X-Gm-Message-State: AFqh2kqv8/q3xBHdddeCLXnpTN3uvwGLe/3WC8OTz7yJ5UFdIhOCmi+p
Fskx0RiG9V92vjIQEhJEMuFEzgd2/u2xgU/ajIpYO+DC
X-Google-Smtp-Source: AMrXdXvtQL16ePulN8G1uNNxK5MNA0Bc51Wkh/NyOTIc16VBeFu3fdx+x4bppyuqKx83i05D2sA6URVvbrqZDbwbDiA=
X-Received: by 2002:a05:6830:1b78:b0:677:9c09:55d1 with SMTP id
d24-20020a0568301b7800b006779c0955d1mr1954624ote.224.1672744755172; Tue, 03
Jan 2023 03:19:15 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Tue, 3 Jan 2023 11:19:14 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
X-Hashcash: 1:20:230102:bug-gnu-emacs@HIDDEN::e746ujEE2/r6dmm3:1wrr
MIME-Version: 1.0
Date: Tue, 3 Jan 2023 11:19:14 +0000
Message-ID: <CADwFkmmHnV1efr0o8utz6Oj4+LALGADF+cdZC_9EBHXj_WLeeg@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=2607:f8b0:4864:20::333;
envelope-from=stefankangas@HIDDEN; helo=mail-ot1-x333.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
Severity: wishlist
This currently emits a warning if the ruby grammar is not installed:
(treesit-ready-p 'ruby)
I think it should *not* emit a warning, as no other predicates in Emacs
do (e.g. `featurep', `integerp', etc.).
It could have an optional flag to emit a warning, if there's a strong
need for that. But personally, I'd rather see a new function for that.
I also don't see much need for the `message' symbol as the second
argument, so I'd simplify the API by dropping that part. It's currently
unused in our tree.
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Stefan Kangas <stefankangas@HIDDEN> Subject: bug#60511: Acknowledgement (29.0.50; treesit-ready-p should not emit warning by default) Message-ID: <handler.60511.B.167274478021547.ack <at> debbugs.gnu.org> References: <CADwFkmmHnV1efr0o8utz6Oj4+LALGADF+cdZC_9EBHXj_WLeeg@HIDDEN> X-Gnu-PR-Message: ack 60511 X-Gnu-PR-Package: emacs Reply-To: 60511 <at> debbugs.gnu.org Date: Tue, 03 Jan 2023 11:20:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. As you requested using X-Debbugs-CC, your message was also forwarded to Yuan Fu <casouri@HIDDEN> (after having been given a bug report number, if it did not have one). Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 60511 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 60511: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60511 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 03 Jan 2023 17:56:02 +0000
Resent-Message-ID: <handler.60511.B60511.167276852417937 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: Yuan Fu <casouri@HIDDEN>, 60511 <at> debbugs.gnu.org
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.167276852417937
(code B ref 60511); Tue, 03 Jan 2023 17:56:02 +0000
Received: (at 60511) by debbugs.gnu.org; 3 Jan 2023 17:55:24 +0000
Received: from localhost ([127.0.0.1]:46667 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pClVU-0004fE-1h
for submit <at> debbugs.gnu.org; Tue, 03 Jan 2023 12:55:24 -0500
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:39805)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1pClVS-0004ew-2E
for 60511 <at> debbugs.gnu.org; Tue, 03 Jan 2023 12:55:22 -0500
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id DFB771BF206;
Tue, 3 Jan 2023 17:55:13 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <CADwFkmmHnV1efr0o8utz6Oj4+LALGADF+cdZC_9EBHXj_WLeeg@HIDDEN>
(Stefan Kangas's message of "Tue, 3 Jan 2023 11:19:14 +0000")
Organization: LINKOV.NET
References: <CADwFkmmHnV1efr0o8utz6Oj4+LALGADF+cdZC_9EBHXj_WLeeg@HIDDEN>
Date: Tue, 03 Jan 2023 19:44:27 +0200
Message-ID: <86r0wby0lh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
> This currently emits a warning if the ruby grammar is not installed:
>
> (treesit-ready-p 'ruby)
>
> I think it should *not* emit a warning, as no other predicates in Emacs
> do (e.g. `featurep', `integerp', etc.).
>
> It could have an optional flag to emit a warning, if there's a strong
> need for that. But personally, I'd rather see a new function for that.
>
> I also don't see much need for the `message' symbol as the second
> argument, so I'd simplify the API by dropping that part. It's currently
> unused in our tree.
Like the argument NOERROR of `require', the argument QUIET of `treesit-ready-p'
could do the same.
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
References: <CADwFkmmHnV1efr0o8utz6Oj4+LALGADF+cdZC_9EBHXj_WLeeg@HIDDEN>
In-Reply-To: <CADwFkmmHnV1efr0o8utz6Oj4+LALGADF+cdZC_9EBHXj_WLeeg@HIDDEN>
Resent-From: Yuan Fu <casouri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 04 Jan 2023 07:03:02 +0000
Resent-Message-ID: <handler.60511.B60511.167281576513715 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Juri Linkov <juri@HIDDEN>
Cc: Stefan Kangas <stefankangas@HIDDEN>, 60511 <at> debbugs.gnu.org
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.167281576513715
(code B ref 60511); Wed, 04 Jan 2023 07:03:02 +0000
Received: (at 60511) by debbugs.gnu.org; 4 Jan 2023 07:02:45 +0000
Received: from localhost ([127.0.0.1]:47424 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pCxnR-0003Z9-1z
for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 02:02:45 -0500
Received: from mail-pg1-f182.google.com ([209.85.215.182]:42843)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <casouri@HIDDEN>) id 1pCxnP-0003Yw-WA
for 60511 <at> debbugs.gnu.org; Wed, 04 Jan 2023 02:02:44 -0500
Received: by mail-pg1-f182.google.com with SMTP id e10so7727781pgc.9
for <60511 <at> debbugs.gnu.org>; Tue, 03 Jan 2023 23:02:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=to:cc:date:message-id:subject:mime-version
:content-transfer-encoding:from:from:to:cc:subject:date:message-id
:reply-to; bh=Jz90uJRVUK1mGeYjm9Q+AcKoCTquSn/1GQ6wtrRXNgo=;
b=PBULr8t1xPfHYo1ByRsDjrBn0OhSGwdrLfQNgVOmA1M8kYO7YybE+6H5AfQLDGGwgo
Fds39qkS6+2T0I8YWoLMfYmbkfLdn1kJHfU2988HFjWJSRlnTAcQiJPNTINE1I//OHPk
4Jb37MvPCb6FY5ipsdif79ESRoReJg2a2LJh6DzhtwZ3xR/XGC4asG5enxHKOHMDf6/3
vlJsBBiLqaHrfCb/kf5lad+xiTuV+Tziw4jRQy+eGxN/GJRRZkKM79f6zh3FRHeYKGvQ
6F42lUOL9gwuifKbnxfaagvdrBegZwpCKJu4D+SWiPbTHqHbdL3foLh6UdNXqei+AgiJ
/rEQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=to:cc:date:message-id:subject:mime-version
:content-transfer-encoding:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=Jz90uJRVUK1mGeYjm9Q+AcKoCTquSn/1GQ6wtrRXNgo=;
b=Bv11/CD80EkvABhnsrCqSSyOc8/VMmBx5xsnQK+YyD8JYx91BsK6lhSEFJwHpMzqWV
yE5HuFSnETmZqUV3hOwhr5t6Ygsljbyef1MHzj929gU6c/5UetWlMgcixt7nMRj2wGeq
D0NhgoH++zs9UL0fTsIo8F7iYUx3lBv/9LcRO/lOslExYs5ZYud18mxakfKuHxu88Pb4
wuFCbPcREJ7glmU0WycPJSWdqI5GcoIwCMm4ju56F6agiT8mQYh6/JfFpVfPkxVVg1uO
4qeYX4URu4G2yD4BHxUJ9n84JQzW8Kk4VcnIbZ2bVhEJMuz+MFfcvn2yibyKjemfGsMf
SK3Q==
X-Gm-Message-State: AFqh2krzdEkvbsijCw6nnoprTWsnvfW20T9j8Vjy7YHmkoV3qm4DvL7x
N+pApeioejHEdnazGxv0cUw=
X-Google-Smtp-Source: AMrXdXsepl6tAH9e5y9obSvvfUL3bt0yH6/xkyTzq4MC7yevRMjRh3WyJmv4LWf11f/xaEX9SKvdYA==
X-Received: by 2002:a62:404:0:b0:581:91d1:3cc4 with SMTP id
4-20020a620404000000b0058191d13cc4mr23128709pfe.7.1672815758229;
Tue, 03 Jan 2023 23:02:38 -0800 (PST)
Received: from smtpclient.apple (ip68-3-33-122.ph.ph.cox.net. [68.3.33.122])
by smtp.gmail.com with ESMTPSA id
63-20020a620542000000b0056be1581126sm22299780pff.143.2023.01.03.23.02.37
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Tue, 03 Jan 2023 23:02:37 -0800 (PST)
From: Yuan Fu <casouri@HIDDEN>
Content-Type: text/plain;
charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Message-Id: <D066D2C0-342C-43C2-B290-6D68B89D3D93@HIDDEN>
Date: Wed, 4 Jan 2023 00:02:36 -0700
X-Mailer: Apple Mail (2.3696.120.41.1.1)
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Juri Linkov <juri@HIDDEN> writes:
>> This currently emits a warning if the ruby grammar is not installed:
>>
>> (treesit-ready-p 'ruby)
>>
>> I think it should *not* emit a warning, as no other predicates in =
Emacs
>> do (e.g. `featurep', `integerp', etc.).
>>
>> It could have an optional flag to emit a warning, if there's a strong
>> need for that. But personally, I'd rather see a new function for =
that.
>>
>> I also don't see much need for the `message' symbol as the second
>> argument, so I'd simplify the API by dropping that part. It's =
currently
>> unused in our tree.
>
> Like the argument NOERROR of `require', the argument QUIET of =
`treesit-ready-p'
> could do the same.
Maybe rename it to treesit-check-readiness?
Yuan
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 04 Jan 2023 07:50:02 +0000
Resent-Message-ID: <handler.60511.B60511.167281857927678 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Yuan Fu <casouri@HIDDEN>
Cc: Stefan Kangas <stefankangas@HIDDEN>, 60511 <at> debbugs.gnu.org
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.167281857927678
(code B ref 60511); Wed, 04 Jan 2023 07:50:02 +0000
Received: (at 60511) by debbugs.gnu.org; 4 Jan 2023 07:49:39 +0000
Received: from localhost ([127.0.0.1]:47561 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pCyWo-0007CM-Ux
for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 02:49:39 -0500
Received: from relay11.mail.gandi.net ([217.70.178.231]:47201)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1pCyWl-0007Bo-Rx
for 60511 <at> debbugs.gnu.org; Wed, 04 Jan 2023 02:49:37 -0500
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 65F0110000A;
Wed, 4 Jan 2023 07:49:27 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <D066D2C0-342C-43C2-B290-6D68B89D3D93@HIDDEN> (Yuan Fu's
message of "Wed, 4 Jan 2023 00:02:36 -0700")
Organization: LINKOV.NET
References: <D066D2C0-342C-43C2-B290-6D68B89D3D93@HIDDEN>
Date: Wed, 04 Jan 2023 09:47:10 +0200
Message-ID: <86wn623fnl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>>> This currently emits a warning if the ruby grammar is not installed:
>>>
>>> (treesit-ready-p 'ruby)
>>>
>>> I think it should *not* emit a warning, as no other predicates in Emacs
>>> do (e.g. `featurep', `integerp', etc.).
>>>
>>> It could have an optional flag to emit a warning, if there's a strong
>>> need for that. But personally, I'd rather see a new function for that.
>>>
>>> I also don't see much need for the `message' symbol as the second
>>> argument, so I'd simplify the API by dropping that part. It's currently
>>> unused in our tree.
>>
>> Like the argument NOERROR of `require', the argument QUIET of `treesit-ready-p'
>> could do the same.
>
> Maybe rename it to treesit-check-readiness?
I think treesit-ready-p already is a good name.
We just need to support more values in its argument QUIET,
with a new value that does nothing in case of an error,
and just returns nil.
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
References: <CADwFkmmHnV1efr0o8utz6Oj4+LALGADF+cdZC_9EBHXj_WLeeg@HIDDEN>
In-Reply-To: <CADwFkmmHnV1efr0o8utz6Oj4+LALGADF+cdZC_9EBHXj_WLeeg@HIDDEN>
Resent-From: Yuan Fu <casouri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 08 Jan 2023 01:32:01 +0000
Resent-Message-ID: <handler.60511.B60511.167314148613928 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Juri Linkov <juri@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>, 60511 <at> debbugs.gnu.org
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.167314148613928
(code B ref 60511); Sun, 08 Jan 2023 01:32:01 +0000
Received: (at 60511) by debbugs.gnu.org; 8 Jan 2023 01:31:26 +0000
Received: from localhost ([127.0.0.1]:59417 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pEKX0-0003ca-7H
for submit <at> debbugs.gnu.org; Sat, 07 Jan 2023 20:31:26 -0500
Received: from mail-pl1-f171.google.com ([209.85.214.171]:34730)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <casouri@HIDDEN>) id 1pEKWy-0003cK-6q
for 60511 <at> debbugs.gnu.org; Sat, 07 Jan 2023 20:31:24 -0500
Received: by mail-pl1-f171.google.com with SMTP id v23so875904plo.1
for <60511 <at> debbugs.gnu.org>; Sat, 07 Jan 2023 17:31:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=to:cc:date:message-id:subject:mime-version
:content-transfer-encoding:from:from:to:cc:subject:date:message-id
:reply-to; bh=SRKq/52utqhoWW4iA/v2FsLax6uMK0yON4SaHYK2DwY=;
b=FdqeUJeTYFiCOEdhBwBU8UDRQyJJBTELmUD1eyk+zm9JNnmXDktzg+ZyCSh+4pA8GW
jY08aiVDo8AJNF2bLGrBXlhXNSGpkwrTkdiK0NpM8HeST8BJlTmH1XpteuBHoXgiWHHm
l4+f99/yqinwETSM/DCDoqIlqs+FtalQIsHptH9zexViS+9TSnAj1MpkN/BXfmFvDr9B
82bGcrxZ5hmJVKQ5+6iHfvPD7hFd3ZxHa7ewAf9u1kMKWFhWA3Je9PqgbV8n9r27r3Cm
zKmiSJVDMbIfWZyWZ3F0XIRfvgGhcckqe3o55XR2vzp68/Nq5iMJCb1siWqEwhyaOcs+
0vnQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=to:cc:date:message-id:subject:mime-version
:content-transfer-encoding:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=SRKq/52utqhoWW4iA/v2FsLax6uMK0yON4SaHYK2DwY=;
b=5LfXmYEJlnKwlkDZ4hG4OrOmxkqMQxzLsbMyj97X/Sx909x3NeTXL8vEwvmvIuJc1a
NjWyagvJA6N5tR2ZQE60kt60zebkRIMpQr2D+cS5xI5mPEu4pClje8bD07JxkiZuw8OI
kdOiJYqFU4oym0xTy3ERu2nQPmgkE57oijS70+j222ZMzR68X67cLP5HqPplM7fm5Db+
NjxIXtiMiB9bT9AZawnS2ZylYCuOj5nlnuTo8U/ezL/QlosuDQ413p0n1bSY+Jhg8RuE
s8x5iHDfXCWtKEF5Qdc1i2CmW/mItaVrugs1gJBeVmbir4xMvDV9SEl0RjNxv+4r0Frt
jZ/A==
X-Gm-Message-State: AFqh2kpB4nM8m9N0oOGvDGxDy7xl0w8ArIhOzincjYQiGHEUGeDQlNOs
UAaGvaGqFsji5fopa3+v5SE=
X-Google-Smtp-Source: AMrXdXuhxk1V5A5/gHWUoh1IrE7WMci42xj6d4yu86IQu5ohdtHki9gyRKmoC7Ht5jBQ02JzvG4Jkw==
X-Received: by 2002:a17:90a:7788:b0:226:f2a0:8723 with SMTP id
v8-20020a17090a778800b00226f2a08723mr3633137pjk.42.1673141478125;
Sat, 07 Jan 2023 17:31:18 -0800 (PST)
Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com.
[172.117.161.177]) by smtp.gmail.com with ESMTPSA id
t11-20020a17090a448b00b00226f49eca92sm1646408pjg.28.2023.01.07.17.31.17
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Sat, 07 Jan 2023 17:31:17 -0800 (PST)
From: Yuan Fu <casouri@HIDDEN>
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Message-Id: <B1EA10E7-5AC1-4F81-869A-112CCF8AED80@HIDDEN>
Date: Sat, 7 Jan 2023 17:31:16 -0800
X-Mailer: Apple Mail (2.3696.120.41.1.1)
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Juri Linkov <juri@HIDDEN> writes:
>>>> This currently emits a warning if the ruby grammar is not =
installed:
>>>>
>>>> (treesit-ready-p 'ruby)
>>>>
>>>> I think it should *not* emit a warning, as no other predicates in =
Emacs
>>>> do (e.g. `featurep', `integerp', etc.).
>>>>
>>>> It could have an optional flag to emit a warning, if there's a =
strong
>>>> need for that. But personally, I'd rather see a new function for =
that.
>>>>
>>>> I also don't see much need for the `message' symbol as the second
>>>> argument, so I'd simplify the API by dropping that part. It's =
currently
>>>> unused in our tree.
>>>
>>> Like the argument NOERROR of `require', the argument QUIET of =
`treesit-ready-p'
>>> could do the same.
>>
>> Maybe rename it to treesit-check-readiness?
>
> I think treesit-ready-p already is a good name.
> We just need to support more values in its argument QUIET,
> with a new value that does nothing in case of an error,
> and just returns nil.
It already has such option: if QUIET is t, treesit-ready-p returns nil =
and don=E2=80=99t emit anything.
I can make treesit-ready-p not emit any warning by default, and change
the quiet parameter to WARN, and accept either 'warn or =E2=80=98message.
Basically:
(treesit-ready-p lang) =3D> t/nil
(treesit-ready-p lang 'warn) =3D> t/emit warning
(treesit-ready-p lang 'message) =3D> t/message
Eli, WDYT?
Yuan
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 08 Jan 2023 05:54:02 +0000
Resent-Message-ID: <handler.60511.B60511.167315719615746 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Yuan Fu <casouri@HIDDEN>
Cc: stefankangas@HIDDEN, 60511 <at> debbugs.gnu.org, juri@HIDDEN
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.167315719615746
(code B ref 60511); Sun, 08 Jan 2023 05:54:02 +0000
Received: (at 60511) by debbugs.gnu.org; 8 Jan 2023 05:53:16 +0000
Received: from localhost ([127.0.0.1]:59641 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pEOcO-00045s-Da
for submit <at> debbugs.gnu.org; Sun, 08 Jan 2023 00:53:16 -0500
Received: from eggs.gnu.org ([209.51.188.92]:57368)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pEOcM-00045e-Iw
for 60511 <at> debbugs.gnu.org; Sun, 08 Jan 2023 00:53:15 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pEOcF-0002im-UC; Sun, 08 Jan 2023 00:53:08 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=7wv2h1LSwOHRlG5WPStR/j7jrvvUvtQabQRWnmgaILQ=; b=Amjb0K+AE4DKRMCgS7V3
kLyxCktuJfjC1F/1HD5o+fOJ2SLHiHb3m2/8yZGG3ENM47+eENxoIRlX6ts7qzpJV/Ad1J+Ob+eEX
u0l5iqRhUAuXIN0f+1W0bUYPIali+TwjkKmOxDY7lSIQ6ozPW4edywVx2CrBDTNhej24+E4aXQJwJ
lklxR9nFCCzd5rfca9/gbSpfMWCWH+D7i6IfvGF/6BPGMfYW8vim4jRO4mwcrKQ0NtBDbaoNCkC64
EiEzQlHBF0dZQv5jJUwWzU/kKkJvqfc05MTa4uCzNH5s9wmcHZ70n2Jhnw0otK1GJ+QevWVHwwlpX
5WXGI/r2ARuu5A==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pEOcF-0002h8-6a; Sun, 08 Jan 2023 00:53:07 -0500
Date: Sun, 08 Jan 2023 07:53:30 +0200
Message-Id: <83lemdr2qt.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <B1EA10E7-5AC1-4F81-869A-112CCF8AED80@HIDDEN> (message from
Yuan Fu on Sat, 7 Jan 2023 17:31:16 -0800)
References: <B1EA10E7-5AC1-4F81-869A-112CCF8AED80@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Yuan Fu <casouri@HIDDEN>
> Date: Sat, 7 Jan 2023 17:31:16 -0800
> Cc: Stefan Kangas <stefankangas@HIDDEN>,
> 60511 <at> debbugs.gnu.org,
> Eli Zaretskii <eliz@HIDDEN>
>
>
> Juri Linkov <juri@HIDDEN> writes:
>
> >>>> This currently emits a warning if the ruby grammar is not installed:
> >>>>
> >>>> (treesit-ready-p 'ruby)
> >>>>
> >>>> I think it should *not* emit a warning, as no other predicates in Emacs
> >>>> do (e.g. `featurep', `integerp', etc.).
> >>>>
> >>>> It could have an optional flag to emit a warning, if there's a strong
> >>>> need for that. But personally, I'd rather see a new function for that.
> >>>>
> >>>> I also don't see much need for the `message' symbol as the second
> >>>> argument, so I'd simplify the API by dropping that part. It's currently
> >>>> unused in our tree.
> >>>
> >>> Like the argument NOERROR of `require', the argument QUIET of `treesit-ready-p'
> >>> could do the same.
> >>
> >> Maybe rename it to treesit-check-readiness?
> >
> > I think treesit-ready-p already is a good name.
> > We just need to support more values in its argument QUIET,
> > with a new value that does nothing in case of an error,
> > and just returns nil.
>
> It already has such option: if QUIET is t, treesit-ready-p returns nil and don’t emit anything.
>
> I can make treesit-ready-p not emit any warning by default, and change
> the quiet parameter to WARN, and accept either 'warn or ‘message.
>
> Basically:
>
> (treesit-ready-p lang) => t/nil
> (treesit-ready-p lang 'warn) => t/emit warning
> (treesit-ready-p lang 'message) => t/message
>
> Eli, WDYT?
I think the default should be to emit a warning, like we do now. We
should support the main use case of the user turning on a TS mode when
the required libraries are not installed or incompatible with our
requirements. Silently doing nothing in that case is not TRT.
No objections from me to extend the QUIET argument other than that.
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 08 Jan 2023 08:50:02 +0000
Resent-Message-ID: <handler.60511.B60511.16731677783222 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Eli Zaretskii <eliz@HIDDEN>
Cc: Yuan Fu <casouri@HIDDEN>, stefankangas@HIDDEN, 60511 <at> debbugs.gnu.org
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.16731677783222
(code B ref 60511); Sun, 08 Jan 2023 08:50:02 +0000
Received: (at 60511) by debbugs.gnu.org; 8 Jan 2023 08:49:38 +0000
Received: from localhost ([127.0.0.1]:59820 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pERN4-0000pu-CL
for submit <at> debbugs.gnu.org; Sun, 08 Jan 2023 03:49:38 -0500
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:45219)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1pERN2-0000pR-KA
for 60511 <at> debbugs.gnu.org; Sun, 08 Jan 2023 03:49:36 -0500
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 433F720008;
Sun, 8 Jan 2023 08:49:28 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <83lemdr2qt.fsf@HIDDEN> (Eli Zaretskii's message of "Sun, 08 Jan
2023 07:53:30 +0200")
Organization: LINKOV.NET
References: <B1EA10E7-5AC1-4F81-869A-112CCF8AED80@HIDDEN>
<83lemdr2qt.fsf@HIDDEN>
Date: Sun, 08 Jan 2023 10:39:36 +0200
Message-ID: <86358lwhbr.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> I can make treesit-ready-p not emit any warning by default, and change
>> the quiet parameter to WARN, and accept either 'warn or ‘message.
>>
>> Basically:
>>
>> (treesit-ready-p lang) => t/nil
>> (treesit-ready-p lang 'warn) => t/emit warning
>> (treesit-ready-p lang 'message) => t/message
>>
>> Eli, WDYT?
>
> I think the default should be to emit a warning, like we do now.
Then how users could change this default?
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 08 Jan 2023 11:03:01 +0000
Resent-Message-ID: <handler.60511.B60511.167317577416486 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Juri Linkov <juri@HIDDEN>
Cc: casouri@HIDDEN, stefankangas@HIDDEN, 60511 <at> debbugs.gnu.org
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.167317577416486
(code B ref 60511); Sun, 08 Jan 2023 11:03:01 +0000
Received: (at 60511) by debbugs.gnu.org; 8 Jan 2023 11:02:54 +0000
Received: from localhost ([127.0.0.1]:60011 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pETS2-0004Hq-6A
for submit <at> debbugs.gnu.org; Sun, 08 Jan 2023 06:02:54 -0500
Received: from eggs.gnu.org ([209.51.188.92]:33722)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pETS0-0004He-5W
for 60511 <at> debbugs.gnu.org; Sun, 08 Jan 2023 06:02:52 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pETRu-00085P-T9; Sun, 08 Jan 2023 06:02:46 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=xhKzWKAdotyrRaxDGc8vmMUitW2mcpA0FrhuFFdqugs=; b=dMebkHWbumgTP0xwnwSb
rOA8uZkx6opW0R+M0hnJ3oN2ZgSncoJKpTqRZdVyErG27V7ThgjMO5OQ/36TsqBbyV+BdkWhCFIMs
phluLBd4dNLsj4JXOWwaiZhyvkTgr4K1VjFdByr8YhwFomf4/8LGcsDlQPDJTV0vpyBpMUmeLslcG
OF4mq8kVCpLspIlDf9ZM3M28ODc8ZaeoC9jBlJc5iC7W1kHEAOGxwhEGAmP138//Ubi8+NQv2ovyt
0joXzuMvjp2ZgNHo3PSo4CDpVFohGbe+1B6/DkJxs6gxefzp3L4LWq4GeUcZmHmvGzgkMoOt/6l2d
eixHp76lRdb8KQ==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pETRu-00032Y-Dx; Sun, 08 Jan 2023 06:02:46 -0500
Date: Sun, 08 Jan 2023 13:03:09 +0200
Message-Id: <837cxxqoeq.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <86358lwhbr.fsf@HIDDEN> (message from Juri Linkov on
Sun, 08 Jan 2023 10:39:36 +0200)
References: <B1EA10E7-5AC1-4F81-869A-112CCF8AED80@HIDDEN>
<83lemdr2qt.fsf@HIDDEN> <86358lwhbr.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Juri Linkov <juri@HIDDEN>
> Cc: Yuan Fu <casouri@HIDDEN>, stefankangas@HIDDEN,
> 60511 <at> debbugs.gnu.org
> Date: Sun, 08 Jan 2023 10:39:36 +0200
>
> >> I can make treesit-ready-p not emit any warning by default, and change
> >> the quiet parameter to WARN, and accept either 'warn or ‘message.
> >>
> >> Basically:
> >>
> >> (treesit-ready-p lang) => t/nil
> >> (treesit-ready-p lang 'warn) => t/emit warning
> >> (treesit-ready-p lang 'message) => t/message
> >>
> >> Eli, WDYT?
> >
> > I think the default should be to emit a warning, like we do now.
>
> Then how users could change this default?
In what situation?
If they invoke the mode, they aren't supposed to disable the warning,
and they cannot.
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 08 Jan 2023 17:49:02 +0000
Resent-Message-ID: <handler.60511.B60511.167320011227424 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Eli Zaretskii <eliz@HIDDEN>
Cc: casouri@HIDDEN, stefankangas@HIDDEN, 60511 <at> debbugs.gnu.org
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.167320011227424
(code B ref 60511); Sun, 08 Jan 2023 17:49:02 +0000
Received: (at 60511) by debbugs.gnu.org; 8 Jan 2023 17:48:32 +0000
Received: from localhost ([127.0.0.1]:34564 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pEZma-00078F-8J
for submit <at> debbugs.gnu.org; Sun, 08 Jan 2023 12:48:32 -0500
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:51171)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1pEZmZ-00077d-8f
for 60511 <at> debbugs.gnu.org; Sun, 08 Jan 2023 12:48:31 -0500
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id B65A020002;
Sun, 8 Jan 2023 17:48:22 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <837cxxqoeq.fsf@HIDDEN> (Eli Zaretskii's message of "Sun, 08 Jan
2023 13:03:09 +0200")
Organization: LINKOV.NET
References: <B1EA10E7-5AC1-4F81-869A-112CCF8AED80@HIDDEN>
<83lemdr2qt.fsf@HIDDEN> <86358lwhbr.fsf@HIDDEN>
<837cxxqoeq.fsf@HIDDEN>
Date: Sun, 08 Jan 2023 19:35:27 +0200
Message-ID: <86pmboudmk.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> >> I can make treesit-ready-p not emit any warning by default, and change
>> >> the quiet parameter to WARN, and accept either 'warn or ‘message.
>> >>
>> >> Basically:
>> >>
>> >> (treesit-ready-p lang) => t/nil
>> >> (treesit-ready-p lang 'warn) => t/emit warning
>> >> (treesit-ready-p lang 'message) => t/message
>> >>
>> >> Eli, WDYT?
>> >
>> > I think the default should be to emit a warning, like we do now.
>>
>> Then how users could change this default?
>
> In what situation?
>
> If they invoke the mode, they aren't supposed to disable the warning,
> and they cannot.
In a situation when they want simply to visit a file without using
tree-sitter features, and that visit won't require from them
customization with modifying auto-mode-alist, etc.
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 08 Jan 2023 17:58:01 +0000
Resent-Message-ID: <handler.60511.B60511.167320065628268 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Juri Linkov <juri@HIDDEN>
Cc: casouri@HIDDEN, stefankangas@HIDDEN, 60511 <at> debbugs.gnu.org
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.167320065628268
(code B ref 60511); Sun, 08 Jan 2023 17:58:01 +0000
Received: (at 60511) by debbugs.gnu.org; 8 Jan 2023 17:57:36 +0000
Received: from localhost ([127.0.0.1]:34588 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pEZvM-0007Ls-6Z
for submit <at> debbugs.gnu.org; Sun, 08 Jan 2023 12:57:36 -0500
Received: from eggs.gnu.org ([209.51.188.92]:52036)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pEZvJ-0007Le-Lq
for 60511 <at> debbugs.gnu.org; Sun, 08 Jan 2023 12:57:34 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pEZvD-0003fb-EP; Sun, 08 Jan 2023 12:57:27 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=WJoSzFOAP3yvLUie/ZFjaCXcusGy+WmM6SyJv+RXFNU=; b=IUT2dpII+lIKxI4/H3CA
fx/k9FFNfNRxquA7//mEqW24lhHnKpwpoUYzSUKULaZrrPGeb05yzD/CKlFTrHsO81gNPRIvfYgQO
5YRTsiGdG2UbEau6jyUZuhPu50rxlbxXu8AecVDcufagdHDJDQb++37pWNBRF+FARYlm6sBELRlV3
DkYvh3Wun7Rp9bRM07gxhIC5z30WbbHmhVOX0eShekkDOxyZ97A8RJKLkLeaolFiI6dmQNK2i1AJ7
6Tebj9hhNxjYkW5iYaLSmRkwClLtD42XOs1G08Tmv2iZ64jflJNmJpXgKwTq8O8P9t746a/tqn5cg
gfX/3bx/TbTXsw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pEZvC-0004FJ-3i; Sun, 08 Jan 2023 12:57:27 -0500
Date: Sun, 08 Jan 2023 19:57:48 +0200
Message-Id: <83lemcq57n.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <86pmboudmk.fsf@HIDDEN> (message from Juri Linkov on
Sun, 08 Jan 2023 19:35:27 +0200)
References: <B1EA10E7-5AC1-4F81-869A-112CCF8AED80@HIDDEN>
<83lemdr2qt.fsf@HIDDEN> <86358lwhbr.fsf@HIDDEN>
<837cxxqoeq.fsf@HIDDEN> <86pmboudmk.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Juri Linkov <juri@HIDDEN>
> Cc: casouri@HIDDEN, stefankangas@HIDDEN, 60511 <at> debbugs.gnu.org
> Date: Sun, 08 Jan 2023 19:35:27 +0200
>
> >> >> I can make treesit-ready-p not emit any warning by default, and change
> >> >> the quiet parameter to WARN, and accept either 'warn or ‘message.
> >> >>
> >> >> Basically:
> >> >>
> >> >> (treesit-ready-p lang) => t/nil
> >> >> (treesit-ready-p lang 'warn) => t/emit warning
> >> >> (treesit-ready-p lang 'message) => t/message
> >> >>
> >> >> Eli, WDYT?
> >> >
> >> > I think the default should be to emit a warning, like we do now.
> >>
> >> Then how users could change this default?
> >
> > In what situation?
> >
> > If they invoke the mode, they aren't supposed to disable the warning,
> > and they cannot.
>
> In a situation when they want simply to visit a file without using
> tree-sitter features, and that visit won't require from them
> customization with modifying auto-mode-alist, etc.
This will soon become a non-issue, as I plan on removing all the TS
modes from auto-mode-alist. Only loading the mode will add it back to
the alist. So there will be no surprises, and no need to conceal the
warning.
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 08 Jan 2023 18:15:01 +0000
Resent-Message-ID: <handler.60511.B60511.167320165729948 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Eli Zaretskii <eliz@HIDDEN>, Yuan Fu <casouri@HIDDEN>
Cc: 60511 <at> debbugs.gnu.org, juri@HIDDEN
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.167320165729948
(code B ref 60511); Sun, 08 Jan 2023 18:15:01 +0000
Received: (at 60511) by debbugs.gnu.org; 8 Jan 2023 18:14:17 +0000
Received: from localhost ([127.0.0.1]:34600 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pEaBU-0007mw-Kr
for submit <at> debbugs.gnu.org; Sun, 08 Jan 2023 13:14:16 -0500
Received: from mail-oa1-f51.google.com ([209.85.160.51]:33758)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stefankangas@HIDDEN>) id 1pEaBR-0007mK-RM
for 60511 <at> debbugs.gnu.org; Sun, 08 Jan 2023 13:14:15 -0500
Received: by mail-oa1-f51.google.com with SMTP id
586e51a60fabf-150debe2b7cso6722971fac.0
for <60511 <at> debbugs.gnu.org>; Sun, 08 Jan 2023 10:14:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=content-transfer-encoding:cc:to:subject:message-id:date
:mime-version:references:in-reply-to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=LcGQ/2pyrBdE6ApMyVbkjAi4QZ0D5baK3szWvcf9Emk=;
b=SD8ySLgLus6b6nC5NKSvnu0VGlaKANs1PUHJaiqlz3kQDvLush4et9lBXd8uYINSYk
SSSYyoIIrbF8Pd709vcpnlH+Sh//IpfjOBm1U+fgwDh6MHzyyPqbo69RUKH4/xz5E+2H
er+/VD/NJ0Gzf23i4+HMnbS1ZXqfmUFI/YrK6kHsuaWyfeOLOZhbqaB3TdFaMyXDh3GI
0RlYAorFzTKgsYvnIZXJPn2sjTfqUy+kUei7FfrLWS6Cy1oVLtw0rrOKuP1laHo56CuD
n/saIJhfvx6hDfIdF7AjtMvoBw/0RxlvKmJJlHZm4uYgG91GT99ZewfCi9PU8LxE+GOi
Knqw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:cc:to:subject:message-id:date
:mime-version:references:in-reply-to:from:x-gm-message-state:from:to
:cc:subject:date:message-id:reply-to;
bh=LcGQ/2pyrBdE6ApMyVbkjAi4QZ0D5baK3szWvcf9Emk=;
b=5Z9gmtQ68cOx7M+8Nj2Wf7bl8vOrhEUKe0PPqm6wqDQ1E63xVgtiQvBiNrb6TGa4Uw
aM4/UgMsWweWqb8N4FLDSzanVghuXI1YAyP6V8jYrsQehl+oIn4YCtLmWaKbgL2n26no
4615L4zqoi66dNw/hz8HehVllRBpRTeq2iR9m0gfWEB2lEvH+GrEcOT9w6h7yt2vo2FL
PNmdjCXsbkAxvAH9NlyGlSdNoUP3upmQEG0NhXdYePIep4h0wMUAg6r0ZQTlzRz41sZ3
SQ/4GF1nDMW9kA2i2lDKvnu0H7JUICfsO4DQi+G6oJf69LrVYx3fW9W4bEKhhzkjARF2
zJnA==
X-Gm-Message-State: AFqh2koRZio2B+UU9M3SWyruC77dm/jBvO7q8ATSOEbBw6x/z0khJejI
G59NhD4uD90Gdm66l0GDhKGlgDmnf8psx4t7/D4=
X-Google-Smtp-Source: AMrXdXsAggkPslPIwK2y2pf20p3qGSU1K+A6UK5tjZ2iwor9ASnZcb3OqhVrqyd1+6e7h9A13b5vHvp+wxr+aUjx4Q8=
X-Received: by 2002:a05:6870:9f86:b0:14c:667e:4620 with SMTP id
xm6-20020a0568709f8600b0014c667e4620mr3112548oab.92.1673201647805; Sun, 08
Jan 2023 10:14:07 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Sun, 8 Jan 2023 10:14:07 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <83lemdr2qt.fsf@HIDDEN>
References: <B1EA10E7-5AC1-4F81-869A-112CCF8AED80@HIDDEN>
<83lemdr2qt.fsf@HIDDEN>
X-Hashcash: 1:20:230108:casouri@HIDDEN::w87gw0FFBFgo2WVv:74Zl
MIME-Version: 1.0
Date: Sun, 8 Jan 2023 10:14:07 -0800
Message-ID: <CADwFkmnZP8erjEB5+OrbgdOa5ikbFjLtPLsb0rOThQbrRv8pRA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
>> I can make treesit-ready-p not emit any warning by default, and change
>> the quiet parameter to WARN, and accept either 'warn or =E2=80=98message=
.
>>
>> Basically:
>>
>> (treesit-ready-p lang) =3D> t/nil
>> (treesit-ready-p lang 'warn) =3D> t/emit warning
>> (treesit-ready-p lang 'message) =3D> t/message
This makes sense to me.
>> Eli, WDYT?
>
> I think the default should be to emit a warning, like we do now.
In that case, it would be better to rename `treesit-ready-p' to reflect
that it's not a predicate function. I believe Juri suggested the name
`treesit-check-readiness'.
Then there's the question if we want a predicate function for this too.
I think it would be useful.
> We should support the main use case of the user turning on a TS mode
> when the required libraries are not installed or incompatible with our
> requirements. Silently doing nothing in that case is not TRT.
To be clear, I did not suggest changing that behavior.
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 08 Jan 2023 18:30:03 +0000
Resent-Message-ID: <handler.60511.B60511.167320256232117 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Eli Zaretskii <eliz@HIDDEN>
Cc: casouri@HIDDEN, stefankangas@HIDDEN, 60511 <at> debbugs.gnu.org
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.167320256232117
(code B ref 60511); Sun, 08 Jan 2023 18:30:03 +0000
Received: (at 60511) by debbugs.gnu.org; 8 Jan 2023 18:29:22 +0000
Received: from localhost ([127.0.0.1]:34633 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pEaQ6-0008Lv-80
for submit <at> debbugs.gnu.org; Sun, 08 Jan 2023 13:29:22 -0500
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:52521)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1pEaQ3-0008Lg-RG
for 60511 <at> debbugs.gnu.org; Sun, 08 Jan 2023 13:29:20 -0500
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 7093860002;
Sun, 8 Jan 2023 18:29:11 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <83lemcq57n.fsf@HIDDEN> (Eli Zaretskii's message of "Sun, 08 Jan
2023 19:57:48 +0200")
Organization: LINKOV.NET
References: <B1EA10E7-5AC1-4F81-869A-112CCF8AED80@HIDDEN>
<83lemdr2qt.fsf@HIDDEN> <86358lwhbr.fsf@HIDDEN>
<837cxxqoeq.fsf@HIDDEN> <86pmboudmk.fsf@HIDDEN>
<83lemcq57n.fsf@HIDDEN>
Date: Sun, 08 Jan 2023 20:11:42 +0200
Message-ID: <86ilhguc9t.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> >> > I think the default should be to emit a warning, like we do now.
>> >>
>> >> Then how users could change this default?
>> >
>> > In what situation?
>> >
>> > If they invoke the mode, they aren't supposed to disable the warning,
>> > and they cannot.
>>
>> In a situation when they want simply to visit a file without using
>> tree-sitter features, and that visit won't require from them
>> customization with modifying auto-mode-alist, etc.
>
> This will soon become a non-issue, as I plan on removing all the TS
> modes from auto-mode-alist. Only loading the mode will add it back to
> the alist. So there will be no surprises, and no need to conceal the
> warning.
Why users need to always load modes that they are using only occasionally?
X-Loop: help-debbugs@HIDDEN
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 08 Jan 2023 18:30:04 +0000
Resent-Message-ID: <handler.60511.B60511.167320256832149 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60511
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, Yuan Fu <casouri@HIDDEN>, 60511 <at> debbugs.gnu.org
Received: via spool by 60511-submit <at> debbugs.gnu.org id=B60511.167320256832149
(code B ref 60511); Sun, 08 Jan 2023 18:30:04 +0000
Received: (at 60511) by debbugs.gnu.org; 8 Jan 2023 18:29:28 +0000
Received: from localhost ([127.0.0.1]:34639 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pEaQB-0008MT-T7
for submit <at> debbugs.gnu.org; Sun, 08 Jan 2023 13:29:28 -0500
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:48437)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1pEaQ9-0008Lm-1L
for 60511 <at> debbugs.gnu.org; Sun, 08 Jan 2023 13:29:25 -0500
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 3723760004;
Sun, 8 Jan 2023 18:29:17 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <CADwFkmnZP8erjEB5+OrbgdOa5ikbFjLtPLsb0rOThQbrRv8pRA@HIDDEN>
(Stefan Kangas's message of "Sun, 8 Jan 2023 10:14:07 -0800")
Organization: LINKOV.NET
References: <B1EA10E7-5AC1-4F81-869A-112CCF8AED80@HIDDEN>
<83lemdr2qt.fsf@HIDDEN>
<CADwFkmnZP8erjEB5+OrbgdOa5ikbFjLtPLsb0rOThQbrRv8pRA@HIDDEN>
Date: Sun, 08 Jan 2023 20:28:45 +0200
Message-ID: <86cz7oswwy.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> I think the default should be to emit a warning, like we do now.
>
> In that case, it would be better to rename `treesit-ready-p' to reflect
> that it's not a predicate function. I believe Juri suggested the name
> `treesit-check-readiness'.
Actually, I think `treesit-check-readiness' is a worse name.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.