GNU bug report logs - #60525
29.0.60; tree-sitter support in semantic-symref

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Juri Linkov <juri@HIDDEN>; dated Tue, 3 Jan 2023 18:08:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 18:43:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 13:43:17 2023
Received: from localhost ([127.0.0.1]:49611 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pD8jM-0004OC-Lr
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 13:43:16 -0500
Received: from eggs.gnu.org ([209.51.188.92]:34682)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pD8jK-0004Ny-5r
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 13:43:14 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD8jE-0005kK-Vf; Wed, 04 Jan 2023 13:43:08 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=TMz9zEy+MXTGnICPbYT6THHOfIpj6k9AMuqxIc5HSh8=; b=QAWDQk8qOE14
 xfjys1nRwAMO5kqfzFEjiPGGJX/M6mDdmk52wfuHvLqAXwzG57XZ1nK9bAef1VOAfotKRWjSS5Lsx
 ss5nWq/qzA4yuWaY2MGCR+cu2l6CQIsP3tXFNfgs5rM4DQcoJW7Os5kcJf8QjE5EzvnftoYDMBusz
 i2Up83SUQlVPvnkNu68ZoxnzH8/qqBlDVSLsLD0SufYS1fIaparq7p4ATWTFfQcMRVQREW1sqtu4K
 QLWutAs3BwUujm3qpBEQ6rfYS8fYnkcCCIrwRgGYr3173uiKyDMyTrcLJoKddZzF0w6qVphlUGL6A
 044DzU8V2ugl++iE9k9aUA==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD8jE-0004dw-G5; Wed, 04 Jan 2023 13:43:08 -0500
Date: Wed, 04 Jan 2023 20:43:21 +0200
Message-Id: <83pmbuxhrq.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <jwv4jt6dv0i.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Wed, 04 Jan 2023 13:20:26 -0500)
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN>
 <83pmbuz88u.fsf@HIDDEN> <jwvwn62e235.fsf-monnier+emacs@HIDDEN>
 <83a62yz18b.fsf@HIDDEN> <jwvfscqdvnn.fsf-monnier+emacs@HIDDEN>
 <jwv4jt6dv0i.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60525
Cc: larsi@HIDDEN, juri@HIDDEN, 60525 <at> debbugs.gnu.org, dgutov@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: dgutov@HIDDEN,  larsi@HIDDEN,  juri@HIDDEN,  60525 <at> debbugs.gnu.org
> Date: Wed, 04 Jan 2023 13:20:26 -0500
> 
> - move the info from `semantic-symref-filepattern-alist` to
>   a buffer-local `semantic-symref-filepattern` which is set by the major
>   modes, so the same setting can be shared by the various modes like all
>   the other buffer-local settings (`comment-start`, ...).
> 
> BTW, I see that the info provided by `semantic-symref-filepattern-alist`
> could be (re)used also in `C-u M-x grep`.

Fine with me, but that is hardly for the release branch.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 18:39:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 13:39:15 2023
Received: from localhost ([127.0.0.1]:49597 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pD8fT-0004HF-52
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 13:39:15 -0500
Received: from eggs.gnu.org ([209.51.188.92]:50194)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pD8fQ-0004H2-LY
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 13:39:13 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD8fK-0002sZ-Vy; Wed, 04 Jan 2023 13:39:07 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=HZcnnhPKMaFSRV4Z58lYeVLnuIdOXI3sXvgru/brfGQ=; b=XlUkkHI7lxog
 gusdF2aAYppixHzY2eho4Qtr/WzC+PQOhzynbe8mvg0FwlVb4pDQT5hH2P1JO4J4DuVbdECb4iJmg
 aVRHzj0MOS9WFDQ3fKaAbdnl992VNjqlXqpLjfEqbbjliD0zV6L3DcxkCaPkm5Bx5+hPJ/OGPUATw
 MAPpYmnsp2tGcyGy4nR+2kwwIX2DjYVL6XwLfu4P8Yq/rSpNQn6oglfaSMg6GaHgjruNkJoAog2EK
 NI5mBnm8BMZaa645EXu2PYNGms8JNc4Vn/Gh6H9iTGMCrl3PJt2ZUaiES6DqTQZzIwVB8F6lc3rEi
 IeEmCku+xN2DVHoYAJm2Mg==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD8fK-0004EN-6I; Wed, 04 Jan 2023 13:39:06 -0500
Date: Wed, 04 Jan 2023 20:39:19 +0200
Message-Id: <83sfgqxhyg.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <jwvfscqdvnn.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Wed, 04 Jan 2023 13:07:47 -0500)
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN>
 <83pmbuz88u.fsf@HIDDEN> <jwvwn62e235.fsf-monnier+emacs@HIDDEN>
 <83a62yz18b.fsf@HIDDEN> <jwvfscqdvnn.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60525
Cc: larsi@HIDDEN, juri@HIDDEN, 60525 <at> debbugs.gnu.org, dgutov@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: dgutov@HIDDEN,  larsi@HIDDEN,  juri@HIDDEN,  60525 <at> debbugs.gnu.org
> Date: Wed, 04 Jan 2023 13:07:47 -0500
> 
> - make the various variants of a major mode all inherit from a shared
>   parent mode (and then use that shared parent mode in
>   `semantic-symref-filepattern-alist`).

This idea was tried, but it doesn't work well enough, at least not for
all such mode pairs.

> - Use `set-auto-mode--last` which remembers the mode specified before it
>   was remapped by things like `major-mode-remap-alist` (or by dispatch
>   functions like `tex-mode`).

I'd need to see the code to reason about it (though I understand the
general idea).




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 18:20:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 13:20:37 2023
Received: from localhost ([127.0.0.1]:49549 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pD8NR-0003kY-6I
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 13:20:37 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28155)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1pD8NP-0003kK-7q
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 13:20:36 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DCFB3441B02;
 Wed,  4 Jan 2023 13:20:29 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 06EC64409B9;
 Wed,  4 Jan 2023 13:20:28 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1672856428;
 bh=sRUnH2fXejDrxO5GZujCL85zhGlC2r2yiW5qd6cY7t8=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=CI9a6etbKK7aGt43ZtLlpUZA20VqvRc2tPHbw2IA1LJG6JCwYbYfmAU75ShDlT3IF
 /0yDyBnBrAXuD5ZsEDDozY7CxZ4YIrh1yJ0+yuLPLHKidbGGTQ3m8Zv4Qz+LC1/axT
 roDtsULR4PiF/jmkxHCZRhWK3HkDjIQidzQ1S9A5aJmnD6yMfFXx9PcAu++1QuRJjc
 omvPLt+TfWxCBUt4uuLIj/ho8FbxahWvF7bdFjNOALnJ1EzSN5YTyU9+7Zdap78n/v
 GV/FRTvUdYLRmfBWU0eaqbf6nRsBq2UUgawXzDbarLJPHfiUEeC4wBBy7vaiiRpk3+
 XB1skYY6LktTg==
Received: from pastel (unknown [45.72.200.228])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C4714120840;
 Wed,  4 Jan 2023 13:20:27 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
In-Reply-To: <jwvfscqdvnn.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Wed, 04 Jan 2023 13:07:47 -0500")
Message-ID: <jwv4jt6dv0i.fsf-monnier+emacs@HIDDEN>
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN>
 <83pmbuz88u.fsf@HIDDEN> <jwvwn62e235.fsf-monnier+emacs@HIDDEN>
 <83a62yz18b.fsf@HIDDEN> <jwvfscqdvnn.fsf-monnier+emacs@HIDDEN>
Date: Wed, 04 Jan 2023 13:20:26 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.292 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60525
Cc: larsi@HIDDEN, juri@HIDDEN, 60525 <at> debbugs.gnu.org, dgutov@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>>> >> On 03/01/2023 20:06, Juri Linkov wrote:
>>> >> > +    (c-ts-mode "*.[ch]")
>>> >> >       (c++-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
>>> >> > +    (c++-ts-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
>>> >> >       (html-mode "*.html" "*.shtml" "*.php")
>>> >> >       (mhtml-mode "*.html" "*.shtml" "*.php") ; FIXME: remove
>>> >> >                                               ; duplication of
>>> >> > @@ -53,7 +55,10 @@ semantic-symref-filepattern-alist
>>> >> >                                               ; major mode definition?
>>> >> >       (ruby-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
>>> >> >                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
>>> >> > +    (ruby-ts-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
>>> >> > +                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
>>> >> >       (python-mode "*.py" "*.pyi" "*.pyw")
>>> >> 
>>> >> Instead of duplicating entries, we could try to look up the remappings 
>>> >> in major-mode-remap-alist.
>>> >
>>> > That doesn't sound to me like the use of major-mode-remap-alist that
>>> > was intended.
>>> >
>>> > I'm okay with duplication at this point.  It is much easier, and we
>>> > can always augment or fix later as needed.  I see no reason to do
>>> > anything fancier at this point.
>>> >
>>> > Stefan, Lars, WDYT?
>>> 
>>> I'll just note that the above alists already duplicate info present in
>>> `auto-mode-alist`.  Admittedly, this redundant info is present in
>>> a different form, so maybe not directly usable as is, but if we care
>>> about redundancy, we should maybe add some layer on top which we can
>>> then use both for `semantic-symref-filepattern-alist` and for
>>> `auto-mode-alist`.
>>
>> I' aware of the redundancy.  But since we decided to go with those
>> separate modes in Emacs 29, I think the redundancy is in general
>> unavoidable.  If we can use the fact that auto-mode-alist already
>> mentions both modes, and we can do that cleanly, it's fine by me.
>> Otherwise we will have to live with this for now.
>
> BTW, other ways to reduce the redundancy (not between
> `semantic-symref-filepattern-alist` and `auto-mode-alist`, but the one
> introduced by the patch above):
>
> - make the various variants of a major mode all inherit from a shared
>   parent mode (and then use that shared parent mode in
>   `semantic-symref-filepattern-alist`).
>
> - Use `set-auto-mode--last` which remembers the mode specified before it
>   was remapped by things like `major-mode-remap-alist` (or by dispatch
>   functions like `tex-mode`).

Oh, and of course:

- move the info from `semantic-symref-filepattern-alist` to
  a buffer-local `semantic-symref-filepattern` which is set by the major
  modes, so the same setting can be shared by the various modes like all
  the other buffer-local settings (`comment-start`, ...).

BTW, I see that the info provided by `semantic-symref-filepattern-alist`
could be (re)used also in `C-u M-x grep`.


        Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 18:07:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 13:07:59 2023
Received: from localhost ([127.0.0.1]:49531 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pD8BD-0003R8-0c
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 13:07:59 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35370)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1pD8BB-0003Qu-AR
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 13:07:57 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 15F511004D9;
 Wed,  4 Jan 2023 13:07:51 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3E2C310033C;
 Wed,  4 Jan 2023 13:07:49 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1672855669;
 bh=t4uJ8rvNUrzRlR7jKS4f/MZY86nBFH1+lMr7i1yLpqE=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=g5IJKMn7IkoG0X7dUrc9H2AhRO7b0cvauCxMmyBTNesUJ5PjgWwTre5xQzbhueNIJ
 pD2rP9uuTQjDpGVSqew/6z0er/MmkypgBqHGzBdpvgZ4IIufPAs+zEvpC5NkNEsdmv
 0E1PNj9pd7BtbWAznRvjKAdG5HueX21VaBNDht/bF7RpHiQ50pX7CXvro3BQVEPAfH
 xzpjyNCsPKRrEjctWJmtCo30JESGbQ7zvV21erZOvMDEH1HOmpVUiFHNzIO73uhALn
 qHDqe9NJfq4TOExWiWkRRvGt3SMd9PMCZYQX7K8vM+UTj7y4PGCLcEpDLduznzWR+S
 EFCkkj0uT1XbQ==
Received: from pastel (unknown [45.72.200.228])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 09A261201F0;
 Wed,  4 Jan 2023 13:07:49 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
In-Reply-To: <83a62yz18b.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 04 Jan
 2023 18:57:40 +0200")
Message-ID: <jwvfscqdvnn.fsf-monnier+emacs@HIDDEN>
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN>
 <83pmbuz88u.fsf@HIDDEN> <jwvwn62e235.fsf-monnier+emacs@HIDDEN>
 <83a62yz18b.fsf@HIDDEN>
Date: Wed, 04 Jan 2023 13:07:47 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.391 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60525
Cc: larsi@HIDDEN, juri@HIDDEN, 60525 <at> debbugs.gnu.org, dgutov@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> >> On 03/01/2023 20:06, Juri Linkov wrote:
>> >> > +    (c-ts-mode "*.[ch]")
>> >> >       (c++-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
>> >> > +    (c++-ts-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
>> >> >       (html-mode "*.html" "*.shtml" "*.php")
>> >> >       (mhtml-mode "*.html" "*.shtml" "*.php") ; FIXME: remove
>> >> >                                               ; duplication of
>> >> > @@ -53,7 +55,10 @@ semantic-symref-filepattern-alist
>> >> >                                               ; major mode definition?
>> >> >       (ruby-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
>> >> >                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
>> >> > +    (ruby-ts-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
>> >> > +                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
>> >> >       (python-mode "*.py" "*.pyi" "*.pyw")
>> >> 
>> >> Instead of duplicating entries, we could try to look up the remappings 
>> >> in major-mode-remap-alist.
>> >
>> > That doesn't sound to me like the use of major-mode-remap-alist that
>> > was intended.
>> >
>> > I'm okay with duplication at this point.  It is much easier, and we
>> > can always augment or fix later as needed.  I see no reason to do
>> > anything fancier at this point.
>> >
>> > Stefan, Lars, WDYT?
>> 
>> I'll just note that the above alists already duplicate info present in
>> `auto-mode-alist`.  Admittedly, this redundant info is present in
>> a different form, so maybe not directly usable as is, but if we care
>> about redundancy, we should maybe add some layer on top which we can
>> then use both for `semantic-symref-filepattern-alist` and for
>> `auto-mode-alist`.
>
> I' aware of the redundancy.  But since we decided to go with those
> separate modes in Emacs 29, I think the redundancy is in general
> unavoidable.  If we can use the fact that auto-mode-alist already
> mentions both modes, and we can do that cleanly, it's fine by me.
> Otherwise we will have to live with this for now.

BTW, other ways to reduce the redundancy (not between
`semantic-symref-filepattern-alist` and `auto-mode-alist`, but the one
introduced by the patch above):

- make the various variants of a major mode all inherit from a shared
  parent mode (and then use that shared parent mode in
  `semantic-symref-filepattern-alist`).

- Use `set-auto-mode--last` which remembers the mode specified before it
  was remapped by things like `major-mode-remap-alist` (or by dispatch
  functions like `tex-mode`).


        Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 17:17:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 12:17:13 2023
Received: from localhost ([127.0.0.1]:49489 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pD7O5-0001sT-1c
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 12:17:13 -0500
Received: from eggs.gnu.org ([209.51.188.92]:56218)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pD7O2-0001sG-OW
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 12:17:11 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD7Nx-0006Yj-EC; Wed, 04 Jan 2023 12:17:05 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=RqJysfbfU2amNFUjCFcVyzOv43Ts2P/N1QdsEnIaPt0=; b=Egn+NoKaF+gL
 NkZkUtxFReqSQYHa3U/do4FceoLFlrkdRYbR331G2LwcREvR3oKjJIZV4kXFaNrzAPO5Qm8H16f2q
 IMVsMCWNLc/OS9uP7suasHqzLNQDc4c17fKO3VKw51jtgV5K1vWbU5uJaDIBNxvsMniEnHVZcv6s0
 0u4CnTS4oqFKjA/YDlqZ1+MWNy2ImHdlSurPt1/WaifUVP7YKBshE5HyOAH/IFX4QxAMrs4GOva04
 UQ3lnvrCyiC5YMbaHUPwrHvGizKuckLzOyaZV4/bHBmKUPbavH17YdE2OCQGK00atEpeQx3jCGG+3
 HYj0uns2B/oSnS9Oby5Bcw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD7Nw-00044d-Pd; Wed, 04 Jan 2023 12:17:05 -0500
Date: Wed, 04 Jan 2023 19:17:17 +0200
Message-Id: <834jt6z0bm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
In-Reply-To: <079899b3-8c81-dba7-0e53-9b521fd14f23@HIDDEN> (message from
 Dmitry Gutov on Wed, 4 Jan 2023 19:03:28 +0200)
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN> <83pmbuz88u.fsf@HIDDEN>
 <jwvwn62e235.fsf-monnier+emacs@HIDDEN> <83a62yz18b.fsf@HIDDEN>
 <079899b3-8c81-dba7-0e53-9b521fd14f23@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60525
Cc: larsi@HIDDEN, 60525 <at> debbugs.gnu.org, monnier@HIDDEN,
 juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Wed, 4 Jan 2023 19:03:28 +0200
> Cc: larsi@HIDDEN, juri@HIDDEN, 60525 <at> debbugs.gnu.org
> From: Dmitry Gutov <dgutov@HIDDEN>
> 
> On 04/01/2023 18:57, Eli Zaretskii wrote:
> > I' aware of the redundancy.  But since we decided to go with those
> > separate modes in Emacs 29, I think the redundancy is in general
> > unavoidable.  If we can use the fact that auto-mode-alist already
> > mentions both modes, and we can do that cleanly, it's fine by me.
> > Otherwise we will have to live with this for now.
> 
> I believe Stefan is referring to redundancy between auto-mode-alist and 
> semantic-symref-filepattern-alist.

Yes, I understood that, and my response was to that aspect.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 17:03:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 12:03:37 2023
Received: from localhost ([127.0.0.1]:49473 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pD7Av-0001XY-Ey
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 12:03:37 -0500
Received: from mail-ej1-f50.google.com ([209.85.218.50]:36661)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1pD7Au-0001XM-4R
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 12:03:36 -0500
Received: by mail-ej1-f50.google.com with SMTP id qk9so83952313ejc.3
 for <60525 <at> debbugs.gnu.org>; Wed, 04 Jan 2023 09:03:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:from:to:cc:subject:date:message-id:reply-to;
 bh=3zEYGfEhfACGKxMY0MimBnX9/m0lxjMQOCY9xTq+eog=;
 b=FSuhDvot23aYtgZrKYXck5ZEF6KfmBsnNvGnam4gPgtYw9kCh1Q/GJ61SAJZHZ3KUZ
 75vRR5AhKYeiHR0u+DpTnmEmtLlriKDjZ2z1pW2htleHydaYM2PSdmfaG37YxKuIp/QZ
 oUXn6gC4HB66kqoFoxVt/QrZfMcQOybI0Gk/PClp6iyi6CgZcZA1zpj18Q5CyspjEZgo
 OlJsoTcSbpnnTNDGdbunhe50eNXO/Gnw046H+keQ+t6UDgmYt7IUOP0TWS6G83JBRpN0
 uWmxWnog3h3rgcjKiz1cQ+OmtVbpJ3BMrHFdSjEhOyiNF5pWvYIQamYKXITllVDu6Cps
 xaBA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=3zEYGfEhfACGKxMY0MimBnX9/m0lxjMQOCY9xTq+eog=;
 b=L708hHu6QtFt0C1sDOzxUiOB2ky3fv1kg0mfnsBIZJ0z2zm6Vz/t65kibXWNW8r/8P
 GhT4xNJ/p8uP7eZ8prmTIaCGEtVTQwGmC5QPpv8M5a3+59OX4TT5HTPh098eSCZTTM7L
 7dwfygYYdptNsRicybqUO6c3JyPt/gjjAD5nlo1EE6oP/YhuiA7lPdVwa8bZPrpFNi2O
 TRHPRFv8S4UhCNQ7V1YRRSrW7+o73bYVnxFtwSjyzRQ7edCc3aHsilsPYkGiNw9zdhzk
 XA4V2ustaVOcvGRty4Kp5ZT0U03HySRkENoPoKlCrAubEu7Lxce/xFaiOAk8qrtme6cp
 /7gA==
X-Gm-Message-State: AFqh2koJ5ZiB0mjOurO3gLk2C4Z4PY2QNIEg1rndZfVF4nK/FL+fLyNU
 N8tXktVPpxGyL17L2rz1JVnNPj0GQlg=
X-Google-Smtp-Source: AMrXdXtKxJQ45ahLqgMltjo854iyV9m7THHff04JQjkiZvGkw05F2DFtIRbp68PivB8nQNVVME8XPw==
X-Received: by 2002:a17:906:a186:b0:803:4549:300b with SMTP id
 s6-20020a170906a18600b008034549300bmr57679376ejy.19.1672851810251; 
 Wed, 04 Jan 2023 09:03:30 -0800 (PST)
Received: from [192.168.0.2] ([46.251.119.176])
 by smtp.googlemail.com with ESMTPSA id
 u17-20020a1709061db100b0084c70c27407sm9975773ejh.84.2023.01.04.09.03.29
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 04 Jan 2023 09:03:29 -0800 (PST)
Message-ID: <079899b3-8c81-dba7-0e53-9b521fd14f23@HIDDEN>
Date: Wed, 4 Jan 2023 19:03:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
Content-Language: en-US
To: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN>
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN> <83pmbuz88u.fsf@HIDDEN>
 <jwvwn62e235.fsf-monnier+emacs@HIDDEN> <83a62yz18b.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
In-Reply-To: <83a62yz18b.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.9 (/)
X-Debbugs-Envelope-To: 60525
Cc: larsi@HIDDEN, 60525 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.9 (-)

On 04/01/2023 18:57, Eli Zaretskii wrote:
> I' aware of the redundancy.  But since we decided to go with those
> separate modes in Emacs 29, I think the redundancy is in general
> unavoidable.  If we can use the fact that auto-mode-alist already
> mentions both modes, and we can do that cleanly, it's fine by me.
> Otherwise we will have to live with this for now.

I believe Stefan is referring to redundancy between auto-mode-alist and 
semantic-symref-filepattern-alist. Which seems unavoidable so far as the 
former requires just one element in the car position, and the latter 
works with lists of filename globs.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 16:57:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 11:57:38 2023
Received: from localhost ([127.0.0.1]:49460 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pD757-0001Mm-Q4
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 11:57:38 -0500
Received: from eggs.gnu.org ([209.51.188.92]:33984)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pD755-0001Ma-TJ
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 11:57:36 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD74z-0006Fy-1p; Wed, 04 Jan 2023 11:57:29 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=NKtCHiceJioApg6chBWWGBzIO15Wlv4g5wh/vEZl7uk=; b=czwLVtaH9RwL
 q/lLO3QD7eYdmrixb9N4Rs7yM41YPNFRf0YJECq1mVY+Rv2KPOHI7R1q7WL30sm8BXwNmG6wx2tmu
 C5kIbqL7wTgy7xWBVbPFGUWw2U2kbJFsQSWZYtApDbuSg8s+yXkpjF4L4vDsppv+Xc/gtY4iqkHYb
 nOBY0nWa97MCq01ulg7C/ph4u/Rb7yYdRjpQsxky6Jau0viH2wJNj/iWZdgi7C1JIzXaCl7i1Qk67
 LOX1hl9u4aO/ElGocuXPn+ijy2K0pbTsFLThh9QYqweltkTRX5BWuK6tN++N+ZG/I+OHrXtRhsa6w
 PRvCJJThCIk+hnnh0ME8aw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD74y-00075y-AR; Wed, 04 Jan 2023 11:57:28 -0500
Date: Wed, 04 Jan 2023 18:57:40 +0200
Message-Id: <83a62yz18b.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <jwvwn62e235.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Wed, 04 Jan 2023 10:47:54 -0500)
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN>
 <83pmbuz88u.fsf@HIDDEN> <jwvwn62e235.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60525
Cc: larsi@HIDDEN, juri@HIDDEN, 60525 <at> debbugs.gnu.org, dgutov@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: Dmitry Gutov <dgutov@HIDDEN>,  Lars Ingebrigtsen <larsi@HIDDEN>,
>   juri@HIDDEN,  60525 <at> debbugs.gnu.org
> Date: Wed, 04 Jan 2023 10:47:54 -0500
> 
> >> On 03/01/2023 20:06, Juri Linkov wrote:
> >> > +    (c-ts-mode "*.[ch]")
> >> >       (c++-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
> >> > +    (c++-ts-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
> >> >       (html-mode "*.html" "*.shtml" "*.php")
> >> >       (mhtml-mode "*.html" "*.shtml" "*.php") ; FIXME: remove
> >> >                                               ; duplication of
> >> > @@ -53,7 +55,10 @@ semantic-symref-filepattern-alist
> >> >                                               ; major mode definition?
> >> >       (ruby-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
> >> >                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
> >> > +    (ruby-ts-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
> >> > +                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
> >> >       (python-mode "*.py" "*.pyi" "*.pyw")
> >> 
> >> Instead of duplicating entries, we could try to look up the remappings 
> >> in major-mode-remap-alist.
> >
> > That doesn't sound to me like the use of major-mode-remap-alist that
> > was intended.
> >
> > I'm okay with duplication at this point.  It is much easier, and we
> > can always augment or fix later as needed.  I see no reason to do
> > anything fancier at this point.
> >
> > Stefan, Lars, WDYT?
> 
> I'll just note that the above alists already duplicate info present in
> `auto-mode-alist`.  Admittedly, this redundant info is present in
> a different form, so maybe not directly usable as is, but if we care
> about redundancy, we should maybe add some layer on top which we can
> then use both for `semantic-symref-filepattern-alist` and for
> `auto-mode-alist`.

I' aware of the redundancy.  But since we decided to go with those
separate modes in Emacs 29, I think the redundancy is in general
unavoidable.  If we can use the fact that auto-mode-alist already
mentions both modes, and we can do that cleanly, it's fine by me.
Otherwise we will have to live with this for now.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 15:48:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 10:48:05 2023
Received: from localhost ([127.0.0.1]:49373 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pD5zp-0007pZ-7G
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 10:48:05 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48643)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1pD5zn-0007oS-5i
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 10:48:03 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C649744111F;
 Wed,  4 Jan 2023 10:47:57 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0E5454410C2;
 Wed,  4 Jan 2023 10:47:56 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1672847276;
 bh=/wwXLcf9Ko4SCUZGO73KYyN1pe43r0iOPwQINAf5COU=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=PRHaA/ZgMYgyWnbhQx7+xi82xuAnPRsDQQRix4JzL1lTfraYHzx1zSDtaE/75779K
 ehsrSH3Thar43O2K0Sl/DYEpGaAt2vqQ6Hzzl0ffivp3sn90P1zA4DdbJEu/l99oU4
 Bs11kk/I9zQVKap/Y4Njr2zF7MZOZEj9GcZz2+OZcCyc55zI1LYC9biU1R7vOYQZyB
 wqSirmbRC5idTpW6W5MR80mNxQXItrADKWe4FqKdmvRd89tlDtNthsIoE9es8wkmZK
 b5sM7XRDVJp5krd0vQ9lafO2bp8NduUSVt4fUgDMuDoIxoIFatEqrUujryIHiFg5Ty
 d9sCTJonEHisA==
Received: from pastel (unknown [45.72.200.228])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CDE1F1209BE;
 Wed,  4 Jan 2023 10:47:55 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
In-Reply-To: <83pmbuz88u.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 04 Jan
 2023 16:26:09 +0200")
Message-ID: <jwvwn62e235.fsf-monnier+emacs@HIDDEN>
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN>
 <83pmbuz88u.fsf@HIDDEN>
Date: Wed, 04 Jan 2023 10:47:54 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.298 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60525
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, juri@HIDDEN, 60525 <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> On 03/01/2023 20:06, Juri Linkov wrote:
>> > +    (c-ts-mode "*.[ch]")
>> >       (c++-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
>> > +    (c++-ts-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
>> >       (html-mode "*.html" "*.shtml" "*.php")
>> >       (mhtml-mode "*.html" "*.shtml" "*.php") ; FIXME: remove
>> >                                               ; duplication of
>> > @@ -53,7 +55,10 @@ semantic-symref-filepattern-alist
>> >                                               ; major mode definition?
>> >       (ruby-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
>> >                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
>> > +    (ruby-ts-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
>> > +                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
>> >       (python-mode "*.py" "*.pyi" "*.pyw")
>> 
>> Instead of duplicating entries, we could try to look up the remappings 
>> in major-mode-remap-alist.
>
> That doesn't sound to me like the use of major-mode-remap-alist that
> was intended.
>
> I'm okay with duplication at this point.  It is much easier, and we
> can always augment or fix later as needed.  I see no reason to do
> anything fancier at this point.
>
> Stefan, Lars, WDYT?

I'll just note that the above alists already duplicate info present in
`auto-mode-alist`.  Admittedly, this redundant info is present in
a different form, so maybe not directly usable as is, but if we care
about redundancy, we should maybe add some layer on top which we can
then use both for `semantic-symref-filepattern-alist` and for
`auto-mode-alist`.


        Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 14:34:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 09:34:10 2023
Received: from localhost ([127.0.0.1]:48001 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pD4qH-0005Vx-KP
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 09:34:10 -0500
Received: from eggs.gnu.org ([209.51.188.92]:51850)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pD4qF-0005Vj-NJ
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 09:34:08 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD4q7-0008Pt-RH; Wed, 04 Jan 2023 09:34:01 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=pNxmOrY5D6dqYPv9RdM/xGnn4Xy13h7YXTFqQwJ2WtM=; b=XufVk3q/ur1Z
 yffOxDy2ZcQkNsiGzXZYEhINCJO4z47xhMD5sZsWUbnIj/qCYkRvFdgzSFKj4RKs6hD1YR5LTL9NP
 IgOe7IOS6sbQpIE/7rzEio3QvK/LhUKiSbY4z4PIKRv6n3meWtkaX5+WlhFhYjzZ1iR9Czgue06g0
 OEx221v1GkZ7+ZnyUS8IhxXNJ1HJ3iMCEXGdtdRxKRLwFmsJohHoc5Q4lnXfs4TV1P+qA+C35JqLw
 G+cYZK0hRYoe72NEFGMjANaEoGfDFvwNQWoabs32wEu9LWQy7R3u8B9mXYPpsrMxZ9YM93yWjrsOo
 fwvgXfpeb62eMn1dmpiflw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD4q6-0000bn-1p; Wed, 04 Jan 2023 09:33:59 -0500
Date: Wed, 04 Jan 2023 16:34:10 +0200
Message-Id: <83o7rez7vh.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <86k0224uen.fsf@HIDDEN> (message from Juri Linkov on
 Wed, 04 Jan 2023 09:43:12 +0200)
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN>
 <86k0224uen.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60525
Cc: 60525 <at> debbugs.gnu.org, dgutov@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 60525 <at> debbugs.gnu.org
> From: Juri Linkov <juri@HIDDEN>
> Date: Wed, 04 Jan 2023 09:43:12 +0200
> 
> > diff --git a/lisp/cedet/semantic/symref/grep.el
> > ...
> > -	 (pat (cdr (assoc mode semantic-symref-filepattern-alist))))
> > +	 (pat
> > +          (or (assoc-default mode semantic-symref-filepattern-alist)
> > +              (assoc-default (car (rassoc mode major-mode-remap-alist))
> > +                             semantic-symref-filepattern-alist))))
> 
> I'm fine with this change if Eli agrees to install it
> on the emacs-29 branch.

No, it's too much for the release branch, and as I wrote elsewhere,
doesn't sound justified to me.

> But also note that such duplication is unavoidable in many other places.
> For example, to support abbreviations there is the need to manually
> rename
> 
>   (define-abbrev-table 'ruby-mode-abbrev-table
> 
> to
> 
>   (define-abbrev-table 'ruby-base-mode-abbrev-table
> 
> in ~/.emacs.d/abbrev_defs.  But on exiting Emacs it insists
> on saving duplicate abbrevs to 
> 
>   (define-abbrev-table 'ruby-ts-mode-abbrev-table

There's no way around that: people who want use both modes will have
to live with duplication for now.  There's a limit to what we can do
so close to the release.  Sorry.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 14:26:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 09:26:10 2023
Received: from localhost ([127.0.0.1]:47989 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pD4iY-0005Jx-Af
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 09:26:10 -0500
Received: from eggs.gnu.org ([209.51.188.92]:57926)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pD4iT-0005JQ-RR
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 09:26:09 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD4iM-0004RU-IK; Wed, 04 Jan 2023 09:25:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=8befNk9C9AfLUzD/CWryVB0Be/WemoPdFXX4FKo802s=; b=ONZXXLsyPxjY
 q7skHEkFBeTLhrAfzRLW5+UjDWVXSYOk1cvuXIYskrtXvwv9d5C3XEBwO5wNHMu9mRwwpR0UId7OK
 VWKvjWYhNtIYDEEH1RU38rBmvEuzk/9f5xcmPnegTGIMR8Ig0d6t8rbSz0ngoinN3jtS9S4pp9/bm
 4IrxwjuOf+Pdpwn5XFhe26vLvYHZogBYh2dzFWonssuM8iWWc8iU9QOMEaGnDI2Gt34njpBtPyZwA
 akDWeBefO9lW+1VHdhS9V+uKBnf2OJSFB1+RCTvIPugvKILvMRfYwk+mCrQvrQ5OMX9gN4HPwLpNa
 v9efBcsXrnr2cH+utaZGCw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pD4iL-0002ps-OE; Wed, 04 Jan 2023 09:25:58 -0500
Date: Wed, 04 Jan 2023 16:26:09 +0200
Message-Id: <83pmbuz88u.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>, Stefan Monnier <monnier@HIDDEN>,
 Lars Ingebrigtsen <larsi@HIDDEN>
In-Reply-To: <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN> (message from
 Dmitry Gutov on Wed, 4 Jan 2023 03:51:28 +0200)
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60525
Cc: 60525 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Wed, 4 Jan 2023 03:51:28 +0200
> From: Dmitry Gutov <dgutov@HIDDEN>
> 
> On 03/01/2023 20:06, Juri Linkov wrote:
> > +    (c-ts-mode "*.[ch]")
> >       (c++-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
> > +    (c++-ts-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
> >       (html-mode "*.html" "*.shtml" "*.php")
> >       (mhtml-mode "*.html" "*.shtml" "*.php") ; FIXME: remove
> >                                               ; duplication of
> > @@ -53,7 +55,10 @@ semantic-symref-filepattern-alist
> >                                               ; major mode definition?
> >       (ruby-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
> >                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
> > +    (ruby-ts-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
> > +                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
> >       (python-mode "*.py" "*.pyi" "*.pyw")
> 
> Instead of duplicating entries, we could try to look up the remappings 
> in major-mode-remap-alist.

That doesn't sound to me like the use of major-mode-remap-alist that
was intended.

I'm okay with duplication at this point.  It is much easier, and we
can always augment or fix later as needed.  I see no reason to do
anything fancier at this point.

Stefan, Lars, WDYT?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 12:06:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 07:06:48 2023
Received: from localhost ([127.0.0.1]:47873 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pD2Xg-0007yt-39
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 07:06:48 -0500
Received: from mail-ej1-f51.google.com ([209.85.218.51]:33577)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1pD2Xe-0007yg-6h
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 07:06:47 -0500
Received: by mail-ej1-f51.google.com with SMTP id u9so82199382ejo.0
 for <60525 <at> debbugs.gnu.org>; Wed, 04 Jan 2023 04:06:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:from:to:cc:subject:date:message-id:reply-to;
 bh=Cxd2tIcGtSSTRKy0ORnU2p0ZlpVvhDhE0clsGbjjZXc=;
 b=lrEZN7mWNB+L81nKb6MBY3VUJRSQeI4J4X46IsJASqzfS75ELIJePyZWyS6sxD66Na
 l06YCjFGlFsWVEvUyevdN4m1gzmxqBVFjA6cj9FAZeIdR8Oh80iN/YyS2XXccNARkoBS
 6KR1MrUAoRlFSJNFEIhp/rxHWNLK71nGpo78bjWSap/cKqqN2FbeXYt4VRBtp7gOgCao
 e8FZ5n98xZH9ZJll5EobCpv/KKX3siv0WWb76B/LJbIpJGUm3iuMSKglhbjEYBDu1ei7
 8IamSy79o0VN6+3T6zgpv6qYSA14IczruCq2t5sh1fjA4hn8XUGy2S30zp5akrqfHAn/
 e3RQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=Cxd2tIcGtSSTRKy0ORnU2p0ZlpVvhDhE0clsGbjjZXc=;
 b=NDV4RMIcCanuKCHq5r4AFCECYj40Njtl85PybMkaQq2r3AKePPB0nn4oQvxmfA1PV1
 IUPo66BTjGZA9dFRFGJUoBpOEvFbnkJVtRiTqpOCOLKecV4t14HgQOsVZK9nWR6/HdMq
 YuZo9lGGPo3F7wsRs2X4ZX+1zMxPSKenyKLL5mbMXqvh+54ZS114jytXXuWtJe31r0qr
 f+WDpRTOdXiD8u3mrjX8MlUU4drIZhSh4fhLMgLoemm6Ygu5kuwcgpIt1TsIFjKUYI6Q
 GQOTbBbQEMS6YTwGUmJWcVMr0pwKyqGa0NZsC5Fd2ItnQjSaS8mz1VhvCHVff3OGSCuP
 sUJw==
X-Gm-Message-State: AFqh2ko9rjJ/XtyVvE+40SYIdQU9PdBiftaMowHJcgA6odInZFrl/N/n
 4mApeNI1A43vC8CjrCJwtElQkG6FT6Y=
X-Google-Smtp-Source: AMrXdXtnQeAcz58IlxXW0yNwORaAl7/oEKw6MVM6POaYjXV9myY2DW/vJuxncueFQYB2xGxdKXc1mg==
X-Received: by 2002:a17:906:49cd:b0:7c0:f684:9092 with SMTP id
 w13-20020a17090649cd00b007c0f6849092mr40108964ejv.37.1672834000507; 
 Wed, 04 Jan 2023 04:06:40 -0800 (PST)
Received: from [192.168.0.2] ([46.251.119.176])
 by smtp.googlemail.com with ESMTPSA id
 fy10-20020a1709069f0a00b007bd7178d311sm15453664ejc.51.2023.01.04.04.06.39
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 04 Jan 2023 04:06:40 -0800 (PST)
Message-ID: <03a85000-c9cd-bdbd-20c4-34b443f5c7d9@HIDDEN>
Date: Wed, 4 Jan 2023 14:06:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
Content-Language: en-US
To: Juri Linkov <juri@HIDDEN>
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN>
 <86k0224uen.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
In-Reply-To: <86k0224uen.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.9 (/)
X-Debbugs-Envelope-To: 60525
Cc: 60525 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.9 (-)

On 04/01/2023 09:43, Juri Linkov wrote:
> But also note that such duplication is unavoidable in many other places.
> For example, to support abbreviations there is the need to manually
> rename
> 
>    (define-abbrev-table 'ruby-mode-abbrev-table
> 
> to
> 
>    (define-abbrev-table 'ruby-base-mode-abbrev-table
> 
> in ~/.emacs.d/abbrev_defs.  But on exiting Emacs it insists
> on saving duplicate abbrevs to
> 
>    (define-abbrev-table 'ruby-ts-mode-abbrev-table

Perhaps something could be done inside abbrev (e.g. save which major 
mode it was enabled in). Not sure.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 07:49:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 04 02:49:30 2023
Received: from localhost ([127.0.0.1]:47555 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pCyWg-0007Bp-8t
	for submit <at> debbugs.gnu.org; Wed, 04 Jan 2023 02:49:30 -0500
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:52623)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1pCyWc-0007BW-FZ
 for 60525 <at> debbugs.gnu.org; Wed, 04 Jan 2023 02:49:29 -0500
Received: (Authenticated sender: juri@HIDDEN)
 by mail.gandi.net (Postfix) with ESMTPSA id 5E44B1BF20B;
 Wed,  4 Jan 2023 07:49:18 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
In-Reply-To: <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN> (Dmitry Gutov's
 message of "Wed, 4 Jan 2023 03:51:28 +0200")
Organization: LINKOV.NET
References: <864jt7xzku.fsf@HIDDEN>
 <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN>
Date: Wed, 04 Jan 2023 09:43:12 +0200
Message-ID: <86k0224uen.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 60525
Cc: 60525 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>>       (ruby-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
>>                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
>> +    (ruby-ts-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
>> +                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
>
> Instead of duplicating entries, we could try to look up the remappings in
> major-mode-remap-alist.
>
> Or (more effort) change the structure of the "alist" to also contain lists
> of modes in the keys. Like in eglot-server-programs.
>
> diff --git a/lisp/cedet/semantic/symref/grep.el
> ...
> -	 (pat (cdr (assoc mode semantic-symref-filepattern-alist))))
> +	 (pat
> +          (or (assoc-default mode semantic-symref-filepattern-alist)
> +              (assoc-default (car (rassoc mode major-mode-remap-alist))
> +                             semantic-symref-filepattern-alist))))

I'm fine with this change if Eli agrees to install it
on the emacs-29 branch.

But also note that such duplication is unavoidable in many other places.
For example, to support abbreviations there is the need to manually
rename

  (define-abbrev-table 'ruby-mode-abbrev-table

to

  (define-abbrev-table 'ruby-base-mode-abbrev-table

in ~/.emacs.d/abbrev_defs.  But on exiting Emacs it insists
on saving duplicate abbrevs to 

  (define-abbrev-table 'ruby-ts-mode-abbrev-table




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 4 Jan 2023 01:51:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 03 20:51:40 2023
Received: from localhost ([127.0.0.1]:47194 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pCswO-0003YR-EU
	for submit <at> debbugs.gnu.org; Tue, 03 Jan 2023 20:51:40 -0500
Received: from mail-wm1-f50.google.com ([209.85.128.50]:41561)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1pCswL-0003YC-FQ
 for 60525 <at> debbugs.gnu.org; Tue, 03 Jan 2023 20:51:39 -0500
Received: by mail-wm1-f50.google.com with SMTP id
 ay2-20020a05600c1e0200b003d22e3e796dso25500408wmb.0
 for <60525 <at> debbugs.gnu.org>; Tue, 03 Jan 2023 17:51:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:from:to:cc:subject:date:message-id:reply-to;
 bh=q9bIDwtKh+czNSja/T0cu9krQ3DbZjbVWTg1f4qysWs=;
 b=gDqv5TgLR0+YburQ6pn+Drqg16Dx4cokmJp1LSItsYqev7lTron5pYNBA48dt54BLO
 BHFJqKpKt5yQ9/jtQePkCE8TRi71rl1/xpmAQrT0ne3J3gWZeDv2PsGvXgGawq89OiVY
 Baq/vnwccOKmiQMD9Gj0jWoOAvTiyr9y7XJbiCTatpYGomYcXHH9ZpGI/c/cPI51nEPu
 FDAdcvuvIjN+5a3XXHmVDOoSvqpG5APLNvaPi/yDcPW9jNRkbed6rZwKrFkbHMwA9ejD
 k7+5Bw2ZQ9kqxDx2uCktdDLEhuE6QAlp0vYVJ6niw6kdQf2hLbtow32ZvubX8E5HnWUr
 mp3A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=q9bIDwtKh+czNSja/T0cu9krQ3DbZjbVWTg1f4qysWs=;
 b=opGA/G//AkWCjuvFw58FipCusyeCLfhLJld5rMOD5/v/Q3//6LCzeuR5fIKan2BvOy
 CFdkivqO1BsgWxY+8C9Pse+L3JzwA2vAYcj1CMIdV2CmZgRM5YJT2j+zaafkQTQ/HHCy
 AFUDeUMC0/t2bJrNACvtOA2lQEHaswTjUOaqsIWfX5Q+R1Ulf0qhhL6BDjhQfmpvvOiG
 6ZRrxAMbnQGzB1Y5H1EdcBf11+FPmcZPDayWfXFgcbosIxPWpKCoNBZLWM/0MPXKwlw0
 9N1ucdsv50lvFuPBZqTBQsn4Daz7Hg+ULP7T7OW/U1qnGXLn8KuJCG8+Sj3/tuIszq0M
 nW5A==
X-Gm-Message-State: AFqh2kqbbDigF1s1SKpB0j8DRakXR9wbeg3+guj0GAoBfQNZeJY+w5fK
 SjODED+GvA47w/6uVM5+YMU=
X-Google-Smtp-Source: AMrXdXsCkMqPPNQMx9hzo8FsxIiULwc4PPVAk794Lqg0v1zYwtu+UPj7KZdTpfM9d2rZVZ4SieKRtQ==
X-Received: by 2002:a1c:4b03:0:b0:3d9:103d:9081 with SMTP id
 y3-20020a1c4b03000000b003d9103d9081mr32014829wma.28.1672797091243; 
 Tue, 03 Jan 2023 17:51:31 -0800 (PST)
Received: from [192.168.0.2] ([46.251.119.176])
 by smtp.googlemail.com with ESMTPSA id
 bg40-20020a05600c3ca800b003b4cba4ef71sm53927187wmb.41.2023.01.03.17.51.29
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 03 Jan 2023 17:51:30 -0800 (PST)
Message-ID: <dba9c96f-ed0e-a848-01f1-42a1dac3851c@HIDDEN>
Date: Wed, 4 Jan 2023 03:51:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
Content-Language: en-US
To: Juri Linkov <juri@HIDDEN>, 60525 <at> debbugs.gnu.org
References: <864jt7xzku.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
In-Reply-To: <864jt7xzku.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.9 (/)
X-Debbugs-Envelope-To: 60525
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.9 (-)

On 03/01/2023 20:06, Juri Linkov wrote:
> +    (c-ts-mode "*.[ch]")
>       (c++-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
> +    (c++-ts-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
>       (html-mode "*.html" "*.shtml" "*.php")
>       (mhtml-mode "*.html" "*.shtml" "*.php") ; FIXME: remove
>                                               ; duplication of
> @@ -53,7 +55,10 @@ semantic-symref-filepattern-alist
>                                               ; major mode definition?
>       (ruby-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
>                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
> +    (ruby-ts-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
> +                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
>       (python-mode "*.py" "*.pyi" "*.pyw")

Instead of duplicating entries, we could try to look up the remappings 
in major-mode-remap-alist.

Or (more effort) change the structure of the "alist" to also contain 
lists of modes in the keys. Like in eglot-server-programs.

diff --git a/lisp/cedet/semantic/symref/grep.el 
b/lisp/cedet/semantic/symref/grep.el
index c698c2ef5a2..ecfeaae220c 100644
--- a/lisp/cedet/semantic/symref/grep.el
+++ b/lisp/cedet/semantic/symref/grep.el
@@ -71,7 +71,10 @@ semantic-symref-derive-find-filepatterns
  Optional argument MODE specifies the `major-mode' to test."
    ;; First, try the filepattern alist.
    (let* ((mode (or mode major-mode))
-	 (pat (cdr (assoc mode semantic-symref-filepattern-alist))))
+	 (pat
+          (or (assoc-default mode semantic-symref-filepattern-alist)
+              (assoc-default (car (rassoc mode major-mode-remap-alist))
+                             semantic-symref-filepattern-alist))))
      (when (not pat)
        ;; No hit, try auto-mode-alist.
        (dolist (X auto-mode-alist)





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at 60525 <at> debbugs.gnu.org:


Received: (at 60525) by debbugs.gnu.org; 3 Jan 2023 20:19:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 03 15:19:01 2023
Received: from localhost ([127.0.0.1]:46747 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pCnkT-0008Rz-9M
	for submit <at> debbugs.gnu.org; Tue, 03 Jan 2023 15:19:01 -0500
Received: from eggs.gnu.org ([209.51.188.92]:45380)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pCnkO-0008Rj-KQ
 for 60525 <at> debbugs.gnu.org; Tue, 03 Jan 2023 15:19:00 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pCnkJ-0001Ci-0s; Tue, 03 Jan 2023 15:18:51 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=LVlCX+gG52K5nKFdWAxEPa3OuZDELWt0jHiRcliGdq0=; b=sAL65bJOrsUn
 6gN84Gp019dZwHJBtqTycsa5yjwLnvOKFpXpNie3s4uX99qQFshyz43lQU/E/dyuYxz9biRPWvYY8
 KOgWZqsxfxmEJlrnUe7Bm73838hVUQg2b8paAmDAbdy2W16iDBEkbIapQbaL8mcN7Ritsmtc1YWKA
 xt5MTvhpWV2F7bKmnHc+gCzGm00EdyzOsInxHSb6oaz+zOq/D67/K5IhBJsBQsL6wRD0Z4670dde5
 q02d1ot9XL050gc3SuWXeo6G4H3yXXLG00vc0TOHVQDNY0B19B/qAMvKdwE58AwEKTyh+7pwjm0hm
 jgOB1lHDxJs2mH9TX6ybAw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pCnkI-0005zj-MH; Tue, 03 Jan 2023 15:18:50 -0500
Date: Tue, 03 Jan 2023 22:19:01 +0200
Message-Id: <83v8lnz80a.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <864jt7xzku.fsf@HIDDEN> (message from Juri Linkov on
 Tue, 03 Jan 2023 20:06:25 +0200)
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
References: <864jt7xzku.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60525
Cc: 60525 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Juri Linkov <juri@HIDDEN>
> Date: Tue, 03 Jan 2023 20:06:25 +0200
> 
> This duplication is needed to support 'M-?' (xref-find-references) in ts-modes:

Thanks, this is okay for the emacs-29 branch.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 3 Jan 2023 18:07:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 03 13:07:33 2023
Received: from localhost ([127.0.0.1]:46681 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pClhF-0004z0-IP
	for submit <at> debbugs.gnu.org; Tue, 03 Jan 2023 13:07:33 -0500
Received: from lists.gnu.org ([209.51.188.17]:34200)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1pClhC-0004ys-Lj
 for submit <at> debbugs.gnu.org; Tue, 03 Jan 2023 13:07:32 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <juri@HIDDEN>) id 1pClhC-0005Lk-Gx
 for bug-gnu-emacs@HIDDEN; Tue, 03 Jan 2023 13:07:30 -0500
Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <juri@HIDDEN>) id 1pClhA-0003bF-Lz
 for bug-gnu-emacs@HIDDEN; Tue, 03 Jan 2023 13:07:30 -0500
Received: (Authenticated sender: juri@HIDDEN)
 by mail.gandi.net (Postfix) with ESMTPSA id A4148C0007
 for <bug-gnu-emacs@HIDDEN>; Tue,  3 Jan 2023 18:07:24 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.60; tree-sitter support in semantic-symref
Organization: LINKOV.NET
Date: Tue, 03 Jan 2023 20:06:25 +0200
Message-ID: <864jt7xzku.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2001:4b98:dc4:8::226;
 envelope-from=juri@HIDDEN; helo=relay6-d.mail.gandi.net
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

--=-=-=
Content-Type: text/plain

This duplication is needed to support 'M-?' (xref-find-references) in ts-modes:


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=ts-semantic-symref.patch

diff --git a/lisp/cedet/semantic/symref/grep.el b/lisp/cedet/semantic/symref/grep.el
index c698c2ef5a2..cebeac3adca 100644
--- a/lisp/cedet/semantic/symref/grep.el
+++ b/lisp/cedet/semantic/symref/grep.el
@@ -44,7 +44,9 @@ semantic-symref-tool-grep
 
 (defvar semantic-symref-filepattern-alist
   '((c-mode "*.[ch]")
+    (c-ts-mode "*.[ch]")
     (c++-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
+    (c++-ts-mode "*.[chCH]" "*.[ch]pp" "*.cc" "*.hh")
     (html-mode "*.html" "*.shtml" "*.php")
     (mhtml-mode "*.html" "*.shtml" "*.php") ; FIXME: remove
                                             ; duplication of
@@ -53,7 +55,10 @@ semantic-symref-filepattern-alist
                                             ; major mode definition?
     (ruby-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
                "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
+    (ruby-ts-mode "*.r[bu]" "*.rake" "*.gemspec" "*.erb" "*.haml"
+                  "Rakefile" "Thorfile" "Capfile" "Guardfile" "Vagrantfile")
     (python-mode "*.py" "*.pyi" "*.pyw")
+    (python-ts-mode "*.py" "*.pyi" "*.pyw")
     (perl-mode "*.pl" "*.PL")
     (cperl-mode "*.pl" "*.PL")
     (lisp-interaction-mode "*.el" "*.ede" ".emacs" "_emacs")

--=-=-=--




Acknowledgement sent to Juri Linkov <juri@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#60525; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 4 Jan 2023 18:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.