GNU bug report logs - #60537
[PATCH] gnu: ledger: Install example referenced in docs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60537 in the body.
You can then email your comments to 60537 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Frank Pursel <frank.pursel <at> gmail.com>
To: guix-patches <at> gnu.org 
Subject: [PATCH] gnu: ledger: Install example referenced in docs.
Date: Tue, 03 Jan 2023 19:04:48 -0800

* gnu/packages/finance.scm (ledger): Provide additional script from upstream.
---
 gnu/packages/finance.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index f5906ec738..abc2134aee 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -32,6 +32,7 @@
 ;;; Copyright © 2022 Philip McGrath <philip <at> philipmcgrath.com>
 ;;; Copyright © 2022 Collin J. Doering <collin <at> rekahsoft.ca>
 ;;; Copyright © 2022 Justin Veilleux <terramorpha <at> cock.li>
+;;; Copyright © 2023 Frank Pursel <frank.pursel <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -342,7 +343,8 @@ (define-public ledger
              (let ((examples (string-append (assoc-ref outputs "out")
                                             "/share/doc/ledger/examples")))
                (install-file "test/input/sample.dat" examples)
-               (install-file "test/input/demo.ledger" examples))
+               (install-file "test/input/demo.ledger" examples)
+               (install-file "config/report" examples))
              #t))
          (add-after 'build 'build-doc
            (lambda _ (invoke "make" "doc")))
-- 
2.38.1

Message #8 received at 60537 <at> debbugs.gnu.org (full text, mbox):

From: Frank Pursel <frank.pursel <at> gmail.com>
To: 60537 <at> debbugs.gnu.org
Subject: [PATCH] gnu: ledger: Install example referenced in docs.
Date: Wed, 04 Jan 2023 07:21:00 -0800

Better.

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index f5906ec738..e96058e7b2 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -32,6 +32,7 @@
 ;;; Copyright © 2022 Philip McGrath <philip <at> philipmcgrath.com>
 ;;; Copyright © 2022 Collin J. Doering <collin <at> rekahsoft.ca>
 ;;; Copyright © 2022 Justin Veilleux <terramorpha <at> cock.li>
+;;; Copyright © 2023 Frank Pursel <frank.pursel <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -342,7 +343,8 @@ (define-public ledger
              (let ((examples (string-append (assoc-ref outputs "out")
                                             "/share/doc/ledger/examples")))
                (install-file "test/input/sample.dat" examples)
-               (install-file "test/input/demo.ledger" examples))
+               (install-file "test/input/demo.ledger" examples)
+               (install-file "contrib/report" examples))
              #t))
          (add-after 'build 'build-doc
            (lambda _ (invoke "make" "doc")))
-- 
2.38.1

Message #11 received at 60537 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Frank Pursel <frank.pursel <at> gmail.com>, 60537 <at> debbugs.gnu.org
Subject: Re: [bug#60537] [PATCH] gnu: ledger: Install example referenced in
 docs.
Date: Sat, 21 Jan 2023 14:27:47 +0100

Hi,

On Wed, 04 Jan 2023 at 07:21, Frank Pursel <frank.pursel <at> gmail.com> wrote:

> Better.

Better compared to what?  It is the same patch as the previous one, no ?


Cheers,
simon

Message #14 received at 60537 <at> debbugs.gnu.org (full text, mbox):

From: Frank Pursel <frank.pursel <at> gmail.com>
To: 60537 <at> debbugs.gnu.org
Subject: [PATCH] gnu: ledger: Install example referenced in docs.
Date: Mon, 23 Jan 2023 12:41:34 -0800

[Message part 1 (text/plain, inline)]

No, the second one is different.  I made a typo on the first one and tried
to bring the file in from the config directory but it's actually in the
'contrib' directory.  The second one is what we want.

Regards,
Frank

[Message part 2 (text/html, inline)]

Message #17 received at 60537 <at> debbugs.gnu.org (full text, mbox):

From: Frank Pursel <frank.pursel <at> gmail.com>
To: 60537 <at> debbugs.gnu.org
Subject: [PATCH] gnu: ledger: Install example referenced in docs.
Date: Fri, 27 Jan 2023 05:59:44 -0800

It may be appropriate for me to provide a little more background on
this one line change to the ledger package.

I use the ledger package nearly daily and it works great.  Still when
you use it a lot and read the documentation you come across
info:(ledger3)"Visualizing with Gnuplot" and you see that another simple
utility is described, report, that adds considerable functionality to
ledger but is not provided in the guix version.  It seems to me that
this one line patch is the most trivial way to remedy this shortcoming.

Sincerely,
Frank

Message #22 received at 60537-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Frank Pursel <frank.pursel <at> gmail.com>
Cc: 60537-done <at> debbugs.gnu.org
Subject: Re: bug#60537: [PATCH] gnu: ledger: Install example referenced in
 docs.
Date: Tue, 31 Jan 2023 23:11:00 +0100

Frank Pursel <frank.pursel <at> gmail.com> skribis:

> Better.
>
> diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> index f5906ec738..e96058e7b2 100644
> --- a/gnu/packages/finance.scm
> +++ b/gnu/packages/finance.scm
> @@ -32,6 +32,7 @@
>  ;;; Copyright © 2022 Philip McGrath <philip <at> philipmcgrath.com>
>  ;;; Copyright © 2022 Collin J. Doering <collin <at> rekahsoft.ca>
>  ;;; Copyright © 2022 Justin Veilleux <terramorpha <at> cock.li>
> +;;; Copyright © 2023 Frank Pursel <frank.pursel <at> gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -342,7 +343,8 @@ (define-public ledger
>               (let ((examples (string-append (assoc-ref outputs "out")
>                                              "/share/doc/ledger/examples")))
>                 (install-file "test/input/sample.dat" examples)
> -               (install-file "test/input/demo.ledger" examples))
> +               (install-file "test/input/demo.ledger" examples)
> +               (install-file "contrib/report" examples))

Hi!  Applied with a commit log, thanks.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.