GNU bug report logs - #60541
[PATCH] check: drop unused trs_list variable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60541 in the body.
You can then email your comments to 60541 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: automake-patches <at> gnu.org
Subject: [PATCH] check: drop unused trs_list variable
Date: Wed,  4 Jan 2023 01:43:20 -0500

When the code that used this variable was removed, the variable
itself was left behind.  Clean that up now too.

* lib/am/check.am: Delete trs_list.
---
 lib/am/check.am | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/am/check.am b/lib/am/check.am
index 6648c011d721..890670d7a178 100644
--- a/lib/am/check.am
+++ b/lib/am/check.am
@@ -417,11 +417,10 @@ check-TESTS: %CHECK_DEPS%
 	@$(am__rm_f) $(TEST_SUITE_LOG)
 	@set +e; $(am__set_TESTS_bases); \
 	log_list=`for i in $$bases; do echo $$i.log; done`; \
-	trs_list=`for i in $$bases; do echo $$i.trs; done`; \
 ## Remove newlines and normalize whitespace.  Trailing (and possibly
 ## leading) whitespace is known to cause segmentation faults on
 ## Solaris 10 XPG4 make.
-	log_list=`echo $$log_list`; trs_list=`echo $$trs_list`; \
+	log_list=`echo $$log_list`; \
 	$(MAKE) $(AM_MAKEFLAGS) $(TEST_SUITE_LOG) TEST_LOGS="$$log_list"; \
 ## Be sure to exit with the proper exit status (automake bug#9245).  See
 ## comments in the recipe of $(TEST_SUITE_LOG) above for more information.
-- 
2.39.0

Message #8 received at 60541 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: vapier <at> gentoo.org
Cc: 60541 <at> debbugs.gnu.org
Subject: Re: [bug#60541] [PATCH] check: drop unused trs_list variable
Date: Wed, 4 Jan 2023 16:54:30 -0700

    When the code that used this variable was removed, the variable
    itself was left behind.  Clean that up now too.
    * lib/am/check.am: Delete trs_list.

I can't find when the code using trs_list was removed (no mention in any
ChangeLog), but indeed, grepping the current sources, I don't find any
references to it.  So please go ahead and commit this one. --thanks, karl.

Message #11 received at 60541 <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: Karl Berry <karl <at> freefriends.org>
Cc: 60541 <at> debbugs.gnu.org
Subject: Re: [bug#60541] [PATCH] check: drop unused trs_list variable
Date: Wed, 4 Jan 2023 19:24:29 -0500

[Message part 1 (text/plain, inline)]

On 04 Jan 2023 16:54, Karl Berry wrote:
>     When the code that used this variable was removed, the variable
>     itself was left behind.  Clean that up now too.
>     * lib/am/check.am: Delete trs_list.
> 
> I can't find when the code using trs_list was removed (no mention in any
> ChangeLog), but indeed, grepping the current sources, I don't find any
> references to it.  So please go ahead and commit this one. --thanks, karl.

`git log -p lib/am/check.am` then search for trs_list.  looks like merge
issues between commit 6c9b282b0a3d7adb3209f74655611e2fdfbf554e and commit
d5443e4c3e6ca109be489bde2e1b4720d69f0029.  this is why i try to avoid
merges myself in general and stick to rebasing -- archaeology is messy.
-mike

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.