GNU bug report logs - #60564
[PATCH] scripts: refresh: Add -T option.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60564 in the body.
You can then email your comments to 60564 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] scripts: refresh: Add -T option.
Date: Wed,  4 Jan 2023 19:10:32 -0600

* doc/guix.texi (Invoking guix refresh): Document the -T option.
* guix/scripts/refresh.scm (%options): Add the -T flag.
---
 doc/guix.texi            | 1 +
 guix/scripts/refresh.scm | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 96b4675a01..e3ecf1f148 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -14197,6 +14197,7 @@ for compatibility with an upgraded @code{flex} package.
 @table @code
 
 @item --list-transitive
+@item --T
 List all the packages which one or more packages depend upon.
 
 @example
diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index 6498d73c2b..6b633840e0 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -101,7 +101,7 @@ (define %options
         (option '(#\r "recursive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'recursive? #t result)))
-        (option '("list-transitive") #f #f
+        (option '(#\T "list-transitive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'list-transitive? #t result)))
 
@@ -159,7 +159,7 @@ (define (show-help)
   (display (G_ "
   -r, --recursive        check the PACKAGE and its inputs for upgrades"))
   (display (G_ "
-      --list-transitive  list all the packages that PACKAGE depends on"))
+  -T, --list-transitive  list all the packages that PACKAGE depends on"))
   (newline)
   (display (G_ "
       --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))
-- 
2.38.1

Message #8 received at 60564 <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: 60564 <at> debbugs.gnu.org
Cc: jgart <at> dismail.de
Subject: Probably a lost battle
Date: Wed, 04 Jan 2023 17:35:27 -0800

Hi,

Would the meaning of that option be more accessible to people without a
mathematics background, if it were called

  --list-prerequisites   ?

Kind regards,
Felix Lechner

Message #11 received at 60564 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 60564 <at> debbugs.gnu.org
Subject: Re: bug#60564: [PATCH] scripts: refresh: Add -T option.
Date: Wed, 11 Jan 2023 14:43:59 -0500

Hi,

jgart <jgart <at> dismail.de> writes:

> * doc/guix.texi (Invoking guix refresh): Document the -T option.
> * guix/scripts/refresh.scm (%options): Add the -T flag.
> ---
>  doc/guix.texi            | 1 +
>  guix/scripts/refresh.scm | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 96b4675a01..e3ecf1f148 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -14197,6 +14197,7 @@ for compatibility with an upgraded @code{flex} package.
>  @table @code
>  
>  @item --list-transitive
> +@item --T

The above should be -T, right?

I wonder if this option is common enough to need a dedicated short
switch?  I use it sparingly myself; typically I use '-l' to know which
packages I'd impact.

The rest looks OK.

-- 
Thanks,
Maxim

Message #14 received at 60564 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, jgart <jgart <at> dismail.de>
Cc: 60564 <at> debbugs.gnu.org
Subject: Re: [bug#60564] [PATCH] scripts: refresh: Add -T option.
Date: Fri, 03 Mar 2023 09:56:38 +0100

[Message part 1 (text/plain, inline)]

Hi everyone,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> The above should be -T, right?
>
> I wonder if this option is common enough to need a dedicated short
> switch?  I use it sparingly myself; typically I use '-l' to know which
> packages I'd impact.
>
> The rest looks OK.

There hasn't been any activity on this: is this still interesting to you
jgart?  If not, we can probably close this.

Best,
-- 
Josselin Poiret

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 60564 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 60564 <at> debbugs.gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, jgart <jgart <at> dismail.de>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH] scripts: refresh: Add -T option.
Date: Fri,  3 Mar 2023 17:21:36 +0100

* doc/guix.texi (Invoking guix refresh): Document the -T option.
* guix/scripts/refresh.scm (%options): Add the -T flag.
---

Hi Josselin and Maxim

> I wonder if this option is common enough to need a dedicated short
> switch?

I would probably use the option more if it had a short option ;()

I think that it is useful. What would be the negative of adding the short option for it?

all best,

jgart

 doc/guix.texi            | 1 +
 guix/scripts/refresh.scm | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 6ff525d0ff..25bbd75f04 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -14327,6 +14327,7 @@ for compatibility with an upgraded @code{flex} package.
 @table @code
 
 @item --list-transitive
+@item -T
 List all the packages which one or more packages depend upon.
 
 @example
diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index 6498d73c2b..6b633840e0 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -101,7 +101,7 @@ (define %options
         (option '(#\r "recursive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'recursive? #t result)))
-        (option '("list-transitive") #f #f
+        (option '(#\T "list-transitive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'list-transitive? #t result)))
 
@@ -159,7 +159,7 @@ (define (show-help)
   (display (G_ "
   -r, --recursive        check the PACKAGE and its inputs for upgrades"))
   (display (G_ "
-      --list-transitive  list all the packages that PACKAGE depends on"))
+  -T, --list-transitive  list all the packages that PACKAGE depends on"))
   (newline)
   (display (G_ "
       --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))
-- 
2.39.1

Message #20 received at 60564 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Josselin Poiret" <dev <at> jpoiret.xyz>, "Maxim Cournoyer"
 <maxim.cournoyer <at> gmail.com>
Cc: 60564 <at> debbugs.gnu.org
Subject: Re: [bug#60564] [PATCH] scripts: refresh: Add -T option.
Date: Fri, 03 Mar 2023 16:43:30 +0000

I forgot to mention that the last patch I sent is v2 fixing the typo that Maxim pointed out.

all best,

jgart

Message #23 received at 60564 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, 60564 <at> debbugs.gnu.org
Subject: Re: [PATCH] scripts: refresh: Add -T option.
Date: Fri, 03 Mar 2023 22:30:01 -0500

Hi jgart,

jgart <jgart <at> dismail.de> writes:

> * doc/guix.texi (Invoking guix refresh): Document the -T option.
> * guix/scripts/refresh.scm (%options): Add the -T flag.
> ---
>
> Hi Josselin and Maxim
>
>> I wonder if this option is common enough to need a dedicated short
>> switch?
>
> I would probably use the option more if it had a short option ;()
>
> I think that it is useful. What would be the negative of adding the short option for it?

Nothing immediately, but we'd have to honor T forever as it'd be part of
the public CLI, loosing that letter for something more useful that may
yet to appear.

Probably an overblown concern, to be honest, eh.

I'll see what Josselin says about it, otherwise I'll push it soon.

-- 
Thanks,
Maxim

Message #26 received at 60564 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, jgart <jgart <at> dismail.de>
Cc: 60564 <at> debbugs.gnu.org
Subject: Re: [PATCH] scripts: refresh: Add -T option.
Date: Sat, 04 Mar 2023 11:51:37 +0100

[Message part 1 (text/plain, inline)]

Hi jgart and Maxim,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Nothing immediately, but we'd have to honor T forever as it'd be part of
> the public CLI, loosing that letter for something more useful that may
> yet to appear.
>
> Probably an overblown concern, to be honest, eh.
>
> I'll see what Josselin says about it, otherwise I'll push it soon.

I'm on the fence as well, it doesn't seem like something you would use
very often, compared to eg. `-l` or `-u`, especially if you mention that
you would use the option more often if this was implemented (I'd expect
more of a "I use it all the time but typing it is annoying"). `guix
size` and `guix graph` are the more useful commands imho. What do you
use it for specifically (maybe that would help us understand the
use-case a bit more)?

At the same time, it's probably fine, we don't have many options for
`guix refresh` and it's not like dozens of them will get added overnight
(and they maybe don't deserve a short argument either).  I'll leave it
in your hands 🤠.

Best,
-- 
Josselin Poiret

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 60564-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 60564-done <at> debbugs.gnu.org
Subject: Re: bug#60564: [PATCH] scripts: refresh: Add -T option.
Date: Tue, 21 Mar 2023 14:56:42 -0400

Hi,

jgart <jgart <at> dismail.de> writes:

> * doc/guix.texi (Invoking guix refresh): Document the -T option.
> * guix/scripts/refresh.scm (%options): Add the -T flag.
> ---
>  doc/guix.texi            | 1 +
>  guix/scripts/refresh.scm | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 96b4675a01..e3ecf1f148 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -14197,6 +14197,7 @@ for compatibility with an upgraded @code{flex} package.
>  @table @code
>  
>  @item --list-transitive
> +@item --T
>  List all the packages which one or more packages depend upon.

Fixed to use itemx:

--8<---------------cut here---------------start------------->8---
modified   doc/guix.texi
@@ -14324,7 +14324,7 @@ for compatibility with an upgraded @code{flex} package.
 @table @code
 
 @item --list-transitive
-@item --T
+@itemx --T
 List all the packages which one or more packages depend upon.
 
 @example
--8<---------------cut here---------------end--------------->8---

>  @example
> diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
> index 6498d73c2b..6b633840e0 100644
> --- a/guix/scripts/refresh.scm
> +++ b/guix/scripts/refresh.scm
> @@ -101,7 +101,7 @@ (define %options
>          (option '(#\r "recursive") #f #f
>                  (lambda (opt name arg result)
>                    (alist-cons 'recursive? #t result)))
> -        (option '("list-transitive") #f #f
> +        (option '(#\T "list-transitive") #f #f
>                  (lambda (opt name arg result)
>                    (alist-cons 'list-transitive? #t result)))
>  
> @@ -159,7 +159,7 @@ (define (show-help)
>    (display (G_ "
>    -r, --recursive        check the PACKAGE and its inputs for upgrades"))
>    (display (G_ "
> -      --list-transitive  list all the packages that PACKAGE depends on"))
> +  -T, --list-transitive  list all the packages that PACKAGE depends on"))
>    (newline)
>    (display (G_ "
>        --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))

And installed it.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.