GNU bug report logs - #60609
[PATCH] gnu: git-annex: Patch 'git-annex webapp' to use hardcoded xdg-open.

Previous Next

Package: guix-patches;

Reported by: "Thompson, David" <dthompson2 <at> worcester.edu>

Date: Fri, 6 Jan 2023 21:32:01 UTC

Severity: normal

Tags: patch

Done: "Thompson, David" <dthompson2 <at> worcester.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60609 in the body.
You can then email your comments to 60609 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#60609; Package guix-patches. (Fri, 06 Jan 2023 21:32:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Thompson, David" <dthompson2 <at> worcester.edu>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 06 Jan 2023 21:32:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: git-annex: Patch 'git-annex webapp' to use hardcoded
 xdg-open.
Date: Fri, 6 Jan 2023 16:30:49 -0500
[Message part 1 (text/plain, inline)]
Hi all,

I was using git-annex for the very first time today and when I tried
to run 'git-annex webapp' I got this error:

    Launching web browser on file:///tmp/webapp3975-0.html
    git-annex: xdg-open: createProcess: posix_spawnp: does not exist
(No such file or directory)
    WebApp crashed: xdg-open: createProcess: posix_spawnp: does not
exist (No such file or directory)

I think this should just work so I wrote a patch to replace a couple
of loose references to xdg-open with a hardcoded store path.

How does it look?

Thanks,

- Dave
[0001-gnu-git-annex-Patch-git-annex-webapp-to-use-hardcode.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#60609; Package guix-patches. (Sun, 08 Jan 2023 13:39:01 GMT) Full text and rfc822 format available.

Message #8 received at 60609 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "Thompson, David" <dthompson2 <at> worcester.edu>
Cc: 60609 <at> debbugs.gnu.org
Subject: Re: bug#60609: [PATCH] gnu: git-annex: Patch 'git-annex webapp' to
 use hardcoded xdg-open.
Date: Sun, 08 Jan 2023 14:38:17 +0100
Hello David,

> I think this should just work so I wrote a patch to replace a couple
> of loose references to xdg-open with a hardcoded store path.
>
> How does it look?

Looks fine, please go ahead!

Mathieu




Reply sent to "Thompson, David" <dthompson2 <at> worcester.edu>:
You have taken responsibility. (Sun, 08 Jan 2023 18:33:02 GMT) Full text and rfc822 format available.

Notification sent to "Thompson, David" <dthompson2 <at> worcester.edu>:
bug acknowledged by developer. (Sun, 08 Jan 2023 18:33:02 GMT) Full text and rfc822 format available.

Message #13 received at 60609-done <at> debbugs.gnu.org (full text, mbox):

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 60609-done <at> debbugs.gnu.org
Subject: Re: bug#60609: [PATCH] gnu: git-annex: Patch 'git-annex webapp' to
 use hardcoded xdg-open.
Date: Sun, 8 Jan 2023 13:32:21 -0500
On Sun, Jan 8, 2023 at 8:38 AM Mathieu Othacehe <othacehe <at> gnu.org> wrote:
>
>
> Hello David,
>
> > I think this should just work so I wrote a patch to replace a couple
> > of loose references to xdg-open with a hardcoded store path.
> >
> > How does it look?
>
> Looks fine, please go ahead!

Pushed, thanks!

- Dave




Information forwarded to guix-patches <at> gnu.org:
bug#60609; Package guix-patches. (Thu, 12 Jan 2023 17:48:03 GMT) Full text and rfc822 format available.

Message #16 received at 60609 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: "Thompson, David" <dthompson2 <at> worcester.edu>, 60609 <at> debbugs.gnu.org
Subject: Re: [bug#60609] [PATCH] gnu: git-annex: Patch 'git-annex webapp' to
 use hardcoded xdg-open.
Date: Thu, 12 Jan 2023 15:39:36 +0100
Hi,

On ven., 06 janv. 2023 at 16:30, "Thompson, David" <dthompson2 <at> worcester.edu> wrote:

> * gnu/packages/haskell-apps.scm (git-annex)[arguments]: Add 'patch-webapp'
> phase.
> [inputs]: Add xdg-utils.

This adds 130MB to the closure.  Well, it is only 5.5% of the complete
closure but that’s not nothing either. :-)

Maybe it could be worth to split this large package; either
git-annex-minimal and git-annex, or two outputs.  Because, we build it
using this:

     `(#:configure-flags
       '("--flags=-Android -Webapp")

when I do not use the Webapp, for instance. :-)

Cheers,
simon




Information forwarded to guix-patches <at> gnu.org:
bug#60609; Package guix-patches. (Thu, 12 Jan 2023 17:54:02 GMT) Full text and rfc822 format available.

Message #19 received at 60609 <at> debbugs.gnu.org (full text, mbox):

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 60609 <at> debbugs.gnu.org
Subject: Re: [bug#60609] [PATCH] gnu: git-annex: Patch 'git-annex webapp' to
 use hardcoded xdg-open.
Date: Thu, 12 Jan 2023 12:52:58 -0500
Hi Simon,

On Thu, Jan 12, 2023 at 12:46 PM Simon Tournier
<zimon.toutoune <at> gmail.com> wrote:
>
> Hi,
>
> On ven., 06 janv. 2023 at 16:30, "Thompson, David" <dthompson2 <at> worcester.edu> wrote:
>
> > * gnu/packages/haskell-apps.scm (git-annex)[arguments]: Add 'patch-webapp'
> > phase.
> > [inputs]: Add xdg-utils.
>
> This adds 130MB to the closure.  Well, it is only 5.5% of the complete
> closure but that’s not nothing either. :-)
>
> Maybe it could be worth to split this large package; either
> git-annex-minimal and git-annex, or two outputs.  Because, we build it
> using this:
>
>      `(#:configure-flags
>        '("--flags=-Android -Webapp")
>
> when I do not use the Webapp, for instance. :-)

I figured that since git-annex is already so huge and it's not a core
thing that it wouldn't be a big deal to add some size in order to make
more features work properly without having to troubleshoot.  I'd be in
favor of a minimal variant for those that don't want the full
git-annex feature set.

- Dave




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 10 Feb 2023 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 47 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.