GNU bug report logs - #60622
[PATCH] gnu: Add nanomq.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Nikolay Korotkiy <sikmir@HIDDEN>; Keywords: patch moreinfo; dated Sat, 7 Jan 2023 11:52:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added tag(s) moreinfo. Request was from Christopher Baines <mail@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 60622 <at> debbugs.gnu.org:


Received: (at 60622) by debbugs.gnu.org; 8 Jan 2023 13:31:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 08 08:31:21 2023
Received: from localhost ([127.0.0.1]:60173 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pEVlh-0002m7-0F
	for submit <at> debbugs.gnu.org; Sun, 08 Jan 2023 08:31:21 -0500
Received: from eggs.gnu.org ([209.51.188.92]:54760)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1pEVld-0002lt-Q0
 for 60622 <at> debbugs.gnu.org; Sun, 08 Jan 2023 08:31:19 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1pEVlY-0002Xu-JO; Sun, 08 Jan 2023 08:31:12 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=ZpbORgxhOpOuVaNVV6yMMiZhuaBj9RjAC7RP7VHhRYE=; b=GAbZkEv24gnGFTv5ufGe
 xMqNanToOu9D+/zBhDRbFIoBoAyfL0BVsI0c9CEGTLtWkEk223Mri6LTu5tGDIhJaYqLIrRNMkcJv
 4Urq4CMed0cG3SV0yIbfXKJoJPJKeFiCM6n48REWk6rvvbL9/R/b0vrVJtFCIP/xpYapzBIfUzkaD
 grA3MLY5J16rWgo0sMjRAQICvl8N2VBOP87GuYhUhlFnSiUNLx+clLYlAk8WOGV0zJrIGPFRB8sFh
 pZ4HrQpWO0SE1DHVCTuaJik32ne1omYXnNLYYPh9JXg8sfoBINZxZQAGVwuIfMLCa/j4kmzsM2+C+
 mjj8QgqNxwSpww==;
Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net
 ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775] helo=meije)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1pEVlV-0007f2-3j; Sun, 08 Jan 2023 08:31:11 -0500
From: Mathieu Othacehe <othacehe@HIDDEN>
To: Nikolay Korotkiy <sikmir@HIDDEN>
Subject: Re: bug#60622: [PATCH] gnu: Add nanomq.
References: <ce59f92df743d81b193de451d5e45614502042c8.1673092288.git.sikmir@HIDDEN>
Date: Sun, 08 Jan 2023 14:31:04 +0100
In-Reply-To: <ce59f92df743d81b193de451d5e45614502042c8.1673092288.git.sikmir@HIDDEN>
 (Nikolay Korotkiy's message of "Sat, 7 Jan 2023 15:51:38 +0400")
Message-ID: <87tu11up9j.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60622
Cc: 60622 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Hey,

> +              (uri (git-reference
> +                    (url "https://github.com/emqx/nanomq")
> +                    (commit version)
> +                    (recursive? #t)))

It looks like nng is packaged by Guix, can it be used?

> +    (arguments
> +     `(#:tests? #f

You need to justify why the tests are disabled. Is it because there are
no tests, because some do not pass?

> +       #:configure-flags (list "-DNNG_ENABLE_TLS=ON" "-DNNG_ENABLE_SQLITE=ON")
> +       #:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'fix-etc-destination
> +                    (lambda _
> +                      (let* ((out (assoc-ref %outputs "out"))

It would be better to use the new gexp based style. You can have a look
to the lldpd package above for an example.


> +                             (etc (string-append out "/etc")))
> +                        (substitute* "CMakeLists.txt"
> +                          (("DESTINATION /etc")
> +                           (string-append "DESTINATION " etc)))) #t)))))

You can omit the trailing #t.

> +    (inputs (list mbedtls-apache sqlite))
> +    (synopsis "An ultra-lightweight and blazing-fast MQTT broker for IoT edge")

This a commercial description. Something like: "Lightweight MQTT broker"
would be enough.

> +    (description
> +     "NanoMQ bases on NNG's asynchronous I/O threading model, with an
> +extension of MQTT support in the protocol layer and reworked transport layer,
> +plus an enhanced asynchronous IO mechanism maximizing the overall capacity.")

It does not really tell what this package does, what is a broker for
instance?

Could you please send an updated version :)? Don't hesitate to ask for
guidance if my comments are unclear.

Thanks,

Mathieu




Information forwarded to guix-patches@HIDDEN:
bug#60622; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 7 Jan 2023 11:51:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 07 06:51:54 2023
Received: from localhost ([127.0.0.1]:56584 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pE7ju-0005GS-Dw
	for submit <at> debbugs.gnu.org; Sat, 07 Jan 2023 06:51:54 -0500
Received: from lists.gnu.org ([209.51.188.17]:37770)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sikmir@HIDDEN>) id 1pE7jt-0005GL-Dq
 for submit <at> debbugs.gnu.org; Sat, 07 Jan 2023 06:51:53 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <sikmir@HIDDEN>)
 id 1pE7jt-0006tn-0e
 for guix-patches@HIDDEN; Sat, 07 Jan 2023 06:51:53 -0500
Received: from knopi.disroot.org ([178.21.23.139])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <sikmir@HIDDEN>)
 id 1pE7jq-0004SZ-RA
 for guix-patches@HIDDEN; Sat, 07 Jan 2023 06:51:52 -0500
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id 713BE403A8;
 Sat,  7 Jan 2023 12:51:48 +0100 (CET)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id gRC1UEKhQNgw; Sat,  7 Jan 2023 12:51:46 +0100 (CET)
From: Nikolay Korotkiy <sikmir@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1673092306; bh=r/ss0lJ1kjaHIwbQdv2rMwMGzRjrx4ZhJQwai/lnHOk=;
 h=From:To:Cc:Subject:Date;
 b=j9hYouQd/8OkmZrMeQyJev/UpAR3DiFpcCddUDiRnDd0XHStRFrwoL/kN2AsiBNmw
 P5Z8aVKNWGH48r75zXTrQg1WDI5ELLnyksSyhn4YmBvmmnv8Wwp+xiQi2ZaEUANv7R
 SPhcEzqsisn8SJerSbAopq8ewdPwKUFkYoq+8aZGuctwseHDfmkrCKFfPiVdmsivcW
 8dvthFNctK/jCM+blY+RQLkB01vfLV4fPQ1EIPgHTMkSw3VK/4SNgYi3X9f4LsEY32
 hdpazeuuw+iHoHKRjdzfGclZK+9IRXCrlYGf3wAmkJxaCqWk8N77Z2m/4ZMXOCmK3h
 aWcXIeD6KzwTQ==
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add nanomq.
Date: Sat,  7 Jan 2023 15:51:38 +0400
Message-Id: <ce59f92df743d81b193de451d5e45614502042c8.1673092288.git.sikmir@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=178.21.23.139; envelope-from=sikmir@HIDDEN;
 helo=knopi.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: Nikolay Korotkiy <sikmir@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

* gnu/packages/networking.scm (nanomq): New variable.
---
 gnu/packages/networking.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index a7b51ed1ff..588f657c00 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -871,6 +871,41 @@ (define-public nanomsg
     (home-page "https://nanomsg.org/")
     (license (license:non-copyleft "file:///COPYING"))))
 
+(define-public nanomq
+  (package
+    (name "nanomq")
+    (version "0.14.8")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/emqx/nanomq")
+                    (commit version)
+                    (recursive? #t)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1min3xrdiyzj8yal02hx3axh4hfr930qi3jwa9zx67jp9lgyqqmd"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f
+       #:configure-flags (list "-DNNG_ENABLE_TLS=ON" "-DNNG_ENABLE_SQLITE=ON")
+       #:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'fix-etc-destination
+                    (lambda _
+                      (let* ((out (assoc-ref %outputs "out"))
+                             (etc (string-append out "/etc")))
+                        (substitute* "CMakeLists.txt"
+                          (("DESTINATION /etc")
+                           (string-append "DESTINATION " etc)))) #t)))))
+    (inputs (list mbedtls-apache sqlite))
+    (synopsis "An ultra-lightweight and blazing-fast MQTT broker for IoT edge")
+    (description
+     "NanoMQ bases on NNG's asynchronous I/O threading model, with an
+extension of MQTT support in the protocol layer and reworked transport layer,
+plus an enhanced asynchronous IO mechanism maximizing the overall capacity.")
+    (home-page "https://nanomq.io/")
+    (license license:expat)))
+
 (define-public blueman
   (package
     (name "blueman")

base-commit: d16edd03cfa84f6d5fed979fd7283966cd3e4934
-- 
2.37.2





Acknowledgement sent to Nikolay Korotkiy <sikmir@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#60622; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 17 Feb 2023 15:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.