GNU bug report logs - #60658
update guile version for guile-aa-tree and fix install.

Previous Next

Package: guix-patches;

Reported by: Nicolas Graves <ngraves <at> ngraves.fr>

Date: Sun, 8 Jan 2023 14:14:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60658 in the body.
You can then email your comments to 60658 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#60658; Package guix-patches. (Sun, 08 Jan 2023 14:14:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Graves <ngraves <at> ngraves.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 08 Jan 2023 14:14:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Subject: update guile version for guile-aa-tree and fix install.
Date: Sun, 08 Jan 2023 15:12:56 +0100
Hi guix!

Small patch series to update guile-aa-tree guiel version and properly
install only the right scheme file (i.e. removing the test file from
install).

-- 
Best regards,
Nicolas Graves




Information forwarded to guix-patches <at> gnu.org:
bug#60658; Package guix-patches. (Sun, 08 Jan 2023 16:04:02 GMT) Full text and rfc822 format available.

Message #8 received at 60658 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 60658 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH 1/3] gnu: guile-aa-tree: Restrict install to aa-tree.scm.
Date: Sun,  8 Jan 2023 17:03:15 +0100
* gnu/packages/guile-xyz.scm (guile-aa-tree):
  [native-inputs]: Remove guile-2.2.
  [inputs]: Add guile-2.2.
  [arguments]: (scheme-file-regexp): Restrict install to aa-tree.scm
  [arguments]: (phases): Add check phase.
---
 gnu/packages/guile-xyz.scm | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 2dd5a520d1..68150c89d0 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1261,7 +1261,23 @@ (define-public guile-aa-tree
                (base32
                 "0044c105r3q9vpl17pv3phl1b79kjm1llhkakqgiasixyav01blh"))))
     (build-system guile-build-system)
-    (native-inputs (list guile-2.2))
+    (inputs (list guile-2.2))
+    (arguments
+     (list
+      #:scheme-file-regexp "^aa-tree\\.scm"
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'install-documentation 'check
+            (lambda* (#:key inputs #:allow-other-keys)
+              (let* ((guile      #$(this-package-input "guile"))
+                     (effective  (target-guile-effective-version guile))
+                     (go-dir     (string-append #$output "/lib/guile/"
+                                                effective "/site-ccache/")))
+                (invoke (search-input-file inputs "/bin/guile")
+                        "--no-auto-compile"
+                        "-C" go-dir
+                        "-c" (string-append
+                              "(load \"" (getcwd) "/test-aa-tree.scm\")"))))))))
     ;; https://savannah.nongnu.org/projects/guile-aa-tree
     (home-page "https://qlfiles.net/guile-aa-tree/")
     (synopsis "AA tree data structure for Guile")
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#60658; Package guix-patches. (Sun, 08 Jan 2023 16:04:02 GMT) Full text and rfc822 format available.

Message #11 received at 60658 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 60658 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH 2/3] gnu: guile-aa-tree: Format origin.
Date: Sun,  8 Jan 2023 17:03:16 +0100
* gnu/packages/guile-xyz.scm (guile-aa-tree): Format origin.
---
 gnu/packages/guile-xyz.scm | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 68150c89d0..f5969dfe19 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1253,13 +1253,13 @@ (define-public guile-aa-tree
   (package
     (name "guile-aa-tree")
     (version "3.1.1")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "mirror://savannah/guile-aa-tree/guile-aa-tree-"
-                                  version ".tar.gz"))
-              (sha256
-               (base32
-                "0044c105r3q9vpl17pv3phl1b79kjm1llhkakqgiasixyav01blh"))))
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://savannah/guile-aa-tree/guile-aa-tree-"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "0044c105r3q9vpl17pv3phl1b79kjm1llhkakqgiasixyav01blh"))))
     (build-system guile-build-system)
     (inputs (list guile-2.2))
     (arguments
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#60658; Package guix-patches. (Sun, 08 Jan 2023 16:04:03 GMT) Full text and rfc822 format available.

Message #14 received at 60658 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 60658 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH 3/3] gnu: guile-aa-tree: Update Guile version to 3.0 .
Date: Sun,  8 Jan 2023 17:03:17 +0100
* gnu/packages/guile-xyz.scm (guile-aa-tree): Update Guile version to 3.0.
---
 gnu/packages/guile-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index f5969dfe19..ea05fd932c 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1261,7 +1261,7 @@ (define-public guile-aa-tree
        (sha256
         (base32 "0044c105r3q9vpl17pv3phl1b79kjm1llhkakqgiasixyav01blh"))))
     (build-system guile-build-system)
-    (inputs (list guile-2.2))
+    (inputs (list guile-3.0))
     (arguments
      (list
       #:scheme-file-regexp "^aa-tree\\.scm"
-- 
2.38.1





Added tag(s) patch. Request was from Bruno Victal <mirai <at> makinata.eu> to control <at> debbugs.gnu.org. (Wed, 11 Jan 2023 17:38:01 GMT) Full text and rfc822 format available.

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Thu, 12 Jan 2023 22:23:02 GMT) Full text and rfc822 format available.

Notification sent to Nicolas Graves <ngraves <at> ngraves.fr>:
bug acknowledged by developer. (Thu, 12 Jan 2023 22:23:02 GMT) Full text and rfc822 format available.

Message #21 received at 60658-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 60658-done <at> debbugs.gnu.org
Subject: Re: bug#60658: update guile version for guile-aa-tree and fix install.
Date: Thu, 12 Jan 2023 23:21:58 +0100
Hi,

Nicolas Graves <ngraves <at> ngraves.fr> skribis:

> Small patch series to update guile-aa-tree guiel version and properly
> install only the right scheme file (i.e. removing the test file from
> install).

Applied, except for the ‘origin’ reindentation since ‘guix style’ would
keep it as it was (which some don’t like it seems, but hey).

Thanks,
Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 10 Feb 2023 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 46 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.