GNU bug report logs - #60706
[PATCH] gnu: hwloc: Update to 2.9.0.

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Tue, 10 Jan 2023 09:05:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60706 in the body.
You can then email your comments to 60706 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#60706; Package guix-patches. (Tue, 10 Jan 2023 09:05:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ludovic Courtès <ludo <at> gnu.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 10 Jan 2023 09:05:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludovic.courtes <at> inria.fr>
Subject: [PATCH] gnu: hwloc: Update to 2.9.0.
Date: Tue, 10 Jan 2023 10:04:14 +0100
From: Ludovic Courtès <ludovic.courtes <at> inria.fr>

* gnu/packages/mpi.scm (hwloc-2): Update to 2.9.0.
[arguments]: Add 'skip-test-that-requires-/sys' phase.
---
 gnu/packages/mpi.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
index af2409aeab..56b7d04209 100644
--- a/gnu/packages/mpi.scm
+++ b/gnu/packages/mpi.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014, 2015, 2018, 2019 Eric Bavier <bavier <at> member.fsf.org>
-;;; Copyright © 2014-2022 Ludovic Courtès <ludo <at> gnu.org>
+;;; Copyright © 2014-2023 Ludovic Courtès <ludo <at> gnu.org>
 ;;; Copyright © 2014 Ian Denhardt <ian <at> zenhack.net>
 ;;; Copyright © 2016 Andreas Enge <andreas <at> enge.fr>
 ;;; Copyright © 2017 Dave Love <fx <at> gnu.org>
@@ -143,7 +143,7 @@ (define-public hwloc-2
   ;; Note: 2.x isn't the default yet, see above.
   (package
     (inherit hwloc-1)
-    (version "2.8.0")
+    (version "2.9.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://download.open-mpi.org/release/hwloc/v"
@@ -151,7 +151,7 @@ (define-public hwloc-2
                                   "/hwloc-" version ".tar.bz2"))
               (sha256
                (base32
-                "1ha23yqfx9kfxm5fcj9m0fnyf0r2k6p4k88xxqishclcsky752il"))))
+                "11v8hnl6fdsdbm3wnz5gg88f2ghixjyl7jlfmywj293ab5iyjw10"))))
 
     ;; libnuma is no longer needed.
     (inputs (modify-inputs (package-inputs hwloc-1)
@@ -167,6 +167,10 @@ (define-public hwloc-2
                (substitute* "tests/hwloc/linux-libnuma.c"
                  (("numa_available\\(\\)")
                   "-1"))))
+           (add-before 'check 'skip-test-that-requires-/sys
+             (lambda _
+               ;; 'test-gather-topology.sh' requires /sys as of 2.9.0; skip it.
+               (setenv "HWLOC_TEST_GATHER_TOPOLOGY" "0")))
            (add-before 'check 'skip-test-that-fails-on-qemu
              (lambda _
                ;; Skip test that fails on emulated hardware due to QEMU bug:

base-commit: 84f117f49587b608b287827793b1b8036d2cff7f
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#60706; Package guix-patches. (Tue, 10 Jan 2023 16:35:01 GMT) Full text and rfc822 format available.

Message #8 received at 60706 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 60706 <at> debbugs.gnu.org,
 Ludovic Courtès <ludovic.courtes <at> inria.fr>
Subject: Re: bug#60706: [PATCH] gnu: hwloc: Update to 2.9.0.
Date: Tue, 10 Jan 2023 11:34:32 -0500
Hi,

Ludovic Courtès <ludo <at> gnu.org> writes:

> From: Ludovic Courtès <ludovic.courtes <at> inria.fr>
>
> * gnu/packages/mpi.scm (hwloc-2): Update to 2.9.0.
> [arguments]: Add 'skip-test-that-requires-/sys' phase.
> ---
>  gnu/packages/mpi.scm | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
> index af2409aeab..56b7d04209 100644
> --- a/gnu/packages/mpi.scm
> +++ b/gnu/packages/mpi.scm
> @@ -1,6 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2014, 2015, 2018, 2019 Eric Bavier <bavier <at> member.fsf.org>
> -;;; Copyright © 2014-2022 Ludovic Courtès <ludo <at> gnu.org>
> +;;; Copyright © 2014-2023 Ludovic Courtès <ludo <at> gnu.org>
>  ;;; Copyright © 2014 Ian Denhardt <ian <at> zenhack.net>
>  ;;; Copyright © 2016 Andreas Enge <andreas <at> enge.fr>
>  ;;; Copyright © 2017 Dave Love <fx <at> gnu.org>

Nitpick: arguably not a copyrightable change (< 10 lines of additions).

> @@ -143,7 +143,7 @@ (define-public hwloc-2
>    ;; Note: 2.x isn't the default yet, see above.
>    (package
>      (inherit hwloc-1)
> -    (version "2.8.0")
> +    (version "2.9.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "https://download.open-mpi.org/release/hwloc/v"
> @@ -151,7 +151,7 @@ (define-public hwloc-2
>                                    "/hwloc-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "1ha23yqfx9kfxm5fcj9m0fnyf0r2k6p4k88xxqishclcsky752il"))))
> +                "11v8hnl6fdsdbm3wnz5gg88f2ghixjyl7jlfmywj293ab5iyjw10"))))
>  
>      ;; libnuma is no longer needed.
>      (inputs (modify-inputs (package-inputs hwloc-1)
> @@ -167,6 +167,10 @@ (define-public hwloc-2
>                 (substitute* "tests/hwloc/linux-libnuma.c"
>                   (("numa_available\\(\\)")
>                    "-1"))))
> +           (add-before 'check 'skip-test-that-requires-/sys
> +             (lambda _
> +               ;; 'test-gather-topology.sh' requires /sys as of 2.9.0; skip it.
> +               (setenv "HWLOC_TEST_GATHER_TOPOLOGY" "0")))
>             (add-before 'check 'skip-test-that-fails-on-qemu
>               (lambda _
>                 ;; Skip test that fails on emulated hardware due to QEMU bug:

Otherwise LGTM.

-- 
Thanks,
Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#60706; Package guix-patches. (Tue, 10 Jan 2023 17:07:02 GMT) Full text and rfc822 format available.

Message #11 received at 60706 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludovic.courtes <at> inria.fr>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 60706 <at> debbugs.gnu.org
Subject: Re: bug#60706: [PATCH] gnu: hwloc: Update to 2.9.0.
Date: Tue, 10 Jan 2023 18:06:08 +0100
Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> From: Ludovic Courtès <ludovic.courtes <at> inria.fr>
>>
>> * gnu/packages/mpi.scm (hwloc-2): Update to 2.9.0.
>> [arguments]: Add 'skip-test-that-requires-/sys' phase.
>> ---
>>  gnu/packages/mpi.scm | 10 +++++++---
>>  1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
>> index af2409aeab..56b7d04209 100644
>> --- a/gnu/packages/mpi.scm
>> +++ b/gnu/packages/mpi.scm
>> @@ -1,6 +1,6 @@
>>  ;;; GNU Guix --- Functional package management for GNU
>>  ;;; Copyright © 2014, 2015, 2018, 2019 Eric Bavier <bavier <at> member.fsf.org>
>> -;;; Copyright © 2014-2022 Ludovic Courtès <ludo <at> gnu.org>
>> +;;; Copyright © 2014-2023 Ludovic Courtès <ludo <at> gnu.org>
>>  ;;; Copyright © 2014 Ian Denhardt <ian <at> zenhack.net>
>>  ;;; Copyright © 2016 Andreas Enge <andreas <at> enge.fr>
>>  ;;; Copyright © 2017 Dave Love <fx <at> gnu.org>
>
> Nitpick: arguably not a copyrightable change (< 10 lines of additions).

Riiight.

> Otherwise LGTM.

Thanks for taking a look!

Let’s see if <https://qa.guix.gnu.org/issue/60706> can tell us more
about dependents and non-x86 architectures…

Ludo’.





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Fri, 27 Jan 2023 17:20:02 GMT) Full text and rfc822 format available.

Notification sent to Ludovic Courtès <ludo <at> gnu.org>:
bug acknowledged by developer. (Fri, 27 Jan 2023 17:20:02 GMT) Full text and rfc822 format available.

Message #16 received at 60706-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 60706-done <at> debbugs.gnu.org
Subject: Re: bug#60706: [PATCH] gnu: hwloc: Update to 2.9.0.
Date: Fri, 27 Jan 2023 18:19:06 +0100
Ludovic Courtès <ludovic.courtes <at> inria.fr> skribis:

> Let’s see if <https://qa.guix.gnu.org/issue/60706> can tell us more
> about dependents and non-x86 architectures…

Pushed as 317ea0458927810754ab154228ace04ff7bab717 with a fix for the
issues qa.guix found in dependent packages.

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 25 Feb 2023 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 32 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.