Received: (at 60740) by debbugs.gnu.org; 4 Feb 2023 12:29:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 07:29:37 2023 Received: from localhost ([127.0.0.1]:40816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pOHfi-0006mS-9k for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 07:29:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pOHfd-0006mB-9l for 60740 <at> debbugs.gnu.org; Sat, 04 Feb 2023 07:29:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pOHfX-00050t-2Z; Sat, 04 Feb 2023 07:29:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oy5uPVlSXVXP10Ldr2ek7OarMZZG7ydnVJ3lQiYCOx8=; b=MCH4hM1KXItS wxQdZ37rEyfisaOuK9wh01T0mbt0wkldsuBa16DZaKxhBsfSx26Xw0o5OB/onbxH6yXpcJTW7ULt+ srYGwLFDemJoHlrXz2HJRdiI/KQN3UQtV2xK7teGeOVA8KfoIYBH8GsHSRNE93r8Fuphok98JEXdC CPlY8CygwFUdgK3XHjmwm7AKXgxZ2yFICFC8MyQvTdGEtmQzeCP4BiXy2MsGx0A/Z3ic9badTIwpX u+iFuwBlfZsczS5f9aaZ/FQ1lBjmD/hHfYHspiLyFTRbselu5Uk9CFMBd3Nfi3yXvI4Y5Qe3nsK5h mixPQr9S/aw4G2rYofysZg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pOHfW-0000gf-7Q; Sat, 04 Feb 2023 07:29:22 -0500 Date: Sat, 04 Feb 2023 14:29:27 +0200 Message-Id: <83r0v5txzs.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jonas Bernoulli <jonas@HIDDEN> In-Reply-To: <874js1vdo7.fsf@HIDDEN> (message from Jonas Bernoulli on Sat, 04 Feb 2023 13:05:28 +0100) Subject: Re: bug#60740: [PATCH 0/2] emoji changes References: <83leli3nly.fsf@HIDDEN> <20230201230918.550-1-jonas@HIDDEN> <83zg9tu91v.fsf@HIDDEN> <874js1vdo7.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60740 Cc: 60740 <at> debbugs.gnu.org, larsi@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Jonas Bernoulli <jonas@HIDDEN> > Cc: 60740 <at> debbugs.gnu.org, larsi@HIDDEN > Date: Sat, 04 Feb 2023 13:05:28 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > Thanks. > > > > Would it make sense to install the first patch on the emacs-29 branch > > and the second on master? Or did I misunderstand your explanations > > above? AFAIU, the first patch solves the immediate issue in this bug, > > right? > > That's correct and it would make sense to do it like this. At the same > time I think that it is risky both to install and not install the second > patch on emacs-29. On the one hand past changes to transient did not > break emoji, even though I did not specifically try to prevent that. On > the other the risk of that happening going forward is not zero. If Lars > finds the time to look at the refactoring before the pre-release, I > think it would be best to install it on emacs-29, but if not, I am find > with it going on master instead. My suggestion is for now to install the first patch on emacs-29 and the second one on master. We can always backport from master to emacs-29 if we decide so later. From my POV at this time, it is important to resolve the few remaining issues that prevent us from starting the Emacs 29 pretest, and this issue is one of them. Which is why I suggest to do the above now, and consider backporting the second patch to emacs-29 later if we have time. Thanks.
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 4 Feb 2023 12:05:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 07:05:38 2023 Received: from localhost ([127.0.0.1]:40800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pOHIY-0003pR-Iw for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 07:05:38 -0500 Received: from mail.hostpark.net ([212.243.197.30]:37590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jonas@HIDDEN>) id 1pOHIT-0003p8-QI for 60740 <at> debbugs.gnu.org; Sat, 04 Feb 2023 07:05:36 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 3A7D716267; Sat, 4 Feb 2023 13:05:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1675512331; bh=MZhaZa11euMUL4QhyUK7ahto Se0xaLTij2FZ4G9wtf0=; b=dwdWavsbLj4rv6FbP2vHxEVonY+mRw3JJY+nMk7j W/TqiJPwGAq8FHncE+WsXyukauvK8tZOoY+ucIPdRehHPxjqxFBGOHT3dFFVxavT Vht9FWqsutJw13v6J9P3OPukS/QrmwCFbLstLcPHNxIMM7B3+5ogO2q65Ee7dlSM 0Jc= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id 8Ikfq6stjrxj; Sat, 4 Feb 2023 13:05:31 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id ED9F3162A9; Sat, 4 Feb 2023 13:05:30 +0100 (CET) From: Jonas Bernoulli <jonas@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#60740: [PATCH 0/2] emoji changes In-Reply-To: <83zg9tu91v.fsf@HIDDEN> References: <83leli3nly.fsf@HIDDEN> <20230201230918.550-1-jonas@HIDDEN> <83zg9tu91v.fsf@HIDDEN> Date: Sat, 04 Feb 2023 13:05:28 +0100 Message-ID: <874js1vdo7.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60740 Cc: 60740 <at> debbugs.gnu.org, larsi@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Eli Zaretskii <eliz@HIDDEN> writes: > Thanks. > > Would it make sense to install the first patch on the emacs-29 branch > and the second on master? Or did I misunderstand your explanations > above? AFAIU, the first patch solves the immediate issue in this bug, > right? That's correct and it would make sense to do it like this. At the same time I think that it is risky both to install and not install the second patch on emacs-29. On the one hand past changes to transient did not break emoji, even though I did not specifically try to prevent that. On the other the risk of that happening going forward is not zero. If Lars finds the time to look at the refactoring before the pre-release, I think it would be best to install it on emacs-29, but if not, I am find with it going on master instead.
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 4 Feb 2023 08:30:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 03:30:38 2023 Received: from localhost ([127.0.0.1]:40644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pODwU-00019s-BP for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 03:30:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pODwS-0000sX-O5 for 60740 <at> debbugs.gnu.org; Sat, 04 Feb 2023 03:30:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pODwM-0000P1-9g; Sat, 04 Feb 2023 03:30:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ow3NdFkN+fmsAJ2hou2UZqRH9Jt5o2ZzxxDVRKbgH4Q=; b=eteGq18uPhXx jb29xq98BcwnkqYD/Z3V7vMTISIns1Sj7Uz96g6xOObdOCpj/YLwewfrRwZ0O6hRHyOXe4FRzviMZ ihdvsxSmpNuYoJaorJC8dcEEessUAvfY/x9eYk9tWRkGrreMvWj0cE2GC6yb5v68kwDtuNhKqW69V roqvg8gHkx8iI7M77RxfVSBqPzcNSc09++WcOutLY26yYWvPob0LbZj8ttC+l3tu4yUjHftgBRlXg UPNFBtuxSnbLDPZTG2YJP1wcd4j0E78qNWFeNzVDJXwTReLHIBm4ZO0dh4AsTFwh2J/qyfrtNg1dc QdqOLgKsgIZflAmR8IhQ0w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pODwL-0003hH-ED; Sat, 04 Feb 2023 03:30:30 -0500 Date: Sat, 04 Feb 2023 10:30:36 +0200 Message-Id: <83zg9tu91v.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jonas Bernoulli <jonas@HIDDEN> In-Reply-To: <20230201230918.550-1-jonas@HIDDEN> (message from Jonas Bernoulli on Thu, 2 Feb 2023 00:09:16 +0100) Subject: Re: bug#60740: [PATCH 0/2] emoji changes References: <83leli3nly.fsf@HIDDEN> <20230201230918.550-1-jonas@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60740 Cc: 60740 <at> debbugs.gnu.org, larsi@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: larsi@HIDDEN > From: Jonas Bernoulli <jonas@HIDDEN> > Date: Thu, 2 Feb 2023 00:09:16 +0100 > > * The first commit changes `isearch-emoji-by-name' to not use > transient. If there are derivations then `completing-read' > is instead used to let the user chose one. > > I think we should stick to that. What I mention next, seems > way to risky at this time and I also do not think it would be > worth it. Selecting a derivation using `completing-read' isn't > bad at all. > > (The problem with using a transient command inside > `with-isearch-suspended' is that expects to be able to call a > function, which uses `recursive-edit' in some way. Once that > returns, the macro resumes isearch. But transient does not do that > and it returns immediately after the transient prefix command > returns. That happens before the user selects a derivation by > invoking one of the suffix commands. So isearch resumes before > the user has made any choice. > > One way around that might be to call `recursive-edit' in > `isearch-emoji-by-name' before calling the code that might then use > transient. But that would also have to automatically invoke a > command inside that recursive edit. I couldn't find a way to do > that. I timer might work, but that seems hacky. > > Another approach could be to break up `with-isearch-suspended' up > into two functions, one that suspends and another that resumes. > The suspend function could maybe also responsible for returning > the resume function as a closure. The macro could use these two > functions and existing callers could continue to use that. But > `isearch-emoji-by-name' would only call the suspend function and > would have to somehow pass the resume function to transient, so > that it could call it when the time has come.) > > * The second commit changes emoji.el to use transient.el the way I > intended it to be used. (I *think* transient already had support > for "dynamic" transient commands, when emoji.el was created, but > some of the convenience features certainly were missing still.) > > The new implementation changes the remaining entry points to be > defined using `define-transient-prefix' but still without adding any > suffix commands to them up front. Previously no *prefix* command > was defined up front. Instead code very similar to what can be > found in `define-transient-prefix' was used to turn certain nodes > inside the tree of emoji into (sub-)prefix commands. These prefix > commands were then invoked using `funcall', which is not how that > is supposed to work; I am surprised that worked at all, but I guess > that just means that emoji doesn't use any of transient's features > that depend on `this-command' "being correct". > > The new implementation adds a single, named suffix command, > `emoji-insert-glyph'. Now every suffix of a transient prefix is > either that command or a "recursive" call to the prefix itself, with > its scope narrowed to only part of the original tree of emoji. That > is a big improvement over the old implementation, which had to > define a new command for each and every emoji, and a new command for > every grouping of emoji. Thanks. Would it make sense to install the first patch on the emacs-29 branch and the second on master? Or did I misunderstand your explanations above? AFAIU, the first patch solves the immediate issue in this bug, right?
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.
Received: (at 60740) by debbugs.gnu.org; 1 Feb 2023 23:09:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 01 18:09:45 2023
Received: from localhost ([127.0.0.1]:60101 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pNMEX-0005pf-Pm
for submit <at> debbugs.gnu.org; Wed, 01 Feb 2023 18:09:45 -0500
Received: from mail.hostpark.net ([212.243.197.30]:37400)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <jonas@HIDDEN>) id 1pNMEV-0005pX-B5
for 60740 <at> debbugs.gnu.org; Wed, 01 Feb 2023 18:09:40 -0500
Received: from localhost (localhost [127.0.0.1])
by mail.hostpark.net (Postfix) with ESMTP id B39FD1625C;
Thu, 2 Feb 2023 00:09:38 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h=
content-transfer-encoding:content-type:content-type:mime-version
:references:in-reply-to:x-mailer:message-id:date:date:subject
:subject:from:from:received:received; s=sel2011a; t=1675292978;
bh=VKKAtoeF02gECtoTChdoEoPjGx1So11pzSdqG8FRrgk=; b=KEHuB7b8AhlL
ejS4nvRA8ksXGxlUKXtCMnRckEWv2MsSL9FH+9dv0pTbh7HQfoMeK7U3FY0Ub7tN
QMpWMnCQzBQimJasr74OZuzrH1YDRZZ0fjRnXogrSf7GhaEp/6ZACXLSMQr0m7x5
UJUih7tP8opnWDTTW0N4pRdfVP1iCxA=
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224)
with ESMTP id V5q7TgJPLD47; Thu, 2 Feb 2023 00:09:38 +0100 (CET)
Received: from customer (localhost [127.0.0.1])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by mail.hostpark.net (Postfix) with ESMTPSA id 52DAB16255;
Thu, 2 Feb 2023 00:09:38 +0100 (CET)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 60740 <at> debbugs.gnu.org
Subject: [PATCH 2/2] Rewrite emoji's usage of transient
Date: Thu, 2 Feb 2023 00:09:18 +0100
Message-Id: <20230201230918.550-3-jonas@HIDDEN>
X-Mailer: git-send-email 2.39.1
In-Reply-To: <20230201230918.550-1-jonas@HIDDEN>
References: <83leli3nly.fsf@HIDDEN>
<20230201230918.550-1-jonas@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 60740
Cc: larsi@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
* lisp/international/emoji.el:
(emoji--done-derived): Remove variable.
(emoji-insert, emoji-recent, emoji-search, emoji-list-select):
Define using 'transient-define-prefix'. Use a base suffix group
whose value is calculated dynamically.
(emoji--setup-prefix, emoji--setup-suffixes, emoji-group-description):
New functions used to dynamically calculate suffixes.
(emoji--narrow): New suffix class, used to pass state to recursive,
narrowed invocations of the prefix command the user initially invoked.
(emoji-insert-glyph): New suffix command that is used for all glyphs
that have no derivations. Previously a separate command was define
for each glyph.
(emoji--fontify-glyph): Replace 'inhibit-derived' argument with
'done-derived' argument.
(emoji--define-transient): Remove function.
(emoji--layout): New function, replacing 'emoji--define-transient'.
Return the suffixes in 'define-transient-prefix' format. Unlike
the replaced function, do not define any new commands, instead use
either the current prefix command or 'emoji-insert-glyph'.
(emoji--recent-transient): Remove function.
(emoji--char-sequence): New function.
(emoji--add-recent): Remove all text properties from glyph.
(emoji--choose-emoji): Remove function.
---
lisp/international/emoji.el | 266 +++++++++++++++++-------------------
1 file changed, 125 insertions(+), 141 deletions(-)
diff --git a/lisp/international/emoji.el b/lisp/international/emoji.el
index f75bd877991..b920582fee0 100644
--- a/lisp/international/emoji.el
+++ b/lisp/international/emoji.el
@@ -68,38 +68,86 @@ emoji--labels
(defvar emoji--all-bases nil)
(defvar emoji--derived nil)
(defvar emoji--names (make-hash-table :test #'equal))
-(defvar emoji--done-derived nil)
(define-multisession-variable emoji--recent (list "😀" "😖"))
(defvar emoji--insert-buffer)
-;;;###autoload
-(defun emoji-insert ()
+;;;###autoload (autoload 'emoji-insert "emoji" nil t)
+(transient-define-prefix emoji-insert ()
"Choose and insert an emoji glyph."
+ :variable-pitch t
+ [:class transient-columns
+ :setup-children emoji--setup-suffixes
+ :description emoji--group-description]
(interactive "*")
(emoji--init)
- (unless (fboundp 'emoji--command-Emoji)
- (emoji--define-transient))
- (funcall (intern "emoji--command-Emoji")))
+ (emoji--setup-prefix 'emoji-insert "Emoji" nil
+ `(("Recent" ,@(multisession-value emoji--recent))
+ ,@emoji--labels)))
-;;;###autoload
-(defun emoji-recent ()
+;;;###autoload (autoload 'emoji-recent "emoji" nil t)
+(transient-define-prefix emoji-recent ()
"Choose and insert one of the recently-used emoji glyphs."
+ :variable-pitch t
+ [:class transient-columns
+ :setup-children emoji--setup-suffixes
+ :description emoji--group-description]
(interactive "*")
(emoji--init)
- (unless (fboundp 'emoji--command-Emoji)
- (emoji--define-transient))
- (funcall (emoji--define-transient
- (cons "Recent" (multisession-value emoji--recent)) t)))
+ (emoji--setup-prefix 'emoji-recent "Recent" t
+ (multisession-value emoji--recent)))
-;;;###autoload
-(defun emoji-search ()
+;;;###autoload (autoload 'emoji-search "emoji" nil t)
+(transient-define-prefix emoji-search ()
"Choose and insert an emoji glyph by typing its Unicode name.
This command prompts for an emoji name, with completion, and
inserts it. It recognizes the Unicode Standard names of emoji,
and also consults the `emoji-alternate-names' alist."
+ :variable-pitch t
+ [:class transient-columns
+ :setup-children emoji--setup-suffixes
+ :description emoji--group-description]
(interactive "*")
(emoji--init)
- (emoji--choose-emoji))
+ (pcase-let ((`(,glyph . ,derived) (emoji--read-emoji)))
+ (if derived
+ (emoji--setup-prefix 'emoji-search "Choose Emoji"
+ (list glyph)
+ (cons glyph derived))
+ (emoji--add-recent glyph)
+ (insert glyph))))
+
+(defun emoji--setup-prefix (command title done-derived spec)
+ (transient-setup
+ command nil nil
+ :scope (if (eq transient-current-command command)
+ (cons (oref (transient-suffix-object) title)
+ (oref (transient-suffix-object) done-derived))
+ (cons title done-derived))
+ :value (if (eq transient-current-command command)
+ (oref (transient-suffix-object) children)
+ spec)))
+
+(defun emoji--setup-suffixes (_)
+ (transient-parse-suffixes
+ (oref transient--prefix command)
+ (pcase-let ((`(,title . ,done-derived) (oref transient--prefix scope)))
+ (emoji--layout (oref transient--prefix command) title
+ (oref transient--prefix value) done-derived))))
+
+(defun emoji--group-description ()
+ (car (oref transient--prefix scope)))
+
+(defclass emoji--narrow (transient-suffix)
+ ((title :initarg :title)
+ (done-derived :initarg :done-derived)
+ (children :initarg :children)))
+
+(transient-define-suffix emoji-insert-glyph ()
+ "Insert the emoji you selected."
+ (interactive nil not-a-mode)
+ (let ((glyph (oref (transient-suffix-object) description)))
+ (emoji--add-recent glyph)
+ (insert glyph)))
;;;###autoload
(defun emoji-list ()
@@ -179,11 +227,10 @@ emoji--list-generate
'help-echo (emoji--name glyph))))
(insert "\n\n"))))
-(defun emoji--fontify-glyph (glyph &optional inhibit-derived)
+(defun emoji--fontify-glyph (glyph &optional done-derived)
(propertize glyph 'face
- (if (and (not inhibit-derived)
- (or (null emoji--done-derived)
- (not (gethash glyph emoji--done-derived)))
+ (if (and (not (or (eq done-derived t)
+ (member glyph done-derived)))
(gethash glyph emoji--derived))
;; If this emoji has derivations, use a special face
;; to tell the user.
@@ -206,33 +253,30 @@ emoji-list-mode
:interactive nil
(setq-local truncate-lines t))
-(defun emoji-list-select (event)
+;;;###autoload (autoload 'emoji-list-select "emoji" nil t)
+(transient-define-prefix emoji-list-select (event)
"Select the emoji under point."
+ :variable-pitch t
+ [:class transient-columns
+ :setup-children emoji--setup-suffixes
+ :description emoji--group-description]
(interactive (list last-nonmenu-event) emoji-list-mode)
(mouse-set-point event)
(let ((glyph (get-text-property (point) 'emoji-glyph)))
(unless glyph
(error "No emoji under point"))
- (let ((derived (gethash glyph emoji--derived))
- (end-func
- (lambda ()
- (let ((buf emoji--insert-buffer))
- (quit-window)
- (if (buffer-live-p buf)
- (switch-to-buffer buf)
- (error "Buffer disappeared"))))))
- (if (not derived)
- ;; Glyph without derivations.
- (progn
- (emoji--add-recent glyph)
- (funcall end-func)
- (insert glyph))
- ;; Pop up a transient to choose between derivations.
- (let ((emoji--done-derived (make-hash-table :test #'equal)))
- (setf (gethash glyph emoji--done-derived) t)
- (funcall
- (emoji--define-transient (cons "Choose Emoji" (cons glyph derived))
- nil end-func)))))))
+ (let ((buf emoji--insert-buffer))
+ (quit-window)
+ (if (buffer-live-p buf)
+ (switch-to-buffer buf)
+ (error "Buffer disappeared")))
+ (let ((derived (gethash glyph emoji--derived)))
+ (if derived
+ (emoji--setup-prefix 'emoji-list-select "Choose Emoji"
+ (list glyph)
+ (cons glyph derived))
+ (emoji--add-recent glyph)
+ (insert glyph)))))
(defun emoji-list-help ()
"Display the name of the emoji at point."
@@ -476,97 +520,51 @@ emoji--add-glyph
(setq parent elem))
(nconc elem (list glyph)))))
-(defun emoji--define-transient (&optional alist inhibit-derived
- end-function)
- (unless alist
- (setq alist (cons "Emoji" emoji--labels)))
- (let* ((mname (pop alist))
- (name (intern (format "emoji--command-%s" mname)))
- (emoji--done-derived (or emoji--done-derived
- (make-hash-table :test #'equal)))
- (has-subs (consp (cadr alist)))
- (layout
- (if has-subs
- ;; Define sub-maps.
- (cl-loop for entry in
- (emoji--compute-prefix
- (if (equal mname "Emoji")
- (cons (list "Recent") alist)
- alist))
- collect (list
- (car entry)
- (emoji--compute-name (cdr entry))
- (if (equal (cadr entry) "Recent")
- (emoji--recent-transient end-function)
- (emoji--define-transient
- (cons (concat mname " > " (cadr entry))
- (cddr entry))))))
- ;; Insert an emoji.
- (cl-loop for glyph in alist
- for i in (append (number-sequence ?a ?z)
- (number-sequence ?A ?Z)
- (number-sequence ?0 ?9)
- (number-sequence ?! ?/))
- collect (let ((this-glyph glyph))
- (list
- (string i)
- (emoji--fontify-glyph
- glyph inhibit-derived)
- (let ((derived
- (and (not inhibit-derived)
- (not (gethash glyph
- emoji--done-derived))
- (gethash glyph emoji--derived))))
- (if derived
- ;; We have a derived glyph, so add
- ;; another level.
- (progn
- (setf (gethash glyph
- emoji--done-derived)
- t)
- (emoji--define-transient
- (cons (concat mname " " glyph)
- (cons glyph derived))
- t end-function))
- ;; Insert the emoji.
- (lambda ()
- (interactive nil not-a-mode)
- ;; Allow switching to the correct
- ;; buffer.
- (when end-function
- (funcall end-function))
- (emoji--add-recent this-glyph)
- (insert this-glyph)))))))))
- (args (apply #'vector mname
- (emoji--columnize layout
- (if has-subs 2 8)))))
- ;; There's probably a better way to do this...
- (setf (symbol-function name)
- (lambda ()
- (interactive nil not-a-mode)
- (transient-setup name)))
- (pcase-let ((`(,class ,slots ,suffixes ,docstr ,_body)
- (transient--expand-define-args (list args))))
- (put name 'interactive-only t)
- (put name 'function-documentation docstr)
- (put name 'transient--prefix
- (apply (or class 'transient-prefix) :command name
- (cons :variable-pitch (cons t slots))))
- (put name 'transient--layout
- (transient-parse-suffixes name suffixes)))
- name))
-
-(defun emoji--recent-transient (end-function)
- "Create a function to display a dynamically generated menu."
- (lambda ()
- (interactive)
- (funcall (emoji--define-transient
- (cons "Recent" (multisession-value emoji--recent))
- t end-function))))
+(defun emoji--layout (command title spec done-derived)
+ (let ((has-subs (consp (cadr spec))))
+ (emoji--columnize
+ (if has-subs
+ (cl-loop for (key desc . glyphs) in (emoji--compute-prefix spec)
+ collect
+ (list key
+ (emoji--compute-name (cons desc glyphs))
+ command
+ :class 'emoji--narrow
+ :title (concat title " > " desc)
+ :done-derived (or (string-suffix-p "Recent" desc)
+ done-derived)
+ :children glyphs))
+ (cl-loop for glyph in spec
+ for char in (emoji--char-sequence)
+ for key = (string char)
+ for derived = (and (not (or (eq done-derived t)
+ (member glyph done-derived)))
+ (gethash glyph emoji--derived))
+ collect
+ (if derived
+ (list key
+ (emoji--fontify-glyph glyph done-derived)
+ command
+ :class 'emoji--narrow
+ :title (concat title " " glyph)
+ :done-derived (or (eq done-derived t)
+ (cons glyph done-derived))
+ :children (cons glyph derived))
+ (list key
+ (emoji--fontify-glyph glyph done-derived)
+ 'emoji-insert-glyph))))
+ (if has-subs 2 8))))
+
+(defun emoji--char-sequence ()
+ (append (number-sequence ?a ?z)
+ (number-sequence ?A ?Z)
+ (number-sequence ?0 ?9)
+ (number-sequence ?! ?/)))
(defun emoji--add-recent (glyph)
"Add GLYPH to the set of recently used emojis."
(let ((recent (multisession-value emoji--recent)))
+ (set-text-properties 0 (length glyph) nil glyph)
(setq recent (delete glyph recent))
(push glyph recent)
;; Shorten the list.
@@ -684,20 +682,6 @@ emoji--read-emoji
(gethash name emoji--all-bases))))
(cons glyph (gethash glyph emoji--derived))))))
-(defun emoji--choose-emoji ()
- (pcase-let ((`(,glyph ,derived)) (emoji--read-emoji))
- (if (not derived)
- ;; Simple glyph with no derivations.
- (progn
- (emoji--add-recent glyph)
- (insert glyph))
- ;; Choose a derived version.
- (let ((emoji--done-derived (make-hash-table :test #'equal)))
- (setf (gethash glyph emoji--done-derived) t)
- (funcall
- (emoji--define-transient
- (cons "Choose Emoji" (cons glyph derived))))))))
-
(defvar-keymap emoji-zoom-map
"+" #'emoji-zoom-increase
"-" #'emoji-zoom-decrease)
--
2.39.1
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.
Received: (at 60740) by debbugs.gnu.org; 1 Feb 2023 23:09:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 01 18:09:32 2023
Received: from localhost ([127.0.0.1]:60098 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pNMEO-0005pF-BP
for submit <at> debbugs.gnu.org; Wed, 01 Feb 2023 18:09:32 -0500
Received: from mail.hostpark.net ([212.243.197.30]:37398)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <jonas@HIDDEN>) id 1pNMEN-0005p7-0z
for 60740 <at> debbugs.gnu.org; Wed, 01 Feb 2023 18:09:31 -0500
Received: from localhost (localhost [127.0.0.1])
by mail.hostpark.net (Postfix) with ESMTP id 6BF8C1625C;
Thu, 2 Feb 2023 00:09:30 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h=
content-transfer-encoding:mime-version:references:in-reply-to
:x-mailer:message-id:date:date:subject:subject:from:from
:received:received; s=sel2011a; t=1675292970; bh=QtVCjcByFpXhbQZ
+9Mj6XzyqhnSx86gU2h8+dPOOTf0=; b=zjQ4H5c1jp7ow6+tGC8XUjlt5UCDZ9g
+JulYznepuVAtAlHAe1BjqmaAV+GppVjDuCSbDlwoNJmpzJ83k+B1plnRmGjN7t0
+QF+j98p/SteIdFATg65cG28JBRwbfVR7OM/q/G8EqF/crByTRJpC+jgPkhdXv7v
a1rNDqaOUn08=
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224)
with ESMTP id Y3IQdFf8VXwC; Thu, 2 Feb 2023 00:09:30 +0100 (CET)
Received: from customer (localhost [127.0.0.1])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by mail.hostpark.net (Postfix) with ESMTPSA id 294EB16255;
Thu, 2 Feb 2023 00:09:30 +0100 (CET)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 60740 <at> debbugs.gnu.org
Subject: [PATCH 1/2] No longer use transient in isearch-emoji-by-name
Date: Thu, 2 Feb 2023 00:09:17 +0100
Message-Id: <20230201230918.550-2-jonas@HIDDEN>
X-Mailer: git-send-email 2.39.1
In-Reply-To: <20230201230918.550-1-jonas@HIDDEN>
References: <83leli3nly.fsf@HIDDEN>
<20230201230918.550-1-jonas@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 60740
Cc: larsi@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
* lisp/isearch.el (isearch-emoji-by-name): Use 'emoji--read-emoji'
and if that returns derivations, 'completing-read' to select one
of them. This fixes bug#60740.
* lisp/international/emoji.el (emoji--init): Autoload.
(emoji--read-emoji): New function, which doesn't use transient
and returns a list of the glyph and all derivations, if any.
(emoji--choose-emoji): Use 'emoji--read-emoji'.
---
lisp/international/emoji.el | 36 ++++++++++++++++++++----------------
lisp/isearch.el | 20 ++++++++------------
2 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/lisp/international/emoji.el b/lisp/international/emoji.el
index 2d17cf639b0..f75bd877991 100644
--- a/lisp/international/emoji.el
+++ b/lisp/international/emoji.el
@@ -245,6 +245,7 @@ emoji-list-help
(error "Emoji name is unknown")
(message "%s" name)))))
+;;;###autoload
(defun emoji--init (&optional force inhibit-adjust)
(when (or (not emoji--labels)
force)
@@ -638,7 +639,7 @@ emoji--split-long-lists
collect (cons (concat (string prefix) "-group")
(seq-take bit 77))))))))
-(defun emoji--choose-emoji ()
+(defun emoji--read-emoji ()
;; Use the list of names.
(let* ((table
(if (not emoji-alternate-names)
@@ -678,21 +679,24 @@ emoji--choose-emoji
(complete-with-action action table string pred)))
nil t)))
(when (cl-plusp (length name))
- (let* ((glyph (if emoji-alternate-names
- (cadr (split-string name "\t"))
- (gethash name emoji--all-bases)))
- (derived (gethash glyph emoji--derived)))
- (if (not derived)
- ;; Simple glyph with no derivations.
- (progn
- (emoji--add-recent glyph)
- (insert glyph))
- ;; Choose a derived version.
- (let ((emoji--done-derived (make-hash-table :test #'equal)))
- (setf (gethash glyph emoji--done-derived) t)
- (funcall
- (emoji--define-transient
- (cons "Choose Emoji" (cons glyph derived))))))))))
+ (let ((glyph (if emoji-alternate-names
+ (cadr (split-string name "\t"))
+ (gethash name emoji--all-bases))))
+ (cons glyph (gethash glyph emoji--derived))))))
+
+(defun emoji--choose-emoji ()
+ (pcase-let ((`(,glyph ,derived)) (emoji--read-emoji))
+ (if (not derived)
+ ;; Simple glyph with no derivations.
+ (progn
+ (emoji--add-recent glyph)
+ (insert glyph))
+ ;; Choose a derived version.
+ (let ((emoji--done-derived (make-hash-table :test #'equal)))
+ (setf (gethash glyph emoji--done-derived) t)
+ (funcall
+ (emoji--define-transient
+ (cons "Choose Emoji" (cons glyph derived))))))))
(defvar-keymap emoji-zoom-map
"+" #'emoji-zoom-increase
diff --git a/lisp/isearch.el b/lisp/isearch.el
index 22e27764127..bfa71756146 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -2774,25 +2774,21 @@ isearch-char-by-name
(mapconcat 'isearch-text-char-description
string ""))))))))
-(defvar emoji--derived)
(defun isearch-emoji-by-name (&optional count)
"Read an Emoji name and add it to the search string COUNT times.
COUNT (interactively, the prefix argument) defaults to 1.
The command accepts Unicode names like \"smiling face\" or
\"heart with arrow\", and completion is available."
(interactive "p")
+ (emoji--init)
(with-isearch-suspended
- (let ((emoji (with-temp-buffer
- ;; Derived emoji not supported yet (bug#60740).
- ;; So first load `emoji--labels', then `emoji--init'
- ;; will not fill `emoji--derived' that is set
- ;; to an empty hash table below.
- (ignore-errors (require 'emoji-labels))
- (let ((emoji--derived (make-hash-table :test #'equal)))
- (emoji-search))
- (if (and (integerp count) (> count 1))
- (apply 'concat (make-list count (buffer-string)))
- (buffer-string)))))
+ (pcase-let* ((`(,glyph . ,derived) (emoji--read-emoji))
+ (emoji (if derived
+ (completing-read "Select derivation: "
+ (cons glyph derived) nil t)
+ glyph)))
+ (when (and (integerp count) (> count 1))
+ (setq emoji (apply 'concat (make-list count emoji))))
(when emoji
(setq isearch-new-string (concat isearch-string emoji)
isearch-new-message (concat isearch-message
--
2.39.1
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.
Received: (at 60740) by debbugs.gnu.org; 1 Feb 2023 23:09:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 01 18:09:30 2023
Received: from localhost ([127.0.0.1]:60095 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pNMEL-0005p0-Q3
for submit <at> debbugs.gnu.org; Wed, 01 Feb 2023 18:09:30 -0500
Received: from mail.hostpark.net ([212.243.197.30]:37396)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <jonas@HIDDEN>) id 1pNMEG-0005oo-SM
for 60740 <at> debbugs.gnu.org; Wed, 01 Feb 2023 18:09:28 -0500
Received: from localhost (localhost [127.0.0.1])
by mail.hostpark.net (Postfix) with ESMTP id 602F61625C;
Thu, 2 Feb 2023 00:09:22 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h=
content-transfer-encoding:mime-version:references:in-reply-to
:x-mailer:message-id:date:date:subject:subject:from:from
:received:received; s=sel2011a; t=1675292962; bh=82VmT6mWaSNNxCS
znlOXpE39x/QO7mmoP9wLMyLLadM=; b=pgtgC6C5kKoNY22lH5gWTe2UbFo1OOw
uSwU1Q0LGpV4iUAtO7/i/FaAtOKMnQ0OT8wWZEoGDgGPCVs71h6lSs/Lh2Kaigsy
6rcifRMvHApT7rUMwohsyqaTLSMd7s+nxci56gt99zW1VV6RR8F0VTrPC/8L7LRP
dDY5JCbpKZjs=
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224)
with ESMTP id YLRNWaIsvshq; Thu, 2 Feb 2023 00:09:22 +0100 (CET)
Received: from customer (localhost [127.0.0.1])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by mail.hostpark.net (Postfix) with ESMTPSA id 1401E16255;
Thu, 2 Feb 2023 00:09:22 +0100 (CET)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 60740 <at> debbugs.gnu.org
Subject: [PATCH 0/2] emoji changes
Date: Thu, 2 Feb 2023 00:09:16 +0100
Message-Id: <20230201230918.550-1-jonas@HIDDEN>
X-Mailer: git-send-email 2.39.1
In-Reply-To: <83leli3nly.fsf@HIDDEN>
References: <83leli3nly.fsf@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 60740
Cc: larsi@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
* The first commit changes `isearch-emoji-by-name' to not use
transient. If there are derivations then `completing-read'
is instead used to let the user chose one.
I think we should stick to that. What I mention next, seems
way to risky at this time and I also do not think it would be
worth it. Selecting a derivation using `completing-read' isn't
bad at all.
(The problem with using a transient command inside
`with-isearch-suspended' is that expects to be able to call a
function, which uses `recursive-edit' in some way. Once that
returns, the macro resumes isearch. But transient does not do that
and it returns immediately after the transient prefix command
returns. That happens before the user selects a derivation by
invoking one of the suffix commands. So isearch resumes before
the user has made any choice.
One way around that might be to call `recursive-edit' in
`isearch-emoji-by-name' before calling the code that might then use
transient. But that would also have to automatically invoke a
command inside that recursive edit. I couldn't find a way to do
that. I timer might work, but that seems hacky.
Another approach could be to break up `with-isearch-suspended' up
into two functions, one that suspends and another that resumes.
The suspend function could maybe also responsible for returning
the resume function as a closure. The macro could use these two
functions and existing callers could continue to use that. But
`isearch-emoji-by-name' would only call the suspend function and
would have to somehow pass the resume function to transient, so
that it could call it when the time has come.)
* The second commit changes emoji.el to use transient.el the way I
intended it to be used. (I *think* transient already had support
for "dynamic" transient commands, when emoji.el was created, but
some of the convenience features certainly were missing still.)
The new implementation changes the remaining entry points to be
defined using `define-transient-prefix' but still without adding any
suffix commands to them up front. Previously no *prefix* command
was defined up front. Instead code very similar to what can be
found in `define-transient-prefix' was used to turn certain nodes
inside the tree of emoji into (sub-)prefix commands. These prefix
commands were then invoked using `funcall', which is not how that
is supposed to work; I am surprised that worked at all, but I guess
that just means that emoji doesn't use any of transient's features
that depend on `this-command' "being correct".
The new implementation adds a single, named suffix command,
`emoji-insert-glyph'. Now every suffix of a transient prefix is
either that command or a "recursive" call to the prefix itself, with
its scope narrowed to only part of the original tree of emoji. That
is a big improvement over the old implementation, which had to
define a new command for each and every emoji, and a new command for
every grouping of emoji.
Lars, previously a hash-table was used to track the emoji, that should
not be derived any further. I changed that to a list, because I am
yet to encounter a situation where more than one element has to be
tracked. Are there even any derivations of derivations? If so,
please point me to an example.
If there are any, then the first commit would have to be adjusted to
account for that. Otherwise, I think that is ready. I would still
like to test the second commit a bit more, before applying it.
Cheers,
Jonas
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 30 Jan 2023 18:14:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 30 13:14:01 2023 Received: from localhost ([127.0.0.1]:50428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pMYfJ-0002GO-BS for submit <at> debbugs.gnu.org; Mon, 30 Jan 2023 13:14:01 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:37099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1pMYfF-0002Fu-IH for 60740 <at> debbugs.gnu.org; Mon, 30 Jan 2023 13:13:57 -0500 Received: (Authenticated sender: juri@HIDDEN) by mail.gandi.net (Postfix) with ESMTPSA id 9DD06C000A; Mon, 30 Jan 2023 18:13:50 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name In-Reply-To: <834js7527z.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 30 Jan 2023 20:03:44 +0200") Organization: LINKOV.NET References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> <875ycyfk1o.fsf@HIDDEN> <837cxdjvu6.fsf@HIDDEN> <83wn59eo31.fsf@HIDDEN> <874jsdfghv.fsf@HIDDEN> <83zga5cku4.fsf@HIDDEN> <87bkmgxub5.fsf@HIDDEN> <837cx45fti.fsf@HIDDEN> <86o7qfgbus.fsf@HIDDEN> <834js7527z.fsf@HIDDEN> Date: Mon, 30 Jan 2023 20:12:05 +0200 Message-ID: <86leljevt6.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60740 Cc: larsi@HIDDEN, jonas@HIDDEN, 60740 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> >> I don't have the time to do that anymore. It would probably be best to >> >> remove this command from Emacs 29.0.90. >> > >> > Since the command works for many Emoji, I prefer to leave it and live >> > with the known issues. >> >> I disabled derived emoji in isearch-emoji-by-name, >> so they don't cause the problems anymore in Emacs 29. > > Does this need some updates to NEWS or the manual? I don't think so. Most users won't notice that something is missing.
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 30 Jan 2023 18:03:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 30 13:03:59 2023 Received: from localhost ([127.0.0.1]:50343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pMYVb-0001vO-1X for submit <at> debbugs.gnu.org; Mon, 30 Jan 2023 13:03:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pMYVY-0001v8-T7 for 60740 <at> debbugs.gnu.org; Mon, 30 Jan 2023 13:03:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pMYVS-0007ac-Go; Mon, 30 Jan 2023 13:03:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5UBy7QPicMnifmLqRoIhrXNykZapVpCbpjaLZtpVk+M=; b=IdX7svaov1Wf Jd92OJJfrTct0LlA5y1JJ7hCFDXasg1N5HTRnCP1eKrjoi9EbaI0yInfGtCbmsv3EbMCtPuL/+eoq 7Oz4zTPkY2bd9DcOQOwYUQtHH+IwqqV4AMultlUlEAEFY1+5U6SgtV8wd3PunqSrChFGtiWJ+bDDE I7s/b4GGbsE7pIJNR2Dv1g34l9i2BMBW3O1COf0ilA3DKmBCCV2gvjhkld65HL0uVtDG3c8d++sZ7 uDiI+UQoOmiYQvAfFf4ErL2wjQSVGO6p/2ue556ALyd0uDGjtAtYLixJqJ24pwRrGyIPg7zd+G7pK p1JiRLxj4sccvklbUu7nTQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pMYVR-0003jj-TA; Mon, 30 Jan 2023 13:03:50 -0500 Date: Mon, 30 Jan 2023 20:03:44 +0200 Message-Id: <834js7527z.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN> In-Reply-To: <86o7qfgbus.fsf@HIDDEN> (message from Juri Linkov on Mon, 30 Jan 2023 19:40:11 +0200) Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> <875ycyfk1o.fsf@HIDDEN> <837cxdjvu6.fsf@HIDDEN> <83wn59eo31.fsf@HIDDEN> <874jsdfghv.fsf@HIDDEN> <83zga5cku4.fsf@HIDDEN> <87bkmgxub5.fsf@HIDDEN> <837cx45fti.fsf@HIDDEN> <86o7qfgbus.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60740 Cc: larsi@HIDDEN, jonas@HIDDEN, 60740 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Juri Linkov <juri@HIDDEN> > Cc: Jonas Bernoulli <jonas@HIDDEN>, larsi@HIDDEN, 60740 <at> debbugs.gnu.org > Date: Mon, 30 Jan 2023 19:40:11 +0200 > > >> I don't have the time to do that anymore. It would probably be best to > >> remove this command from Emacs 29.0.90. > > > > Since the command works for many Emoji, I prefer to leave it and live > > with the known issues. > > I disabled derived emoji in isearch-emoji-by-name, > so they don't cause the problems anymore in Emacs 29. Does this need some updates to NEWS or the manual?
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 30 Jan 2023 17:41:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 30 12:41:30 2023 Received: from localhost ([127.0.0.1]:50288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pMY9q-0001BX-0f for submit <at> debbugs.gnu.org; Mon, 30 Jan 2023 12:41:30 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:49117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1pMY9o-0001BA-MV for 60740 <at> debbugs.gnu.org; Mon, 30 Jan 2023 12:41:28 -0500 Received: (Authenticated sender: juri@HIDDEN) by mail.gandi.net (Postfix) with ESMTPSA id 1472C20008; Mon, 30 Jan 2023 17:41:19 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name In-Reply-To: <837cx45fti.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 30 Jan 2023 15:10:01 +0200") Organization: LINKOV.NET References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> <875ycyfk1o.fsf@HIDDEN> <837cxdjvu6.fsf@HIDDEN> <83wn59eo31.fsf@HIDDEN> <874jsdfghv.fsf@HIDDEN> <83zga5cku4.fsf@HIDDEN> <87bkmgxub5.fsf@HIDDEN> <837cx45fti.fsf@HIDDEN> Date: Mon, 30 Jan 2023 19:40:11 +0200 Message-ID: <86o7qfgbus.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60740 Cc: larsi@HIDDEN, Jonas Bernoulli <jonas@HIDDEN>, 60740 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> I don't have the time to do that anymore. It would probably be best to >> remove this command from Emacs 29.0.90. > > Since the command works for many Emoji, I prefer to leave it and live > with the known issues. I disabled derived emoji in isearch-emoji-by-name, so they don't cause the problems anymore in Emacs 29. Leaving this bug report open to find a proper fix for master if someone needs to select derived emoji.
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 30 Jan 2023 13:10:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 30 08:10:18 2023 Received: from localhost ([127.0.0.1]:46655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pMTvN-000485-MP for submit <at> debbugs.gnu.org; Mon, 30 Jan 2023 08:10:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pMTvL-00047o-QS for 60740 <at> debbugs.gnu.org; Mon, 30 Jan 2023 08:10:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pMTvE-0003gN-TB; Mon, 30 Jan 2023 08:10:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wVK0cUt2bUAlvqbCyGKibDGX+Mc5u1W/hbotHKAswms=; b=IFkG2whQyOEE Fn3o5Oj2sxEXDAKTfubfhcCluaK2RYbxUhAEVIRy+cAGgYrgTuwAor/1Z8wnYD1CsIz5D74m+Mh6K 0hNjJaYmJloOmtViTHrNVfWIAU71mzcQ9OiocNewf33GwYM5brJ11tBuUtbBbs6dCRPCSgDbsDQed 4q59CmhqegwPDArXDl8AXJ8jgJbwBy5R5eKVgzFyKiEABaHycNMbA2LEitIJJFNVsAnOEgegx6qsj ucKJQJ4xPsAtre72l3euDEIP2AHxkwqRZVYXarbsLoaaFU71cuOosEq2HPjC/ge8iVsBy4tLEJoh1 7OupxKOjOIK7PajBUtGUAg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pMTvE-0004tg-Bz; Mon, 30 Jan 2023 08:10:08 -0500 Date: Mon, 30 Jan 2023 15:10:01 +0200 Message-Id: <837cx45fti.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jonas Bernoulli <jonas@HIDDEN> In-Reply-To: <87bkmgxub5.fsf@HIDDEN> (message from Jonas Bernoulli on Mon, 30 Jan 2023 10:09:34 +0100) Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> <875ycyfk1o.fsf@HIDDEN> <837cxdjvu6.fsf@HIDDEN> <83wn59eo31.fsf@HIDDEN> <874jsdfghv.fsf@HIDDEN> <83zga5cku4.fsf@HIDDEN> <87bkmgxub5.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60740 Cc: larsi@HIDDEN, 60740 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Jonas Bernoulli <jonas@HIDDEN> > Cc: larsi@HIDDEN, 60740 <at> debbugs.gnu.org, juri@HIDDEN > Date: Mon, 30 Jan 2023 10:09:34 +0100 > > Unfortunately there is a major bug in transient, which I am struggling > to fix. I have a working solution but it is quite abstruse and still > needs testing. I also have a nicer solution that doesn't really work > yet. If I knew I had time, I would work on the latter. But since the > pre-release could happen any time now, I should probably work on the > former. What kind of time frame are you talking when you say "if I knew I had time"? > Please warn me a day before you create the pre-release, so I can switch > my focus in time to merge the best solution I can come up by then into > Emacs. Will do. > I probably won't have time to fix isearch-emoji-by-name by then. One > problem is that emoji (not just this particular command) uses transient > in a way it was never intended to be used. I pointed that out when it > was originally added. But somehow it worked, so I never got around to > redo it. > > I have actually rewritten how emoji uses transient a day ago, and while > it works in principal, it is not finished yet. I had some faint hope > that doing so would also magically fix isearch-emoji-by-name. It did > not. But it lays the ground work for doing that eventually. > > I don't have the time to do that anymore. It would probably be best to > remove this command from Emacs 29.0.90. Since the command works for many Emoji, I prefer to leave it and live with the known issues. Thanks.
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 30 Jan 2023 09:09:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 30 04:09:41 2023 Received: from localhost ([127.0.0.1]:46378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pMQAX-0006wA-2F for submit <at> debbugs.gnu.org; Mon, 30 Jan 2023 04:09:41 -0500 Received: from mail.hostpark.net ([212.243.197.30]:60728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jonas@HIDDEN>) id 1pMQAU-0006w1-Pr for 60740 <at> debbugs.gnu.org; Mon, 30 Jan 2023 04:09:39 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 7096316524; Mon, 30 Jan 2023 10:09:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1675069776; bh=xGb1UKFTc04/4+DG3GVQJ9/8 4T0z/AVyRb5zH8cfyH4=; b=CWCXJSAduFT574RLkSBuw7WRgK2YnZfJ6C9ucO9p wqC1jVOu1x0aCTxXriezGafeGbLZAOlFq+rX6N8qNJTPaoWu4QjQ88L20IM/EH+a 8xD189RqnPfsDUl/pYcWRnM10oEHGbyIvDBbNHEILvBymu0EFIZDO/JVTStq5/kc eto= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id PcOMk7bf_-3Q; Mon, 30 Jan 2023 10:09:36 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 23CCF164B2; Mon, 30 Jan 2023 10:09:36 +0100 (CET) From: Jonas Bernoulli <jonas@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name In-Reply-To: <83zga5cku4.fsf@HIDDEN> References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> <875ycyfk1o.fsf@HIDDEN> <837cxdjvu6.fsf@HIDDEN> <83wn59eo31.fsf@HIDDEN> <874jsdfghv.fsf@HIDDEN> <83zga5cku4.fsf@HIDDEN> Date: Mon, 30 Jan 2023 10:09:34 +0100 Message-ID: <87bkmgxub5.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60740 Cc: larsi@HIDDEN, 60740 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> From: Jonas Bernoulli <jonas@HIDDEN> >> Cc: 60740 <at> debbugs.gnu.org, juri@HIDDEN >> Date: Thu, 26 Jan 2023 16:43:56 +0100 >> >> Eli Zaretskii <eliz@HIDDEN> writes: >> >> > Ping! Any progress with this issue? >> >> I have worked on it but haven't gotten anywhere yet. >> I'll try again tomorrow. > > Thanks. I thought you wanted to install a newer version of Transient, > and that the new version solves this problem? Which is why I thought > it would be a relatively simple job. Sorry if I misunderstood. Unfortunately there is a major bug in transient, which I am struggling to fix. I have a working solution but it is quite abstruse and still needs testing. I also have a nicer solution that doesn't really work yet. If I knew I had time, I would work on the latter. But since the pre-release could happen any time now, I should probably work on the former. Please warn me a day before you create the pre-release, so I can switch my focus in time to merge the best solution I can come up by then into Emacs. I probably won't have time to fix isearch-emoji-by-name by then. One problem is that emoji (not just this particular command) uses transient in a way it was never intended to be used. I pointed that out when it was originally added. But somehow it worked, so I never got around to redo it. I have actually rewritten how emoji uses transient a day ago, and while it works in principal, it is not finished yet. I had some faint hope that doing so would also magically fix isearch-emoji-by-name. It did not. But it lays the ground work for doing that eventually. I don't have the time to do that anymore. It would probably be best to remove this command from Emacs 29.0.90.
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 26 Jan 2023 16:38:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 26 11:38:46 2023 Received: from localhost ([127.0.0.1]:35973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pL5Gv-0002P5-R8 for submit <at> debbugs.gnu.org; Thu, 26 Jan 2023 11:38:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pL5Gu-0002Os-1n for 60740 <at> debbugs.gnu.org; Thu, 26 Jan 2023 11:38:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pL5Gm-0005z8-DB; Thu, 26 Jan 2023 11:38:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qA2er5kPAHq1+IkAX29PkupH3xu3b3e9xo7YD7rKVR4=; b=khBd5FkJwaxO 1o9p8ZPOvxAjpqV0ynl9q5OmIO0k+HJ4sb4+DdSyl6qUWiChV/tEGaIaA7wxkCwEFnr0HZ3dbNW0c sA/cTfyIJtH8J9aL1kjE2kPPExkHQpuleRkYKQIjpNmd9RQRGMsbbSMUgj0Lw8C2HAedxBTW8hGYM xxBYVBdvgjJI2RLR8f1ZJhEhB0d6FPuZW6zS0nOPg4XmIUrM1r9yVhNjrxu6s8yOq8ugXR6LDUUQH P3Aph/1kVfGI2jC2GeXXOrA2OlwJpQGbFqXIYHzskon5Bc0why3sD6ta8ASsVd2yZ3KV0XOuMOQgF o/HlKXWv7Hp6NQ7WeBzITg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pL5Gl-0002i8-Sx; Thu, 26 Jan 2023 11:38:36 -0500 Date: Thu, 26 Jan 2023 18:38:27 +0200 Message-Id: <83zga5cku4.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jonas Bernoulli <jonas@HIDDEN> In-Reply-To: <874jsdfghv.fsf@HIDDEN> (message from Jonas Bernoulli on Thu, 26 Jan 2023 16:43:56 +0100) Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> <875ycyfk1o.fsf@HIDDEN> <837cxdjvu6.fsf@HIDDEN> <83wn59eo31.fsf@HIDDEN> <874jsdfghv.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60740 Cc: larsi@HIDDEN, 60740 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Jonas Bernoulli <jonas@HIDDEN> > Cc: 60740 <at> debbugs.gnu.org, juri@HIDDEN > Date: Thu, 26 Jan 2023 16:43:56 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > Ping! Any progress with this issue? > > I have worked on it but haven't gotten anywhere yet. > I'll try again tomorrow. Thanks. I thought you wanted to install a newer version of Transient, and that the new version solves this problem? Which is why I thought it would be a relatively simple job. Sorry if I misunderstood.
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 26 Jan 2023 15:44:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 26 10:44:03 2023 Received: from localhost ([127.0.0.1]:35923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pL4Pz-0000wV-0s for submit <at> debbugs.gnu.org; Thu, 26 Jan 2023 10:44:03 -0500 Received: from mail.hostpark.net ([212.243.197.30]:36850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jonas@HIDDEN>) id 1pL4Pw-0000vv-PY for 60740 <at> debbugs.gnu.org; Thu, 26 Jan 2023 10:44:01 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id CABC81625E; Thu, 26 Jan 2023 16:43:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1674747838; bh=6Rh19+NeLynbInJdq8uYOABY fWhODVp8+9jg9Z0/hE0=; b=LctVXgAbDg27kcHZxDZ7Ybn8C/bL7yUNq6yzAAfL 3q3H6oEJy7v+DFZedgw0/DLA54yqwCHGHJKKpzb+x2wRc3oDtolnnXTNKmNuPaTR ug2j3GKCez5OLDoXnJGRSFCppFrJYDwazFth+CKeBeZkaJMVPCyo4p1QdPSlAP3h HvY= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id 81ulQ0tt4Pgl; Thu, 26 Jan 2023 16:43:58 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 763181626C; Thu, 26 Jan 2023 16:43:58 +0100 (CET) From: Jonas Bernoulli <jonas@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN>, larsi@HIDDEN Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name In-Reply-To: <83wn59eo31.fsf@HIDDEN> References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> <875ycyfk1o.fsf@HIDDEN> <837cxdjvu6.fsf@HIDDEN> <83wn59eo31.fsf@HIDDEN> Date: Thu, 26 Jan 2023 16:43:56 +0100 Message-ID: <874jsdfghv.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60740 Cc: 60740 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Eli Zaretskii <eliz@HIDDEN> writes: > Ping! Any progress with this issue? I have worked on it but haven't gotten anywhere yet. I'll try again tomorrow.
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 26 Jan 2023 07:45:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 26 02:45:16 2023 Received: from localhost ([127.0.0.1]:60518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pKwwd-0005aM-Vh for submit <at> debbugs.gnu.org; Thu, 26 Jan 2023 02:45:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pKwwb-0005a7-J0 for 60740 <at> debbugs.gnu.org; Thu, 26 Jan 2023 02:45:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pKwwU-0000Qx-NY; Thu, 26 Jan 2023 02:45:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=cOFSrrtVR6D8u+WlnGozws2HKFs9SVV+uZRNwGHDBO8=; b=By9Ht4UKZdKh9XiPjV/o GQsB2iGwGuTpEKc7gEfNABlXILC2kT3r4lZzRrAb8PfGcNZbpzqeD2NeFh0+u7SNPP2MxRT9QG9du f+wrUkk1JwBzSL3KKROHPtj5X8zZFZHvzz0Na+XhDjCILKS30T5tvT5s335nQ15gVb/oGG7Kf39Ei pgEIpdCDGQOBX7O3bWX+qy8TvD8V1zVocZf9/ty8A+B/4o6Y5fCBNJWYQlhAlPmAgYbQvHx0MwRS7 CSOWYOyCPdugUvCQzERlbuM7h8wS41Rfa6Ry7ZNQWcIM/I/hRIVV/4gB1BK9Yo/+NlVEmJlSg6EAJ TaGrYfJdeZ6fGQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pKwwU-0003kG-70; Thu, 26 Jan 2023 02:45:06 -0500 Date: Thu, 26 Jan 2023 09:45:22 +0200 Message-Id: <83wn59eo31.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: jonas@HIDDEN, larsi@HIDDEN In-Reply-To: <837cxdjvu6.fsf@HIDDEN> (message from Eli Zaretskii on Mon, 23 Jan 2023 14:09:53 +0200) Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> <875ycyfk1o.fsf@HIDDEN> <837cxdjvu6.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60740 Cc: 60740 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Any progress with this issue? > Cc: larsi@HIDDEN, 60740 <at> debbugs.gnu.org, juri@HIDDEN > Date: Mon, 23 Jan 2023 14:09:53 +0200 > From: Eli Zaretskii <eliz@HIDDEN> > > > From: Jonas Bernoulli <jonas@HIDDEN> > > Cc: 60740 <at> debbugs.gnu.org > > Date: Sun, 22 Jan 2023 20:25:55 +0100 > > > > >> But typing e.g. 'C-s C-x 8 e RET waving hand RET' fails with: > > > > That binding doesn't exist in my configuration. Do you mean > > "C-x 8 e e", i.e., emoji-insert? > > > > >> â›” Error (transient): Inconsistent transient state detected. > > > > I couldn't reproduce this with the above command (and also tried a > > few other emoji commands). > > What exactly did you try? The problem I see here is that after typing > "C-s C-x 8 e RET waving hand RET", I immediately get the echo area > shows several variants of the "waving hands" Emoji, but if I type a > letter to choose one of them, I get the error message cited above. > > > Recently I also noticed that my most recent attempt to update transient > > in emacs.git has gone wrong; I think I just forgot to push. I intend > > to merge transient.git into emacs.git very soon (it's all bugfixes and > > minor cosmetics), but have come aware of additional problems that I was > > planning to address first. > > Please do that soon, and if that solves this problem, we can close the > bug. > > > > I'd really like to have a solution for this before Emacs 29 goes into > > > pretest. > > > > When will that be? > > VSN. Like in a week or so. > > > >
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 23 Jan 2023 12:09:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 23 07:09:56 2023 Received: from localhost ([127.0.0.1]:53505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pJve8-0002NL-7b for submit <at> debbugs.gnu.org; Mon, 23 Jan 2023 07:09:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pJve5-0002N7-NP for 60740 <at> debbugs.gnu.org; Mon, 23 Jan 2023 07:09:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pJvdy-0002w0-Q6; Mon, 23 Jan 2023 07:09:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=O/PkbHAHvNIAzuiMioTBYqtR4oKDyh4tfGN+EzvKaHo=; b=VX4OIR8dhaxdkk+yaIPf 7rCZMCtrrBXFWr0oho3XXHb5xc8HNtAHvwcppHQuwSXABtsVJzDT9hfwe29nWpc8/H80fhV9Mc5ga Nta1mJz/Q+347GTO8j3pyR63yQTQzKqdSkRVqHOtJNjqOMjdO4KRCaxnbpRi1VJwH6kKnNJHbK6aA VSH2R/i4UpkIdjkiDuQKlVRxcxE/Pr5EuRaylHAwoGDKpXIkkKU8LWTE8su6SwlUBqoMpTjgQsork 2gdCG6ReiusyzOttLuv2XcJQ62kznwIZiZynjUjap59aBspeljy6oKJ1o2ynomNBGS6S0L4LjJaax aAhJmP6eVSNnQA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pJvdy-0001Dv-9W; Mon, 23 Jan 2023 07:09:46 -0500 Date: Mon, 23 Jan 2023 14:09:53 +0200 Message-Id: <837cxdjvu6.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jonas Bernoulli <jonas@HIDDEN> In-Reply-To: <875ycyfk1o.fsf@HIDDEN> (message from Jonas Bernoulli on Sun, 22 Jan 2023 20:25:55 +0100) Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> <875ycyfk1o.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60740 Cc: larsi@HIDDEN, 60740 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Jonas Bernoulli <jonas@HIDDEN> > Cc: 60740 <at> debbugs.gnu.org > Date: Sun, 22 Jan 2023 20:25:55 +0100 > > >> But typing e.g. 'C-s C-x 8 e RET waving hand RET' fails with: > > That binding doesn't exist in my configuration. Do you mean > "C-x 8 e e", i.e., emoji-insert? > > >> â›” Error (transient): Inconsistent transient state detected. > > I couldn't reproduce this with the above command (and also tried a > few other emoji commands). What exactly did you try? The problem I see here is that after typing "C-s C-x 8 e RET waving hand RET", I immediately get the echo area shows several variants of the "waving hands" Emoji, but if I type a letter to choose one of them, I get the error message cited above. > Recently I also noticed that my most recent attempt to update transient > in emacs.git has gone wrong; I think I just forgot to push. I intend > to merge transient.git into emacs.git very soon (it's all bugfixes and > minor cosmetics), but have come aware of additional problems that I was > planning to address first. Please do that soon, and if that solves this problem, we can close the bug. > > I'd really like to have a solution for this before Emacs 29 goes into > > pretest. > > When will that be? VSN. Like in a week or so.
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 23 Jan 2023 07:06:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 23 02:06:15 2023 Received: from localhost ([127.0.0.1]:53157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pJquF-0002Yv-AF for submit <at> debbugs.gnu.org; Mon, 23 Jan 2023 02:06:15 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:38474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <kevin.legouguec@HIDDEN>) id 1pJquB-0002Yg-0h for 60740 <at> debbugs.gnu.org; Mon, 23 Jan 2023 02:06:14 -0500 Received: by mail-wm1-f48.google.com with SMTP id f12-20020a7bc8cc000000b003daf6b2f9b9so9866444wml.3 for <60740 <at> debbugs.gnu.org>; Sun, 22 Jan 2023 23:06:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wjBpwjKLTjYDB3En45GT47QtlYCcop87W2BjkflDWzg=; b=OlZ1YRQa6GDIE1sS+C4YySMB9u7HZesYIkdoe/RTHrUnO+hqLB0ZAZkrX4rccXtpMs U9uYEa7r+l2xxnMbLEVyzTdfpRpE8yKgIciy4DRjRv8hG0hR22v91u+R0xW45xM1ll8J XEigDbOT4vkkJIEWlCmCMbLkKCkNhdu6Od2w1J/jrAczmMblrzSjSyDDqKFdquDB32Rn pufsrbFVQJalja7TgqUuCujYWH4CaiMme2tYKwSFZCW2iW5QjIw2+Sb6TFHKem9nWaC/ T1K7aKdN1Lbjq3YGQNPDqkoKRIUysFfuBI6/wmt6lrtokdyRLTjXLRsi1Q/6ywJoCmA/ 4doA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wjBpwjKLTjYDB3En45GT47QtlYCcop87W2BjkflDWzg=; b=4/gFyre6xSr+riIVNlEQS+TM5xonjzVfw5vkk7j93njMz6Tl0AZTgAyCEf5ZQ1Ksgg uhrVOif5e9nmsBuaeBom25PeVWVqAvC/gZcX50XaLnDmWDSEH1jwVShJFNjAujM88Ywr J9pRW5bnJ8gRyU61oDf4wYz+x0IPMXBKlbi+SeS1i9C4KxrOXy4mCWDnsd1c8DwiH2wA hg40Hnzj9/OaYRFJiH9dHFBriRTGeSdLQ+OO6eTD9saL3FU1iUOh01u6mVs+gR1qIwPd RCiRpQnWy56VkTLhjM7KKHBdpnwXHiNmrHKz2upPWX2JJD1J1/ORwxCVxT2eJ6dHWKcf nw2g== X-Gm-Message-State: AFqh2kqTcFyxd6hSuEqYR6+OtiJ5wPZtfUA/jwGFDJd9R5nG4pmxmzHc wbKh1DHQfIYe2y5jFDwJW9A6Xp0itfc= X-Google-Smtp-Source: AMrXdXvS/Nppl6BtY862eeC9uMx6Ir4fzoOCXRBcJOh2XHaRpeQx+65IihRgEeHcZQ4yf1esjiVYBA== X-Received: by 2002:a1c:750e:0:b0:3da:fcf6:7146 with SMTP id o14-20020a1c750e000000b003dafcf67146mr22938022wmc.14.1674457564746; Sun, 22 Jan 2023 23:06:04 -0800 (PST) Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id v17-20020a05600c445100b003d9e74dd9b2sm10179274wmn.9.2023.01.22.23.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Jan 2023 23:06:04 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= <kevin.legouguec@HIDDEN> To: Jonas Bernoulli <jonas@HIDDEN> Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name In-Reply-To: <875ycyfk1o.fsf@HIDDEN> (Jonas Bernoulli's message of "Sun, 22 Jan 2023 20:25:55 +0100") References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> <875ycyfk1o.fsf@HIDDEN> Date: Mon, 23 Jan 2023 08:06:03 +0100 Message-ID: <87a629hgro.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60740 Cc: 60740 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, Juri Linkov <juri@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Jonas Bernoulli <jonas@HIDDEN> writes: >>> But typing e.g. 'C-s C-x 8 e RET waving hand RET' fails with: > > That binding doesn't exist in my configuration. Do you mean > "C-x 8 e e", i.e., emoji-insert? The command is isearch-emoji-by-name, and the sequence to invoke it _ends with RET_; FWIW that's what tripped me up when attempting to reproduce (I kept hitting C-s C-x 8 e and failing to get the prompt). FWIW=C2=B2 I can reproduce here (with 29 and master) _after_ removing ~/.emacs.d/transient.
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 22 Jan 2023 19:26:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 22 14:26:03 2023 Received: from localhost ([127.0.0.1]:52652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pJfyc-0003pM-O2 for submit <at> debbugs.gnu.org; Sun, 22 Jan 2023 14:26:02 -0500 Received: from mail.hostpark.net ([212.243.197.30]:60230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jonas@HIDDEN>) id 1pJfya-0003os-9x for 60740 <at> debbugs.gnu.org; Sun, 22 Jan 2023 14:26:01 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id C7763164DD; Sun, 22 Jan 2023 20:25:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:references:in-reply-to:subject:subject :from:from:received:received; s=sel2011a; t=1674415557; bh=J2gZp 2ikqD0oS00l+ZSWeHzpVfyAjZlSjAe8H+7XLQ0=; b=Zyjd/VAuzuvf5sxIlc1Qw PAIbocRMlv/SCev3YVltrxHqMEWH9Trpqrhdh22C/sTyVNRV3p1xYcepT2oU9FGF GIfHucrWb5xoV3bNCyJYRyTZ2TWdzRzczVTuRjFirF/0tFmQteijxdXplx3lRUp/ bt+EJ22KAQQFfrRT9H3qBI= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id nFpcUJ3ZjvQw; Sun, 22 Jan 2023 20:25:57 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 669B6164CC; Sun, 22 Jan 2023 20:25:57 +0100 (CET) From: Jonas Bernoulli <jonas@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN>, Juri Linkov <juri@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN> Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name In-Reply-To: <838ri8krtv.fsf@HIDDEN> References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> Date: Sun, 22 Jan 2023 20:25:55 +0100 Message-ID: <875ycyfk1o.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60740 Cc: 60740 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> But typing e.g. 'C-s C-x 8 e RET waving hand RET' fails with: That binding doesn't exist in my configuration. Do you mean "C-x 8 e e", i.e., emoji-insert? >> =E2=9B=94 Error (transient): Inconsistent transient state detected. I couldn't reproduce this with the above command (and also tried a few other emoji commands). But I haven't tried with the version of transient in emacs.git, and I have somewhat recently fixed related issues in transient's own repository. Recently I also noticed that my most recent attempt to update transient in emacs.git has gone wrong; I think I just forgot to push. I intend to merge transient.git into emacs.git very soon (it's all bugfixes and minor cosmetics), but have come aware of additional problems that I was planning to address first. > I'd really like to have a solution for this before Emacs 29 goes into > pretest. When will that be? I also want to get the latest bugfixes in before then and maybe even create a transient release before that happens, but I would also like to avoid rushing it, if I can help it. (That being said, fixing these issues is my top priority now, so I hope to be ready to merge very soon.)
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 21 Jan 2023 07:24:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 21 02:24:18 2023 Received: from localhost ([127.0.0.1]:47845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pJ8Ec-00013Q-Ho for submit <at> debbugs.gnu.org; Sat, 21 Jan 2023 02:24:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pJ8EZ-00013C-Hq for 60740 <at> debbugs.gnu.org; Sat, 21 Jan 2023 02:24:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pJ8ES-00013N-R3; Sat, 21 Jan 2023 02:24:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=aNpQ2NgBTzwH4oXyY4tV9vzh12gP+Crf3fkJKTtzOeQ=; b=bp/0NsJzDLsX2jkgmkXH TMnR33m0RtJiGT7bTwW6PPKe/XToGdqOnlqfJZ7zTtBXnSOJGS64SKJkrOX17eurxYtoUY0LuQpV5 RpYqEt1gjOgnRnQHnVxaHfBykhIaLdfSezAHIw2GT+Vwm7Oa/1/DfDZQ2eph1QPdzZF0FlNYdDvpl U8l9OOuKoQeAJhe0YxRxfPct1ltquwigCOIUOmy0oNtZYIbDWVXF3Qthz8tu2eFdPp9CKn5c0gRCe WxwxDHH0He5sJ+3bYDFBVs1wm1L1QDa3zjquMZjy1lN4KgQ9ePjVRhY53r4Bkatiodk+pAS3+vvVK 5ekr6aDfL/4mbw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pJ8ER-0000e8-HO; Sat, 21 Jan 2023 02:24:08 -0500 Date: Sat, 21 Jan 2023 09:24:10 +0200 Message-Id: <838rhwmjtx.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: larsi@HIDDEN, jonas@HIDDEN In-Reply-To: <838ri8krtv.fsf@HIDDEN> (message from Eli Zaretskii on Thu, 12 Jan 2023 11:47:08 +0200) Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60740 Cc: 60740 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Lars, Jonas: I'd really like to have a solution for this before Emacs 29 goes into pretest. Please help. > Cc: 60740 <at> debbugs.gnu.org > Date: Thu, 12 Jan 2023 11:47:08 +0200 > From: Eli Zaretskii <eliz@HIDDEN> > > > From: Juri Linkov <juri@HIDDEN> > > Date: Wed, 11 Jan 2023 21:45:44 +0200 > > > > etc/NEWS: > > > > +++ > > *** New command 'isearch-emoji-by-name'. > > It is bound to 'C-x 8 e RET' during an incremental search. The > > command accepts the Unicode name of an Emoji (for example, "smiling > > face" or "heart with arrow"), like 'C-x 8 e e', with minibuffer > > completion, and adds the Emoji into the search string. > > > > These examples "smiling face" and "heart with arrow" work fine. > > > > But typing e.g. 'C-s C-x 8 e RET waving hand RET' fails with: > > > > â›” Error (transient): Inconsistent transient state detected. > > This should never happen. > > Please open an issue and post the shown command log. > > This is a heisenbug, so any additional details might help. > > Thanks! > > Looks like a problem with any Emoji that has variants, where you need > to select one of the variants? > > Lars, Jonas, could you please look into this? > > > >
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.
Received: (at 60740) by debbugs.gnu.org; 12 Jan 2023 17:31:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 12 12:31:36 2023
Received: from localhost ([127.0.0.1]:48497 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pG1QN-0002P3-Vh
for submit <at> debbugs.gnu.org; Thu, 12 Jan 2023 12:31:36 -0500
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:37635)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1pG1QM-0002Oq-1n
for 60740 <at> debbugs.gnu.org; Thu, 12 Jan 2023 12:31:34 -0500
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id D7B71FF808;
Thu, 12 Jan 2023 17:31:25 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Daniel =?iso-8859-1?Q?Mart=EDn?= <mardani29@HIDDEN>
Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name
In-Reply-To: <m1mt6o806o.fsf@HIDDEN> ("Daniel =?iso-8859-1?Q?Mart=EDn=22?=
=?iso-8859-1?Q?'s?= message of "Thu, 12 Jan 2023 12:25:03 +0100")
Organization: LINKOV.NET
References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN>
<m1mt6o806o.fsf@HIDDEN>
Date: Thu, 12 Jan 2023 19:29:43 +0200
Message-ID: <861qnzhda0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 60740
Cc: 60740 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>,
Jonas Bernoulli <jonas@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>>> But typing e.g. 'C-s C-x 8 e RET waving hand RET' fails with:
>>>
>>> â›” Error (transient): Inconsistent transient state detected.
>>> This should never happen.
>>> Please open an issue and post the shown command log.
>>> This is a heisenbug, so any additional details might help.
>>> Thanks!
>>
>> Looks like a problem with any Emoji that has variants, where you need
>> to select one of the variants?
>
> The command suspends the isearch while the emoji-search command is
> invoked, but I see that the isearch reactivates prematurely, when the
> Transient menu is shown (M-x debug-watch RET isearch-suspended RET is
> helpful here).
>
> Perhaps this is conflicting with Transient in some way. We should try
> to keep the isearch suspended until after the Transient menu interaction
> has finished, I think.
The question is rather opposite: why Transient doesn't use
recursive-edit like all normal minibuffers?
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 12 Jan 2023 11:25:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 12 06:25:17 2023 Received: from localhost ([127.0.0.1]:44871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pFvhs-0003zN-Kn for submit <at> debbugs.gnu.org; Thu, 12 Jan 2023 06:25:16 -0500 Received: from sonic313-20.consmr.mail.ir2.yahoo.com ([77.238.179.187]:38410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mardani29@HIDDEN>) id 1pFvhq-0003sy-Eh for 60740 <at> debbugs.gnu.org; Thu, 12 Jan 2023 06:25:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1673522708; bh=3ARCtjwI/c36dNl1qyR4SJfiuyEtpdYvkIQ4KCLi0eY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=lg2zSwTGE5sYlCR4RWrWT0sXEYH9+0nrQaA/pFhRgdt+eCq3MLNU5afMyNistBqlHa3yRqxJMbZTzn4y1s6te5lrWb0KQQdJBiuLLptirCFuwWMnVWarGD/S8z+3fGGmwddYvpPyS294yy1GwN4jv1gmXHUXyhW7C5wUF8AiAc4vPLflKObeEnlqfEP3bpBQVRUpvV6wIAoH3vhjo2awAyIsiT5dIqGW/YYRWhj0cfQY9f2tdJY0tUpd4HFkWLoeoGD2hGD7Io1383sbn3avS6pOdHvN+t9Z3WfePr+jy9Gggz1dLNoX1mcn1rGq/7tbTvWH8+rhryZ0s6BhctIdfA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673522708; bh=jhWgKyP1Ogjawhc+ZzWaiQPLPoXP1P9wFY4EeYYFTHW=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XygqFUShVj2ihMR0ZmuzQr/uHXhz7AlKhMukH+ErR/B48Gt4Ve/xbQ4K+bfpPSWAvAt1oNOegobViD1qpqiVVB5dGW23bECoZdNYrVwbEC/6+ovIozbQ8Ncq9wudS2ZFmpARR+1nTAnsJWPpTbExE1DiaT0hXLC1ZI6SpYxtBf5UlmeCQX44Vh36J60nlAsI1ezcreo+vTtpoe8Xb6wB3pTP59wk2wAsnku+gCYbkL4y1cJ5sPR7nLoYmrtpLlUi0pQZ53ynJHiV7pbrBP7K5HnFkU0to5YLKJ6VxGlTUyms2r0NkYybsWI6rkweaM4OzMhGXtTuOFEaT2QH2jWgog== X-YMail-OSG: G3gDLm8VM1kXUDXB26qSApxl8x3rBG28BlUviP12HTkWc.Ebp6vBV8RP60WO8vs ciGuxvWizG1HmhG2yLUxTOIwc8QLwfzE.hP7ZwX8qj_3yZgOlc9SkJWWQREt6dxAKYevqc4JUuV5 0EZpBzTSiMfrZPDmtqx._y5Ut1N9q.ad6J1ou9wEdCLWM2fWuH1sBK52xKmhK3keIRmU98JkJw1e dA6Q3hoWjq1ODGDXAb9yGfLYFHJGnyGqXnDJaloyh66K7jp48H4GAtvrvwuXCq1ZOtShXCNWhCYE En9e.ARtPKOvWNlJD_LvPuLrSAbbSkq8qSeUL0Ro.AfVOM_q63HFwAzsAqLrMlYhtxBusk.3euEt 0hEBKmLyXB6vaKXO8KkhwM32MDN.eDKhMuAz8Xjii.NDKrdxYyBVR.3qf4IvuBULUEtgS3aJAD_q gNCCJeSFDAAFghYxayN4wLna.Q7CFBbdiMKUjB46ICrIteZaIxfITkqAHSCZwwF0o87Lu8I_tR4V TRmTUR5v.7mz6ADE2ZMktU5HKZoK.OMu6KoPqOrDRBKNtziE3XPi20gxEONwDWwhacM71JjLeR88 qLwWVzVnGuqQdnlUSgbUalCSZ20qt5qRmSBuaAe75kMeIUP_jUiNmw5I8TIlEXHYtuICYiSqH_zi k_l2tbetquT3bdFt7v0OmlgQyPy0FkRkrEAwzgwCxINyS.7gP1b2VBv_Cqx3QwzRAZnEeV10O4mp R5vHzKCc4yZ0Lr9lQxEYUhjIBsez_y917umZZw.J_Hk2gX_Y7s_lo4r6giui2x1ouG4gFAfR8sKL Qo_c9Y0He0gdvtagQlAQwR2uKTnz6DG0KN1zQxcP1WK7Ul_4wtO3Poql6INgNLXI8gwn7PdTjeMt 52YaEjDg3g6dbvIpmWosz5xx0p0HuMJlJscGBMqkuDhlAKlwH.2FojY0cgqFpI.ygEM1LnBiirGy UVpCd_ub0MRFwe_Iaw_zATftWsUKL5fwnp3J222IpWakjGebSCcPZTcyrTx1xzZlPHhjByBG3h5w C.SBkImz7VGG.8JqYqn8KBwdo9wn6Ndbx_cydmYWQ8jJV8c7WHZXsysSaJcHC.W2CMTSnWdEZzW. 9oiuWLXCrTbg831rhC9IqY_.5Max0NLkzfKdYeOJDmkoEHFUfjmihbiCRIOxljy66q5NrZkTgTcx wzsnAW9hEI2jjzT28f2JU4O0JWYMHrB6A2dAFmeVxM4zOVuhuUDC0Y9G1.a2nsMw.hbcIhbwPvTO M.n1YmYZrY4wHw_1wSSs4dwZvwb4KbUqCh.25Xs4SCWgioOk48VzmuTj3c1L4u_3140q8pVuaeM3 yp4AFEEDW1Jy19dcAy3ohyWXbtHACPaKuyXcWGBRQnNkis.j82rcQkB4wqAs4aMQEN6da5nVwkIO dCkf4q1na4KQKAdie.bHpwSAm.emTpIcxLKzUPdudFrKL8XahS5lmxWIGYMPNk9imWL9aikUVFc4 ICV.o9ldBTR.tuXujutvs6z0WBqOKhSya_G.gUFbkSaR9YPBayzto4HSeIPjqj3LSmDsp2ncYub3 w4U8s0uxUcvPQ.DCgcm0SFFTl28IqXuC8_aJknAOLdIRBOS7XphGUFCKnz9UhSKocJRgfwhaFRxM ZBOUXXlNXOY_4PaLJvfpOEoMgZmkUqWWqD6OY5alWu2Rxdeddjq3C2T8yo6z9q_JRaW4f7eW3nwn KEpZgBhnFwj2eJS2yr8kQM3CqPd3WMpk1HLTcRYxFjHzdVeGHOU2I.VgFjQj.G0MQLmWK3AuZHCC 7HgWQ49T5kUJ.mXPBvDBmCQFigqmGWOs2.yEwsXFwoOGzP2KJSvK10zmNzQkZUs5XA41makpq7rU SE52y8PGVvXUZVcHMixOsajHlepDjN3AemKTCOzVDG.AGLltqIkUhVisa2Qp3nRjL6oPIt5DsiaY TYcjcejs5xXlWF6Mt9hLXHrlxBhKwteVAhdy2yOirazy.yLiF37KSz99vIpQ.MOvBe_jeJKlx7T. ROjH.KUU3wHzv9UAE5L77wD5JU9VhArto33cSJzqQJtcnyrn8uZeUA1uBPMaRa0Tc9mgd7gEEg44 TsgijG9sGmuATIoe6IXlXT07g8pI0FyP3nzZncODPTlx.v.HtfkMhJy6p06dPQ7neDqPH.T9X.vh a54A.aJ7IKjg7FHCsVzhd4eTUjT.q456QZrDcEbPbFvP7.rAKHoBtisrWz2JXJVhsq97O3jv3b0H WHnTnSQUHYVyrQNH6UxY0Ni8C4DcOuCcJ4Xo- X-Sonic-MF: <mardani29@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Thu, 12 Jan 2023 11:25:08 +0000 Received: by hermes--production-ir2-69cbd7d4db-tcw2j (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 23781ec680a7e570e4036ae45ac4cfec; Thu, 12 Jan 2023 11:25:04 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= <mardani29@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN> Date: Thu, 12 Jan 2023 12:25:03 +0100 In-Reply-To: <838ri8krtv.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 12 Jan 2023 11:47:08 +0200") Message-ID: <m1mt6o806o.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21062 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1358 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 60740 Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Jonas Bernoulli <jonas@HIDDEN>, 60740 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) Eli Zaretskii <eliz@HIDDEN> writes: >> From: Juri Linkov <juri@HIDDEN> >> Date: Wed, 11 Jan 2023 21:45:44 +0200 >>=20 >> etc/NEWS: >>=20 >> +++ >> *** New command 'isearch-emoji-by-name'. >> It is bound to 'C-x 8 e RET' during an incremental search. The >> command accepts the Unicode name of an Emoji (for example, "smiling >> face" or "heart with arrow"), like 'C-x 8 e e', with minibuffer >> completion, and adds the Emoji into the search string. >>=20 >> These examples "smiling face" and "heart with arrow" work fine. >>=20 >> But typing e.g. 'C-s C-x 8 e RET waving hand RET' fails with: >>=20 >> =E2=9B=94 Error (transient): Inconsistent transient state detected. >> This should never happen. >> Please open an issue and post the shown command log. >> This is a heisenbug, so any additional details might help. >> Thanks! > > Looks like a problem with any Emoji that has variants, where you need > to select one of the variants? > The command suspends the isearch while the emoji-search command is invoked, but I see that the isearch reactivates prematurely, when the Transient menu is shown (M-x debug-watch RET isearch-suspended RET is helpful here). Perhaps this is conflicting with Transient in some way. We should try to keep the isearch suspended until after the Transient menu interaction has finished, I think.
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.
Received: (at 60740) by debbugs.gnu.org; 12 Jan 2023 09:57:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 12 04:57:47 2023
Received: from localhost ([127.0.0.1]:44730 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pFuLC-0007db-O0
for submit <at> debbugs.gnu.org; Thu, 12 Jan 2023 04:57:47 -0500
Received: from mail-wm1-f48.google.com ([209.85.128.48]:54807)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <rpluim@HIDDEN>) id 1pFuL7-0007dK-TH
for 60740 <at> debbugs.gnu.org; Thu, 12 Jan 2023 04:57:45 -0500
Received: by mail-wm1-f48.google.com with SMTP id o15so12776475wmr.4
for <60740 <at> debbugs.gnu.org>; Thu, 12 Jan 2023 01:57:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=xst4rla8RAHv92nhrlM5gi+Qsg/5zcqi/rwad54gz/Q=;
b=eSKtJNV2LuYIp46z8mkBKuh5qLjg4bcAWClU9rdysG95DBeKSSq3Xhvgc5Mkul1yXa
d8aqAN+Xlj1XiQ/POiYUpdS7kQUlXCCEIkdqsVMs4oAiw8RG+1INNW0t2bv7bRkvlrz5
2PUDivW5jnMS7DhiiXuqWNiWmATfHYWpKAFWElO3nVeu7d/tbepD8t245G8MohgoD9Wr
/Z/KhhweFkcqAv9HjqWR8wE0a0L5zoqxJ/8QmeD+zniG+iMPskw+UDHvJSa3FMXeuhhA
fFOTlUpGjh4Q4OHcr9cKfnG1n89c19b/i0fE1sRpF5isrdzlU0dhEn1lo7CQ5bW+gZTU
TlUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=xst4rla8RAHv92nhrlM5gi+Qsg/5zcqi/rwad54gz/Q=;
b=qnW5PDcgIExfhf1kQ7gzgAfdcMYIiFEPcrmey2k8I0UjP7a7e3ydi39m71xg8hpHPh
D4jWQPvqZfM29sg20p4MfnfB01SWVwZJZOaP1Y4DCdIh/GvJbYJv0k9ssI0zo9nuFFhE
XdCFvnrbB9obmKQvyWBqsoI7Y0myL6FpWtnmi/6z+dgAv0qUxwBOZ0jExJawEmwaswRS
1FUtdk5GWHdq3IPXosIoybcUhWWW5DhjKJN3/D+Spne2NhFRLjbK4EQR7JI6UlzwUWv7
t/FvzCOl/zGWJVbATX4OrxcGSgwkaU29dd2kxwRRdztpeZKBLZPQFLm6iG0dqEWPlILd
wTYw==
X-Gm-Message-State: AFqh2kphYfFRniYVuPW84szAcX8xOUtfITE8vd8u3sPn6cced70/n4dp
mtLajglLn1RY9HSXY/KRbkm4yjAA/xw=
X-Google-Smtp-Source: AMrXdXvnQcbhEVNlVapnEbIstGWB+7EOF2cVkOE2wf9yop75uFJLoTsqgkofd/NLdn/PIeCnF+aSLw==
X-Received: by 2002:a7b:c447:0:b0:3c6:e63d:adaf with SMTP id
l7-20020a7bc447000000b003c6e63dadafmr55698042wmi.31.1673517455336;
Thu, 12 Jan 2023 01:57:35 -0800 (PST)
Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id
az20-20020a05600c601400b003d96bdddd3dsm21868209wmb.15.2023.01.12.01.57.34
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 12 Jan 2023 01:57:34 -0800 (PST)
From: Robert Pluim <rpluim@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name
In-Reply-To: <838ri8krtv.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 12 Jan
2023 11:47:08 +0200")
References: <86wn5sua6v.fsf@HIDDEN> <838ri8krtv.fsf@HIDDEN>
Date: Thu, 12 Jan 2023 10:57:34 +0100
Message-ID: <87mt6of52p.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 60740
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Jonas Bernoulli <jonas@HIDDEN>,
60740 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
>>>>> On Thu, 12 Jan 2023 11:47:08 +0200, Eli Zaretskii <eliz@HIDDEN> said:
>> But typing e.g. 'C-s C-x 8 e RET waving hand RET' fails with:
>>=20
>> =E2=9B=94 Error (transient): Inconsistent transient state detected.
>> This should never happen.
>> Please open an issue and post the shown command log.
>> This is a heisenbug, so any additional details might help.
>> Thanks!
I get it straight from 'emacs -Q', so obviously the quantum
probabilities are different here =F0=9F=98=80
Eli> Looks like a problem with any Emoji that has variants, where you n=
eed
Eli> to select one of the variants?
Could be. The transient command log looks like this:
e ;; transient:emoji--command-Choose Emoji:=F0=9F=91=8B=F0=9F=
=8F=BE
C-s ;; isearch-repeat-forward
C-x 8 e RET ;; isearch-emoji-by-name
w ;; self-insert-command
a ;; self-insert-command
v ;; self-insert-command
i ;; self-insert-command
n ;; self-insert-command
g ;; self-insert-command
SPC ;; minibuffer-complete-word
h ;; self-insert-command
a ;; self-insert-command
n ;; self-insert-command
d ;; self-insert-command
RET ;; minibuffer-complete-and-exit
e ;; isearch-printing-char
(should that really be calling `isearch-printing-char' at the end
there?)
'C-x 8 e RET' for the same emoji works fine.
Robert
--=20
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at 60740) by debbugs.gnu.org; 12 Jan 2023 09:46:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 12 04:46:46 2023 Received: from localhost ([127.0.0.1]:44717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pFuAY-0007KK-6m for submit <at> debbugs.gnu.org; Thu, 12 Jan 2023 04:46:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pFuAW-0007K8-Kv for 60740 <at> debbugs.gnu.org; Thu, 12 Jan 2023 04:46:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pFuAP-00022j-Nu; Thu, 12 Jan 2023 04:46:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=nior9vMmvsZQ5S2fZ9pBIk9NIWwSgyxC+PcBn4dqd+c=; b=gJbIjvvAezfehS+KVHMl aKcVQATxsHSMI37xl+ZK1hjVLkN+zpwwRQx9M3kvosL52ltdenUeJ1CCTAAqNWNNfa8u5qM3GhWyf 7OBIORhpOwqNiFsBQH+F5be0OH3AiYJ9SkFpuE8sqjQN0IdPgXe9PN2y6T9Dc6bjzIj15rCXIE1Ll ifSnreocx1p2eBgWgADhddBQvwEBZgLUz//TbV+sCp5EWbn80F1cZmgAA4S3h0QAlhVxclmKJoQCF 1f0tEbq/66SV2i+39ulpaF0UjgIu29ext+4Ud0ANTh/z6M4khbC/yLMg2j5UjZEL+OFliYjxxv5dQ BGvNtrPZksuc0g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pFuAM-0001DL-Qp; Thu, 12 Jan 2023 04:46:37 -0500 Date: Thu, 12 Jan 2023 11:47:08 +0200 Message-Id: <838ri8krtv.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, Jonas Bernoulli <jonas@HIDDEN> In-Reply-To: <86wn5sua6v.fsf@HIDDEN> (message from Juri Linkov on Wed, 11 Jan 2023 21:45:44 +0200) Subject: Re: bug#60740: 29.0.60; Broken isearch-emoji-by-name References: <86wn5sua6v.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60740 Cc: 60740 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Juri Linkov <juri@HIDDEN> > Date: Wed, 11 Jan 2023 21:45:44 +0200 > > etc/NEWS: > > +++ > *** New command 'isearch-emoji-by-name'. > It is bound to 'C-x 8 e RET' during an incremental search. The > command accepts the Unicode name of an Emoji (for example, "smiling > face" or "heart with arrow"), like 'C-x 8 e e', with minibuffer > completion, and adds the Emoji into the search string. > > These examples "smiling face" and "heart with arrow" work fine. > > But typing e.g. 'C-s C-x 8 e RET waving hand RET' fails with: > > â›” Error (transient): Inconsistent transient state detected. > This should never happen. > Please open an issue and post the shown command log. > This is a heisenbug, so any additional details might help. > Thanks! Looks like a problem with any Emoji that has variants, where you need to select one of the variants? Lars, Jonas, could you please look into this?
bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 11 Jan 2023 19:47:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 11 14:47:02 2023 Received: from localhost ([127.0.0.1]:43933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pFh3u-0005mg-A5 for submit <at> debbugs.gnu.org; Wed, 11 Jan 2023 14:47:02 -0500 Received: from lists.gnu.org ([209.51.188.17]:57698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1pFh3q-0005mG-DK for submit <at> debbugs.gnu.org; Wed, 11 Jan 2023 14:47:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <juri@HIDDEN>) id 1pFh3p-0004gV-5G for bug-gnu-emacs@HIDDEN; Wed, 11 Jan 2023 14:46:58 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <juri@HIDDEN>) id 1pFh3i-0006D8-Qr for bug-gnu-emacs@HIDDEN; Wed, 11 Jan 2023 14:46:54 -0500 Received: (Authenticated sender: juri@HIDDEN) by mail.gandi.net (Postfix) with ESMTPSA id E449240006 for <bug-gnu-emacs@HIDDEN>; Wed, 11 Jan 2023 19:46:44 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.0.60; Broken isearch-emoji-by-name Organization: LINKOV.NET Date: Wed, 11 Jan 2023 21:45:44 +0200 Message-ID: <86wn5sua6v.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=217.70.183.194; envelope-from=juri@HIDDEN; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.6 (--) etc/NEWS: +++ *** New command 'isearch-emoji-by-name'. It is bound to 'C-x 8 e RET' during an incremental search. The command accepts the Unicode name of an Emoji (for example, "smiling face" or "heart with arrow"), like 'C-x 8 e e', with minibuffer completion, and adds the Emoji into the search string. These examples "smiling face" and "heart with arrow" work fine. But typing e.g. 'C-s C-x 8 e RET waving hand RET' fails with: â›” Error (transient): Inconsistent transient state detected. This should never happen. Please open an issue and post the shown command log. This is a heisenbug, so any additional details might help. Thanks!
Juri Linkov <juri@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#60740; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.