GNU bug report logs - #60741
29.0.60; 'M-c' shadowed in the minibuffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60741 in the body.
You can then email your comments to 60741 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; 'M-c' shadowed in the minibuffer
Date: Wed, 11 Jan 2023 21:54:48 +0200

etc/NEWS:

  +++
  ** 'M-c' in 'read-regexp' now toggles case folding.

'M-c' is bound globally to 'capitalize-word', but this keybinding
is shadowed in the minibuffer, thus making it impossible to
capitalize words.

Isearch had this problem for a long time but now it's already solved with:

  (put 'isearch-toggle-case-fold :advertised-binding "\M-sc")

where 'M-s c' is used to toggle search case-sensitivity.

So to avoid the problem the same could be done in 'read-regexp':

```
diff --git a/lisp/replace.el b/lisp/replace.el
index 2f063bbf66b..9471435bda3 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -824,7 +830,7 @@ read-regexp-suggestions
 
 (defvar-keymap read-regexp-map
   :parent minibuffer-local-map
-  "M-c" #'read-regexp-toggle-case-folding)
+  "M-s c" #'read-regexp-toggle-case-folding)
 
 (defvar read-regexp--case-fold nil)
 
```

Message #8 received at 60741 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 60741 <at> debbugs.gnu.org
Subject: Re: bug#60741: 29.0.60; 'M-c' shadowed in the minibuffer
Date: Wed, 18 Jan 2023 20:06:00 +0200

close 60741 29.0.60
quit

> 'M-c' is bound globally to 'capitalize-word', but this keybinding
> is shadowed in the minibuffer, thus making it impossible to
> capitalize words.
>
> Isearch had this problem for a long time but now it's already solved with:
>
>   (put 'isearch-toggle-case-fold :advertised-binding "\M-sc")
>
> where 'M-s c' is used to toggle search case-sensitivity.
>
> So to avoid the problem the same could be done in 'read-regexp':

Pushed to make compatible with the search map currently
discussed in bug#60815 where it will be unified in master
among other M-s keys under the general setting search-key.

Message #13 received at 60741 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Juri Linkov <juri <at> linkov.net>, "60741 <at> debbugs.gnu.org"
 <60741 <at> debbugs.gnu.org>
Subject: RE: [External] : bug#60741: 29.0.60; 'M-c' shadowed in the minibuffer
Date: Wed, 18 Jan 2023 18:46:50 +0000

> > 'M-c' is bound globally to 'capitalize-word', but this keybinding
> > is shadowed in the minibuffer, thus making it impossible to
> > capitalize words.

Is this something new in Emacs 29?  I don't see it
in previous versions (I don't have 29).  What is
`M-c' bound to now in the minibuffer keymaps?

Why should we lose this longstanding, useful key
binding?  Users should be able to use most normal
editing keys in the minibuffer - it's first and
foremost an editing buffer.

Message #16 received at 60741 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: "60741 <at> debbugs.gnu.org" <60741 <at> debbugs.gnu.org>
Subject: Re: [External] : bug#60741: 29.0.60; 'M-c' shadowed in the minibuffer
Date: Wed, 18 Jan 2023 20:52:18 +0200

>> > 'M-c' is bound globally to 'capitalize-word', but this keybinding
>> > is shadowed in the minibuffer, thus making it impossible to
>> > capitalize words.
>
> Is this something new in Emacs 29?

Yes, it's new.

> I don't see it in previous versions (I don't have 29).
> What is `M-c' bound to now in the minibuffer keymaps?

It was bound to `read-regexp-toggle-case-folding'.

> Why should we lose this longstanding, useful key
> binding?  Users should be able to use most normal
> editing keys in the minibuffer - it's first and
> foremost an editing buffer.

Now normal editing keys are available again.

Message #19 received at 60741 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: "60741 <at> debbugs.gnu.org" <60741 <at> debbugs.gnu.org>
Subject: RE: [External] : bug#60741: 29.0.60; 'M-c' shadowed in the minibuffer
Date: Wed, 18 Jan 2023 18:59:28 +0000

> Now normal editing keys are available again.

Thx.

Message #22 received at 60741 <at> debbugs.gnu.org (full text, mbox):

From: Jean Louis <bugs <at> gnu.support>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: "60741 <at> debbugs.gnu.org" <60741 <at> debbugs.gnu.org>,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#60741: 29.0.60; 'M-c' shadowed in the minibuffer
Date: Thu, 19 Jan 2023 08:34:05 +0300

* Drew Adams <drew.adams <at> oracle.com> [2023-01-18 21:48]:
> > > 'M-c' is bound globally to 'capitalize-word', but this keybinding
> > > is shadowed in the minibuffer, thus making it impossible to
> > > capitalize words.
> 
> Is this something new in Emacs 29?  I don't see it
> in previous versions (I don't have 29).  What is
> `M-c' bound to now in the minibuffer keymaps?
> 
> Why should we lose this longstanding, useful key
> binding?  Users should be able to use most normal
> editing keys in the minibuffer - it's first and
> foremost an editing buffer.

I use that key all the time in the minibuffer, and can't without
it. I give you the practical example:

- PDF book in Dired is called:
  21252030 agenda for sustainable development web.pdf

- I click and wish to index the book, so initial prompt for the title
  will be:
  21252030 agenda for sustainable development web.pdf

- I delete 21252030 with M-d and use M-c to get following:
  Agenda For Sustainable Development

- then I press RET to record information

Without M-c in minibuffer I would need to re-assign key binding.

But it works, I did not know something changed.

--
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/

Message #25 received at 60741 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jean Louis <bugs <at> gnu.support>
Cc: 60741 <at> debbugs.gnu.org, drew.adams <at> oracle.com, juri <at> linkov.net
Subject: Re: bug#60741: 29.0.60; 'M-c' shadowed in the minibuffer
Date: Thu, 19 Jan 2023 09:25:23 +0200

> Cc: "60741 <at> debbugs.gnu.org" <60741 <at> debbugs.gnu.org>,
>  Juri Linkov <juri <at> linkov.net>
> Date: Thu, 19 Jan 2023 08:34:05 +0300
> From: Jean Louis <bugs <at> gnu.support>
> 
> * Drew Adams <drew.adams <at> oracle.com> [2023-01-18 21:48]:
> > > > 'M-c' is bound globally to 'capitalize-word', but this keybinding
> > > > is shadowed in the minibuffer, thus making it impossible to
> > > > capitalize words.
> > 
> > Is this something new in Emacs 29?  I don't see it
> > in previous versions (I don't have 29).  What is
> > `M-c' bound to now in the minibuffer keymaps?
> > 
> > Why should we lose this longstanding, useful key
> > binding?  Users should be able to use most normal
> > editing keys in the minibuffer - it's first and
> > foremost an editing buffer.
> 
> I use that key all the time in the minibuffer, and can't without
> it. I give you the practical example:
> 
> - PDF book in Dired is called:
>   21252030 agenda for sustainable development web.pdf
> 
> - I click and wish to index the book, so initial prompt for the title
>   will be:
>   21252030 agenda for sustainable development web.pdf
> 
> - I delete 21252030 with M-d and use M-c to get following:
>   Agenda For Sustainable Development
> 
> - then I press RET to record information
> 
> Without M-c in minibuffer I would need to re-assign key binding.
> 
> But it works, I did not know something changed.

You are barking up the wrong tree: Juri has _fixed_ this, didn't
_break_ this.

Please review the changeset before posting opinions about it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.