GNU bug report logs - #60748
30.0.50; [PATCH]: Fix indentation of object_expressions in csharp-ts-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60748 in the body.
You can then email your comments to 60748 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH]: Fix indentation of object_expressions in
 csharp-ts-mode
Date: Thu, 12 Jan 2023 09:15:44 +0100

[Message part 1 (text/plain, inline)]

Hi Jostein!

What do you think of this patch?  It fixes typing out this, taken from
[0]:

```
namespace Foo {
    class Foo {
        void foo() {
            CatOwner owner = new CatOwner
            {
                Cats = new List<Cat>
                {
                    new X
                    {
                        Name = "Sylvester",
                        Age=8
                    },
                    new Cat
                    {
                        Name = "Whiskers", Age=2
                    },
                    new Cat
                    { Name = "Sasha", Age=14 }
                }
            };

            var x = new
            {
                X = 5
            };

            Foo foo = new Foo
            {
            };

            Cat cat = new Cat
            {
                Cats = new List<Cat>
                {
                    new X
                    {
                        Name = "Sten"
                    },
                    new Y
                    { Foo = "rst" }
                }
            };

            Cat c = new Foo()
            {
                
            };

            RudimentaryMultiValuedDictionary<string, string> rudimentaryMultiValuedDictionary3
                = new RudimentaryMultiValuedDictionary<string, string>()
                {
                    {"Group1", new string []{ "Bob", "John", "Mary" } },
                    { "Group2", new string[]{ "Eric", "Emily", "Debbie", "Jesse" } }
                };
        }
    }
}
```

Are there any regressions, or is this ok to you?

Theo

[0]: 

[0001-Fix-indentation-of-object_expressions-in-csharp-ts-m.patch (text/x-patch, attachment)]

Message #8 received at 60748 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: 60748 <at> debbugs.gnu.org
Cc: jostein <at> kjonigsen.net,
 Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Subject: Re: bug#60748: 30.0.50; [PATCH]: Fix indentation of
 object_expressions in csharp-ts-mode
Date: Fri, 13 Jan 2023 11:41:04 +0100

Theodor Thornhill <theo <at> thornhill.no> writes:

> Hi Jostein!
>
> Are there any regressions, or is this ok to you?
>
> Theo
>
> [0]:

Not sure if sent to correct mail, so just appending another one here :)

I can't see any regressions right now, so I'll install the patch when
you're ok with it :)

Theo

Message #11 received at 60748 <at> debbugs.gnu.org (full text, mbox):

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: Theodor Thornhill <theo <at> thornhill.no>, 60748 <at> debbugs.gnu.org
Subject: Re: bug#60748: 30.0.50; [PATCH]: Fix indentation of
 object_expressions in csharp-ts-mode
Date: Fri, 13 Jan 2023 12:16:42 +0100

On 13.01.2023 11:41, Theodor Thornhill wrote:
> Theodor Thornhill <theo <at> thornhill.no> writes:
>
>> Hi Jostein!
>>
>> Are there any regressions, or is this ok to you?
>>
>> Theo
>>
>> [0]:
> Not sure if sent to correct mail, so just appending another one here :)
>
> I can't see any regressions right now, so I'll install the patch when
> you're ok with it :)
>
> Theo

You had a/the right email, but not the right point in time ;)

This last week I've been busy, and working almost entirely with 
TypeScript (and I will for the next weeks too), so I haven't been able 
to testdrive the new C# changes properly or thouroughly enough to feel 
confident enough to give feedback.

I've looked over the code though, and that looks good to me.

If you feel you've done adequate testing, don't wait for me to merge this.

--
Jostein

Message #14 received at 60748 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>,
 60748 <at> debbugs.gnu.org
Subject: Re: bug#60748: 30.0.50; [PATCH]: Fix indentation of object_expressions in csharp-ts-mode
Date: Fri, 13 Jan 2023 12:42:25 +0100

On 13 January 2023 12:16:42 CET, "Jostein Kjønigsen" <jostein <at> secure.kjonigsen.net> wrote:
>On 13.01.2023 11:41, Theodor Thornhill wrote:
>> Theodor Thornhill <theo <at> thornhill.no> writes:
>> 
>>> Hi Jostein!
>>> 
>>> Are there any regressions, or is this ok to you?
>>> 
>>> Theo
>>> 
>>> [0]:
>> Not sure if sent to correct mail, so just appending another one here :)
>> 
>> I can't see any regressions right now, so I'll install the patch when
>> you're ok with it :)
>> 
>> Theo
>
>You had a/the right email, but not the right point in time ;)
>
>This last week I've been busy, and working almost entirely with TypeScript (and I will for the next weeks too), so I haven't been able to testdrive the new C# changes properly or thouroughly enough to feel confident enough to give feedback.
>
>I've looked over the code though, and that looks good to me.
>
>If you feel you've done adequate testing, don't wait for me to merge this.
>
>--
>Jostein
>

Nice, didn't mean to rush, just never got used to all the mails:)

But now I know :)

I'll install it tonight, feel free to report back if something's messed up!

Theo 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.