GNU bug report logs - #60752
[PATCH] services: connman: Add iwd backend support.

Previous Next

Package: guix-patches;

Reported by: Declan Tsien <declantsien <at> riseup.net>

Date: Thu, 12 Jan 2023 12:58:01 UTC

Severity: normal

Tags: patch

Merged with 60800

Done: Andrew Tropin <andrew <at> trop.in>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60752 in the body.
You can then email your comments to 60752 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#60752; Package guix-patches. (Thu, 12 Jan 2023 12:58:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Declan Tsien <declantsien <at> riseup.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 12 Jan 2023 12:58:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Declan Tsien <declantsien <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: connman: Add iwd backend support.
Date: Thu, 12 Jan 2023 20:56:59 +0800
[0001-services-connman-Add-iwd-backend-support.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#60752; Package guix-patches. (Thu, 12 Jan 2023 14:13:02 GMT) Full text and rfc822 format available.

Message #8 received at 60752 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 60752 <at> debbugs.gnu.org
Cc: declantsien <at> riseup.net
Subject: [PATCH] services: connman: Add iwd backend support.
Date: Thu, 12 Jan 2023 14:12:45 +0000
Hi,

Does connman absolutely require a wireless adapter backend?
IMO if that's not the case, neither iwd nor wpa-supplicant backends should be pulled by connman. (or at least they should be required only if they are present among the services field)
This is because not every machine comes or wants to use a wireless adapter.


Cheers,
Bruno




Information forwarded to guix-patches <at> gnu.org:
bug#60752; Package guix-patches. (Thu, 12 Jan 2023 14:32:02 GMT) Full text and rfc822 format available.

Message #11 received at 60752 <at> debbugs.gnu.org (full text, mbox):

From: Declan Tsien <declantsien <at> riseup.net>
To: 60752 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: Re: [PATCH] services: connman: Add iwd backend support.
Date: Thu, 12 Jan 2023 22:31:19 +0800
[Message part 1 (text/plain, inline)]
Bruno Victal <mirai <at> makinata.eu> writes:

>
> IMO if that's not the case, neither iwd nor wpa-supplicant backends should be pulled by connman. (or at least they should be required only if they are present among the services field)
> This is because not every machine comes or wants to use a wireless adapter.
>

Right, are you suggesting removing wpa-supplicant from requirement
field?

Yeah, it would make more sense and fit my needs too.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#60752; Package guix-patches. (Thu, 12 Jan 2023 14:54:01 GMT) Full text and rfc822 format available.

Message #14 received at 60752 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: Declan Tsien <declantsien <at> riseup.net>, 60752 <at> debbugs.gnu.org
Subject: Re: [PATCH] services: connman: Add iwd backend support.
Date: Thu, 12 Jan 2023 14:53:34 +0000
On 2023-01-12 14:31, Declan Tsien wrote:
> Bruno Victal <mirai <at> makinata.eu> writes:
> 
>>
>> IMO if that's not the case, neither iwd nor wpa-supplicant backends should be pulled by connman. (or at least they should be required only if they are present among the services field)
>> This is because not every machine comes or wants to use a wireless adapter.
>>
> 
> Right, are you suggesting removing wpa-supplicant from requirement
> field?

If that's possible, yes.




Information forwarded to guix-patches <at> gnu.org:
bug#60752; Package guix-patches. (Thu, 12 Jan 2023 15:23:01 GMT) Full text and rfc822 format available.

Message #17 received at 60752 <at> debbugs.gnu.org (full text, mbox):

From: Declan Tsien <declantsien <at> riseup.net>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: 60752 <at> debbugs.gnu.org
Subject: Re: [PATCH] services: connman: Add iwd backend support.
Date: Thu, 12 Jan 2023 23:22:04 +0800
[Message part 1 (text/plain, inline)]
Bruno Victal <mirai <at> makinata.eu> writes:

> On 2023-01-12 14:31, Declan Tsien wrote:
>> Bruno Victal <mirai <at> makinata.eu> writes:
>> 
>>>
>>> IMO if that's not the case, neither iwd nor wpa-supplicant backends should be pulled by connman. (or at least they should be required only if they are present among the services field)
>>> This is because not every machine comes or wants to use a wireless adapter.
>>>
>> 
>> Right, are you suggesting removing wpa-supplicant from requirement
>> field?
>
> If that's possible, yes.

I think that is a question for people with more knowledge in this regard.

But to my experiencing using connman and iwd. I think it's OK.
Now I am running these two shepherd services separately

- connman (without wpa-supplicant and iwd)
- iwd

This patch can be closed without applying.

Thanks for clarifying things for me.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#60752; Package guix-patches. (Sat, 14 Jan 2023 01:18:01 GMT) Full text and rfc822 format available.

Message #20 received at 60752 <at> debbugs.gnu.org (full text, mbox):

From: Declan Tsien <declantsien <at> riseup.net>
To: 60752 <at> debbugs.gnu.org
Subject: [Declan Tsien] Re: [bug#60752] [PATCH] services: connman: Add
 option to disable wpa-supplicant.
Date: Sat, 14 Jan 2023 09:17:02 +0800
[Message part 1 (text/plain, inline)]
-------------------- Start of forwarded message --------------------
From: Declan Tsien <declantsien <at> riseup.net>
To: Bruno Victal <mirai <at> makinata.eu>
Subject: Re: [bug#60752] [PATCH] services: connman: Add option to disable
 wpa-supplicant.
Date: Sat, 14 Jan 2023 09:13:50 +0800

[Message part 2 (text/plain, inline)]
Bruno Victal <mirai <at> makinata.eu> writes:

> Hi,
>
> Does connman absolutely require a wireless adapter backend?
> IMO if that's not the case, neither iwd nor wpa-supplicant backends should be pulled by connman. (or at least they should be required only if they are present among the services field)
> This is because not every machine comes or wants to use a wireless adapter.
>
>
> Cheers,
> Bruno

Hi,
what about this.

[0001-services-connman-Add-option-to-disable-wpa-supplican.patch (text/x-patch, attachment)]
[Message part 4 (text/plain, inline)]
This way, connman service can let users disable wireless adapters or hook
in a another implementation like iwd.

Cheers,
Declan
[signature.asc (application/pgp-signature, inline)]
[Message part 6 (text/plain, inline)]
-------------------- End of forwarded message --------------------
[signature.asc (application/pgp-signature, inline)]

Reply sent to Declan Tsien <declantsien <at> riseup.net>:
You have taken responsibility. (Sat, 14 Jan 2023 01:55:02 GMT) Full text and rfc822 format available.

Notification sent to Declan Tsien <declantsien <at> riseup.net>:
bug acknowledged by developer. (Sat, 14 Jan 2023 01:55:02 GMT) Full text and rfc822 format available.

Message #25 received at 60752-done <at> debbugs.gnu.org (full text, mbox):

From: Declan Tsien <declantsien <at> riseup.net>
To: 60752-done <at> debbugs.gnu.org
Date: Sat, 14 Jan 2023 09:54:03 +0800
[Message part 1 (text/plain, inline)]
Started a new thread since the subject has changed
https://issues.guix.gnu.org/60800
[signature.asc (application/pgp-signature, inline)]

Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 16 Jan 2023 16:35:01 GMT) Full text and rfc822 format available.

Merged 60752 60800. Request was from Andrew Tropin <andrew <at> trop.in> to control <at> debbugs.gnu.org. (Mon, 16 Jan 2023 16:35:01 GMT) Full text and rfc822 format available.

Reply sent to Andrew Tropin <andrew <at> trop.in>:
You have taken responsibility. (Mon, 16 Jan 2023 17:23:02 GMT) Full text and rfc822 format available.

Notification sent to Declan Tsien <declantsien <at> riseup.net>:
bug acknowledged by developer. (Mon, 16 Jan 2023 17:23:02 GMT) Full text and rfc822 format available.

Message #34 received at 60752-done <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Declan Tsien <declantsien <at> riseup.net>, 60752-done <at> debbugs.gnu.org
Subject: Re: bug#60752:
Date: Mon, 16 Jan 2023 21:22:11 +0400
[Message part 1 (text/plain, inline)]
On 2023-01-14 09:54, Declan Tsien wrote:

> Started a new thread since the subject has changed
> https://issues.guix.gnu.org/60800

Let's keep the discussion in this thread, not to lose the context.

BTW, there is a retitle command for debbugs in case it necessary to
change the title of the bug. 


From what I see wpa-supplicant requirement is not needed, as Bruno
mentioned, there are use cases, where connman can be used without
wpa-supplicant or wireless backend at all.

According to the documentation I was able to find, to enable iwd support
--wifi=iwd_agent should be added to connmand, so I applied the first
patch with a few adjustments: Completely removed wpa-supplicant
requirement, realigned the code.  Unfortunately, I don't use connman and
can't easily check, Declan, could you please confirm that iwd is now
working correctly with connman?

-- 
Best regards,
Andrew Tropin
[signature.asc (application/pgp-signature, inline)]

Reply sent to Andrew Tropin <andrew <at> trop.in>:
You have taken responsibility. (Mon, 16 Jan 2023 17:23:02 GMT) Full text and rfc822 format available.

Notification sent to Declan Tsien <declantsien <at> riseup.net>:
bug acknowledged by developer. (Mon, 16 Jan 2023 17:23:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#60752; Package guix-patches. (Tue, 17 Jan 2023 00:32:01 GMT) Full text and rfc822 format available.

Message #42 received at 60752 <at> debbugs.gnu.org (full text, mbox):

From: Declan Tsien <declantsien <at> riseup.net>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 60752 <at> debbugs.gnu.org
Subject: Re: bug#60752:
Date: Tue, 17 Jan 2023 08:30:53 +0800
[Message part 1 (text/plain, inline)]
Andrew Tropin <andrew <at> trop.in> writes:

> On 2023-01-14 09:54, Declan Tsien wrote:
>
>> Started a new thread since the subject has changed
>> https://issues.guix.gnu.org/60800
>
> Let's keep the discussion in this thread, not to lose the context.
>
> BTW, there is a retitle command for debbugs in case it necessary to
> change the title of the bug. 
>

Thanks.

>
> From what I see wpa-supplicant requirement is not needed, as Bruno
> mentioned, there are use cases, where connman can be used without
> wpa-supplicant or wireless backend at all.
>
> According to the documentation I was able to find, to enable iwd support
> --wifi=iwd_agent should be added to connmand, so I applied the first
> patch with a few adjustments: Completely removed wpa-supplicant
> requirement, realigned the code.  Unfortunately, I don't use connman and
> can't easily check, Declan, could you please confirm that iwd is now
> working correctly with connman?
>
> -- 
> Best regards,
> Andrew Tropin

Yeah, Its working.

In my case, --wifi=iwd_agent is not required either when using iwd.
But it should be useful when wpa-supplicant and iwd services are both
in the system.

Best regards,
Declan Tsien
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 14 Feb 2023 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 71 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.