GNU bug report logs - #60761
[PATCH] Remove deprecated RLS server from list of eglot servers

Previous Next

Package: emacs;

Reported by: Dimitri Belopopsky <dimitri <at> belopopsky.com>

Date: Thu, 12 Jan 2023 22:07:02 UTC

Severity: normal

Tags: patch

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60761 in the body.
You can then email your comments to 60761 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#60761; Package emacs. (Thu, 12 Jan 2023 22:07:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dimitri Belopopsky <dimitri <at> belopopsky.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 12 Jan 2023 22:07:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dimitri Belopopsky <dimitri <at> belopopsky.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove deprecated RLS server from list of eglot servers
Date: Thu, 12 Jan 2023 22:43:41 +0100
[Message part 1 (text/plain, inline)]
Hello,

I'm suggesting removing RLS from the server list in eglot, as it is
currently not maintained anymore by the Rust developers.
The github was archived: https://github.com/rust-lang/rls
[Message part 2 (text/html, inline)]
[0001-Remove-deprecated-RLS-server-from-list-of-eglot-serv.patch (application/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60761; Package emacs. (Fri, 13 Jan 2023 01:16:02 GMT) Full text and rfc822 format available.

Message #8 received at 60761 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Dimitri Belopopsky <dimitri <at> belopopsky.com>, 60761 <at> debbugs.gnu.org
Cc: João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#60761: [PATCH] Remove deprecated RLS server from list of
 eglot servers
Date: Thu, 12 Jan 2023 17:15:42 -0800
close 60761 30.1
thanks

Dimitri Belopopsky <dimitri <at> belopopsky.com> writes:

> I'm suggesting removing RLS from the server list in eglot, as it is
> currently not maintained anymore by the Rust developers.
> The github was archived: https://github.com/rust-lang/rls

Thanks, pushed to master (commit f1310859a0d).




bug marked as fixed in version 30.1, send any further explanations to 60761 <at> debbugs.gnu.org and Dimitri Belopopsky <dimitri <at> belopopsky.com> Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Fri, 13 Jan 2023 01:16:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60761; Package emacs. (Fri, 13 Jan 2023 07:19:01 GMT) Full text and rfc822 format available.

Message #13 received at 60761 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 60761 <at> debbugs.gnu.org, dimitri <at> belopopsky.com, joaotavora <at> gmail.com
Subject: Re: bug#60761: [PATCH] Remove deprecated RLS server from list of eglot
 servers
Date: Fri, 13 Jan 2023 09:18:18 +0200
> Cc: João Távora <joaotavora <at> gmail.com>
> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Thu, 12 Jan 2023 17:15:42 -0800
> 
> Dimitri Belopopsky <dimitri <at> belopopsky.com> writes:
> 
> > I'm suggesting removing RLS from the server list in eglot, as it is
> > currently not maintained anymore by the Rust developers.
> > The github was archived: https://github.com/rust-lang/rls
> 
> Thanks, pushed to master (commit f1310859a0d).

Does "not maintained anymore by the Rust developers" necessarily mean
it is wrong to use it?  Having the server mentioned in the DB doesn't
mean we force the users to use it, just that we support it if the user
has it installed.

João, WDYT?  I guess we should to have some criteria for when to
remove servers from the DB?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60761; Package emacs. (Fri, 13 Jan 2023 08:28:03 GMT) Full text and rfc822 format available.

Message #16 received at 60761 <at> debbugs.gnu.org (full text, mbox):

From: Dimitri Belopopsky <dimitri <at> belopopsky.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60761 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>,
 joaotavora <at> gmail.com
Subject: Re: bug#60761: [PATCH] Remove deprecated RLS server from list of
 eglot servers
Date: Fri, 13 Jan 2023 08:36:51 +0100
[Message part 1 (text/plain, inline)]
On Fri, 13 Jan 2023, 08:19 Eli Zaretskii, <eliz <at> gnu.org> wrote:

> > Cc: João Távora <joaotavora <at> gmail.com>
> > From: Stefan Kangas <stefankangas <at> gmail.com>
> > Date: Thu, 12 Jan 2023 17:15:42 -0800
> >
> > Dimitri Belopopsky <dimitri <at> belopopsky.com> writes:
> >
> > > I'm suggesting removing RLS from the server list in eglot, as it is
> > > currently not maintained anymore by the Rust developers.
> > > The github was archived: https://github.com/rust-lang/rls
> >
> > Thanks, pushed to master (commit f1310859a0d).
>
> Does "not maintained anymore by the Rust developers" necessarily mean
> it is wrong to use it?  Having the server mentioned in the DB doesn't
> mean we force the users to use it, just that we support it if the user
> has it installed.
>

In the general case I think I agree.
Here, it is explicitely stated that users should move to rust-analyzer.
There is nothing wrong in using it anyway,
but I don't think it should be encouraged to use in this case.


> João, WDYT?  I guess we should to have some criteria for when to
> remove servers from the DB?
>
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60761; Package emacs. (Fri, 13 Jan 2023 17:52:01 GMT) Full text and rfc822 format available.

Message #19 received at 60761 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60761 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>,
 dimitri <at> belopopsky.com
Subject: Re: bug#60761: [PATCH] Remove deprecated RLS server from list of
 eglot servers
Date: Fri, 13 Jan 2023 17:51:13 +0000
[Message part 1 (text/plain, inline)]
On Fri, Jan 13, 2023, 07:18 Eli Zaretskii <eliz <at> gnu.org> wrote:.

>
> João, WDYT?  I guess we should to have some criteria for when to
> remove servers from the DB?
>

We could, yes. But I can't come up with one.
Here, i think it makes sense to remove it if it's deprecated. Because it's
more likely to be a disappointment than not. And users that really want to
use it can still do so.

João

>
[Message part 2 (text/html, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 11 Feb 2023 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 75 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.