GNU bug report logs - #60776
[PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60776 in the body.
You can then email your comments to 60776 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: automake-patches <at> gnu.org
Subject: [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P
Date: Fri, 13 Jan 2023 04:06:14 -0500

We don't need to do the `test -d ... || mkdir ...` dance when we
have the MKDIR_P helper, so simplify this code a bit.

* lib/am/distdir.am: Use $(MKDIR_P).
* lib/am/lisp.am: Drop redundant `test -d`.
---
 lib/am/distdir.am | 2 +-
 lib/am/lisp.am    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/am/distdir.am b/lib/am/distdir.am
index 4cfc742ce23d..264713c332e6 100644
--- a/lib/am/distdir.am
+++ b/lib/am/distdir.am
@@ -103,7 +103,7 @@ endif %?TOPDIR_P%
 ##
 if %?TOPDIR_P%
 	$(am__remove_distdir)
-	test -d "$(distdir)" || mkdir "$(distdir)"
+	$(AM_V_at)$(MKDIR_P) "$(distdir)"
 endif %?TOPDIR_P%
 ##
 ##
diff --git a/lib/am/lisp.am b/lib/am/lisp.am
index d5858f8661af..c96be2121656 100644
--- a/lib/am/lisp.am
+++ b/lib/am/lisp.am
@@ -37,7 +37,7 @@ endif %?INSTALL%
 	    am__subdir_includes="-L $$am__dir -L $(srcdir)/$$am__dir"; \
 	  esac; \
 ## Emacs byte-compilation won't create this automatically, sadly.
-	  test -d "$$am__dir" || $(MKDIR_P) "$$am__dir" || exit 1; \
+	  $(MKDIR_P) "$$am__dir" || exit 1; \
 	  $(EMACS) --batch --no-site-file \
 	    $(AM_ELCFLAGS) $(ELCFLAGS) \
 	    $$am__subdir_includes -L $(builddir) -L $(srcdir) \
-- 
2.39.0

Message #8 received at 60776 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: vapier <at> gentoo.org
Cc: 60776 <at> debbugs.gnu.org
Subject: Re: [bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P
Date: Fri, 13 Jan 2023 15:36:33 -0700

    -	test -d "$(distdir)" || mkdir "$(distdir)"
    +	$(AM_V_at)$(MKDIR_P) "$(distdir)"

Ok by me, but why the AM_V_at for this particular command?
I don't see it used anywhere else in distdir.am.

    -	  test -d "$$am__dir" || $(MKDIR_P) "$$am__dir" || exit 1; \
    +	  $(MKDIR_P) "$$am__dir" || exit 1; \

Sure. Thanks. -k

Message #11 received at 60776 <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: Karl Berry <karl <at> freefriends.org>
Cc: 60776 <at> debbugs.gnu.org
Subject: Re: [bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P
Date: Fri, 13 Jan 2023 23:47:30 -0500

[Message part 1 (text/plain, inline)]

On 13 Jan 2023 15:36, Karl Berry wrote:
>     -	test -d "$(distdir)" || mkdir "$(distdir)"
>     +	$(AM_V_at)$(MKDIR_P) "$(distdir)"
> 
> Ok by me, but why the AM_V_at for this particular command?
> I don't see it used anywhere else in distdir.am.

this is certainly true, and it's something i want to fix ... at some point.
imo we overly rely on explicit @ in many places which can make debugging
failures painful.  i imagine the current state is due to the silent-rules
work focusing on the most common paths (compile/rebuilds) and leaving the
rest to "one day".  so if we ever get to that day, we'd use $(AM_V_at) in
this location.  i figured making the change while i was here means we have
a slightly higher chance of this code eventually being silent-rules compat
vs finding the time to convert it all at once.
-mike

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 60776 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: vapier <at> gentoo.org
Cc: 60776 <at> debbugs.gnu.org
Subject: Re: [bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P
Date: Sat, 14 Jan 2023 15:17:48 -0700

    imo we overly rely on explicit @ in many places which can make debugging
    failures painful.

FWIW, I agree. Although I see no @ here.

    if we ever get to that day, we'd use $(AM_V_at) in
    this location.

Ok by me. --thanks, karl.

Message #17 received at 60776 <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: Karl Berry <karl <at> freefriends.org>
Cc: 60776 <at> debbugs.gnu.org
Subject: Re: [bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P
Date: Sat, 14 Jan 2023 18:43:58 -0500

[Message part 1 (text/plain, inline)]

On 14 Jan 2023 15:17, Karl Berry wrote:
>     imo we overly rely on explicit @ in many places which can make debugging
>     failures painful.
> 
> FWIW, I agree. Although I see no @ here.

most of the code directly preceding & following this line use @.
i.e. the vast majority of the current distdir logic.
-mike

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 60776 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: vapier <at> gentoo.org
Cc: 60776 <at> debbugs.gnu.org
Subject: Re: [bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P
Date: Sat, 14 Jan 2023 17:05:00 -0700

    most of the code directly preceding & following this line use @.
    i.e. the vast majority of the current distdir logic.

Yeah.

If you feel like changing those @'s to AM_v_at while we're here, sounds
good to me ... -k

Message #23 received at 60776 <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: Karl Berry <karl <at> freefriends.org>
Cc: 60776 <at> debbugs.gnu.org
Subject: Re: [bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P
Date: Sat, 14 Jan 2023 19:24:33 -0500

[Message part 1 (text/plain, inline)]

On 14 Jan 2023 17:05, Karl Berry wrote:
>     most of the code directly preceding & following this line use @.
>     i.e. the vast majority of the current distdir logic.
> 
> Yeah.
> 
> If you feel like changing those @'s to AM_v_at while we're here, sounds
> good to me ... -k

i'd like to give it a bit more thought as to what the output should look
like in general in a non-verbose build, so i'll do it in a follow up
-mike

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.