GNU bug report logs - #60789
[PATCH] gnu: moreutils: Fix library path.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60789 in the body.
You can then email your comments to 60789 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: guix-patches <at> gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH] gnu: moreutils: Fix library path.
Date: Fri, 13 Jan 2023 20:58:01 +0000

Fix for the following error.

$ guix shell --container moreutils -- chronic ls
Can't locate IPC/Run.pm in @INC (you may need to install the IPC::Run module) (@INC contains: /gnu/store/hy6abswwv4d89zp464fw52z65fkzr7h5-perl-5.34.0/lib/perl5/site_perl/5.34.0/x86_64-linux-thread-multi /gnu/store/hy6abswwv4d89zp464fw52z65fkzr7h5-perl-5.34.0/lib/perl5/site_perl/5.34.0 /gnu/store/hy6abswwv4d89zp464fw52z65fkzr7h5-perl-5.34.0/lib/perl5/5.34.0/x86_64-linux-thread-multi /gnu/store/hy6abswwv4d89zp464fw52z65fkzr7h5-perl-5.34.0/lib/perl5/5.34.0) at /gnu/store/r7kzz76arp9h480h2rnpdg21yzd6pyk2-profile/bin/chronic line 57.
BEGIN failed--compilation aborted at /gnu/store/r7kzz76arp9h480h2rnpdg21yzd6pyk2-profile/bin/chronic line 57.

* gnu/packages/moreutils.scm: Set Perl library path for all scripts.
[inputs]: Add perl-ipc-run.
---
 gnu/packages/moreutils.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/moreutils.scm b/gnu/packages/moreutils.scm
index 5c9560530b..4b0b617bde 100644
--- a/gnu/packages/moreutils.scm
+++ b/gnu/packages/moreutils.scm
@@ -49,9 +49,11 @@ (define-public moreutils
            #~(modify-phases %standard-phases
                (add-after 'install 'wrap-program
                  (lambda _
-                   (wrap-program
-                       (string-append #$output "/bin/ts")
-                     `("PERL5LIB" ":" prefix (,(getenv "PERL5LIB"))))))
+                   (for-each
+                     (lambda (script)
+                       (wrap-program script
+                         `("PERL5LIB" ":" prefix (,(getenv "PERL5LIB")))))
+                     (find-files (string-append #$output "/bin")))))
                (delete 'configure))     ; no configure script
            #:make-flags
            #~(list (string-append "PREFIX=" #$output)
@@ -63,6 +65,7 @@ (define-public moreutils
                    (string-append "CC=" #$(cc-for-target)))))
     (inputs
      (list perl
+           perl-ipc-run
            perl-timedate
            perl-time-duration))
     ;; For building the manual pages.
-- 
2.39.0

Message #8 received at 60789 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: 60789 <at> debbugs.gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH v2] gnu: moreutils: Fix missing library.
Date: Fri, 13 Jan 2023 21:24:26 +0000

Same patch as before with a more proper log message.

* gnu/packages/moreutils.scm (moreutils): Fix missing library.
[arguments]<#:phases>{wrap-program}: Set Perl library path for all
scripts.
[inputs]: Add perl-ipc-run.
---
 gnu/packages/moreutils.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/moreutils.scm b/gnu/packages/moreutils.scm
index 5c9560530b..4b0b617bde 100644
--- a/gnu/packages/moreutils.scm
+++ b/gnu/packages/moreutils.scm
@@ -49,9 +49,11 @@ (define-public moreutils
            #~(modify-phases %standard-phases
                (add-after 'install 'wrap-program
                  (lambda _
-                   (wrap-program
-                       (string-append #$output "/bin/ts")
-                     `("PERL5LIB" ":" prefix (,(getenv "PERL5LIB"))))))
+                   (for-each
+                     (lambda (script)
+                       (wrap-program script
+                         `("PERL5LIB" ":" prefix (,(getenv "PERL5LIB")))))
+                     (find-files (string-append #$output "/bin")))))
                (delete 'configure))     ; no configure script
            #:make-flags
            #~(list (string-append "PREFIX=" #$output)
@@ -63,6 +65,7 @@ (define-public moreutils
                    (string-append "CC=" #$(cc-for-target)))))
     (inputs
      (list perl
+           perl-ipc-run
            perl-timedate
            perl-time-duration))
     ;; For building the manual pages.
-- 
2.39.0

Message #13 received at 60789-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Greg Hogan <code <at> greghogan.com>
Cc: 60789-done <at> debbugs.gnu.org
Subject: Re: bug#60789: [PATCH] gnu: moreutils: Fix library path.
Date: Sat, 28 Jan 2023 10:38:23 +0800

Greg Hogan <code <at> greghogan.com> writes:

> Same patch as before with a more proper log message.
>
> * gnu/packages/moreutils.scm (moreutils): Fix missing library.
> [arguments]<#:phases>{wrap-program}: Set Perl library path for all
> scripts.
> [inputs]: Add perl-ipc-run.

Applied, thank you!  Though I think only perl scripts needed to to
wrapped, but it's no harm for ELF executables too...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.