GNU bug report logs - #60793
[PATCH] gnu: Add julia-cfitsio-jll.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Sharlatan Hellseher <sharlatanus@HIDDEN>; Keywords: patch; dated Fri, 13 Jan 2023 22:18:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 60793 <at> debbugs.gnu.org:


Received: (at 60793) by debbugs.gnu.org; 17 Jan 2023 08:39:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 17 03:39:37 2023
Received: from localhost ([127.0.0.1]:35610 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pHhVJ-0005An-0u
	for submit <at> debbugs.gnu.org; Tue, 17 Jan 2023 03:39:37 -0500
Received: from mail-wr1-f45.google.com ([209.85.221.45]:44625)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1pHhVA-0005AG-Uw
 for 60793 <at> debbugs.gnu.org; Tue, 17 Jan 2023 03:39:33 -0500
Received: by mail-wr1-f45.google.com with SMTP id bk16so29742177wrb.11
 for <60793 <at> debbugs.gnu.org>; Tue, 17 Jan 2023 00:39:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
 :reply-to; bh=YQWIr+TnOsSE9hM2ex06hK/n7fhT0Fi66+aby1b5tbk=;
 b=P5mzqkpxeayA9xbN7nGYNv6ugxrUHlg+CrE8t+Hp5Dxi5uh2deZagDq9SHLH3QcQrW
 wt8GGdpnO5jvXka0P3UIguhMuhv0DygNnX6KyGh+n6UpAMFCpvMLYExyixvAVRj8Oa18
 yS+Mv+ASo+yLj8TJAn8pW8jDXPfGoGr7SPbHuI5CXnSMRC8k/LvXcFRFXEb/wBPctneV
 tiLOAorg/AUyKbG4PX1xkAVO/Nlc8/yQztovY+xUMxoLNVpRXE/kcWxo93c0obFjY++/
 34obhmgG7DvuBXrFsW+Vi2NqdDINOlX6gjpX79KGhSmoNfAKAdwAzw2gPwvfi8uLknfl
 8L1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=YQWIr+TnOsSE9hM2ex06hK/n7fhT0Fi66+aby1b5tbk=;
 b=dT6/o0/253skUmkEsST8tOwSsz18FofU8ZPpRjJVXekTT3J1zHeg/cbbDEKDyexM74
 Ic76BmbYWrpdb/whXu5sSHpYgUflouLdiNr77+4NBmE8+EMuWs1hG7+5Odd6s9kjbG78
 E0ggW+WjXj+Wazop9ukkkzcwP3ZKrMiDRJyV/UctqWU1FaNWjFIQZRm9Uk5qVQoj3W+k
 8KkatK/BDVMCXpLww6It23LMMTAMjixKeMZO2kS68+97eM5MW2KElVxz6DuUT3ervl5e
 nnDOSOfZUijPhvmzQ8LeEpCP2pbtvXqjh1M+9WtXpl6sMUC+CRxXJ5Okrp8fNxE0jxQI
 VqZg==
X-Gm-Message-State: AFqh2kqsUykf09hvvuRcQ2hRv7Ak6CQfNVAarml1maADOi/2ed4OFchL
 bR47w+ottrmVd1pigdygNWSVhchBJgc=
X-Google-Smtp-Source: AMrXdXvShoa2h43jOcyCngXKppKlP2d75wqmFthJbCmZzpfG7kuOoBes/5oetKFce2tmD44AjtSxPA==
X-Received: by 2002:a5d:634a:0:b0:2bd:e0e8:6951 with SMTP id
 b10-20020a5d634a000000b002bde0e86951mr413482wrw.5.1673944762836; 
 Tue, 17 Jan 2023 00:39:22 -0800 (PST)
Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e])
 by smtp.gmail.com with ESMTPSA id
 s2-20020adff802000000b00241bd7a7165sm28230594wrp.82.2023.01.17.00.39.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 17 Jan 2023 00:39:22 -0800 (PST)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Sharlatan Hellseher <sharlatanus@HIDDEN>
Subject: Re: [bug#60793] [PATCH] gnu: Add julia-cfitsio-jll.
In-Reply-To: <CAO+9K5rq73BAw28ewe3hvOuuCvq8u3=spKy2ZC_YOBDU73=P5w@HIDDEN>
References: <20230113221658.8158-1-sharlatanus@HIDDEN>
 <87zgais8z5.fsf@HIDDEN>
 <CAO+9K5rq73BAw28ewe3hvOuuCvq8u3=spKy2ZC_YOBDU73=P5w@HIDDEN>
Date: Tue, 17 Jan 2023 09:03:53 +0100
Message-ID: <86a62hoady.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 60793
Cc: 60793 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

On Mon, 16 Jan 2023 at 20:36, Sharlatan Hellseher <sharlatanus@HIDDEN> w=
rote:

> Yes it's a long journey to bring Julia's Astronomical projects to
> Guix.

Cool!  Thank you for this effort.


> I've got a question on how to group Julia packages related just to
> Astronomy. gnu/packages/astronomy.scm contains python bindings to cfitsio,
> wcs and erfa would I follow the same pass and add Julia packages next to
> them?

Well, I think all Julia packages should go to gnu/packages/julia-xyz.scm
with the prefix =E2=80=99julia-=E2=80=99 for the symbol and the package nam=
e.

If, or when, the Julia packages related to astronomy will be too many,
then it will be possible to just move them to
gnu/packages/julia-astronomy.scm.

Last, when writing new Julia packages, please consider some implicit
conventions in these Julia-related modules:

 + sort alphabetically, package name and inputs,

 + if one test does not pass, please disallow it using something like:
   =E2=80=99#~(modify-phases %standard-phases (add-after 'link-depot
   'skip-failing-test=E2=80=99 (gexp and after link-depot),

 + try set the packages used by the tests under native-inputs.

Cheers,
simon




Information forwarded to guix-patches@HIDDEN:
bug#60793; Package guix-patches. Full text available.

Message received at 60793 <at> debbugs.gnu.org:


Received: (at 60793) by debbugs.gnu.org; 16 Jan 2023 20:36:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 16 15:36:22 2023
Received: from localhost ([127.0.0.1]:34934 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pHWDO-0000iQ-3B
	for submit <at> debbugs.gnu.org; Mon, 16 Jan 2023 15:36:22 -0500
Received: from mail-qk1-f172.google.com ([209.85.222.172]:41492)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sharlatanus@HIDDEN>) id 1pHWDL-0000iB-L6
 for 60793 <at> debbugs.gnu.org; Mon, 16 Jan 2023 15:36:20 -0500
Received: by mail-qk1-f172.google.com with SMTP id w21so1743942qkf.8
 for <60793 <at> debbugs.gnu.org>; Mon, 16 Jan 2023 12:36:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=JGk6NYCqvLSBcqM+ZTpfMxdPLoF5ykTRh9sC4XjDsCo=;
 b=PtDsl3LbyamiMc6GVl/CZAVWoseAhWx8I7oRvR1ZN9bcKg48QDozrWvDh0YCL1I7bt
 JrAOjRb5EKYjsfqZpqcCeELyhGs2w6YnTVWPf2R0M9cbTer2+WQhcXX86rHT/SZBHp5B
 zaQePId35OhnMwu1xhzwUfjlzu+8sRNlZgytLzErAuN8kIp0M7gyPz0zLMwkWd6lWy9T
 Er9Ykr1yHpBx908AHoQUeoRNBn4xx+JCl5f53JDd8i65rVtCVgvmC+veFVDIsQE3/D6S
 O23rRjUmvfurkcDPv4Ir3MBnodtBb+z3VzUGnpaIXTerrrMNP3lsQTFkVSCInbbNMCXU
 F5Xw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=JGk6NYCqvLSBcqM+ZTpfMxdPLoF5ykTRh9sC4XjDsCo=;
 b=W6g/dDQtAhiO7KREKE5Q/ykaVi5y8Y4sQR6ncs3REXsBf96GbdynjXmsp65W5WvVaI
 +ISA4UzmkfnXejoMs9ScRLOiXcGC+AX/x8AOYbZ9OvuFLKBKmDuSu0UGw0mEfMFDAgfW
 UytecDDu+zP+oCOeZZkAL/FNwyIRfFBLhIVigtYbjKScggjr6AByq2bIgZeydBNceLwC
 SWxuuOzh6zeRVTq1p21iMPxarDGUt6y1ELV8VqZGbFGctcsE65yL8kssIGUZBD1e2Vjs
 cCwGn50OEXqy55HS1jMdJIexhdwv80BikWm2FYM6K8bIKI6yZ0nSsPE5n47sJ+EjoXFj
 3nXg==
X-Gm-Message-State: AFqh2kr83SJdQJuHVXbQT6CS24DdPK10GXLgxec4KtSWG3AFp4MUgS8S
 Yk/vH6urohnKQfDubjy27YeXFmjAgAhtYlNFE58=
X-Google-Smtp-Source: AMrXdXsB0kKsyXd0vdoBP/Y5Nx8vW68+qEPPt3t31MVZV9JiHF6ws5YP4FL+P+72dsulO+TkfEgxl8NRgXugvDjtQlk=
X-Received: by 2002:a37:ef0b:0:b0:705:48ec:a949 with SMTP id
 j11-20020a37ef0b000000b0070548eca949mr9252qkk.418.1673901374030; Mon, 16 Jan
 2023 12:36:14 -0800 (PST)
MIME-Version: 1.0
References: <20230113221658.8158-1-sharlatanus@HIDDEN>
 <87zgais8z5.fsf@HIDDEN>
In-Reply-To: <87zgais8z5.fsf@HIDDEN>
From: Sharlatan Hellseher <sharlatanus@HIDDEN>
Date: Mon, 16 Jan 2023 20:36:03 +0000
Message-ID: <CAO+9K5rq73BAw28ewe3hvOuuCvq8u3=spKy2ZC_YOBDU73=P5w@HIDDEN>
Subject: Re: [bug#60793] [PATCH] gnu: Add julia-cfitsio-jll.
To: Simon Tournier <zimon.toutoune@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000c9c70105f2678833"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 60793
Cc: 60793 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--000000000000c9c70105f2678833
Content-Type: text/plain; charset="UTF-8"

Hi Simon,

Thanks for your review and comments.

Yes it's a long journey to bring Julia's Astronomical projects to Guix.

Here is my plan:
https://git.sr.ht/~hellseher/ffab/tree/main/item/org/astronomy.org#L1202

cfitsio, wcs and erfa would be essential jll bindings for base Julia
packages.

I've got a question on how to group Julia packages related just to
Astronomy. gnu/packages/astronomy.scm contains python bindings to cfitsio,
wcs and erfa would I follow the same pass and add Julia packages next to
them?

Regards,
Oleg

On Mon, 16 Jan 2023, 18:36 Simon Tournier, <zimon.toutoune@HIDDEN> wrote:

> Hi,
>
> On ven., 13 janv. 2023 at 22:16, Sharlatan Hellseher <
> sharlatanus@HIDDEN> wrote:
> > * gnu/packages/julia-jll.scm (julia-cfitsio-jll): New variable.
>
> Thank for this patch.
>
> Well, out of curiosity, why is this package required?  I mean, usually
> JLL packages are binding to access from Julia to some libraries.
> Therefore, do you plan to use this package for another regular Julia
> package?
>
>
> > +  #:use-module (guix gexp)
>
> [...]
>
> > +      #~(modify-phases %standard-phases
> > +          (add-after 'link-depot 'override-binary-path
> > +            (lambda* (#:key inputs #:allow-other-keys)
>
> [...]
>
> > +                     (assoc-ref inputs "cfitsio") "\")\n"))))
>
> I do not think (guix gexp) is required here.  For instance, other
> packages just use, for instance:
>
> --8<---------------cut here---------------start------------->8---
>     (arguments
>      '(#:tests? #f ; no runtests
>        #:phases
>        (modify-phases %standard-phases
>          (add-after 'link-depot 'override-binary-path
>            (lambda* (#:key inputs #:allow-other-keys)
>              (map
>                (lambda (wrapper)
>                  (substitute* wrapper
>                    (("artifact\"FFMPEG\"")
>                     (string-append "\"" (assoc-ref inputs "ffmpeg")
> "\""))))
>                ;; There's a Julia file for each platform, override them all
>                (find-files "src/wrappers/" "\\.jl$")))))))
> --8<---------------cut here---------------end--------------->8---
>
>
> Cheers,
> simon
>

--000000000000c9c70105f2678833
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Hi Simon,<div dir=3D"auto"><br></div><div dir=3D"auto">Th=
anks for your review and comments.</div><div dir=3D"auto"><br></div><div di=
r=3D"auto">Yes it&#39;s a long journey to bring Julia&#39;s Astronomical pr=
ojects to Guix.</div><div dir=3D"auto"><br></div><div dir=3D"auto">Here is =
my plan:=C2=A0<a href=3D"https://git.sr.ht/~hellseher/ffab/tree/main/item/o=
rg/astronomy.org#L1202">https://git.sr.ht/~hellseher/ffab/tree/main/item/or=
g/astronomy.org#L1202</a></div><div dir=3D"auto"><br></div><div dir=3D"auto=
">cfitsio, wcs and erfa would be essential jll bindings for base Julia pack=
ages.</div><div dir=3D"auto"><br></div><div dir=3D"auto">I&#39;ve got a que=
stion on how to group Julia packages related just to Astronomy. gnu/package=
s/astronomy.scm contains python bindings to cfitsio, wcs and erfa would I f=
ollow the same pass and add Julia packages next to them?</div><div dir=3D"a=
uto"><br></div><div dir=3D"auto">Regards,</div><div dir=3D"auto">Oleg</div>=
</div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">=
On Mon, 16 Jan 2023, 18:36 Simon Tournier, &lt;<a href=3D"mailto:zimon.tout=
oune@HIDDEN" target=3D"_blank" rel=3D"noreferrer">zimon.toutoune@HIDDEN=
om</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
On ven., 13 janv. 2023 at 22:16, Sharlatan Hellseher &lt;<a href=3D"mailto:=
sharlatanus@HIDDEN" rel=3D"noreferrer noreferrer" target=3D"_blank">shar=
latanus@HIDDEN</a>&gt; wrote:<br>
&gt; * gnu/packages/julia-jll.scm (julia-cfitsio-jll): New variable.<br>
<br>
Thank for this patch.<br>
<br>
Well, out of curiosity, why is this package required?=C2=A0 I mean, usually=
<br>
JLL packages are binding to access from Julia to some libraries.<br>
Therefore, do you plan to use this package for another regular Julia<br>
package?<br>
<br>
<br>
&gt; +=C2=A0 #:use-module (guix gexp)<br>
<br>
[...]<br>
<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 #~(modify-phases %standard-phases<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (add-after &#39;link-depot &#39;ov=
erride-binary-path<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda* (#:key inputs #:al=
low-other-keys)<br>
<br>
[...]<br>
<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0(assoc-ref inputs &quot;cfitsio&quot;) &quot;\&quot;)\n&quot;))))<br=
>
<br>
I do not think (guix gexp) is required here.=C2=A0 For instance, other<br>
packages just use, for instance:<br>
<br>
--8&lt;---------------cut here---------------start-------------&gt;8---<br>
=C2=A0 =C2=A0 (arguments<br>
=C2=A0 =C2=A0 =C2=A0&#39;(#:tests? #f ; no runtests<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0#:phases<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0(modify-phases %standard-phases<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(add-after &#39;link-depot &#39;override-=
binary-path<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(lambda* (#:key inputs #:allow-oth=
er-keys)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(map<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(lambda (wrapper)<br=
>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(substitute* =
wrapper<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0((&quo=
t;artifact\&quot;FFMPEG\&quot;&quot;)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (stri=
ng-append &quot;\&quot;&quot; (assoc-ref inputs &quot;ffmpeg&quot;) &quot;\=
&quot;&quot;))))<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; There&#39;s a Jul=
ia file for each platform, override them all<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(find-files &quot;sr=
c/wrappers/&quot; &quot;\\.jl$&quot;)))))))<br>
--8&lt;---------------cut here---------------end---------------&gt;8---<br>
<br>
<br>
Cheers,<br>
simon<br>
</blockquote></div>

--000000000000c9c70105f2678833--




Information forwarded to guix-patches@HIDDEN:
bug#60793; Package guix-patches. Full text available.

Message received at 60793 <at> debbugs.gnu.org:


Received: (at 60793) by debbugs.gnu.org; 16 Jan 2023 18:36:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 16 13:36:53 2023
Received: from localhost ([127.0.0.1]:34857 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pHULl-00063U-6O
	for submit <at> debbugs.gnu.org; Mon, 16 Jan 2023 13:36:53 -0500
Received: from mail-wm1-f44.google.com ([209.85.128.44]:53894)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1pHULi-00062j-GM
 for 60793 <at> debbugs.gnu.org; Mon, 16 Jan 2023 13:36:51 -0500
Received: by mail-wm1-f44.google.com with SMTP id l8so3511971wms.3
 for <60793 <at> debbugs.gnu.org>; Mon, 16 Jan 2023 10:36:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=JaTJNtfpTS/nYF7ibdF2FETC1QvmfxE/LQyMngPmqIY=;
 b=UCCI7P17Azyn3I3xDl2c6Gof+aad0Fuu5MviBd8y0KqSfoAGsT/pSxBaIkdltKvbz4
 1FhzcO52d++JFL42FzIaTw6GpHstC9FtiUnHxXqUjxkpd8T2ySOhAZD8wtrUpGPOR5xr
 nXFmAq/mujNRzOs+moajD5LG8+H/nq+FF3SWP8tdKUxEOI5xpUuGa+XrHj52dTNdCpxf
 WvSC9mTMwQtCq5LCdjl+ReOJLrXT7Q3G8xdm/cFrK9aK0o1Q6evFjPV4KtlBwB28GR0g
 Nl6b55z/gGZuDTazn3BIP1fj6Jcz01ynObJItQ4ymdNNJAGqRiwdQeP1GwSntXxapb5k
 N/sw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=JaTJNtfpTS/nYF7ibdF2FETC1QvmfxE/LQyMngPmqIY=;
 b=HcgLS0769QvivFB7/PIkOybSFM7m/vykqReqoWDwwHvjlhENmmhxXF7WXZriZDom+e
 3z/7rvT3I+gxoS3GUDiOuM59xVD238djAsGtQPZsoFAO+1PE56Oa80g8RikHYEq8u947
 aA2Fkiyw4dp3obm7x5+P3WZzzpWoalzrjDfBgO1CV29J+z1BGGYyRtb2lt/LeynpPx7j
 mTRkrhEmr89kosaPLYZZPXXWzNHoV2FbHtAXGLmVsZN2jfokLQf5Uwhy6olCW1QXyWg2
 p8938QvUve0XulQdZMbYtcV+6j5+ybEXIMR8qUQTer3KQK0672IqAAjSo8alGqgICj6F
 FyNQ==
X-Gm-Message-State: AFqh2kric0DwgePMvFeqt3jfHNYBByQ+ZZ89fzKKWb+wI0mFtnbuJjOD
 jeZ9AxmUd8C4WpwheHXMgZLys+uQXQM=
X-Google-Smtp-Source: AMrXdXuv2OxJhqemV5yF8hv4j3v9TsXN5bioQ+sMS4VrdeLw+xMmNpqX/Hiunuq3wRnsa/jzXHMDCQ==
X-Received: by 2002:a7b:c849:0:b0:3db:303:2724 with SMTP id
 c9-20020a7bc849000000b003db03032724mr132963wml.1.1673894204974; 
 Mon, 16 Jan 2023 10:36:44 -0800 (PST)
Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id
 g15-20020a05600c4ecf00b003daff80f16esm3682228wmq.27.2023.01.16.10.36.44
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 16 Jan 2023 10:36:44 -0800 (PST)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Sharlatan Hellseher <sharlatanus@HIDDEN>, 60793 <at> debbugs.gnu.org
Subject: Re: [bug#60793] [PATCH] gnu: Add julia-cfitsio-jll.
In-Reply-To: <20230113221658.8158-1-sharlatanus@HIDDEN>
References: <20230113221658.8158-1-sharlatanus@HIDDEN>
Date: Mon, 16 Jan 2023 18:08:30 +0100
Message-ID: <87zgais8z5.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 60793
Cc: Sharlatan Hellseher <sharlatanus@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

On ven., 13 janv. 2023 at 22:16, Sharlatan Hellseher <sharlatanus@HIDDEN> wrote:
> * gnu/packages/julia-jll.scm (julia-cfitsio-jll): New variable.

Thank for this patch.

Well, out of curiosity, why is this package required?  I mean, usually
JLL packages are binding to access from Julia to some libraries.
Therefore, do you plan to use this package for another regular Julia
package?


> +  #:use-module (guix gexp)

[...]

> +      #~(modify-phases %standard-phases
> +          (add-after 'link-depot 'override-binary-path
> +            (lambda* (#:key inputs #:allow-other-keys)

[...]

> +                     (assoc-ref inputs "cfitsio") "\")\n"))))

I do not think (guix gexp) is required here.  For instance, other
packages just use, for instance:

--8<---------------cut here---------------start------------->8---
    (arguments
     '(#:tests? #f ; no runtests
       #:phases
       (modify-phases %standard-phases
         (add-after 'link-depot 'override-binary-path
           (lambda* (#:key inputs #:allow-other-keys)
             (map
               (lambda (wrapper)
                 (substitute* wrapper
                   (("artifact\"FFMPEG\"")
                    (string-append "\"" (assoc-ref inputs "ffmpeg") "\""))))
               ;; There's a Julia file for each platform, override them all
               (find-files "src/wrappers/" "\\.jl$")))))))
--8<---------------cut here---------------end--------------->8---


Cheers,
simon




Information forwarded to guix-patches@HIDDEN:
bug#60793; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 Jan 2023 22:17:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 13 17:17:07 2023
Received: from localhost ([127.0.0.1]:52637 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pGSMF-0006Wf-53
	for submit <at> debbugs.gnu.org; Fri, 13 Jan 2023 17:17:07 -0500
Received: from lists.gnu.org ([209.51.188.17]:43388)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sharlatanus@HIDDEN>) id 1pGSMD-0006WY-AO
 for submit <at> debbugs.gnu.org; Fri, 13 Jan 2023 17:17:05 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <sharlatanus@HIDDEN>)
 id 1pGSMD-00064Y-5U
 for guix-patches@HIDDEN; Fri, 13 Jan 2023 17:17:05 -0500
Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <sharlatanus@HIDDEN>)
 id 1pGSMB-0005rr-06
 for guix-patches@HIDDEN; Fri, 13 Jan 2023 17:17:04 -0500
Received: by mail-wr1-x42c.google.com with SMTP id z5so21247736wrt.6
 for <guix-patches@HIDDEN>; Fri, 13 Jan 2023 14:17:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=zjSA4sSaoWiU7t7aNS5kH5UgqxRKdkg+MLFIwF7rBDo=;
 b=GYBDSis8iJx8S2z9Lz9/3BLK5V58S2nF6qcp9eKGbaGAJT95ibzYCqeziVZohA3nfu
 pdKTNVW9isnXsY3MV1YFMcTFcQehgRmFNpRpV8TYB74tss3E1ZhfG3w1GkAXW+cpGmUX
 BTQN4RFDO6XmEnslrpccLmaikq4efClQJxEiMpf28mlaAn8czyB19rAzaFH2PSX9JKlh
 tFZptmFIgkTiXz9QdxRmLQcTEokCFZqZv9HdyUIbeFzmyL+FclxpEWUKBtQQp9aTi3uz
 gYw5c35w1qs5qJuUUrxiENEdBi0ERWdCAkW14HirCoRjjLGN93fNhiLXbfe/wobOUKer
 YQOw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=zjSA4sSaoWiU7t7aNS5kH5UgqxRKdkg+MLFIwF7rBDo=;
 b=AY5OEWzaLzcGFHct6BfMELRktJg5xfBhSQOD1ixJ8+/RVf6dPkMhgvs4co8rfEPWM8
 dlcmr1V4eTJgHuaJhd6YsjPsu2zbHUhXI3s8iZxGHvkwUwVL1HVhXLeoKUuUReP9COva
 XJhkZAP7Z2BwgWFcRIDg0SJGUHO0ugs/uUq7OvEjv5lGW8HZqEPg9STgLkxUzp364+1x
 A10JfpEyUBz/sulkycQng4bnLRMxy+DQ8jgZfs5skk3vSVsfwTqCGA261/SjKPswPm6K
 1CRr05blRUGGaUv7vL2I0acI/gkidWy358KW4qBdUMx39Wc9yuP48U6RDYo7JZ4WWg9s
 fOgw==
X-Gm-Message-State: AFqh2kqKufKvYQ/gG9uADqBbimkcBYHpnjlTuYXpZqUyFTSM5Ic5exQD
 KLiv09+Zn4ceFCCjDzf0yDskceE5Tfw=
X-Google-Smtp-Source: AMrXdXuhZRMiSeBHrVI550T115MKMEyDb1ku+vGbunQngM2RkzeDQGMzcETHUKvcYp6S567FaqZF/A==
X-Received: by 2002:adf:ec90:0:b0:2bb:5d8c:9575 with SMTP id
 z16-20020adfec90000000b002bb5d8c9575mr17593192wrn.12.1673648221184; 
 Fri, 13 Jan 2023 14:17:01 -0800 (PST)
Received: from guxtil.incerto.xyz
 (cpc100856-bagu15-2-0-cust368.1-3.cable.virginm.net. [82.25.93.113])
 by smtp.gmail.com with ESMTPSA id
 w8-20020adf8bc8000000b002bdc39849d1sm7647241wra.44.2023.01.13.14.17.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 13 Jan 2023 14:17:00 -0800 (PST)
From: Sharlatan Hellseher <sharlatanus@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add julia-cfitsio-jll.
Date: Fri, 13 Jan 2023 22:16:58 +0000
Message-Id: <20230113221658.8158-1-sharlatanus@HIDDEN>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::42c;
 envelope-from=sharlatanus@HIDDEN; helo=mail-wr1-x42c.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: Sharlatan Hellseher <sharlatanus@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

* gnu/packages/julia-jll.scm (julia-cfitsio-jll): New variable.
---
 gnu/packages/julia-jll.scm | 45 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/julia-jll.scm b/gnu/packages/julia-jll.scm
index 2b0f644736..364088c4b0 100644
--- a/gnu/packages/julia-jll.scm
+++ b/gnu/packages/julia-jll.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@HIDDEN>
 ;;; Copyright © 2021 Efraim Flashner <efraim@HIDDEN>
 ;;; Copyright © 2021 Jean-Baptiste Volatier <jbv@HIDDEN>
+;;; Copyright © 2023 Sharlatan Hellseher <sharlatanus@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21,12 +22,14 @@
 
 (define-module (gnu packages julia-jll)
   #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix gexp)
   #:use-module (guix packages)
   #:use-module (guix git-download)
   #:use-module (guix utils)
   #:use-module (guix build-system julia)
   #:use-module (gnu packages)
   #:use-module (gnu packages audio)
+  #:use-module (gnu packages astronomy)
   #:use-module (gnu packages base)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages fontutils)
@@ -146,6 +149,48 @@ (define-public julia-cairo-jll
     (description "This package provides a wrapper for the cairo library.")
     (license license:expat)))
 
+(define-public julia-cfitsio-jll
+  (package
+    (name "julia-cfitsio-jll")
+    (version "4.0.0+0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/JuliaBinaryWrappers/CFITSIO_jll.jl")
+             (commit (string-append "CFITSIO-v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1k0mqmpyfjr3ibcmda08llw8m166zw0n3lh5y5aj81q37lrxw990"))))
+    (build-system julia-build-system)
+    (arguments
+     (list
+      #:tests? #f ; no runtests
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'link-depot 'override-binary-path
+            (lambda* (#:key inputs #:allow-other-keys)
+              (map
+               (lambda (wrapper)
+                 (substitute* wrapper
+                   (("using LibCURL_jll") "") ; Not require to download cfitsio.
+                   (("using Zlib_jll") "") ; Not require to upnpack not donwloaded archvie.
+                   (("generate_init_header.*") "generate_init_header()\n" )
+                   (("generate_wrapper_header.*")
+                    (string-append
+                     "generate_wrapper_header(\"CFITSIO\", \""
+                     (assoc-ref inputs "cfitsio") "\")\n"))))
+               ;; There's a Julia file for each platform, override them all
+               (find-files "src/wrappers/" "\\.jl$")))))))
+    (inputs
+     (list cfitsio))
+    (propagated-inputs
+     (list julia-jllwrappers))
+    (home-page "https://github.com/JuliaBinaryWrappers/CFITSIO_jll.jl")
+    (synopsis "cfitsio library wrappers")
+    (description "This package provides a wrapper for the cfitsio library.")
+    (license license:expat)))
+
 (define-public julia-compilersupportlibraries-jll
   (package
     (name "julia-compilersupportlibraries-jll")
-- 
2.38.1





Acknowledgement sent to Sharlatan Hellseher <sharlatanus@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#60793; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 17 Jan 2023 08:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.