GNU bug report logs - #60795
28.2; `diary-list-entries' hides the interesting message done in `diary-display-no-entries'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60795 in the body.
You can then email your comments to 60795 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Farblos" <AKFKQU.9DF7RP <at> vodafonemail.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.2; `diary-list-entries' hides the interesting message done in
 `diary-display-no-entries'
Date: Fri, 13 Jan 2023 22:54:17 +0100

`diary-list-entries' hides the interesting status message done in
`diary-display-no-entries' ("No diary entries for %s") with a less
important progress message ("Preparing diary...done").

To reproduce:

  # ensure you do not clobber anything important ...
  $ test -f ~/.emacs/diary && mv ~/.emacs/diary ~/.emacs/diary.bak
  $ cp /dev/null ~/.emacs/diary
  $ emacs -Q
  M-x diary RET

Observe the minibuffer showing "Preparing diary...done" and check the
message buffer to find the really relevant message "No diary entries for
Friday, January 13, 2023" issued just before that.

This used to work at least in Emacs, well, 23.4.1.

In GNU Emacs 28.2 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
 of 2022-12-20, modified by Debian built on x86-csail-01
Windowing system distributor 'The X.Org Foundation', version 11.0.12101005
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/libexec
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-libsystemd --with-pop=yes
 --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/28.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/28.2/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --with-mailutils
 --with-native-compilation --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/libexec
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-libsystemd --with-pop=yes
 --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/28.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/28.2/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --with-mailutils
 --with-native-compilation --with-x=yes --with-x-toolkit=lucid
 --with-toolkit-scroll-bars --without-gsettings 'CFLAGS=-g -O2
 -ffile-prefix-map=/build/emacs-OltuXQ/emacs-28.2+1=. -fstack-protector-strong
 -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time
 -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2
LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XAW3D XDBE XIM XPM LUCID ZLIB

Important settings:
  value of $LC_COLLATE: POSIX
  value of $LC_TIME: POSIX
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Outline

Minor modes in effect:
  shell-dirtrack-mode: t
  display-time-mode: t
  delete-selection-mode: t
  tooltip-mode: t
  show-paren-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t

Load-path shadows:
~/work/elisp/refold hides ~/etc/elisp/refold
~/work/elisp/precious-text hides ~/etc/elisp/precious-text
~/work/elisp/patch hides ~/etc/elisp/patch
~/work/elisp/bbdb-diary hides ~/etc/elisp/bbdb-diary
/usr/share/emacs/site-lisp/elpa/htmlize-1.56/htmlize hides /usr/share/emacs/site-lisp/elpa-src/htmlize-1.56/htmlize
/usr/share/emacs/site-lisp/elpa/htmlize-1.56/htmlize-autoloads hides /usr/share/emacs/site-lisp/elpa-src/htmlize-1.56/htmlize-autoloads
/usr/share/emacs/site-lisp/elpa/htmlize-1.56/htmlize-pkg hides /usr/share/emacs/site-lisp/elpa-src/htmlize-1.56/htmlize-pkg
/usr/share/emacs/site-lisp/elpa/markdown-mode-2.5/markdown-mode-pkg hides /usr/share/emacs/site-lisp/elpa-src/markdown-mode-2.5/markdown-mode-pkg
/usr/share/emacs/site-lisp/elpa/markdown-mode-2.5/markdown-mode hides /usr/share/emacs/site-lisp/elpa-src/markdown-mode-2.5/markdown-mode
/usr/share/emacs/site-lisp/elpa/markdown-mode-2.5/markdown-mode-autoloads hides /usr/share/emacs/site-lisp/elpa-src/markdown-mode-2.5/markdown-mode-autoloads
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-xml-common hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-xml-common
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-http hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-http
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-poem hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-poem
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-backlink hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-backlink
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-wiki hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-wiki
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-split hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-split
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-latex hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-latex
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-ipc hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-ipc
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-context hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-context
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-project hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-project
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-regexps hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-regexps
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-groff hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-groff
/usr/share/emacs/site-lisp/elpa/muse-3.20/httpd hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/httpd
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-pkg hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-pkg
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-import-xml hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-import-xml
/usr/share/emacs/site-lisp/elpa/muse-3.20/cgi hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/cgi
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-texinfo hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-texinfo
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-autoloads hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-autoloads
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-colors hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-colors
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-import-docbook hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-import-docbook
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-blosxom hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-blosxom
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-mode hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-mode
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-html hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-html
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-import-latex hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-import-latex
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-protocols hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-protocols
/usr/share/emacs/site-lisp/elpa/muse-3.20/htmlize-hack hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/htmlize-hack
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-xml hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-xml
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-message hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-message
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-protocol-iw hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-protocol-iw
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-latex2png hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-latex2png
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-ikiwiki hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-ikiwiki
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-mathml hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-mathml
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-cite hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-cite
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-docbook hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-docbook
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-journal hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-journal
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-book hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-book
/usr/share/emacs/site-lisp/elpa/muse-3.20/muse-publish hides /usr/share/emacs/site-lisp/elpa-src/muse-3.20/muse-publish
/usr/share/emacs/site-lisp/elpa/simple-httpd-1.5.1/simple-httpd hides /usr/share/emacs/site-lisp/elpa-src/simple-httpd-1.5.1/simple-httpd
/usr/share/emacs/site-lisp/elpa/simple-httpd-1.5.1/simple-httpd-pkg hides /usr/share/emacs/site-lisp/elpa-src/simple-httpd-1.5.1/simple-httpd-pkg
/usr/share/emacs/site-lisp/elpa/simple-httpd-1.5.1/simple-httpd-autoloads hides /usr/share/emacs/site-lisp/elpa-src/simple-httpd-1.5.1/simple-httpd-autoloads

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies
mm-encode mail-parse rfc2231 gmm-utils mailheader sendmail noutline
outline bbdb-mua gnus nnheader gnus-util rmail rmail-loaddefs rfc2047
rfc2045 ietf-drums mail-utils mm-util mail-prsvr tex-mode latexenc
bbdb-tex shell pcomplete files-x grep compile comint ansi-color ring
rect bbdb-migrate bbdb-com pcase crm mailabbrev bbdb derived bbdb-site
timezone vc-filewise ediff ediff-merg ediff-mult ediff-wind ediff-diff
ediff-help ediff-init ediff-util vc eieio-opt shortdoc
text-property-search ede/speedbar ede/files ede ede/detect ede/base
ede/auto ede/source eieio-base eieio-speedbar speedbar ezimage dframe
eieio-custom cedet mule-util info edebug cal-coptic cal-julian help-fns
radix-tree cl-print debug backtrace thingatpt misearch multi-isearch
vc-dispatcher parse-time iso8601 time-date vc-cvs vc-rcs refold
easy-mmode cus-edit pp cus-start wid-edit jka-compr appt diary-lib
diary-loaddefs cal-menu calendar cal-loaddefs comp comp-cstr warnings rx
cl-extra help-mode patch find-func time delsel cus-load server advice
finder-inf bbdb-loaddefs muse-autoloads package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie url-domsuf
url-util mailcap url-handlers url-parse auth-source cl-seq eieio
eieio-core cl-macs eieio-loaddefs password-cache json subr-x map
url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting font-render-setting cairo x-toolkit x
multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 376078 57378)
 (symbols 48 18860 1)
 (strings 32 73693 4365)
 (string-bytes 1 2739436)
 (vectors 16 42912)
 (vector-slots 8 1425719 127351)
 (floats 8 142 428)
 (intervals 56 16878 0)
 (buffers 992 32))

Message #8 received at 60795 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Farblos" <AKFKQU.9DF7RP <at> vodafonemail.de>
Cc: 60795 <at> debbugs.gnu.org
Subject: Re: bug#60795: 28.2;
 `diary-list-entries' hides the interesting message done in
 `diary-display-no-entries'
Date: Sat, 14 Jan 2023 15:13:04 +0200

> Date: Fri, 13 Jan 2023 22:54:17 +0100
> From:  "Farblos" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> `diary-list-entries' hides the interesting status message done in
> `diary-display-no-entries' ("No diary entries for %s") with a less
> important progress message ("Preparing diary...done").
> 
> To reproduce:
> 
>   # ensure you do not clobber anything important ...
>   $ test -f ~/.emacs/diary && mv ~/.emacs/diary ~/.emacs/diary.bak
>   $ cp /dev/null ~/.emacs/diary
>   $ emacs -Q
>   M-x diary RET
> 
> Observe the minibuffer showing "Preparing diary...done" and check the
> message buffer to find the really relevant message "No diary entries for
> Friday, January 13, 2023" issued just before that.
> 
> This used to work at least in Emacs, well, 23.4.1.

Thank you for your report.

Does the patch below give good results?

diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el
index b90ed71..80fc66f 100644
--- a/lisp/calendar/diary-lib.el
+++ b/lisp/calendar/diary-lib.el
@@ -880,7 +880,10 @@ diary-list-entries
                                    (original-date original-date))
                     (run-hooks 'diary-hook))))))
         (and temp-buff (buffer-name temp-buff) (kill-buffer temp-buff)))
-      (or d-incp (message "Preparing diary...done"))
+      (or d-incp
+          ;; Don't clobber messages displayed by preparing the diary.
+          (not (equal (current-message) "Preparing diary..."))
+          (message "Preparing diary...done"))
       diary-entries-list)))
 
 (defun diary-unhide-everything ()

Message #11 received at 60795 <at> debbugs.gnu.org (full text, mbox):

From: "Farblos" <AKFKQU.9DF7RP <at> vodafonemail.de>
To: "Eli Zaretskii" <eliz <at> gnu.org>
Cc: 60795 <at> debbugs.gnu.org
Subject: Re: bug#60795: 28.2;
 `diary-list-entries' hides the interesting message done
 in`diary-display-no-entries'
Date: Sat, 14 Jan 2023 22:41:27 +0100

> Does the patch below give good results?

Yes it does!  Plus I learned that there is `current-message', thanks a lot.

Message #16 received at 60795-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Farblos" <AKFKQU.9DF7RP <at> vodafonemail.de>
Cc: 60795-done <at> debbugs.gnu.org
Subject: Re: bug#60795: 28.2;
 `diary-list-entries' hides the interesting message done
 in`diary-display-no-entries'
Date: Sun, 15 Jan 2023 08:12:56 +0200

> From: "Farblos" <AKFKQU.9DF7RP <at> vodafonemail.de>
> CC: 60795 <at> debbugs.gnu.org
> Date: Sat, 14 Jan 2023 22:41:27 +0100
> 
> > Does the patch below give good results?
> 
> Yes it does!  Plus I learned that there is `current-message', thanks a lot.

Thanks, installed on the emacs-29 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.