GNU bug report logs - #60896
make error if not in 7z format

Previous Next

Package: emacs;

Reported by: Dan Jacobson <jidanni <at> jidanni.org>

Date: Wed, 18 Jan 2023 00:53:02 UTC

Severity: normal

Tags: moreinfo

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60896 in the body.
You can then email your comments to 60896 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#60896; Package emacs. (Wed, 18 Jan 2023 00:53:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dan Jacobson <jidanni <at> jidanni.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 18 Jan 2023 00:53:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: dired-view-file vs. .7z
Date: Wed, 18 Jan 2023 08:52:06 +0800
dired-view-file knows how to deal with .gz,
but not .7z.

$ apropos 7z
7z (1)               - A file archiver with high compression ratio format
7za (1)              - A file archiver with high compression ratio format
7zr (1)              - A file archiver with high compression ratio format
p7zip (1)            - Wrapper on 7-Zip file archiver with high compression ratio




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60896; Package emacs. (Wed, 18 Jan 2023 13:29:01 GMT) Full text and rfc822 format available.

Message #8 received at 60896 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dan Jacobson <jidanni <at> jidanni.org>
Cc: 60896 <at> debbugs.gnu.org
Subject: Re: bug#60896: dired-view-file vs. .7z
Date: Wed, 18 Jan 2023 15:28:40 +0200
> From: Dan Jacobson <jidanni <at> jidanni.org>
> Date: Wed, 18 Jan 2023 08:52:06 +0800
> 
> dired-view-file knows how to deal with .gz,
> but not .7z.

It does here, at least with Emacs 27 and later.




Added tag(s) moreinfo. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 18 Jan 2023 22:10:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60896; Package emacs. (Wed, 25 Jan 2023 02:52:02 GMT) Full text and rfc822 format available.

Message #13 received at 60896 <at> debbugs.gnu.org (full text, mbox):

From: Dan Jacobson <jidanni <at> jidanni.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60896 <at> debbugs.gnu.org, control <at> debbugs.gnu.org
Subject: Re: bug#60896: dired-view-file vs. .7z
Date: Wed, 25 Jan 2023 10:51:43 +0800
rename 60896 make error if not in 7z format
thanks

I see.
OK.
Well, if the file is not in 7z format,
then I hope dired-view-file would make an error message,
like it does if a file is not in .gz format:
---
Error while executing "gzip -c -q -d < /tmp/x.gz"


gzip: stdin: not in gzip format
---




Changed bug title to 'make error if not in 7z format' from 'dired-view-file vs. .7z' Request was from Dan Jacobson <jidanni <at> jidanni.org> to control <at> debbugs.gnu.org. (Wed, 25 Jan 2023 04:31:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60896; Package emacs. (Wed, 25 Jan 2023 12:22:01 GMT) Full text and rfc822 format available.

Message #18 received at 60896 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dan Jacobson <jidanni <at> jidanni.org>
Cc: 60896 <at> debbugs.gnu.org
Subject: Re: bug#60896: dired-view-file vs. .7z
Date: Wed, 25 Jan 2023 14:21:59 +0200
> From: Dan Jacobson <jidanni <at> jidanni.org>
> Cc: 60896 <at> debbugs.gnu.org,control <at> debbugs.gnu.org
> Date: Wed, 25 Jan 2023 10:51:43 +0800
> 
> Well, if the file is not in 7z format,
> then I hope dired-view-file would make an error message,
> like it does if a file is not in .gz format:
> ---
> Error while executing "gzip -c -q -d < /tmp/x.gz"
> 
> 
> gzip: stdin: not in gzip format

That gzip error message comes from the gzip program, not from Emacs.
What does 7z say in a similar case?  That's what dired-view-file
should show.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60896; Package emacs. (Wed, 25 Jan 2023 13:17:01 GMT) Full text and rfc822 format available.

Message #21 received at 60896 <at> debbugs.gnu.org (full text, mbox):

From: Ruijie Yu <ruijie <at> netyu.xyz>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60896 <at> debbugs.gnu.org, Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#60896: dired-view-file vs. .7z
Date: Wed, 25 Jan 2023 21:13:15 +0800
[Message part 1 (text/plain, inline)]
Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Dan Jacobson <jidanni <at> jidanni.org>
>> Cc: 60896 <at> debbugs.gnu.org,control <at> debbugs.gnu.org
>> Date: Wed, 25 Jan 2023 10:51:43 +0800
>>
>> Well, if the file is not in 7z format,
>> then I hope dired-view-file would make an error message,
>> like it does if a file is not in .gz format:
>> ---
>> Error while executing "gzip -c -q -d < /tmp/x.gz"
>>
>>
>> gzip: stdin: not in gzip format
>
> That gzip error message comes from the gzip program, not from Emacs.
> What does 7z say in a similar case?  That's what dired-view-file
> should show.

See the attachments for example outputs.  #1 is a malformed 7z archive
(in my case just an empty file created by `touch`), and #2 contains an
actual 7z archive created by `7z a 2.7z memsize.c`.

Best,


RY

[1-out.txt (text/plain, attachment)]
[2-out.txt (text/plain, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60896; Package emacs. (Wed, 25 Jan 2023 13:24:01 GMT) Full text and rfc822 format available.

Message #24 received at 60896 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ruijie Yu <ruijie <at> netyu.xyz>
Cc: 60896 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#60896: dired-view-file vs. .7z
Date: Wed, 25 Jan 2023 15:23:41 +0200
> From: Ruijie Yu <ruijie <at> netyu.xyz>
> Cc: Dan Jacobson <jidanni <at> jidanni.org>, 60896 <at> debbugs.gnu.org
> Date: Wed, 25 Jan 2023 21:13:15 +0800
> 
> >> gzip: stdin: not in gzip format
> >
> > That gzip error message comes from the gzip program, not from Emacs.
> > What does 7z say in a similar case?  That's what dired-view-file
> > should show.
> 
> See the attachments for example outputs.  #1 is a malformed 7z archive
> (in my case just an empty file created by `touch`), and #2 contains an
> actual 7z archive created by `7z a 2.7z memsize.c`.

Thanks, but I'm not sure I follow.  My point is that dired-view-file
should show what the archiver program says, no more, no less.  If
that's what happens, then we are good.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60896; Package emacs. (Thu, 26 Jan 2023 07:15:01 GMT) Full text and rfc822 format available.

Message #27 received at 60896 <at> debbugs.gnu.org (full text, mbox):

From: Dan Jacobson <jidanni <at> jidanni.org>
To: Ruijie Yu <ruijie <at> netyu.xyz>
Cc: 60896 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#60896: dired-view-file vs. .7z
Date: Thu, 26 Jan 2023 15:13:48 +0800
Also maybe some message should be printed if no .gz or .7z handler is
found. Same for the rest: .jpg etc.

Currently emacs just opens the file in fundamental mode.

Emacs should print a message that it looked for a handler but didn't
find one.

That way the user would know emacs already can deal with such files,
and all he needs to do is install a handler.

Else he thinks emacs is just acting like it is 1980 an has never heard
of such files.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60896; Package emacs. (Thu, 26 Jan 2023 08:09:02 GMT) Full text and rfc822 format available.

Message #30 received at 60896 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dan Jacobson <jidanni <at> jidanni.org>
Cc: ruijie <at> netyu.xyz, 60896 <at> debbugs.gnu.org
Subject: Re: bug#60896: dired-view-file vs. .7z
Date: Thu, 26 Jan 2023 10:08:55 +0200
> From: Dan Jacobson <jidanni <at> jidanni.org>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  60896 <at> debbugs.gnu.org
> Date: Thu, 26 Jan 2023 15:13:48 +0800
> 
> Also maybe some message should be printed if no .gz or .7z handler is
> found. Same for the rest: .jpg etc.
> 
> Currently emacs just opens the file in fundamental mode.
> 
> Emacs should print a message that it looked for a handler but didn't
> find one.

Sorry, no.  That way lies madness: most of the files Emacs users visit
have no handlers.  Announcing we didn't find a handler will be a
terrible annoyance.




Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Sun, 03 Sep 2023 09:43:02 GMT) Full text and rfc822 format available.

Notification sent to Dan Jacobson <jidanni <at> jidanni.org>:
bug acknowledged by developer. (Sun, 03 Sep 2023 09:43:02 GMT) Full text and rfc822 format available.

Message #35 received at 60896-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: ruijie <at> netyu.xyz, 60896-done <at> debbugs.gnu.org,
 Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#60896: make error if not in 7z format
Date: Sun, 3 Sep 2023 02:42:34 -0700
tags 60896
close 60896
thanks

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Dan Jacobson <jidanni <at> jidanni.org>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>,  60896 <at> debbugs.gnu.org
>> Date: Thu, 26 Jan 2023 15:13:48 +0800
>>
>> Also maybe some message should be printed if no .gz or .7z handler is
>> found. Same for the rest: .jpg etc.
>>
>> Currently emacs just opens the file in fundamental mode.
>>
>> Emacs should print a message that it looked for a handler but didn't
>> find one.
>
> Sorry, no.  That way lies madness: most of the files Emacs users visit
> have no handlers.  Announcing we didn't find a handler will be a
> terrible annoyance.

Having read this bug report, I see no bug in Emacs.  We print the
message from the external archiver, as we should, and suggestions for
other changes were rejected.

I'm therefore closing this bug report.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 01 Oct 2023 11:24:32 GMT) Full text and rfc822 format available.

This bug report was last modified 179 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.