GNU bug report logs -
#60899
[PATCH 00/25] gnu: golang: Add gopls
Previous Next
Reported by: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Date: Wed, 18 Jan 2023 01:46:02 UTC
Severity: normal
Tags: patch
Merged with 60898,
60900,
60901,
60902,
60903,
60904,
60905,
60906,
60907,
60908,
60909,
60910,
60911,
60912,
60913,
60914,
60915,
60916,
60917,
60918,
60919,
60920,
60921,
60922
Done: Christopher Baines <mail <at> cbaines.net>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60899 in the body.
You can then email your comments to 60899 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Wed, 18 Jan 2023 01:46:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Wed, 18 Jan 2023 01:46:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
This is a patch series to add the gopls package.
I haven't contributed to many projects which use the e-mail flow, so hopefully
I'm doing this correctly. Please feel free to make suggestions if not!
Some of the diffs are a little busier than I'd like for version bumps. This is
due to running `guix style` over everything.
For all of the packages I have:
. Run guix style
. Run guix lint
. Built 2x
. Checked that the change is in the correct branch
. Built all dependencies
. Built the repository
Katherine Cox-Buday (25):
gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60.
gnu: go-golang-org-x-mod: Update to 0.7.0.
gnu: Add go-golang-org-x-exp.
gnu: Add go-github-com-jba-printsrc.
gnu: Add go-github-com-google-safehtml.
gnu: Add go-github-com-jba-templatecheck.
gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9.
gnu: go-github-com-pkg-diff: Update to
0.0.0-20210226163009-20ebb0f2a09e.
gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0.
gnu: gopkg-in-errgo-fmt-errors: Rename package to
go-gopkg-in-errgo-fmt-errors.
gnu: go-golang-org-x-tools: Update to 0.5.0.
gnu: Add xurls.
gnu: Add go-mvdan-cc-xurls.
gnu: Add misspell.
gnu: Add go-github-com-client9-misspell.
gnu: Add go-github-com-google-go-cmdtest.
gnu: Add unparam.
gnu: Add go-mvdan-cc-unparam.
gnu: Add govulncheck.
gnu: Add go-golang-org-x-vuln.
gnu: go-github-com-burntsushi-toml: Update to 1.2.1.
gnu: go-honnef-co-go-tools: Update to 0.3.3.
gnu: Add gofumpt.
gnu: Add go-mvdan-cc-gofumpt.
gnu: Add gopls.
gnu/packages/configuration-management.scm | 2 +-
gnu/packages/golang.scm | 695 ++++++++++++++++++----
2 files changed, 578 insertions(+), 119 deletions(-)
base-commit: 5c921977179489caef4a9e54ada6696fc86d2f0b
--
2.38.1
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Wed, 18 Jan 2023 01:47:02 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/golang.scm (gopls): New variable.
---
gnu/packages/golang.scm | 45 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 3dcd97a8c1..faa6c61bc4 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -3021,6 +3021,51 @@ (define-public go-golang-org-x-vuln
(native-inputs '())
(inputs '())))
+(define-public gopls
+ (package
+ (name "gopls")
+ (version "0.11.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://go.googlesource.com/tools")
+ (commit (string-append "gopls/v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1l9y1rp7x51s6dnjn227fhdlnz4z1h41jn3x1aq49qki241w7m73"))))
+ (build-system go-build-system)
+ (arguments
+ `(#:import-path "golang.org/x/tools/gopls"
+ #:unpack-path "golang.org/x/tools"
+ #:install-source? #f
+ #:phases (modify-phases %standard-phases
+ (add-before 'unpack 'override-tools
+ (lambda _
+ (delete-file-recursively "src/golang.org/x/tools"))))))
+ (propagated-inputs (list go-github-com-google-go-cmp-cmp
+ go-github-com-jba-printsrc
+ go-github-com-jba-templatecheck
+ go-github-com-sergi-go-diff
+ go-golang-org-x-mod
+ go-golang-org-x-sync
+ go-golang-org-x-sys
+ go-golang-org-x-text
+ go-gopkg-in-yaml-v3
+ go-honnef-co-go-tools
+ go-github-com-burntsushi-toml
+ go-github-com-google-safehtml
+ go-golang-org-x-exp
+ go-mvdan-cc-gofumpt
+ go-golang-org-x-vuln
+ go-mvdan-cc-xurls))
+ (home-page "https://golang.org/x/tools/gopls")
+ (synopsis "Official language server for the Go language")
+ (description
+ "Pronounced \"Go please\", this is the official Go language server developed by
+the Go team. It provides IDE features to any LSP-compatible editor.")
+ (license license:bsd-3)))
+
(define-public go-github-com-protonmail-go-crypto
(package
(name "go-github-com-protonmail-go-crypto")
--
2.38.1
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Mon, 30 Jan 2023 16:54:02 GMT)
Full text and
rfc822 format available.
Message #27 received at 60899 <at> debbugs.gnu.org (full text, mbox):
Katherine Cox-Buday <cox.katherine.e <at> gmail.com> writes:
> This is a patch series to add the gopls package.
>
> I haven't contributed to many projects which use the e-mail flow, so
> hopefully I'm doing this correctly. Please feel free to make
> suggestions if not!
>
> Some of the diffs are a little busier than I'd like for version bumps.
> This is due to running `guix style` over everything.
>
> For all of the packages I have:
>
> . Run guix style
> . Run guix lint
> . Built 2x
> . Checked that the change is in the correct branch
> . Built all dependencies
> . Built the repository
>
> Katherine Cox-Buday (25):
> gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60.
> gnu: go-golang-org-x-mod: Update to 0.7.0.
> gnu: Add go-golang-org-x-exp.
> gnu: Add go-github-com-jba-printsrc.
> gnu: Add go-github-com-google-safehtml.
> gnu: Add go-github-com-jba-templatecheck.
> gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9.
> gnu: go-github-com-pkg-diff: Update to
> 0.0.0-20210226163009-20ebb0f2a09e.
> gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0.
> gnu: gopkg-in-errgo-fmt-errors: Rename package to
> go-gopkg-in-errgo-fmt-errors.
> gnu: go-golang-org-x-tools: Update to 0.5.0.
> gnu: Add xurls.
> gnu: Add go-mvdan-cc-xurls.
> gnu: Add misspell.
> gnu: Add go-github-com-client9-misspell.
> gnu: Add go-github-com-google-go-cmdtest.
> gnu: Add unparam.
> gnu: Add go-mvdan-cc-unparam.
> gnu: Add govulncheck.
> gnu: Add go-golang-org-x-vuln.
> gnu: go-github-com-burntsushi-toml: Update to 1.2.1.
> gnu: go-honnef-co-go-tools: Update to 0.3.3.
> gnu: Add gofumpt.
> gnu: Add go-mvdan-cc-gofumpt.
> gnu: Add gopls.
>
> gnu/packages/configuration-management.scm | 2 +-
> gnu/packages/golang.scm | 695 ++++++++++++++++++----
> 2 files changed, 578 insertions(+), 119 deletions(-)
>
>
> base-commit: 5c921977179489caef4a9e54ada6696fc86d2f0b
Hello Guix! Acknowledging that everyone are volunteers, and busy (guilty
myself), this is a humble request for a review of this patch-series I
made two weeks ago so that it doesn't bit-rot.
I have a `gopls` home service[1] waiting to be proposed after this
patch-series is merged.
Thank you very much!
[1] https://github.com/kat-co/guix-channels/blob/upstream-staging/upstream/home/services/gopls.scm
P.S. I think I am following etiquette for review reminders (i.e. waiting
long enough, bringing this over to guix-devel), but I was having trouble
finding examples. If I haven't waited long enough, or have reminded in
the wrong way, please give me feedback.
--
Katherine
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Mon, 06 Feb 2023 16:54:01 GMT)
Full text and
rfc822 format available.
Message #30 received at 60899 <at> debbugs.gnu.org (full text, mbox):
Katherine Cox-Buday <cox.katherine.e <at> gmail.com> writes:
> Katherine Cox-Buday <cox.katherine.e <at> gmail.com> writes:
>
>> This is a patch series to add the gopls package.
>>
>> I haven't contributed to many projects which use the e-mail flow, so
>> hopefully I'm doing this correctly. Please feel free to make
>> suggestions if not!
>>
>> Some of the diffs are a little busier than I'd like for version bumps.
>> This is due to running `guix style` over everything.
>>
>> For all of the packages I have:
>>
>> . Run guix style
>> . Run guix lint
>> . Built 2x
>> . Checked that the change is in the correct branch
>> . Built all dependencies
>> . Built the repository
>>
>> Katherine Cox-Buday (25):
>> gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60.
>> gnu: go-golang-org-x-mod: Update to 0.7.0.
>> gnu: Add go-golang-org-x-exp.
>> gnu: Add go-github-com-jba-printsrc.
>> gnu: Add go-github-com-google-safehtml.
>> gnu: Add go-github-com-jba-templatecheck.
>> gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9.
>> gnu: go-github-com-pkg-diff: Update to
>> 0.0.0-20210226163009-20ebb0f2a09e.
>> gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0.
>> gnu: gopkg-in-errgo-fmt-errors: Rename package to
>> go-gopkg-in-errgo-fmt-errors.
>> gnu: go-golang-org-x-tools: Update to 0.5.0.
>> gnu: Add xurls.
>> gnu: Add go-mvdan-cc-xurls.
>> gnu: Add misspell.
>> gnu: Add go-github-com-client9-misspell.
>> gnu: Add go-github-com-google-go-cmdtest.
>> gnu: Add unparam.
>> gnu: Add go-mvdan-cc-unparam.
>> gnu: Add govulncheck.
>> gnu: Add go-golang-org-x-vuln.
>> gnu: go-github-com-burntsushi-toml: Update to 1.2.1.
>> gnu: go-honnef-co-go-tools: Update to 0.3.3.
>> gnu: Add gofumpt.
>> gnu: Add go-mvdan-cc-gofumpt.
>> gnu: Add gopls.
>>
>> gnu/packages/configuration-management.scm | 2 +-
>> gnu/packages/golang.scm | 695 ++++++++++++++++++----
>> 2 files changed, 578 insertions(+), 119 deletions(-)
>>
>>
>> base-commit: 5c921977179489caef4a9e54ada6696fc86d2f0b
>
> Hello Guix! Acknowledging that everyone are volunteers, and busy (guilty
> myself), this is a humble request for a review of this patch-series I
> made two weeks ago so that it doesn't bit-rot.
>
> I have a `gopls` home service[1] waiting to be proposed after this
> patch-series is merged.
>
> Thank you very much!
>
> [1]
> https://github.com/kat-co/guix-channels/blob/upstream-staging/upstream/home/services/gopls.scm
>
> P.S. I think I am following etiquette for review reminders (i.e. waiting
> long enough, bringing this over to guix-devel), but I was having trouble
> finding examples. If I haven't waited long enough, or have reminded in
> the wrong way, please give me feedback.
Hello, this is another humble request for review :)
It looks like QA is passing, and I think I did a pretty thorough job of
making sure things follow standards and will apply cleanly.
--
Katherine
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Mon, 06 Feb 2023 23:16:01 GMT)
Full text and
rfc822 format available.
Message #33 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Katherine Cox-Buday <cox.katherine.e <at> gmail.com> writes:
> This is a patch series to add the gopls package.
>
> I haven't contributed to many projects which use the e-mail flow, so hopefully
> I'm doing this correctly. Please feel free to make suggestions if not!
>
> Some of the diffs are a little busier than I'd like for version bumps. This is
> due to running `guix style` over everything.
>
> For all of the packages I have:
>
> . Run guix style
> . Run guix lint
> . Built 2x
> . Checked that the change is in the correct branch
> . Built all dependencies
> . Built the repository
>
> Katherine Cox-Buday (25):
> gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60.
> gnu: go-golang-org-x-mod: Update to 0.7.0.
> gnu: Add go-golang-org-x-exp.
> gnu: Add go-github-com-jba-printsrc.
> gnu: Add go-github-com-google-safehtml.
> gnu: Add go-github-com-jba-templatecheck.
> gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9.
> gnu: go-github-com-pkg-diff: Update to
> 0.0.0-20210226163009-20ebb0f2a09e.
> gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0.
> gnu: gopkg-in-errgo-fmt-errors: Rename package to
> go-gopkg-in-errgo-fmt-errors.
> gnu: go-golang-org-x-tools: Update to 0.5.0.
> gnu: Add xurls.
> gnu: Add go-mvdan-cc-xurls.
> gnu: Add misspell.
> gnu: Add go-github-com-client9-misspell.
> gnu: Add go-github-com-google-go-cmdtest.
> gnu: Add unparam.
> gnu: Add go-mvdan-cc-unparam.
> gnu: Add govulncheck.
> gnu: Add go-golang-org-x-vuln.
> gnu: go-github-com-burntsushi-toml: Update to 1.2.1.
> gnu: go-honnef-co-go-tools: Update to 0.3.3.
> gnu: Add gofumpt.
> gnu: Add go-mvdan-cc-gofumpt.
> gnu: Add gopls.
>
> gnu/packages/configuration-management.scm | 2 +-
> gnu/packages/golang.scm | 695 ++++++++++++++++++----
> 2 files changed, 578 insertions(+), 119 deletions(-)
I've made a few tweaks and pushed this to master as
f3ab5888a0bc6446104ddbba41a413a86eb298e2.
Thanks,
Chris
[signature.asc (application/pgp-signature, inline)]
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:03 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:03 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:03 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:03 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:03 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:03 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:04 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:04 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:04 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:04 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:04 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:04 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:04 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:05 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:05 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:05 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:05 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:05 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:06 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:06 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:06 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:06 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:06 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:06 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:06 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:07 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:07 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:07 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:07 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:07 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:07 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:07 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:07 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:08 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:08 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:08 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:08 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:08 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:09 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:09 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:09 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:09 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:09 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:09 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:09 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:10 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:10 GMT)
Full text and
rfc822 format available.
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Mon, 06 Feb 2023 23:16:10 GMT)
Full text and
rfc822 format available.
Notification sent
to
Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
:
bug acknowledged by developer.
(Mon, 06 Feb 2023 23:16:10 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Mon, 06 Feb 2023 23:29:01 GMT)
Full text and
rfc822 format available.
Message #161 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Mon Feb 6, 2023 at 11:14 PM GMT, Christopher Baines wrote:
> I've made a few tweaks and pushed this to master as
> f3ab5888a0bc6446104ddbba41a413a86eb298e2.
Nooo, my review was too slow :P
-- (
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Mon, 06 Feb 2023 23:29:01 GMT)
Full text and
rfc822 format available.
Message #164 received at 60899 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
* gnu/packages/golang.scm (gopls): New variable.
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -3021,6 +3021,51 @@ (define-public go-golang-org-x-vuln
> + (arguments
> + `(#:import-path "golang.org/x/tools/gopls"
> + #:unpack-path "golang.org/x/tools"
> + #:install-source? #f
> + #:phases (modify-phases %standard-phases
> + (add-before 'unpack 'override-tools
> + (lambda _
> + (delete-file-recursively "src/golang.org/x/tools"))))))
s/override/remove-other/, perhaps?
> + (propagated-inputs (list go-github-com-google-go-cmp-cmp
> + go-github-com-jba-printsrc
> + go-github-com-jba-templatecheck
> + go-github-com-sergi-go-diff
> + go-golang-org-x-mod
> + go-golang-org-x-sync
> + go-golang-org-x-sys
> + go-golang-org-x-text
> + go-gopkg-in-yaml-v3
> + go-honnef-co-go-tools
> + go-github-com-burntsushi-toml
> + go-github-com-google-safehtml
> + go-golang-org-x-exp
> + go-mvdan-cc-gofumpt
> + go-golang-org-x-vuln
> + go-mvdan-cc-xurls))
Could this be changed to just ``inputs''?
> + (description
> + "Pronounced \"Go please\", this is the official Go language server developed by
> +the Go team. It provides IDE features to any LSP-compatible editor.")
(description
"This package provides the official @acronym{LSP, language server protocol}
server for the Go language, allowing LSP-compatible editors to automatically
support @acronym{IDE, integrated development environment}-like features.")
-- (
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Mon, 06 Feb 2023 23:29:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Tue, 07 Feb 2023 07:51:01 GMT)
Full text and
rfc822 format available.
Message #170 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
"(" <paren <at> disroot.org> writes:
> [[PGP Signed Part:Undecided]]
> On Mon Feb 6, 2023 at 11:14 PM GMT, Christopher Baines wrote:
>> I've made a few tweaks and pushed this to master as
>> f3ab5888a0bc6446104ddbba41a413a86eb298e2.
>
> Nooo, my review was too slow :P
I think reviewing changes/sending feedback after things have been merged
is fine (and important). If more people get involved in reviewing
things, this is probably something that'll happen more, so I think for
now it's good to embrace it.
Hopefully we can continue the discussion around these changes and
perhaps further improve things with some additional patches.
Chris
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Tue, 07 Feb 2023 07:51:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Tue, 07 Feb 2023 16:01:02 GMT)
Full text and
rfc822 format available.
Message #176 received at 60899 <at> debbugs.gnu.org (full text, mbox):
Christopher Baines <mail <at> cbaines.net> writes:
> I've made a few tweaks and pushed this to master as
> f3ab5888a0bc6446104ddbba41a413a86eb298e2.
>
> Thanks,
>
> Chris
Thank you so much!
I'm going to review the changes (and the reviews from open-paren) to try
and incorporate that going forward.
--
Katherine
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Tue, 07 Feb 2023 16:03:02 GMT)
Full text and
rfc822 format available.
Message #179 received at 60899 <at> debbugs.gnu.org (full text, mbox):
Christopher Baines <mail <at> cbaines.net> writes:
> "(" <paren <at> disroot.org> writes:
>
>> [[PGP Signed Part:Undecided]]
>> On Mon Feb 6, 2023 at 11:14 PM GMT, Christopher Baines wrote:
>>> I've made a few tweaks and pushed this to master as
>>> f3ab5888a0bc6446104ddbba41a413a86eb298e2.
>>
>> Nooo, my review was too slow :P
>
> I think reviewing changes/sending feedback after things have been merged
> is fine (and important). If more people get involved in reviewing
> things, this is probably something that'll happen more, so I think for
> now it's good to embrace it.
>
> Hopefully we can continue the discussion around these changes and
> perhaps further improve things with some additional patches.
>
> Chris
I responded to Chris's original message, but: +1 to what Chris says. I'm
still going to look at your feedback, paren, and maybe send some more
patches.
Personally, I prefer always moving forward, so long as it doesn't break
anything.
Thank you very much for the reviews!
--
Katherine
Information forwarded
to
guix-patches <at> gnu.org
:
bug#60899
; Package
guix-patches
.
(Tue, 07 Feb 2023 16:03:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Wed, 08 Mar 2023 12:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 21 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.