GNU bug report logs - #60908
[PATCH 10/25] gnu: gopkg-in-errgo-fmt-errors: Rename package to go-gopkg-in-errgo-fmt-errors.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60908 in the body.
You can then email your comments to 60908 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Subject: [PATCH 10/25] gnu: gopkg-in-errgo-fmt-errors: Rename package to
 go-gopkg-in-errgo-fmt-errors.
Date: Tue, 17 Jan 2023 18:44:55 -0700

* gnu/packages/configuration-management.scm (chezmoi): Define in terms
of'go-gopkg-in-errgo-fmt-errors'.

* (go-gopkg-in-errgo-fmt-errors): New variable, formerly known as "gopkg-in-errgo-fmt-errors".
---
 gnu/packages/configuration-management.scm | 2 +-
 gnu/packages/golang.scm                   | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/configuration-management.scm b/gnu/packages/configuration-management.scm
index 3ebb6957c8..b66f70545a 100644
--- a/gnu/packages/configuration-management.scm
+++ b/gnu/packages/configuration-management.scm
@@ -97,7 +97,7 @@ (define-public chezmoi
            go-golang-org-x-net
            go-golang-org-x-oauth2
            go-github-com-rogpeppe-go-internal
-           gopkg-in-errgo-fmt-errors))
+           go-gopkg-in-errgo-fmt-errors))
     (home-page "https://www.chezmoi.io/")
     (synopsis "Personal configuration files manager")
     (description "This package helps to manage personal configuration files
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 240f8ea56c..4cef0f61f6 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -9147,9 +9147,9 @@ (define-public go-github-com-rogpeppe-go-internal
 @end itemize\n")
     (license license:bsd-3)))
 
-(define-public gopkg-in-errgo-fmt-errors
+(define-public go-gopkg-in-errgo-fmt-errors
   (package
-    (name "gopkg-in-errgo-fmt-errors")
+    (name "go-gopkg-in-errgo-fmt-errors")
     (version "2.1.0")
     (source (origin
               (method git-fetch)
@@ -9162,7 +9162,7 @@ (define-public gopkg-in-errgo-fmt-errors
                 "065mbihiy7q67wnql0bzl9y1kkvck5ivra68254zbih52jxwrgr2"))))
     (build-system go-build-system)
     (arguments
-     `(#:import-path "gopkg.in/errgo.v2/fmt/errors"
+     `(#:import-path "gopkg.in/errgo.v2"
        #:tests? #f
        ;; Source-only package
        #:phases
-- 
2.38.1

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Cc: 60908 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#60908] [PATCH 10/25] gnu: gopkg-in-errgo-fmt-errors:
 Rename package to go-gopkg-in-errgo-fmt-errors.
Date: Mon, 06 Feb 2023 23:17:03 +0100

[Message part 1 (text/plain, inline)]

Katherine Cox-Buday <cox.katherine.e <at> gmail.com> writes:

> * gnu/packages/configuration-management.scm (chezmoi): Define in terms
> of'go-gopkg-in-errgo-fmt-errors'.
>
> * (go-gopkg-in-errgo-fmt-errors): New variable, formerly known as "gopkg-in-errgo-fmt-errors".

I'm no expert in changelog entries in commit messages, but I'd probably
write this like:

* gnu/packages/golang.scm (gopkg-in-errgo-fmt-errors):
Rename to …
(go-gopkg-in-errgo-fmt-errors): … this.
* gnu/packages/configuration-management.scm (chezmoi)[native-inputs]: Update
accordingly.


I think that's a little clearer in terms of the changes being made, and
has less words as well.

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 60908 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Katherine Cox-Buday" <cox.katherine.e <at> gmail.com>, <60908 <at> debbugs.gnu.org>
Subject: Re: [bug#60908] [PATCH 10/25] gnu: gopkg-in-errgo-fmt-errors:
 Rename package to go-gopkg-in-errgo-fmt-errors.
Date: Mon, 06 Feb 2023 22:22:05 +0000

[Message part 1 (text/plain, inline)]

* gnu/packages/configuration-management.scm (chezmoi): Define in terms
of'go-gopkg-in-errgo-fmt-errors'.

* (go-gopkg-in-errgo-fmt-errors): New variable, formerly known as "gopkg-in-errgo-fmt-errors".

LGTM except for the commit message; please adopt Chris's suggestion :)

    -- (

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 60908 <at> debbugs.gnu.org (full text, mbox):

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 60908 <at> debbugs.gnu.org
Subject: Re: [bug#60908] [PATCH 10/25] gnu: gopkg-in-errgo-fmt-errors:
 Rename package to go-gopkg-in-errgo-fmt-errors.
Date: Tue, 07 Feb 2023 10:20:37 -0700

Christopher Baines <mail <at> cbaines.net> writes:

> Katherine Cox-Buday <cox.katherine.e <at> gmail.com> writes:
>
>> * gnu/packages/configuration-management.scm (chezmoi): Define in terms
>> of'go-gopkg-in-errgo-fmt-errors'.
>>
>> * (go-gopkg-in-errgo-fmt-errors): New variable, formerly known as
>> "gopkg-in-errgo-fmt-errors".
>
> I'm no expert in changelog entries in commit messages, but I'd probably
> write this like:
>
> * gnu/packages/golang.scm (gopkg-in-errgo-fmt-errors):
> Rename to …
> (go-gopkg-in-errgo-fmt-errors): … this.
> * gnu/packages/configuration-management.scm (chezmoi)[native-inputs]: Update
> accordingly.
>
>
> I think that's a little clearer in terms of the changes being made,
> and has less words as well.

Thank you for the suggestions; I agree it is much clearer.

The changelog format is something I personally really struggle with, so
I use tools to hopefully get me closer to being correct. I am using the
auto-complete snippets provided `./etc/snippets`, and it looks like this
is the format defined in:

`./etc/snippets/yas/log-edit-mode/guix-vc-commit-message-rename-package`

I'd love to be able to get these right, and I'll endeavor to do so, but
if the tooling is suggesting unhelpful things, it's going to be a real
struggle for me. Should we update the snippets?

-- 
Katherine

Message #32 received at 60908 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Cc: 60908 <at> debbugs.gnu.org
Subject: Re: [bug#60908] [PATCH 10/25] gnu: gopkg-in-errgo-fmt-errors:
 Rename package to go-gopkg-in-errgo-fmt-errors.
Date: Wed, 08 Feb 2023 12:45:20 +0100

[Message part 1 (text/plain, inline)]

Katherine Cox-Buday <cox.katherine.e <at> gmail.com> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> Katherine Cox-Buday <cox.katherine.e <at> gmail.com> writes:
>>
>>> * gnu/packages/configuration-management.scm (chezmoi): Define in terms
>>> of'go-gopkg-in-errgo-fmt-errors'.
>>>
>>> * (go-gopkg-in-errgo-fmt-errors): New variable, formerly known as
>>> "gopkg-in-errgo-fmt-errors".
>>
>> I'm no expert in changelog entries in commit messages, but I'd probably
>> write this like:
>>
>> * gnu/packages/golang.scm (gopkg-in-errgo-fmt-errors):
>> Rename to …
>> (go-gopkg-in-errgo-fmt-errors): … this.
>> * gnu/packages/configuration-management.scm (chezmoi)[native-inputs]: Update
>> accordingly.
>>
>>
>> I think that's a little clearer in terms of the changes being made,
>> and has less words as well.
>
> Thank you for the suggestions; I agree it is much clearer.
>
> The changelog format is something I personally really struggle with, so
> I use tools to hopefully get me closer to being correct. I am using the
> auto-complete snippets provided `./etc/snippets`, and it looks like this
> is the format defined in:
>
> `./etc/snippets/yas/log-edit-mode/guix-vc-commit-message-rename-package`
>
> I'd love to be able to get these right, and I'll endeavor to do so, but
> if the tooling is suggesting unhelpful things, it's going to be a real
> struggle for me. Should we update the snippets?

I also struggle with this, so I'm don't really have any great
suggestions. If you think the snippets could be improved, then that
sounds great to me.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.