GNU bug report logs - #60925
29.0.60; [PATCH] Use proper types for Eshell warnings

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Wed, 18 Jan 2023 04:57:01 UTC

Severity: normal

Tags: patch

Found in version 29.0.60

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60925 in the body.
You can then email your comments to 60925 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#60925; Package emacs. (Wed, 18 Jan 2023 04:57:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jim Porter <jporterbugs <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 18 Jan 2023 04:57:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; [PATCH] Use proper types for Eshell warnings
Date: Tue, 17 Jan 2023 20:56:51 -0800

[Message part 1 (text/plain, inline)]
Looking over the 'display-warning' code, I realized that I had misread 
the docstring and wasn't calling it properly in Eshell. I gave these 
warnings a type of ':warning', but that's a warning *level*, not a 
warning *type*. Attached is a fix.

I'd like to merge this to the Emacs 29 branch. These are trivial fixes 
to a couple new features, and should make it easier for users to 
properly suppress these warnings if they choose to do so.
[0001-Use-proper-types-for-Eshell-warnings.patch (text/plain, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60925; Package emacs. (Wed, 18 Jan 2023 12:09:01 GMT) Full text and rfc822 format available.

Message #8 received at 60925 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 60925 <at> debbugs.gnu.org
Subject: Re: bug#60925: 29.0.60; [PATCH] Use proper types for Eshell warnings
Date: Wed, 18 Jan 2023 14:08:04 +0200

> Date: Tue, 17 Jan 2023 20:56:51 -0800
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> Looking over the 'display-warning' code, I realized that I had misread 
> the docstring and wasn't calling it properly in Eshell. I gave these 
> warnings a type of ':warning', but that's a warning *level*, not a 
> warning *type*. Attached is a fix.
> 
> I'd like to merge this to the Emacs 29 branch. These are trivial fixes 
> to a couple new features, and should make it easier for users to 
> properly suppress these warnings if they choose to do so.

OK, thanks.
Reply sent to Jim Porter <jporterbugs <at> gmail.com>:
You have taken responsibility. (Wed, 18 Jan 2023 17:17:01 GMT) Full text and rfc822 format available.
Notification sent to Jim Porter <jporterbugs <at> gmail.com>:
bug acknowledged by developer. (Wed, 18 Jan 2023 17:17:02 GMT) Full text and rfc822 format available.

Message #13 received at 60925-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60925-done <at> debbugs.gnu.org
Subject: Re: bug#60925: 29.0.60; [PATCH] Use proper types for Eshell warnings
Date: Wed, 18 Jan 2023 09:16:45 -0800

On 1/18/2023 4:08 AM, Eli Zaretskii wrote:
> OK, thanks.

Thanks. Merged to Emacs 29 as dc3f85fd4b, and closing this bug.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 16 Feb 2023 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 70 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.