GNU bug report logs - #60936
30.0.50; ERC >5.5: Add erc-fill style based on visual-line-mode

Previous Next

Package: emacs;

Reported by: "J.P." <jp <at> neverwas.me>

Date: Wed, 18 Jan 2023 14:55:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Fixed in version 30.1

Done: "J.P." <jp <at> neverwas.me>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60936 in the body.
You can then email your comments to 60936 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to emacs-erc <at> gnu.org, bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 18 Jan 2023 14:55:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to "J.P." <jp <at> neverwas.me>:
New bug report received and forwarded. Copy sent to emacs-erc <at> gnu.org, bug-gnu-emacs <at> gnu.org. (Wed, 18 Jan 2023 14:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; ERC >5.5: Add erc-fill style based on visual-line-mode
Date: Wed, 18 Jan 2023 06:53:48 -0800
[Message part 1 (text/plain, inline)]
Tags: patch

This bug is broadly related to

  bug#51969: 29.0.50; Add command for refilling ERC buffers

Hi people,

Newcomers to ERC are sometimes disappointed to discover that messages
are "filled" in the traditional sense, meaning white space is
permanently added and removed to produce "folded" lines as if M-q'd in
an editing mode. Unfortunately, much of IRC involves dealing with
preformatted messages sent by bots or a server (think "figlet" banners
in MOTD bursts or /msg NickServ help). While it's always been possible
to turn off filling everywhere (`fill' is global module, remember),
doing so necessarily means surrendering any and all filling, whose very
purpose is to make it easy to distinguish between speakers at a glance.

This patch aims to offer a compromise of sorts, assuming users are
willing to tolerate some opinionated choices. The first is that, for
now, per-message lefty timestamps are out. If you want timestamps, they
must go on the right (except for the occasional dateline break).
Moreover, right-hand timestamps basically look awful unless you accept a
new paradigm that places them all in the right margin. (This can be
toggled off when space is tight.) Yet another catch involves
`visual-line-mode' itself, which is managed for you. Basically, users of
modal editing packages may suffer from basic navigation issues without
taking extra care to cope with its idiosyncrasies.

An ancillary goal of this patch is to have this mode double as a
reference implementation for a certain flavor of local module, namely
one that's "tunably persistent" per buffer. Also on display will be an
added degree of versatility in terms of activation. While users can
still add `fill-wrap' to `erc-modules' or enable it manually via
minor-mode toggle, they can also elect to allow the global `fill' module
to control it transparently, as a child module, simply by setting
`erc-fill-function' to `erc-fill-wrap'.

If you'd like to try this, do the following after applying these
patches and before connecting:

  (setopt erc-fill-function #'erc-fill-wrap
          erc-timestamp-user-align-to 'margin)

Screenshots to follow (possibly).

Thanks,
J.P.

P.S. These patches come bundled with the so-called "edge" edition of
ERC, an alpha-quality hodgepodge of WIP patches available as an ELPA
package ("https://emacs-erc.gitlab.io/bugs/archive/").


In GNU Emacs 30.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version
 3.24.35, cairo version 1.17.6) of 2023-01-17 built on localhost
Repository revision: 281f48f19ecad706a639d57cb937afb0b97eded7
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs
 'CFLAGS=-O0 -g3'
 PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config
gnus-util text-property-search mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils erc iso8601 time-date
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map thingatpt pp format-spec cl-loaddefs cl-lib erc-backend erc-goodies
erc-networks byte-opt gv bytecomp byte-compile erc-common erc-compat
erc-loaddefs rmc iso-transl tooltip cconv eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty
make-network-process emacs)

Memory information:
((conses 16 64390 6319)
 (symbols 48 8639 0)
 (strings 32 23673 1623)
 (string-bytes 1 685926)
 (vectors 16 15259)
 (vector-slots 8 209777 7692)
 (floats 8 24 35)
 (intervals 56 232 0)
 (buffers 976 10))

[0001-5.6-Adjust-some-old-text-properties-in-ERC-buffers.patch (text/x-patch, attachment)]
[0002-5.6-Leverage-display-properties-better-in-erc-stamp.patch (text/x-patch, attachment)]
[0003-5.6-Convert-erc-fill-minor-mode-into-a-proper-module.patch (text/x-patch, attachment)]
[0004-5.6-Add-erc-fill-style-based-on-visual-line-mode.patch (text/x-patch, attachment)]

Message #6 received at 60936-quiet <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936-quiet <at> debbugs.gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 18 Jan 2023 06:57:57 -0800
[Message part 1 (text/plain, inline)]
Screenshot storage:
[wrap_demo.webm (video/webm, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 18 Jan 2023 15:02:01 GMT) Full text and rfc822 format available.

Message #9 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 18 Jan 2023 07:01:39 -0800
Brief demo (video/webm):

  https://debbugs.gnu.org/cgi/bugreport.cgi?filename=wrap_demo.webm;msg=6;bug=60936;att=1




Message #10 received at 60936-quiet <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936-quiet <at> debbugs.gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Fri, 20 Jan 2023 06:16:05 -0800
[Message part 1 (text/plain, inline)]
v2. Add toggle for visual-line-mode's command analogs (e.g.,
`beginning-of-visual-line', `kill-visual-line', etc.).

[0000-v1-v2.diff (text/x-patch, attachment)]
[0001-5.6-Adjust-some-old-text-properties-in-ERC-buffers.patch (text/x-patch, attachment)]
[0002-5.6-Leverage-display-properties-better-in-erc-stamp.patch (text/x-patch, attachment)]
[0003-5.6-Convert-erc-fill-minor-mode-into-a-proper-module.patch (text/x-patch, attachment)]
[0004-5.6-Add-erc-fill-style-based-on-visual-line-mode.patch (text/x-patch, attachment)]

Message #11 received at 60936-quiet <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936-quiet <at> debbugs.gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 25 Jan 2023 06:04:13 -0800
[Message part 1 (text/plain, inline)]
Screenshot (variable-pitch).

[fill-wrap-vp.png (image/png, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 25 Jan 2023 14:12:01 GMT) Full text and rfc822 format available.

Message #14 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 25 Jan 2023 06:11:13 -0800
[Message part 1 (text/plain, inline)]
v3. Accommodate variable-pitch faces on graphical displays. Use
`defvar-keymap', now available in the latest Compat.

Screenshot:
https://debbugs.gnu.org/cgi/bugreport.cgi?msg=11;filename=fill-wrap-vp.png;bug=60936;att=1

[0000-v2-v3.diff (text/x-patch, attachment)]
[0001-5.6-Adjust-some-old-text-properties-in-ERC-buffers.patch (text/x-patch, attachment)]
[0002-5.6-Leverage-display-properties-better-in-erc-stamp.patch (text/x-patch, attachment)]
[0003-5.6-Convert-erc-fill-minor-mode-into-a-proper-module.patch (text/x-patch, attachment)]
[0004-5.6-Add-erc-fill-style-based-on-visual-line-mode.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Fri, 27 Jan 2023 14:32:02 GMT) Full text and rfc822 format available.

Message #17 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Fri, 27 Jan 2023 06:31:47 -0800
[Message part 1 (text/plain, inline)]
v4. Fix invisibility for fools and timestamps with wrapped filling.
Consolidate prompt setup in `erc-open'. Deprecate some items in
erc-stamp.

[0000-v3-v4.diff (text/x-patch, attachment)]
[0001-5.6-Refactor-marker-initialization-in-erc-open.patch (text/x-patch, attachment)]
[0002-5.6-Adjust-some-old-text-properties-in-ERC-buffers.patch (text/x-patch, attachment)]
[0003-5.6-Expose-insertion-time-as-text-prop-in-erc-stamp.patch (text/x-patch, attachment)]
[0004-5.6-Make-some-erc-stamp-functions-more-limber.patch (text/x-patch, attachment)]
[0005-5.6-Put-display-properties-to-better-use-in-erc-stam.patch (text/x-patch, attachment)]
[0006-5.6-Convert-erc-fill-minor-mode-into-a-proper-module.patch (text/x-patch, attachment)]
[0007-5.6-Add-variant-for-erc-match-invisibility-spec.patch (text/x-patch, attachment)]
[0008-5.6-Add-erc-fill-style-based-on-visual-line-mode.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 31 Jan 2023 15:29:02 GMT) Full text and rfc822 format available.

Message #20 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 31 Jan 2023 07:28:29 -0800
[Message part 1 (text/plain, inline)]
v5. Fix some sloppiness in nudge command. Add (temporary) compat
function for `set-transient-map'. Improve tests.

[0000-v4-v5.diff (text/x-patch, attachment)]
[0001-5.6-Refactor-marker-initialization-in-erc-open.patch (text/x-patch, attachment)]
[0002-5.6-Adjust-some-old-text-properties-in-ERC-buffers.patch (text/x-patch, attachment)]
[0003-5.6-Expose-insertion-time-as-text-prop-in-erc-stamp.patch (text/x-patch, attachment)]
[0004-5.6-Make-some-erc-stamp-functions-more-limber.patch (text/x-patch, attachment)]
[0005-5.6-Put-display-properties-to-better-use-in-erc-stam.patch (text/x-patch, attachment)]
[0006-5.6-Convert-erc-fill-minor-mode-into-a-proper-module.patch (text/x-patch, attachment)]
[0007-5.6-Add-variant-for-erc-match-invisibility-spec.patch (text/x-patch, attachment)]
[0008-5.6-Add-erc-fill-style-based-on-visual-line-mode.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 01 Feb 2023 14:28:01 GMT) Full text and rfc822 format available.

Message #23 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 01 Feb 2023 06:27:44 -0800
[Message part 1 (text/plain, inline)]
v6. Revert addition of leading space for `margin' timestamps. Add
`erc-log-filter-function' tailored to new `erc-timestamp-use-align-to'
offerings.

(For now, this log style resembles those produced by the ZNC bouncer.
See attached sample and screenshot of originating buffer.)

[#chan!tester@127.0.0.1:6667.txt (text/plain, attachment)]
[fill-wrap-log-compare-chan.png (image/png, attachment)]
[0000-v5-v6.diff (text/x-patch, attachment)]
[0001-5.6-Refactor-marker-initialization-in-erc-open.patch (text/x-patch, attachment)]
[0002-5.6-Adjust-some-old-text-properties-in-ERC-buffers.patch (text/x-patch, attachment)]
[0003-5.6-Expose-insertion-time-as-text-prop-in-erc-stamp.patch (text/x-patch, attachment)]
[0004-5.6-Make-some-erc-stamp-functions-more-limber.patch (text/x-patch, attachment)]
[0005-5.6-Put-display-properties-to-better-use-in-erc-stam.patch (text/x-patch, attachment)]
[0006-5.6-Convert-erc-fill-minor-mode-into-a-proper-module.patch (text/x-patch, attachment)]
[0007-5.6-Add-variant-for-erc-match-invisibility-spec.patch (text/x-patch, attachment)]
[0008-5.6-Add-erc-fill-style-based-on-visual-line-mode.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 07 Feb 2023 15:24:02 GMT) Full text and rfc822 format available.

Message #26 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 07 Feb 2023 07:23:20 -0800
[Message part 1 (text/plain, inline)]
v7. Remove unused variable. Get smarter about display props. Add test
for key bindings.

[0000-v6-v7.diff (text/x-patch, attachment)]
[0001-5.6-Refactor-marker-initialization-in-erc-open.patch (text/x-patch, attachment)]
[0002-5.6-Adjust-some-old-text-properties-in-ERC-buffers.patch (text/x-patch, attachment)]
[0003-5.6-Expose-insertion-time-as-text-prop-in-erc-stamp.patch (text/x-patch, attachment)]
[0004-5.6-Make-some-erc-stamp-functions-more-limber.patch (text/x-patch, attachment)]
[0005-5.6-Put-display-properties-to-better-use-in-erc-stam.patch (text/x-patch, attachment)]
[0006-5.6-Convert-erc-fill-minor-mode-into-a-proper-module.patch (text/x-patch, attachment)]
[0007-5.6-Add-variant-for-erc-match-invisibility-spec.patch (text/x-patch, attachment)]
[0008-5.6-Add-erc-fill-style-based-on-visual-line-mode.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Sun, 19 Feb 2023 15:07:03 GMT) Full text and rfc822 format available.

Message #29 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Sun, 19 Feb 2023 07:05:49 -0800
[Message part 1 (text/plain, inline)]
v8. Fix minor-mode teardown in erc-stamp. Improve tests.

[0000-v7-v8.diff (text/x-patch, attachment)]
[0001-5.6-Refactor-marker-initialization-in-erc-open.patch (text/x-patch, attachment)]
[0002-5.6-Adjust-some-old-text-properties-in-ERC-buffers.patch (text/x-patch, attachment)]
[0003-5.6-Expose-insertion-time-as-text-prop-in-erc-stamp.patch (text/x-patch, attachment)]
[0004-5.6-Make-some-erc-stamp-functions-more-limber.patch (text/x-patch, attachment)]
[0005-5.6-Put-display-properties-to-better-use-in-erc-stam.patch (text/x-patch, attachment)]
[0006-5.6-Convert-erc-fill-minor-mode-into-a-proper-module.patch (text/x-patch, attachment)]
[0007-5.6-Add-variant-for-erc-match-invisibility-spec.patch (text/x-patch, attachment)]
[0008-5.6-Add-erc-fill-style-based-on-visual-line-mode.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Mon, 20 Feb 2023 15:32:01 GMT) Full text and rfc822 format available.

Message #32 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Mon, 20 Feb 2023 07:31:12 -0800
[Message part 1 (text/plain, inline)]
v9. Trust previous values when initializing markers.

[0000-v8-v9.diff (text/x-patch, attachment)]
[0001-5.6-Refactor-marker-initialization-in-erc-open.patch (text/x-patch, attachment)]
[0002-5.6-Adjust-some-old-text-properties-in-ERC-buffers.patch (text/x-patch, attachment)]
[0003-5.6-Expose-insertion-time-as-text-prop-in-erc-stamp.patch (text/x-patch, attachment)]
[0004-5.6-Make-some-erc-stamp-functions-more-limber.patch (text/x-patch, attachment)]
[0005-5.6-Put-display-properties-to-better-use-in-erc-stam.patch (text/x-patch, attachment)]
[0006-5.6-Convert-erc-fill-minor-mode-into-a-proper-module.patch (text/x-patch, attachment)]
[0007-5.6-Add-variant-for-erc-match-invisibility-spec.patch (text/x-patch, attachment)]
[0008-5.6-Add-erc-fill-style-based-on-visual-line-mode.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Thu, 09 Mar 2023 14:43:02 GMT) Full text and rfc822 format available.

Message #35 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Thu, 09 Mar 2023 06:42:34 -0800
[Message part 1 (text/plain, inline)]
v10. Redo some key bindings. Remove unneeded Compat functions. Rename
`erc-message' text prop to `erc-command'. Revive mistakenly deleted hunk
in erc-match.

[0000-v9-v10.diff (text/x-patch, attachment)]
[0001-5.6-Refactor-marker-initialization-in-erc-open.patch (text/x-patch, attachment)]
[0002-5.6-Adjust-some-old-text-properties-in-ERC-buffers.patch (text/x-patch, attachment)]
[0003-5.6-Expose-insertion-time-as-text-prop-in-erc-stamp.patch (text/x-patch, attachment)]
[0004-5.6-Make-some-erc-stamp-functions-more-limber.patch (text/x-patch, attachment)]
[0005-5.6-Put-display-properties-to-better-use-in-erc-stam.patch (text/x-patch, attachment)]
[0006-5.6-Convert-erc-fill-minor-mode-into-a-proper-module.patch (text/x-patch, attachment)]
[0007-5.6-Add-variant-for-erc-match-invisibility-spec.patch (text/x-patch, attachment)]
[0008-5.6-Add-erc-fill-style-based-on-visual-line-mode.patch (text/x-patch, attachment)]

bug marked as fixed in version 30.1, send any further explanations to 60936 <at> debbugs.gnu.org and "J.P." <jp <at> neverwas.me> Request was from "J.P." <jp <at> neverwas.me> to control <at> debbugs.gnu.org. (Sat, 08 Apr 2023 23:11:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Mon, 10 Apr 2023 20:50:02 GMT) Full text and rfc822 format available.

Message #40 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Mon, 10 Apr 2023 13:49:31 -0700
"J.P." <jp <at> neverwas.me> writes:

> v10. Redo some key bindings. Remove unneeded Compat functions. Rename
> `erc-message' text prop to `erc-command'. Revive mistakenly deleted hunk
> in erc-match.

This module probably shouldn't be hiding fringes without good reason or
calling `set-window-margins' on whatever window happens to be selected.
The current behavior also carries the potential to pollute the test
suite.

I've gone ahead and installed a small fix that hopefully addresses these
concerns. Thanks.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 09 May 2023 11:24:05 GMT) Full text and rfc822 format available.

bug unarchived. Request was from "J.P." <jp <at> neverwas.me> to control <at> debbugs.gnu.org. (Tue, 09 May 2023 19:31:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 09 May 2023 20:47:02 GMT) Full text and rfc822 format available.

Message #47 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 09 May 2023 13:46:32 -0700
Related followup (caught by the archive filter):

  https://lists.gnu.org/archive/html/emacs-erc/2023-05/msg00004.html




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Mon, 22 May 2023 04:22:02 GMT) Full text and rfc822 format available.

Message #50 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Sun, 21 May 2023 21:20:57 -0700
[Message part 1 (text/plain, inline)]
The following commit introduced a regression:

  commit 05f6fdb9e7893329baff675bd31fb36ad64c756d
  Author: F. Jason Park <jp <at> neverwas.me>

  Preserve ERC prompt and its bounding markers

  1 file changed, 27 insertions(+), 22 deletions(-)
  lisp/erc/erc.el | 49 +++++++++++++++++++++++++++----------------------


To reproduce from emacs -Q:

  1. Eval:

     (require 'erc)
     (setq erc-prompt (lambda () (format-time-string "%T>"))
           erc-autojoin-channels-alist '((ErgoTestnet "#test")))
     (erc-tls :server "testnet.ergo.chat")

  2. In #test, note the timestamp in the prompt
  3. Say "something" RET
  4. Notice that the prompt doesn't change, whereas in ERC 5.5 and
     earlier, it would change on every outgoing message

The attached patch fixes the regression and changes the behavior to
redraw the prompt on every incoming message as well, but only when
`erc-prompt' is a function. Doing this should bring us one step closer
to being able to look at

  bug#51082 erc-prompt: support substitution patterns "%target" and "%network"     

However, we'd still be missing user-mode tracking, which seems fairly
trivial to add.

[0001-5.6-Recompute-erc-prompt-when-inserting-messages.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 30 May 2023 14:16:02 GMT) Full text and rfc822 format available.

Message #53 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 30 May 2023 07:14:50 -0700
"J.P." <jp <at> neverwas.me> writes:

> The following commit introduced a regression:
>
>   commit 05f6fdb9e7893329baff675bd31fb36ad64c756d
>   Author: F. Jason Park <jp <at> neverwas.me>
>
> [...]
>
> The attached patch fixes the regression and changes the behavior to
> redraw the prompt on every incoming message as well, but only when
> `erc-prompt' is a function.

I've added this as

  commit 4f93c52f7fd1b7c5f75a0d049e5a1015a268265a
  
      Recompute erc-prompt when inserting messages
      
   lisp/erc/erc.el            | 16 ++++++++++--
   test/lisp/erc/erc-tests.el | 99 +++++++++++++++++++++++++++++++++++++++
   2 files changed, 113 insertions(+), 2 deletions(-)

along with

  commit 31a80f61ec03bcbb79720c0dc640272aba160865 (origin/master)
  
      Preserve prompt in erc-cmd-CLEAR
      
   etc/ERC-NEWS                       |  11 ++++
   lisp/erc/erc-log.el                |  17 ++++--
   lisp/erc/erc-stamp.el              |  16 +++++
   lisp/erc/erc-truncate.el           |  21 +++----
   lisp/erc/erc.el                    |   9 ++-
   test/lisp/erc/erc-scenarios-log.el | 207 ++++++++++++++++++++++++++++++
   6 files changed, 264 insertions(+), 17 deletions(-)

which fixes a bug affecting the /CLEAR command. It was introduced by

  05f6fdb9e78 "Preserve ERC prompt and its bounding markers"

and pointed out by incal on IRC. Some background:

For almost two decades, `erc-cmd-CLEAR' was simply defined as

  (recenter 0)

However, in 2019, it was changed to destructively truncate the current
buffer, something traditionally (though perhaps inadequately) provided
by the command `erc-save-buffer-in-logs' in concert with the option
`erc-truncate-buffer-on-save'. It happens that 05f6fdb9e78 "Preserve"
also introduced a regression affecting the latter option, which has
always suffered from an awkward implementation and insufficient
documentation (and, consequently, poor discoverability). In addition to
restoring its functionality, I've also deprecated it because of the
inherent confusion surrounding its usage and, to a lesser degree,
because it's redundant (/CLEAR now does the exact same thing). If anyone
thinks this rash or unwarranted, please say so. Thanks.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 28 Jun 2023 11:24:05 GMT) Full text and rfc822 format available.

bug unarchived. Request was from "J.P." <jp <at> neverwas.me> to control <at> debbugs.gnu.org. (Wed, 28 Jun 2023 20:57:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 28 Jun 2023 21:03:01 GMT) Full text and rfc822 format available.

Message #60 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 28 Jun 2023 14:02:06 -0700
Another one denied by the archive trap (mere minutes this time):

  https://lists.gnu.org/archive/html/emacs-erc/2023-06/msg00021.html




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Mon, 03 Jul 2023 13:15:01 GMT) Full text and rfc822 format available.

Message #63 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Mon, 03 Jul 2023 06:14:31 -0700
[Message part 1 (text/plain, inline)]
"J.P." <jp <at> neverwas.me> writes:

> A commit associated with this bug
>
>   d880a08f "Cement ordering of essential hook members in ERC"
>
> introduced a regression that basically nullifies the `match' module when
> a certain `erc-stamp' option is customized to a certain value. To
> reproduce from Emacs -Q:
>
>   - Set `erc-insert-timestamp-function' to `erc-insert-timestamp-left'
>
>   - Connect to any server
>
>   - Find the first mention of your nickname in the text of some early
>     numeric (often something like "Welcome to FooNet <nick>")
>
>   - Notice that it appears in plain `erc-notice-face' rather than
>     `erc-current-nick-face' (a "match" face)
>
> The attached patch should fix the issue. Thanks to Libera.Chat user jrm
> for reporting this bug.

Actually, the veracity of that claim is unclear and most likely bogus.
What is clear is that this approach is unsustainable because related
bugs are bound to crop up in the near future (if they haven't already).

Basically, in trying to code defensively around possibly encountering
unexpected text before inserted messages (such as leading stamps, white
space, decorations, etc.), my attempted solution traded superficial
robustness for a new dimension of complexity that's almost certainly
unsustainable. (This outcome was more or less predicted in the
justification for d880a08f "Cement ...", which this fix rather callously
contravened the spirit of.)

Anyway, to address all this, I think we should:

  1. Revert the previous attempted fix, which now exists on HEAD as

     commit 99d74dcd45938e2686d93eb5649800e14a88cd84
     Author: F. Jason Park <jp <at> neverwas.me>
     Date:   Tue Jun 27 20:47:26 2023 -0700
     
         Account for leading timestamps in erc-match
         
      lisp/erc/erc-match.el                |  41 ++++++++----
      test/lisp/erc/erc-scenarios-match.el | 120 +++++++++++++++++++++++++
      2 files changed, 149 insertions(+), 12 deletions(-)

  2. Undo the change of ordering for `erc-add-timestamp' and
     `erc-match-message' in `erc-insert-modify-hook' (from d880a08f
     "Cement ...").

  3. Take an entirely different tack bent on including (rather than
     omitting) time stamps from invisible messages. If not yet obvious,
     the impetus for the poor decision (of mine) to switch the order of
     those hook members was to improve the toggling of invisible
     elements created by the `match' module (and potentially others),
     and also to make logs less ragged when they feature invisible
     messages.

I'll go ahead and install the first of the attached patches (reverting
the misguided fix) and continue to iterate on the second, which proposes
the more comprehensive solution described in 3. Thanks.

> While we're at it, I'm thinking the option `erc-fill-spaced-commands',
> which has been on HEAD for a few months now, should be demoted to a
> plain variable, maybe even an internal one, because there aren't any
> obvious use cases for non-default values. Unless someone has a good
> argument to the contrary, I will do this in an accompanying patch to be
> installed along with this one. Thanks.

I've decided to instead lump this in with bug#64301 (speaker labels).

[0001-Revert-Account-for-leading-timestamps-in-erc-match.patch (text/x-patch, attachment)]
[0002-5.6-Respect-existing-invisibility-props-in-erc-stamp.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 18 Jul 2023 13:35:02 GMT) Full text and rfc822 format available.

Message #66 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 18 Jul 2023 06:33:49 -0700
[Message part 1 (text/plain, inline)]
This feature initially included a small omission in its lack of support
for left-sided time stamps. Apparently, they're popular enough to
warrant the additional complexity. The attached patch attempts to add
that support as well as fix a few related bugs.

It currently introduces two options:

  `erc-fill-wrap-margin-width'
  `erc-fill-wrap-margin-side'

Both are nil by default, but the second must be customized for users who
define their own `erc-insert-timestamp-function'.

Note that this variant behaves a little differently with regard to the
prompt, which appears in the left margin via `display' properties. The
option `erc-fill-wrap-width' controls the margin's starting width, which
defaults to either stamp width or prompt width: whichever's wider on
MOTD. The prompt is padded on the left and truncated on the right if
need be to conform to the margin. This look may take some getting used
to, but I think most will agree that it's preferable to the alternative,
which would see the prompt floating in no man's land, between the margin
and the "static center," where speaker labels are right-aligned.

As with the right margin, the left can also be adjusted in-session with
the command `erc-fill-wrap-nudge' and the keys `)', `_', and `+'.

On a related note, I'm also proposing we remove the `margin' Custom
:type choice for the option `erc-timestamp-align-to' (new in 5.6). It
was only ever tangentially related and doesn't really do much, and it
only really existed to service the needs of the internal minor mode
`erc-stamp--display-margin-mode'.

Thanks.

[0001-5.6-Make-erc-fill-wrap-work-with-left-hand-stamps.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 18 Jul 2023 13:56:01 GMT) Full text and rfc822 format available.

Message #69 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 18 Jul 2023 06:55:31 -0700
[Message part 1 (text/plain, inline)]
Quick fixup (misc/test-custom-opts just caught some sloppiness in my
Custom :type specs).

[0001-5.6-Make-erc-fill-wrap-work-with-left-hand-stamps.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 19 Jul 2023 13:17:01 GMT) Full text and rfc822 format available.

Message #72 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 19 Jul 2023 06:15:53 -0700
[Message part 1 (text/plain, inline)]
v2 (left-margin enhancement). Merge subsequent messages from a
status-prefixed speaker. Fix prompt not appearing in left margin on
/QUERY. Fix `visual-line-mode' not being restored after toggling off
`truncate-lines'. Have `erc-fill-wrap-nudge' print margin width.

[0000-v1-v2.diff (text/x-patch, attachment)]
[0001-5.6-Make-erc-fill-wrap-work-with-left-hand-stamps.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Thu, 20 Jul 2023 13:29:02 GMT) Full text and rfc822 format available.

Message #75 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Thu, 20 Jul 2023 06:28:41 -0700
[Message part 1 (text/plain, inline)]
v3 (left-margin enhancement). Extend stamp-only text properties to
leading white space on right-sided stamps occupying their own line.

[0000-v2-v3.diff (text/x-patch, attachment)]
[0001-5.6-Make-erc-fill-wrap-work-with-left-sided-stamps.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Sun, 23 Jul 2023 14:01:02 GMT) Full text and rfc822 format available.

Message #78 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Sun, 23 Jul 2023 07:00:07 -0700
[Message part 1 (text/plain, inline)]
"J.P." <jp <at> neverwas.me> writes:

> v3 (left-margin enhancement). Extend stamp-only text properties to
> leading white space on right-sided stamps occupying their own line.

This was installed as

  * 63d8b2a59a4 Make erc-fill-wrap work with left-sided stamps

Unfortunately, it introduced a regression involving CTCP ACTIONs from
consecutive speakers. To reproduce, say something in a target buffer,
then do a "/me something" immediately afterward. You'll see that ERC
inserts

  <nick> something
         something

instead of

  <nick> something
       * nick something

or

  <nick> something
  * nick something

The attached patch should fix this.

[0001-5.6-Fix-CTCP-ACTION-regression-in-erc-fill-wrap.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Sat, 29 Jul 2023 00:00:02 GMT) Full text and rfc822 format available.

Message #81 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Fri, 28 Jul 2023 16:59:18 -0700
"J.P." <jp <at> neverwas.me> writes:

> Unfortunately, it introduced a regression involving CTCP ACTIONs from
> consecutive speakers. To reproduce, say something in a target buffer,
> then do a "/me something" immediately afterward. You'll see that ERC
> inserts
>
>   <nick> something
>          something
>
> instead of
>
>   <nick> something
>        * nick something
>
> or
>
>   <nick> something
>   * nick something
>
> The attached patch should fix this.

This has been installed as

  8623159b Fix CTCP ACTION regression in erc-fill-wrap

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 09 Aug 2023 14:55:01 GMT) Full text and rfc822 format available.

Message #84 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 09 Aug 2023 07:53:53 -0700
[Message part 1 (text/plain, inline)]
I'd like to add a minor improvement and some small bug fixes to this
feature (new in ERC 5.6). The improvement concerns the command
`erc-fill-wrap-cycle-visual-movement', which cycles through three
flavors of interactive movement: "logcial-line", "screen-line", and
"DWIM". In an unfortunate omission (by me), basic line-wise movement
commands weren't initially included. But now I'm thinking users would at
least appreciate being able to navigate by whole IRC message when the
logical-line variant (nil state) is active. That's what the third patch
does.

The second patch introduces a minor change involving the mostly
unrelated bug#60933, which did away with the oddball "nickname" entry in
`erc-button-alist' and introduced an escape hatch (in the
function-valued variable `erc-button-nickname-callback-function') for
those needing access to the excised entry's "on-click" callback. The
interface was initially defined to accommodate the nick-button's
"erc-data" object, in this case a list containing a lone arg, the
nickname, to pass to the callback. However, in this instance, we're not
really obliged to preserve compatibility because this is a new variable,
and the old hard-wired callback, `erc-nick-popup', remains untouched.

Therefore, I think we should take this opportunity to redefine this
interface to accept any number of TBD trailing args after the nickname.
This will make it easier to retain more informative data for rich UI
features without resorting to hacks, like hiding data in text-properties
of public strings, which can leak memory. I also think we ought to
deprecate this variable even though it's new in ERC 5.6 to stress the
fact that the default value is basically required when using ERC as an
interactive client.

[0001-Relax-timeouts-on-some-ERC-tests.patch (text/x-patch, attachment)]
[0002-5.6-Deprecate-erc-button-nickname-callback-function.patch (text/x-patch, attachment)]
[0003-5.6-Add-line-wise-movement-commands-for-erc-fill-wra.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 09 Aug 2023 16:52:02 GMT) Full text and rfc822 format available.

Message #87 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: "J.P." <jp <at> neverwas.me>
Cc: 60936 <at> debbugs.gnu.org, emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 09 Aug 2023 18:50:58 +0200
"J.P." <jp <at> neverwas.me> writes:

Hi,

> There have been three failures (all on native-comp-speed2-master) over
> the last three weeks pointing to these tests, which haven't changed in
> the year-plus they've existed in tree.  No test appears in multiple
> failures, and all continue to pass daily on commercial GitLab (GCP)
> runners using the same EMBA container image.  They also pass locally
> with "make check" and "make -j -C test SELECTOR=t check-lisp-erc".  If
> these tweaks don't fix the problem, they can be branded :unstable.

If the problem happens only on emba, you can skip the tests with

--8<---------------cut here---------------start------------->8---
  :tags (if (getenv "EMACS_EMBA_CI")
            '(:expensive-test :unstable)
          '(:expensive-test))
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 15 Aug 2023 14:02:02 GMT) Full text and rfc822 format available.

Message #90 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 60936 <at> debbugs.gnu.org, emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 15 Aug 2023 07:01:44 -0700
Michael Albinus <michael.albinus <at> gmx.de> writes:

> "J.P." <jp <at> neverwas.me> writes:
>
> Hi,
>
>> There have been three failures (all on native-comp-speed2-master) over
>> the last three weeks pointing to these tests, which haven't changed in
>> the year-plus they've existed in tree.  No test appears in multiple
>> failures, and all continue to pass daily on commercial GitLab (GCP)
>> runners using the same EMBA container image.  They also pass locally
>> with "make check" and "make -j -C test SELECTOR=t check-lisp-erc".  If
>> these tweaks don't fix the problem, they can be branded :unstable.
>
> If the problem happens only on emba, you can skip the tests with
>
>   :tags (if (getenv "EMACS_EMBA_CI")
>             '(:expensive-test :unstable)
>           '(:expensive-test))
>
> Best regards, Michael.

Thanks Michael. I guess checking for

  (equal (get-env "CI_JOB_STAGE") "native-comp")

might also help unless that's inadvisable for some reason (though I'm
still hoping it doesn't come to this). And not that you should care, but
I've been waiting for

  bug#65176: ~25 test failures from make check in the latest master

to wrap up before installing this or similar.

BTW, does EMBA expose any public /metrics endpoints? I ask because
perhaps investigating possible relationships between intermittent
EMBA-only job failures and something like node-exporter signals [1]
might prove fruitful. Just a thought.

[1] https://docs.gitlab.com/ee/administration/monitoring/prometheus/index.html#prometheus-as-a-grafana-data-source




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 15 Aug 2023 16:13:01 GMT) Full text and rfc822 format available.

Message #93 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: "J.P." <jp <at> neverwas.me>
Cc: 60936 <at> debbugs.gnu.org, emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 15 Aug 2023 18:12:00 +0200
"J.P." <jp <at> neverwas.me> writes:

Hi,

> Thanks Michael. I guess checking for
>
>   (equal (get-env "CI_JOB_STAGE") "native-comp")
>
> might also help unless that's inadvisable for some reason (though I'm
> still hoping it doesn't come to this).

Should be OK. If you use `getenv'.

> And not that you should care, but I've been waiting for
>
>   bug#65176: ~25 test failures from make check in the latest master
>
> to wrap up before installing this or similar.

This bug has been closed yesterday.

> BTW, does EMBA expose any public /metrics endpoints? I ask because
> perhaps investigating possible relationships between intermittent
> EMBA-only job failures and something like node-exporter signals [1]
> might prove fruitful. Just a thought.
>
> [1] https://docs.gitlab.com/ee/administration/monitoring/prometheus/index.html#prometheus-as-a-grafana-data-source

I've enabled the /metrics endpoint on emba. This requires a restart of
gitlab, which I haven't done. Should happen next time, when gitlab
patches are installed (which is not my responsibility).

Best regards, Michael.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 15 Aug 2023 16:39:02 GMT) Full text and rfc822 format available.

Message #96 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: "J.P." <jp <at> neverwas.me>
Cc: 60936 <at> debbugs.gnu.org, emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 15 Aug 2023 18:37:45 +0200
Michael Albinus <michael.albinus <at> gmx.de> writes:

Hi,

>> BTW, does EMBA expose any public /metrics endpoints? I ask because
>> perhaps investigating possible relationships between intermittent
>> EMBA-only job failures and something like node-exporter signals [1]
>> might prove fruitful. Just a thought.
>>
>> [1] https://docs.gitlab.com/ee/administration/monitoring/prometheus/index.html#prometheus-as-a-grafana-data-source
>
> I've enabled the /metrics endpoint on emba. This requires a restart of
> gitlab, which I haven't done. Should happen next time, when gitlab
> patches are installed (which is not my responsibility).

Hmm. I've just read <https://docs.gitlab.com/ee/operations/>. It tells us

--8<---------------cut here---------------start------------->8---
Measure reliability and stability with metrics (removed)

This feature was deprecated in GitLab 14.7 and removed in 16.0.
--8<---------------cut here---------------end--------------->8---

So it might work ATM (we're using GitLab CE 13.12.15), but it might
disappear in the future.

Best regards, Michael.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 16 Aug 2023 14:29:02 GMT) Full text and rfc822 format available.

Message #99 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 60936 <at> debbugs.gnu.org, emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 16 Aug 2023 07:28:26 -0700
Michael Albinus <michael.albinus <at> gmx.de> writes:

> Michael Albinus <michael.albinus <at> gmx.de> writes:
>
>> I've enabled the /metrics endpoint on emba. This requires a restart of
>> gitlab, which I haven't done. Should happen next time, when gitlab
>> patches are installed (which is not my responsibility).
>
> Hmm. I've just read <https://docs.gitlab.com/ee/operations/>. It tells us
>
> Measure reliability and stability with metrics (removed)
>
> This feature was deprecated in GitLab 14.7 and removed in 16.0.
>
> So it might work ATM (we're using GitLab CE 13.12.15), but it might
> disappear in the future.

Hi Michael. This deprecation notice appears to be about GitLab's metrics
feature, which they describe as a managed Prometheus instance and
integrated dashboard solution for their enterprise product. Apparently,
they're replacing that with a full observability offering. In case
you're curious, they also say [1]:

  This deprecation does not include:

  - Deprecating alerts for Prometheus
  - Capabilities that GitLab comes with that allow operators of GitLab
    to retrieve metrics from those instances [2]

It's the second bullet I was referring to initially, which allows
external Prometheus instances to poll the /-/metrics endpoint if
exposed. But to be of any use, those instances would need their IP
addresses whitelisted. Additionally, we'd need a "node exporter" [3]
process running on the same host to provide intel on system-resource
consumption. In the end, this is probably too involved to be worth
anyone's while. So, I guess you can probably just revert whatever change
you made to the configuration. Thanks anyway and please pardon the
distraction.

[1] https://gitlab.com/gitlab-org/gitlab/-/issues/346541
[2] https://docs.gitlab.com/ee/administration/monitoring/prometheus/gitlab_metrics.html
[3] https://prometheus.io/docs/guides/node-exporter/




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 16 Aug 2023 17:40:02 GMT) Full text and rfc822 format available.

Message #102 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: "J.P." <jp <at> neverwas.me>
Cc: 60936 <at> debbugs.gnu.org, emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 16 Aug 2023 19:38:51 +0200
"J.P." <jp <at> neverwas.me> writes:

Hi,

> It's the second bullet I was referring to initially, which allows
> external Prometheus instances to poll the /-/metrics endpoint if
> exposed. But to be of any use, those instances would need their IP
> addresses whitelisted. Additionally, we'd need a "node exporter" [3]
> process running on the same host to provide intel on system-resource
> consumption. In the end, this is probably too involved to be worth
> anyone's while. So, I guess you can probably just revert whatever change
> you made to the configuration. Thanks anyway and please pardon the
> distraction.

No problem. I've disabled it on emba.

Best regards, Michael.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Thu, 31 Aug 2023 13:33:01 GMT) Full text and rfc822 format available.

Message #105 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Thu, 31 Aug 2023 06:31:46 -0700
[Message part 1 (text/plain, inline)]
One of my patches for this feature introduced a corner-case regression
involving the option `erc-echo-timestamps'. If `cursor-sensor-mode' is
somehow enabled outside of this module, then timestamps will still be
echoed even when `erc-echo-timestamps' is nil.

  commit ad3dc74e074719a58226e23a45c4556cd54c0a48
  Author: F. Jason Park <jp <at> neverwas.me>
  Date:   Wed Nov 24 03:10:20 2021 -0800
  
      Expose insertion time as text prop in erc-stamp
      
      * lisp/erc/erc-stamp.el (erc-add-timestamp): Add new text property
      [...]
      (erc-echo-timestamp): Make interactive and show timestamps even when
      the variable `erc-echo-timestamps' is nil.
      (erc--echo-ts-csf): Add new function to serve as value of
      cursor-sensor function text properties.
      * test/lisp/erc/erc-stamp-tests.el: New file.  (Bug#60936.)
  
   lisp/erc/erc-stamp.el            |  15 ++-
   test/lisp/erc/erc-stamp-tests.el | 207 +++++++++++++++++++++++++++++++++++++++
   2 files changed, 217 insertions(+), 5 deletions(-)

In addition to addressing the above, the attached patch includes a new
optional parameter for the command `erc-echo-timestamp'. It allows for
specifying a timezone for the echoed stamp via prefix argument or a new
option, `erc-echo-timestamp-zone'.

These changes are intended for ERC 5.6.

[0001-5.6-Allow-alternate-ert-info-text-in-ERC-test-utilit.patch (text/x-patch, attachment)]
[0002-5.6-Add-optional-timezone-param-to-erc-echo-timestam.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 13 Sep 2023 14:07:02 GMT) Full text and rfc822 format available.

Message #108 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 13 Sep 2023 07:06:28 -0700
"J.P." <jp <at> neverwas.me> writes:

> In addition to addressing the above, the attached patch includes a new
> optional parameter for the command `erc-echo-timestamp'. It allows for
> specifying a timezone for the echoed stamp via prefix argument or a new
> option, `erc-echo-timestamp-zone'.
>
> These changes are intended for ERC 5.6.

Added as

  commit 7c932fa307851ccef1cf17a1d7eec689af82a0ef
  Add optional timezone param to erc-echo-timestamp

This bug is already closed.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 13 Sep 2023 15:57:02 GMT) Full text and rfc822 format available.

Message #111 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: "J.P." <jp <at> neverwas.me>, 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50;
 ERC >5.5: Add erc-fill style based on visual-line-mode
Date: Wed, 13 Sep 2023 08:56:12 -0700
"J.P." <jp <at> neverwas.me> writes:

> One of my patches for this feature introduced a corner-case regression
> involving the option `erc-echo-timestamps'. If `cursor-sensor-mode' is
> somehow enabled outside of this module, then timestamps will still be
> echoed even when `erc-echo-timestamps' is nil.
>
>   commit ad3dc74e074719a58226e23a45c4556cd54c0a48
>   Author: F. Jason Park <jp <at> neverwas.me>
>   Date:   Wed Nov 24 03:10:20 2021 -0800
>
>       Expose insertion time as text prop in erc-stamp
>
>       * lisp/erc/erc-stamp.el (erc-add-timestamp): Add new text property
>       [...]
>       (erc-echo-timestamp): Make interactive and show timestamps even when
>       the variable `erc-echo-timestamps' is nil.
>       (erc--echo-ts-csf): Add new function to serve as value of
>       cursor-sensor function text properties.
>       * test/lisp/erc/erc-stamp-tests.el: New file.  (Bug#60936.)

I'm seeing new test failures with this file on master:

Running 6 tests (2023-09-13 16:45:56+0200, selector ‘(not (or (tag
:expensive-test) (tag :unstable) (tag :nativecomp)))’)
Test erc-echo-timestamp backtrace:
  signal(ert-test-failed (((should (equal (call-interactively #'erc-ec
  ert-fail(((should (equal (call-interactively #'erc-echo-timestamp) "
  #f(compiled-function () #<bytecode -0x766a19e4460e6be>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name erc-echo-timestamp :documentation nil
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ... ...))
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/erc/erc-stamp-tests"
  command-line()
  normal-top-level()
Test erc-echo-timestamp condition:
    (ert-test-failed
     ((should (equal (call-interactively ...) "1983-09-27 04:00:00 GMT"))
      :form (equal "1983-09-27 04:00:00 UTC" "1983-09-27 04:00:00 GMT")
      :value nil :explanation
      (array-elt 20 (different-atoms (85 "#x55" "?U") (71 "#x47" "?G")))))
   FAILED  1/6  erc-echo-timestamp (0.002433 sec) at
lisp/erc/erc-stamp-tests.el:277
   passed  2/6  erc-stamp--display-margin-mode--right (0.009260 sec)
   passed  3/6  erc-timestamp-intangible--left (0.012494 sec)
   passed  4/6  erc-timestamp-use-align-to--integer (0.007917 sec)
   passed  5/6  erc-timestamp-use-align-to--nil (0.015289 sec)
   passed  6/6  erc-timestamp-use-align-to--t (0.024845 sec)

Ran 6 tests, 5 results as expected, 1 unexpected (2023-09-13
16:45:56+0200, 0.484120 sec)

1 unexpected results:
   FAILED  erc-echo-timestamp

  GEN      lisp/eshell/em-dirs-tests.log
make[3]: *** [lisp/erc/erc-stamp-tests.log] Error 1

In GNU Emacs 30.0.50 (build 3, x86_64-apple-darwin21.6.0, NS
 appkit-2113.60 Version 12.6.9 (Build 21G726)) of 2023-09-13 built on
 MY-MacBook-Pro
Repository revision: 1f7113e68988fa0bcbdeca5ae364cba8d6db3637
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.6.9

Configured features:
ACL GIF GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS
PDUMPER PNG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP
XIM ZLIB




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 13 Sep 2023 23:12:01 GMT) Full text and rfc822 format available.

Message #114 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 60936 <at> debbugs.gnu.org, emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 13 Sep 2023 16:11:21 -0700
Stefan Kangas <stefankangas <at> gmail.com> writes:

> I'm seeing new test failures with this file on master:
>
> [...]
>   normal-top-level()
> Test erc-echo-timestamp condition:
>     (ert-test-failed
>      ((should (equal (call-interactively ...) "1983-09-27 04:00:00 GMT"))
>       :form (equal "1983-09-27 04:00:00 UTC" "1983-09-27 04:00:00 GMT")
>       :value nil :explanation
>       (array-elt 20 (different-atoms (85 "#x55" "?U") (71 "#x47" "?G")))))
>    FAILED  1/6  erc-echo-timestamp (0.002433 sec) at

Oof. Sorry about that. Should be fixed now (hopefully).




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 13 Sep 2023 23:41:02 GMT) Full text and rfc822 format available.

Message #117 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: "J.P." <jp <at> neverwas.me>
Cc: 60936 <at> debbugs.gnu.org, emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50;
 ERC >5.5: Add erc-fill style based on visual-line-mode
Date: Wed, 13 Sep 2023 16:40:00 -0700
"J.P." <jp <at> neverwas.me> writes:

> Should be fixed now (hopefully).

I can confirm that it is fixed.  Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Fri, 22 Sep 2023 14:12:01 GMT) Full text and rfc822 format available.

Message #120 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Fri, 22 Sep 2023 07:11:08 -0700
[Message part 1 (text/plain, inline)]
A couple more bugs stemming from this feature's introduction have
surfaced. The first involves stamp hiding when `erc-fill-wrap-mode' is
enabled. To reproduce from emacs -Q:

- Connect and join a channel
- In the channel buffer, set `erc-timestamp-last-inserted-left' to nil
- Say something and notice a new date stamp inserted
- Run M-x erc-toggle-timestamps RET
- Notice that the message after the stamp is dedented incorrectly

This problem occurs because date stamps are not well defined and
straddle roles occupied by normal stamps and standalone messages. The
remedy I've chosen retains compatibility at the cost of kicking the can
down the road WRT defining the precise role and expected behavior of
date stamps. (If still unclear, I say "date stamp" to mean a left-sided
stamp inserted by the function `erc-insert-timestamp-left-and-right' and
formatted using the string `erc-timestamp-format-left'.) This issue is
closely related to the interplay between normal right-hand stamps and
non-`fill-wrap' fill functions because the latter hard-wrap (i.e.,
"fill") messages, which results in a stamp often residing on its own
line.

The second issue comes down to the lack of an integration with
`text-scale-mode'. To reproduce from emacs -Q:

- Connect from a graphical Emacs
- In the server buffer, hit C-x C-=, and notice misaligned speaker tags
  among the upscaled text
- Run a command, like "/msg NickServ help", and notice the leading
  `erc-notice-prefix' portion of new messages correctly dedented
- Hit C-x C-0 and observe the just-inserted messages now looking mangled
  and the preexisting ones seemingly restored

The problem is that our `line-prefix' values use display specs with
pixel widths, which is needed for speakers with variable-width faces and
non-ascii chars. (Based on a cursory glance at relevant sections of the
manual, it doesn't look like there's an easy way to adjust these
automatically.) For now, I'm proposing we include a command to manually
traverse and refill target buffers. Luckily, this is much faster than
it'd be with some other `erc-fill-function' because no actual "filling"
takes place. We're just remeasuring speaker tags and replacing existing
display-spec values.

If you're affected by these bugs, please try these patches. Thanks.

[0001-5.6-Prefer-ticks-hz-pairs-for-erc-timestamp-values-o.patch (text/x-patch, attachment)]
[0002-5.6-Fix-date-stamp-invisibility-in-erc-fill-wrap.patch (text/x-patch, attachment)]
[0003-5.6-Add-command-to-refill-buffer-with-erc-fill-wrap-.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 27 Sep 2023 14:01:02 GMT) Full text and rfc822 format available.

Message #123 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 27 Sep 2023 06:59:48 -0700
[Message part 1 (text/plain, inline)]
v2. Move massaging of `invisible' date-stamp intervals from `erc-fill'
to `erc-stamp'. Ensure `erc-timestamp-format-left' has a trailing
newline. Add helper for easily removing `invisible' prop members. Ensure
`erc-fill' extends the `erc-command' text prop to cover prepended
whitespace. Don't add inherited `invisible' props to date stamps.

[0000-v1-v2.diff (text/x-patch, attachment)]
[0001-5.6-Prefer-ticks-hz-pairs-for-some-ERC-timestamps-on.patch (text/x-patch, attachment)]
[0002-5.6-Fix-date-stamp-invisibility-in-erc-fill-wrap.patch (text/x-patch, attachment)]
[0003-5.6-Add-command-to-refill-buffer-with-erc-fill-wrap-.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Fri, 06 Oct 2023 15:18:02 GMT) Full text and rfc822 format available.

Message #126 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Fri, 06 Oct 2023 08:17:23 -0700
[Message part 1 (text/plain, inline)]
v3. Move new meta-data related text properties to a single-character
interval at the head of every message. Add facility for managing such
props on behalf of modification hooks. Add utilities for retrieving data
from message-delimiting props and for traversing inserted messages.

In an attempt to tamp down on the growing mound of complications
involved in wrangling text properties across modules, I'm proposing a
general facility for managing certain props going forward. It works as
follows:

  1. confine meta-data related props to a one-char interval that, along
     with a preceding newline, delimit all message boundaries [1]

  2. apply nonessential message-spanning props, like
     `cursor-sensor-functions', lazily and only as needed by their
     controlling options [2]

  3. offer a means of passing state between hook stages, optionally to
     end up as properties in the meta-data interval

  4. keep this mechanism internal for the time being, but have it manage
     most props introduced in 5.6

In some ways, this amounts to a major reworking of how ERC handles
messages during and after insertion. Initially, I wanted to defer such
an endeavor to 5.7, but it's become clear to me that doing this now will
immensely fortify the implementation of various features shipping with
this release. If you're a module author or would-be contributor, it's in
your interest to keep an eye on how this unfolds. Happy to answer
questions or concerns, as always. Thanks.


[1] In an ideal world, a message's properties would live on its
    preceding newline. However, ERC's hooks have always visited messages
    along with their trailing newline. Obviously, having hooks see
    properties for the message to follow (or having the current
    message's props live on its trailing newline) would never work.

[2] Props whose intervals inform their role, such as buttons, faces, and
    display/formatting attributes, can't easily conform to this system.
    But, we can still benefit from formally declaring the hook stage
    (and maybe specific depth range) at which such props should be
    added. For example, message-spanning props ought to be applied no
    earlier than post-modification (e.g., `erc-send-post-hook' and
    `erc-insert-post-hook').

[0000-v2-v3.diff (text/x-patch, attachment)]
[0001-5.6-Allow-spoofing-process-marker-in-erc-display-lin.patch (text/x-patch, attachment)]
[0002-5.6-Honor-nil-values-in-erc-restore-initialize-prior.patch (text/x-patch, attachment)]
[0003-5.6-Preserve-format-spec-args-in-erc-server-JOIN.patch (text/x-patch, attachment)]
[0004-5.6-Deprecate-option-erc-remove-parsed-property.patch (text/x-patch, attachment)]
[0005-5.6-Add-helper-for-removing-list-valued-text-props-i.patch (text/x-patch, attachment)]
[0006-5.6-Manage-meta-data-text-props-for-ERC-hook-members.patch (text/x-patch, attachment)]
[0007-5.6-Add-command-to-refill-buffer-with-erc-fill-wrap-.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Sat, 14 Oct 2023 00:25:02 GMT) Full text and rfc822 format available.

Message #129 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Fri, 13 Oct 2023 17:24:15 -0700
I've added these changes as

  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c68dc778

Although I've done so with zero discussion, as usual, others can perhaps
take some comfort in knowing that this semi-major overhaul only reaches
as far back as the latest release (but not into it). Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Sat, 14 Oct 2023 17:05:01 GMT) Full text and rfc822 format available.

Message #132 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Sat, 14 Oct 2023 10:04:18 -0700
"J.P." <jp <at> neverwas.me> writes:

> I've added these changes as
>
>   https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c68dc778
>
> Although I've done so with zero discussion, as usual, others can perhaps
> take some comfort in knowing that this semi-major overhaul only reaches
> as far back as the latest release (but not into it). Thanks.

These changes introduced a(t least one) bug. To reproduce, call
`erc-display-line' with a list of buffers, and notice only the first
sees its message inserted with the correct text properties. A quick way
to simulate this is by having two clients join the same two channels
and then having one quit. The expected text props will be missing from
one of the inserted

  *** someuser (n!~u <at> h) has quit

messages. Verify by going to the first asterisk and doing C-u C-x =.

Fix forthcoming.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Mon, 16 Oct 2023 14:09:02 GMT) Full text and rfc822 format available.

Message #135 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Mon, 16 Oct 2023 07:07:44 -0700
[Message part 1 (text/plain, inline)]
"J.P." <jp <at> neverwas.me> writes:

> These changes introduced a(t least one) bug. To reproduce, call
> `erc-display-line' with a list of buffers, and notice only the first
> sees its message inserted with the correct text properties. A quick way
> to simulate this is by having two clients join the same two channels
> and then having one quit. The expected text props will be missing from
> one of the inserted
>
>   *** someuser (n!~u <at> h) has quit
>
> messages. Verify by going to the first asterisk and doing C-u C-x =.
>
> Fix forthcoming.

The second of the attached patches should hopefully do the trick.

[0001-Try-waiting-for-assertion-in-erc-scenarios-log.patch (text/x-patch, attachment)]
[0002-5.6-Restore-missing-metadata-props-in-erc-display-li.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 17 Oct 2023 13:49:02 GMT) Full text and rfc822 format available.

Message #138 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 17 Oct 2023 06:48:21 -0700
[Message part 1 (text/plain, inline)]
v2 (erc-display-line redux). Fix initial bug involving missing text
props on multi-buffer calls to `erc-display-line'. Convert latter to
internal function and reimplement interface as high-level wrapper around
`erc-display-message'.


"J.P." <jp <at> neverwas.me> writes:

> "J.P." <jp <at> neverwas.me> writes:
>
>> These changes introduced a(t least one) bug. To reproduce, call
>> `erc-display-line' with a list of buffers, and notice only the first
>> sees its message inserted with the correct text properties. A quick way
>> to simulate this is by having two clients join the same two channels
>> and then having one quit. The expected text props will be missing from
>> one of the inserted
>>
>>   *** someuser (n!~u <at> h) has quit
>>
>> messages. Verify by going to the first asterisk and doing C-u C-x =.
>>
>> Fix forthcoming.
>
> The second of the attached patches should hopefully do the trick.

Actually, merely hoping folks will use `erc-display-message' instead of
`erc-display-line' is surely delusional. There's likely far too much
code out there doing stuff like:

  (erc-display-line (erc-make-notice "foo") my-buffer)

So I've instead converted `erc-display-line' into a high-level insertion
function more aligned with the manner in which it's used in practice.
It's now more or less a thin wrapper around `erc-display-message' with a
bit of special casing to intercept instances of the `erc-make-notice'
pattern above for rewriting as:

  (erc-display-message nil 'notice my-buffer "foo")

Hopefully, this is an acceptable compromise.

[0000-v1-v2.diff (text/x-patch, attachment)]
[0001-Mark-erc-log-test-as-unstable.patch (text/x-patch, attachment)]
[0002-5.6-Restore-missing-metadata-props-in-erc-display-li.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Thu, 19 Oct 2023 14:04:02 GMT) Full text and rfc822 format available.

Message #141 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Thu, 19 Oct 2023 07:02:44 -0700
[Message part 1 (text/plain, inline)]
v3 (erc-display-line redux). Properly offset renarrowed region after
inserting initial date stamp in `erc-insert-timestamp-left-and-right'.
Don't displace third-party markers when inserting left-sided stamps in
`erc-stamp--display-margin-mode'.

The first bug was introduced by

  c68dc7786fc * Manage some text props for ERC insertion-hook members

and causes right-sided stamps to appear inside the prompt, among other
unpleasant things (see third patch). Thanks to Corwin for spotting this.
The other bug has been around a bit longer, likely since

  63d8b2a59a4 * Make erc-fill-wrap work with left-sided stamps

It has the potential to break packages that place markers in
modification hooks (see last patch).

[0000-v2-v3.diff (text/x-patch, attachment)]
[0001-Mark-erc-log-test-as-unstable.patch (text/x-patch, attachment)]
[0002-5.6-Restore-missing-metadata-props-in-erc-display-li.patch (text/x-patch, attachment)]
[0003-5.6-Fix-right-stamps-commingling-with-erc-prompt.patch (text/x-patch, attachment)]
[0004-5.6-Respect-user-markers-in-erc-insert-timestamp-lef.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 24 Oct 2023 02:21:01 GMT) Full text and rfc822 format available.

Message #144 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Mon, 23 Oct 2023 19:19:47 -0700
[Message part 1 (text/plain, inline)]
Some bugs have surfaced stemming from recent work on this initiative.
Most come down to sloppiness on my part. The worst of the bunch involves
`erc-insert-done-hook' being narrowed on date-stamp insertion, which
defies a tacit agreement to the contrary. A related bug concerns members
of the new internal date-stamp hook possibly running twice if the latter
has a buffer-local value.

I've also added a new helper for deleting inserted messages. It attempts
to respect user markers and invisibility props.

[0001-5.6-Ensure-marker-for-max-pos-in-erc-traverse-insert.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 24 Oct 2023 14:30:03 GMT) Full text and rfc822 format available.

Message #147 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 24 Oct 2023 07:29:16 -0700
[Message part 1 (text/plain, inline)]
v2. Fix date-stamp regression in erc-track. Optionally reinstate old
"prepended" date-stamp behavior gated by new compat var.

Earlier changes for this feature introduced a regression involving date
stamps and the option `erc-track-exclude-types'. Basically, date stamps
aren't supposed to affect the mode line, at least so long as their
inciting message's command appears in `erc-track-exclude-types'.
However, this changed after

  c68dc7786fc * Manage some text props for ERC insertion-hook members

To reproduce from -Q:

  1. Connect and ensure "JOIN" appears in `erc-track-exclude-types'
  2. Join #chan
  3. From the server buffer, do

     (with-current-buffer "#chan"
       (setq erc-timestamp-last-inserted-left nil))

  3. Connect and join #chan from another client
  4. Notice a [#c] in the mode line of the original client

Thanks to Corwin for pointing this out. The way I'm proposing we tackle
this is to decouple date stamps from `erc-track-exclude-types'
completely. That is, have erc-track completely ignore them, so they
never affect the mode line.

In addition to this fix, I've also added a path for accessing the old
behavior in which date stamps aren't standalone messages.

[0000-v1-v2.diff (text/x-patch, attachment)]
[0001-lisp-erc-erc.el-erc-after-connect-Remove-package-ver.patch (text/x-patch, attachment)]
[0002-5.6-Ignore-date-stamps-in-erc-track.patch (text/x-patch, attachment)]
[0003-5.6-Ensure-marker-for-max-pos-in-erc-traverse-insert.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Tue, 24 Oct 2023 17:12:01 GMT) Full text and rfc822 format available.

Message #150 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: Corwin Brust <corwin <at> bru.st>
To: "J.P." <jp <at> neverwas.me>
Cc: 60936 <at> debbugs.gnu.org, emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50;
 ERC >5.5: Add erc-fill style based on visual-line-mode
Date: Tue, 24 Oct 2023 12:10:22 -0500
[Message part 1 (text/plain, inline)]
On Tue, Oct 24, 2023 at 9:29 AM J.P. <jp <at> neverwas.me> wrote:

> v2. Fix date-stamp regression in erc-track. Optionally reinstate old
> "prepended" date-stamp behavior gated by new compat var.
>
> Earlier changes for this feature introduced a regression involving date
> stamps and the option `erc-track-exclude-types'. Basically, date stamps
>
>
[SNIP]


>
> To reproduce from -Q:
>
>   1. Connect and ensure "JOIN" appears in `erc-track-exclude-types'
>   2. Join #chan
>   3. From the server buffer, do
>
>      (with-current-buffer "#chan"
>        (setq erc-timestamp-last-inserted-left nil))
>
>   3. Connect and join #chan from another client
>   4. Notice a [#c] in the mode line of the original client
>
>
I can no longer reproduce after applying the 001-003 patches from your last
to rev 522a74d60a915ca9e922ad42dedc19d9f72e3ae5

Thank you JP!
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 25 Oct 2023 02:19:02 GMT) Full text and rfc822 format available.

Message #153 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 24 Oct 2023 19:17:51 -0700
"J.P." <jp <at> neverwas.me> writes:

> v2. Fix date-stamp regression in erc-track. Optionally reinstate old
> "prepended" date-stamp behavior gated by new compat var.
>
> [...]
>
> @@ -665,19 +666,17 @@ erc-stamp--insert-date-stamp-as-phony-message
>    (cl-assert string)
>    (let ((erc-stamp--skip t)
>          (erc--msg-props (map-into `((erc-msg . datestamp)
> -                                    (erc-ts . ,erc-stamp--current-time))
> +                                    (erc-ts . ,(erc-stamp--current-time)))
>                                    'hash-table))
> -        (erc-send-modify-hook `(,@erc-send-modify-hook
> -                                erc-stamp--propertize-left-date-stamp
> -                                ,@erc-stamp--insert-date-hook))
>          (erc-insert-modify-hook `(,@erc-insert-modify-hook
> -                                  erc-stamp--propertize-left-date-stamp
> -                                  ,@erc-stamp--insert-date-hook)))
> +                                  erc-stamp--propertize-left-date-stamp))
> +        ;; Don't run hooks that aren't expecting a narrowed buffer.

This also needs

           (erc-insert-pre-hook nil)

> +        (erc-insert-done-hook nil))
>      (erc-display-message nil nil (current-buffer) string)
>      (setq erc-timestamp-last-inserted-left string)))

because any hook member that can't operate in a narrowed buffer will
fail, especially on init, when the narrowed region is empty.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Mon, 30 Oct 2023 13:50:01 GMT) Full text and rfc822 format available.

Message #156 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Mon, 30 Oct 2023 06:48:32 -0700
"J.P." <jp <at> neverwas.me> writes:

> This also needs
>
>            (erc-insert-pre-hook nil)
>
>> +        (erc-insert-done-hook nil))
>>      (erc-display-message nil nil (current-buffer) string)
>>      (setq erc-timestamp-last-inserted-left string)))
>
> because any hook member that can't operate in a narrowed buffer will
> fail, especially on init, when the narrowed region is empty.

The change above was included as part of

  5c4a9b73031 * Use marker for max pos in erc--traverse-inserted

This bug is already closed.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 01 Nov 2023 00:30:01 GMT) Full text and rfc822 format available.

Message #159 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 31 Oct 2023 17:28:48 -0700
[Message part 1 (text/plain, inline)]
Recent work on this feature introduced an annoying regression.

From emacs -Q:

  1. M-: (erc-tls :server "testnet.inspircd.org") RET
  2. /JOIN #test and say something
  3. M-: (setq erc-timestamp-last-inserted-left nil) RET to reset the
     date stamp's deduping snapshot
  4. Say something else
  5. Notice that point has been dislodged from the prompt and that a new
     date stamp has not been inserted

The second of the attached patches should fix it.

[0001-5.6-Fix-concurrency-bug-in-erc-buffer-display-test.patch (text/x-patch, attachment)]
[0002-5.6-Preserve-point-when-inserting-date-stamps-in-ERC.patch (text/x-patch, attachment)]

Message #160 received at 60936-quiet <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936-quiet <at> debbugs.gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Sun, 05 Nov 2023 17:45:59 -0800
[Message part 1 (text/plain, inline)]
Screenshot storage (unrelated to this feature):

[erc-multi-target-match-hack.png (image/png, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Mon, 06 Nov 2023 02:32:01 GMT) Full text and rfc822 format available.

Message #163 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Sun, 05 Nov 2023 18:30:14 -0800
"J.P." <jp <at> neverwas.me> writes:

> Recent work on this feature introduced an annoying regression.
>
>>From emacs -Q:
>
>   1. M-: (erc-tls :server "testnet.inspircd.org") RET
>   2. /JOIN #test and say something
>   3. M-: (setq erc-timestamp-last-inserted-left nil) RET to reset the
>      date stamp's deduping snapshot
>   4. Say something else
>   5. Notice that point has been dislodged from the prompt and that a new
>      date stamp has not been inserted
>
> The second of the attached patches should fix it.

This and related fixes involving date stamps were recently installed.
See:

  * f99a0dae7ca Align date stamps to whole days in ERC
  * 4c851085769 Decouple disparate escape-hatch concerns in erc-stamp
  * 781f950edab Preserve user markers when inserting ERC date stamps
  * f7c7f7ac20d Don't over-truncate erc-timestamp-format-left

The second one might be of interest to users with a legitimate need to
call `erc-insert-line' (formerly `erc-display-line') directly, as
opposed to via `erc-display-message'. It's now possible to do so without
sacrificing timestamps and without also incurring the likely unwanted
`cursor-sensor-functions' property. (The latter now has its own separate
compatibility flag.)




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Mon, 13 Nov 2023 21:04:01 GMT) Full text and rfc822 format available.

Message #166 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Mon, 13 Nov 2023 13:01:47 -0800
[Message part 1 (text/plain, inline)]
I'm thinking it might make sense to have `fill-wrap' formally depend on
`scrolltobottom', even though there's no technical reason to do so. The
rare user who prefers otherwise can still get their way via
`erc-scrolltobottom-mode-hook'. Alternatively, we could just enable
`scrolltobottom' by default in a future release.

[0001-5.6-Make-erc-fill-wrap-depend-on-scrolltobottom.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Thu, 07 Dec 2023 07:15:02 GMT) Full text and rfc822 format available.

Message #169 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60936 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Wed, 06 Dec 2023 23:14:33 -0800
[Message part 1 (text/plain, inline)]
Changes related to this feature introduced a number of meta-data
oriented text properties that I think, in retrospect, should have been
double-hyphenated to dissuade users from depending on them. Also, a
couple of properties, like `erc-stamp-type', are superfluous, and can be
removed. The first of the attached patches should take care of this.

There's also (IMO) a rather obvious need for an `erc--spkr' property to
aid modules in quickly distinguishing between inserted messages based on
their speaker (nick). For example, a module that detects continued
messages that should be displayed as a single unit might otherwise have
to keep a local backlog or parse inserted messages at runtime. The
second of the attached patches tries to address this.

Lastly, in "designing" the makeup of these properties, I chose to assign
a constant `msg' value for the required `erc--msg' property to all
speaker-owned messages, like those originating from PRIVMSG and NOTICE
commands. The idea was to allow modules to distinguish between speaker
messages and other types. However, making `erc--msg' a union of `msg'
and `format-spec' "catalog" keys (and `erc-display-message' TYPE
parameters) meant coercing keys for speaker messages to `msg', thereby
discarding what now looks to be valuable information (especially in
light of bug#67677). Thus, I'm proposing we remove `msg' as an
advertised `erc--msg' value and instead rely on `erc--spkr' to convey
speaker associations. See bug#67677 for more.


[0003-5.6-Double-hyphenate-internal-ERC-5.6-text-props.patch (text/x-patch, attachment)]
[0004-5.6-Add-erc-spkr-text-property-to-chat-messages.patch (text/x-patch, attachment)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 04 Jan 2024 12:24:07 GMT) Full text and rfc822 format available.

bug unarchived. Request was from tzakmagiel <tzakmagiel <at> proton.me> to control <at> debbugs.gnu.org. (Thu, 15 Feb 2024 11:59:04 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Thu, 15 Feb 2024 12:02:01 GMT) Full text and rfc822 format available.

Message #176 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: tzakmagiel <tzakmagiel <at> proton.me>
To: "60936 <at> debbugs.gnu.org" <60936 <at> debbugs.gnu.org>
Subject: Re: bug#60936: 30.0.50;
 ERC >5.5: Add erc-fill style based on visual-line-mode
Date: Thu, 15 Feb 2024 12:01:07 +0000
+1'ing this the issue in Message #166 for visibility. I raised this question under the nick "alcor" on #erc yesterday, and I agree that the default behavior of `fill-wrap' (i.e. without `scrolltobottom') might be confusing/unexpected for new `fill-wrap' users (such as myself, in this case).

For the record, the behavior without the scrolltobottom module could be described as "messages tend to drift upward on screen, gradually increasing the whitespace between prompt and bottom of window" (This description courtesy of corwin on #erc).

>I'm thinking it might make sense to have `fill-wrap' formally depend on `scrolltobottom', even though there's no technical reason to do so.

+1 on that too. The behavior with `scrolltobottom' makes more sense (as a default) and is more in line with other IRC clients, where the message prompt is kept at the bottom of the window.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60936; Package emacs. (Wed, 21 Feb 2024 01:13:01 GMT) Full text and rfc822 format available.

Message #179 received at 60936 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: tzakmagiel <tzakmagiel <at> proton.me>
Cc: 60936 <at> debbugs.gnu.org
Subject: Re: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on
 visual-line-mode
Date: Tue, 20 Feb 2024 17:12:23 -0800
tzakmagiel writes:

> +1'ing this the issue in Message #166 for visibility. I raised this question
> under the nick "alcor" on #erc yesterday, and I agree that the default
> behavior of `fill-wrap' (i.e. without `scrolltobottom') might be
> confusing/unexpected for new `fill-wrap' users (such as myself, in this case).
>
> For the record, the behavior without the scrolltobottom module could be
> described as "messages tend to drift upward on screen, gradually increasing
> the whitespace between prompt and bottom of window" (This description courtesy
> of corwin on #erc).
>
>>I'm thinking it might make sense to have `fill-wrap' formally depend on
> `scrolltobottom', even though there's no technical reason to do so.
>
> +1 on that too. The behavior with `scrolltobottom' makes more sense (as a
> default) and is more in line with other IRC clients, where the message prompt
> is kept at the bottom of the window.

Appreciate the input. `fill-wrap' now activates `scrolltobottom' if not
already enabled and also reminds users to add it to `erc-modules' when
that's the case:

  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9668b4f9

Please let us know if something's still amiss or if the fix is otherwise
inadequate. Thanks.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 20 Mar 2024 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 8 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.