GNU bug report logs - #60945
[PATCH] Add support for building tree-sitter modules with MinGW

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60945 in the body.
You can then email your comments to 60945 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Add support for building tree-sitter modules with MinGW
Date: Thu, 19 Jan 2023 14:28:20 +0000

[Message part 1 (text/plain, inline)]

X-Debbugs-CC: casouri <at> gmail.com

See attached patch.

I think there was a bug report about supporting building tree-sitter modules on Windows but I can't find it.

[Message part 2 (text/html, inline)]

[0001-Add-support-for-building-tree-sitter-modules-with-Mi.patch (text/x-patch, attachment)]

Message #8 received at 60945 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: casouri <at> gmail.com
Cc: 60945 <at> debbugs.gnu.org
Subject: Re: bug#60945: [PATCH] Add support for building tree-sitter modules
 with MinGW
Date: Wed, 25 Jan 2023 01:42:35 +0000

[Message part 1 (text/plain, inline)]

> On Thursday, January 19th, 2023 at 09:28, Randy Taylor <dev <at> rjt.dev> wrote:
>
> X-Debbugs-CC: casouri <at> gmail.com
>
>See attached patch.
>
>I think there was a bug report about supporting building tree-sitter modules on >Windows but I can't find it.

Ping.

[Message part 2 (text/html, inline)]

Message #11 received at 60945 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 60945 <at> debbugs.gnu.org
Subject: Re: bug#60945: [PATCH] Add support for building tree-sitter modules
 with MinGW
Date: Tue, 24 Jan 2023 19:08:16 -0800

> On Jan 24, 2023, at 5:42 PM, Randy Taylor <dev <at> rjt.dev> wrote:
> 
> > On Thursday, January 19th, 2023 at 09:28, Randy Taylor <dev <at> rjt.dev> wrote:
> >
> > X-Debbugs-CC: casouri <at> gmail.com
> >
> >See attached patch.
> >
> >I think there was a bug report about supporting building tree-sitter modules on >Windows but I can't find it.
> 
> Ping.

Thanks, I applied it. Treesit-install-langauge-grammar should already handle windows, if all the difference is the extension, but someone with a Windows could give it a try and see, so we know for sure.

Yuan

Message #14 received at 60945 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: dev <at> rjt.dev, 60945 <at> debbugs.gnu.org
Subject: Re: bug#60945: [PATCH] Add support for building tree-sitter modules
 with MinGW
Date: Wed, 25 Jan 2023 14:23:21 +0200

> Cc: 60945 <at> debbugs.gnu.org
> From: Yuan Fu <casouri <at> gmail.com>
> Date: Tue, 24 Jan 2023 19:08:16 -0800
> 
> 
> 
> > On Jan 24, 2023, at 5:42 PM, Randy Taylor <dev <at> rjt.dev> wrote:
> > 
> > > On Thursday, January 19th, 2023 at 09:28, Randy Taylor <dev <at> rjt.dev> wrote:
> > >
> > > X-Debbugs-CC: casouri <at> gmail.com
> > >
> > >See attached patch.
> > >
> > >I think there was a bug report about supporting building tree-sitter modules on >Windows but I can't find it.
> > 
> > Ping.
> 
> Thanks, I applied it. Treesit-install-langauge-grammar should already handle windows, if all the difference is the extension, but someone with a Windows could give it a try and see, so we know for sure.

I indeed think that maintaining this script in admin is no longer
worth our while, since we have the treesit-install-langauge-grammar
command, which is both more portable and convenient, and doesn't need
a Posix shell to run.

Message #19 received at 60945-done <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Yuan Fu <casouri <at> gmail.com>
Cc: "60945-done <at> debbugs.gnu.org" <60945-done <at> debbugs.gnu.org>
Subject: Re: bug#60945: [PATCH] Add support for building tree-sitter modules
 with MinGW
Date: Sat, 28 Jan 2023 01:39:05 +0000

On Tuesday, January 24th, 2023 at 22:08, Yuan Fu <casouri <at> gmail.com> wrote:
> 
> > On Jan 24, 2023, at 5:42 PM, Randy Taylor dev <at> rjt.dev wrote:
> > 
> > > On Thursday, January 19th, 2023 at 09:28, Randy Taylor dev <at> rjt.dev wrote:
> > > 
> > > X-Debbugs-CC: casouri <at> gmail.com
> > > 
> > > See attached patch.
> > > 
> > > I think there was a bug report about supporting building tree-sitter modules on >Windows but I can't find it.
> > 
> > Ping.
> 
> 
> Thanks, I applied it. Treesit-install-langauge-grammar should already handle windows, if all the difference is the extension, but someone with a Windows could give it a try and see, so we know for sure.
> 
> Yuan

Thanks, closing this. I plan to try out that new functionality sometime next week.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.