GNU logs - #60974, boring messages

Message sent to monnier@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#60974: 30.0.50; byte-compile-preprocess mutates self evaluating forms in expanded macro bodies
Resent-From: Vibhav Pant <vibhavp@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: monnier@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 20 Jan 2023 21:25:01 +0000
Resent-Message-ID: <handler.60974.B.167424986120678 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 60974 <at> debbugs.gnu.org
Cc: monnier@HIDDEN
Message-ID: <b979003119097f23f6b13d5bc4f561596cdb9704.camel@HIDDEN>
From: Vibhav Pant <vibhavp@HIDDEN>
Date: Sat, 21 Jan 2023 02:54:05 +0530
Content-Type: multipart/signed; micalg="pgp-sha256";
 protocol="application/pgp-signature"; boundary="=-P76KcDcLHQmkm5YmgCwd"
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Received-SPF: pass client-ip=2a00:1450:4864:20::335;
 envelope-from=vibhavp@HIDDEN; helo=mail-wm1-x335.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)


--=-P76KcDcLHQmkm5YmgCwd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

`cconv-closure-convert`, called from `byte-compile-preprocess` calls
`setcar` on a self evaluating interactive form as part of the function
body. This can be reproduced by adding the following snippet to
`lisp/loadup.el`, and building Emacs:

```
(load "emacs-lisp/bytecomp")
(setq sample-interactive-spec
      (purecopy '(interactive
                  (list (if current-prefix-arg
                            (prefix-numeric-value=20
                             current-prefix-arg)
                          'toggle)))))

(defmacro define-purecopied-func ()
  `(defun foo-bar (arg)
     ,sample-interactive-spec))

(let ((byte-compile-debug t))
  (byte-compile '(define-purecopied-func)))
```
(`purecopy` ensures mutating the list triggers a `pure_write_error`)

As mutating quoted/constant lists is undefined behaviour as per the
Elisp reference manual
(https://www.gnu.org/software/emacs/manual/html_node/elisp/Mutability.htm
),
the body returned by `macroexpand-all` should likely be copied using
`copy-tree`.

In GNU Emacs 30.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
 3.24.36, cairo version 1.17.6) of 2023-01-05 built on vibhavp-mbp
Repository revision: 15fc7b3cde92e420f48dfe188251e6af4d832af5
Repository branch: master
System Description: Arch Linux

Configured using:
 'configure --with-pgtk --with-sqlite3 --with-native-compilation=3Dyes
 --with-all --without-compress-install --enable-link-time-optimization
 -C 'CFLAGS=3D-march=3Dnative -mtune=3Dnative -O3 -g3 -ggdb3 -gdwarf-5''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY
PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: (only . t)
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg
rfc6068
epg-config gnus-util text-property-search time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-
loaddefs
comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra
help-mode bytecomp byte-compile cl-lib sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv
eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq
simple cl-generic indonesian philippine cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button
loaddefs theme-loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads
dbusbind
inotify dynamic-setting system-font-setting font-render-setting cairo
gtk pgtk lcms2 multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 78180 10230)
 (symbols 48 7127 0)
 (strings 32 19480 1383)
 (string-bytes 1 595292)
 (vectors 16 16343)
 (vector-slots 8 326128 14214)
 (floats 8 28 51)
 (intervals 56 237 0)
 (buffers 984 11))

--=-P76KcDcLHQmkm5YmgCwd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEftHUjFE8oCS+Onhf4/soy2q1lZgFAmPLBnUACgkQ4/soy2q1
lZj+OAf9G416O/xWZ/g4lRsUSA4VM6JswitF3WYqCV7wo/NF+OuyWqSp7y0P+AKq
NnjhJ33i195B7/WwBjqQdHWf1r/wu/en1hit2MZKs6eFdtWT5r4uHu60CNzxKNkU
iMf056XS9jsc3Y6o04cWzojicMMI2USfqd0jif9BBJ8iuEG2kkeNyIoD+RoDV5fi
GT0XjEJ87C7uZ1eXth5VVAYgzAYOtxfE2+SU3WuxNsInXMqkm7HJRVlR0NieAuLB
6jdpw7ZmDnSMi7MZA2k2vwcDihs7FiDOEz8w+7T+7Y8ANGxzQCcHOgZnlYLEHChX
QM/QtTL3i1sa5hm/VPWPXU8vZhGBaA==
=ObXE
-----END PGP SIGNATURE-----

--=-P76KcDcLHQmkm5YmgCwd--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Vibhav Pant <vibhavp@HIDDEN>
Subject: bug#60974: Acknowledgement (30.0.50; byte-compile-preprocess
 mutates self evaluating forms in expanded macro bodies)
Message-ID: <handler.60974.B.167424986120678.ack <at> debbugs.gnu.org>
References: <b979003119097f23f6b13d5bc4f561596cdb9704.camel@HIDDEN>
X-Gnu-PR-Message: ack 60974
X-Gnu-PR-Package: emacs
Reply-To: 60974 <at> debbugs.gnu.org
Date: Fri, 20 Jan 2023 21:25:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  monnier@HIDDEN
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 60974 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
60974: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60974
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#60974: 30.0.50; byte-compile-preprocess mutates self evaluating forms in expanded macro bodies
References: <b979003119097f23f6b13d5bc4f561596cdb9704.camel@HIDDEN>
In-Reply-To: <b979003119097f23f6b13d5bc4f561596cdb9704.camel@HIDDEN>
Resent-From: Vibhav Pant <vibhavp@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 20 Jan 2023 21:37:01 +0000
Resent-Message-ID: <handler.60974.B60974.167425057030848 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 60974 <at> debbugs.gnu.org, monnier@HIDDEN
Cc: emacs-devel <emacs-devel@HIDDEN>
Message-ID: <6eb5f27bf591c3d52766d8b9da46e7301f2ff0ab.camel@HIDDEN>
From: Vibhav Pant <vibhavp@HIDDEN>
Date: Sat, 21 Jan 2023 03:05:51 +0530
Content-Type: multipart/signed; micalg="pgp-sha256";
 protocol="application/pgp-signature"; boundary="=-DSTct1ZHqnuHFzZw8eTt"
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


--=-DSTct1ZHqnuHFzZw8eTt
Content-Type: multipart/mixed; boundary="=-QQB76uzzYGO3ruGQtert"

--=-QQB76uzzYGO3ruGQtert
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

The attached patch should fix this, thoughts?

Best,
Vibhav

--=20
Vibhav Pant
vibhavp@HIDDEN
GPG: 7ED1 D48C 513C A024 BE3A  785F E3FB 28CB 6AB5 9598

--=-QQB76uzzYGO3ruGQtert
Content-Type: text/x-patch; name="60974.patch"; charset="UTF-8"
Content-Description: 
Content-Disposition: inline; filename="60974.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCBiL2xpc3AvZW1hY3MtbGlz
cC9ieXRlY29tcC5lbAppbmRleCBhYTk1MjFlNWE2NS4uODQ3OTY1ZTZhZjYgMTAwNjQ0Ci0tLSBh
L2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvYnl0ZWNv
bXAuZWwKQEAgLTI1ODEsNyArMjU4MSw4IEBAIGJ5dGUtY29tcGlsZS1mbHVzaC1wZW5kaW5nCiAK
IChkZWZ1biBieXRlLWNvbXBpbGUtcHJlcHJvY2VzcyAoZm9ybSAmb3B0aW9uYWwgX2Zvci1lZmZl
Y3QpCiAgIChsZXQgKChwcmludC1zeW1ib2xzLWJhcmUgdCkpICAgICAgICAgOyBQb3NzaWJseSBy
ZWR1bmRhbnQgYmluZGluZy4KLSAgICAoc2V0cSBmb3JtIChtYWNyb2V4cGFuZC1hbGwgZm9ybSBi
eXRlLWNvbXBpbGUtbWFjcm8tZW52aXJvbm1lbnQpKSkKKyAgICAoc2V0cSBmb3JtIChjb3B5LXRy
ZWUKKyAgICAgICAgICAgICAgICAobWFjcm9leHBhbmQtYWxsIGZvcm0gYnl0ZS1jb21waWxlLW1h
Y3JvLWVudmlyb25tZW50KSkpKQogICA7OyBGSVhNRTogV2Ugc2hvdWxkIHJ1biBieXRlLW9wdGlt
aXplLWZvcm0gaGVyZSwgYnV0IGl0IGN1cnJlbnRseSBkb2VzIG5vdAogICA7OyByZWN1cnNlIHRo
cm91Z2ggYWxsIHRoZSBjb2RlLCBzbyB3ZSdkIGhhdmUgdG8gZml4IHRoaXMgZmlyc3QuCiAgIDs7
IE1heWJlIGEgZ29vZCBmaXggd291bGQgYmUgdG8gbWVyZ2UgYnl0ZS1vcHRpbWl6ZS1mb3JtIGlu
dG8K


--=-QQB76uzzYGO3ruGQtert--

--=-DSTct1ZHqnuHFzZw8eTt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEftHUjFE8oCS+Onhf4/soy2q1lZgFAmPLCTcACgkQ4/soy2q1
lZhfBQgAwKXBa2acL/Hj+ugoUCPKXb/e567KSWsnzf7DOEgCd2qBKqCrXS5d1t3h
OY1ZvuGqNyQZGGBT/3SbOzGmbsAFmvJc8wYGLnOwvaRktYpvXZdx1Dx37IvJZ8wv
w3CPkZbtfZvMVfI84ZzEiDxnNCMaP42joWYGWnIWuBE4BgHWcCsmUipI1lVhEDRt
PH4ZDsYqITfSgoaHyzk2Y0GUUWsQtjoPiAwGWwO5ffaRQiOVcr8bbazI5ifxvj27
GdaO9nYpRP8tiamodB2GW6NEdRni0EHVhvOMKRwbxNMbbJ/plRRXENX/OzYXriyj
hYs/8sRHuPZN7aCRN9NeUQEWb441AA==
=rcM7
-----END PGP SIGNATURE-----

--=-DSTct1ZHqnuHFzZw8eTt--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#60974: [PATCH] 30.0.50; byte-compile-preprocess mutates self evaluating forms in expanded macro bodies
References: <b979003119097f23f6b13d5bc4f561596cdb9704.camel@HIDDEN>
In-Reply-To: <b979003119097f23f6b13d5bc4f561596cdb9704.camel@HIDDEN>
Resent-From: Vibhav Pant <vibhavp@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 20 Jan 2023 21:37:02 +0000
Resent-Message-ID: <handler.60974.B60974.167425061530909 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 60974 <at> debbugs.gnu.org, monnier@HIDDEN
Cc: emacs-devel <emacs-devel@HIDDEN>
Message-ID: <bdbc43eda9150848fc289d4afddb010cd567655f.camel@HIDDEN>
From: Vibhav Pant <vibhavp@HIDDEN>
Date: Sat, 21 Jan 2023 03:06:34 +0530
Content-Type: multipart/signed; micalg="pgp-sha256";
 protocol="application/pgp-signature"; boundary="=-cecALFqOIeboHZy/Q1p/"
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


--=-cecALFqOIeboHZy/Q1p/
Content-Type: multipart/mixed; boundary="=-fEXbxZCsjJhPTCi0JSkv"

--=-fEXbxZCsjJhPTCi0JSkv
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

The attached patch should fix this, thoughts?

Thanks,
Vibhav

--=20
Vibhav Pant
vibhavp@HIDDEN
GPG: 7ED1 D48C 513C A024 BE3A  785F E3FB 28CB 6AB5 9598

--=-fEXbxZCsjJhPTCi0JSkv
Content-Type: text/x-patch; name="60974.patch"; charset="UTF-8"
Content-Description: 
Content-Disposition: inline; filename="60974.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCBiL2xpc3AvZW1hY3MtbGlz
cC9ieXRlY29tcC5lbAppbmRleCBhYTk1MjFlNWE2NS4uODQ3OTY1ZTZhZjYgMTAwNjQ0Ci0tLSBh
L2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvYnl0ZWNv
bXAuZWwKQEAgLTI1ODEsNyArMjU4MSw4IEBAIGJ5dGUtY29tcGlsZS1mbHVzaC1wZW5kaW5nCiAK
IChkZWZ1biBieXRlLWNvbXBpbGUtcHJlcHJvY2VzcyAoZm9ybSAmb3B0aW9uYWwgX2Zvci1lZmZl
Y3QpCiAgIChsZXQgKChwcmludC1zeW1ib2xzLWJhcmUgdCkpICAgICAgICAgOyBQb3NzaWJseSBy
ZWR1bmRhbnQgYmluZGluZy4KLSAgICAoc2V0cSBmb3JtIChtYWNyb2V4cGFuZC1hbGwgZm9ybSBi
eXRlLWNvbXBpbGUtbWFjcm8tZW52aXJvbm1lbnQpKSkKKyAgICAoc2V0cSBmb3JtIChjb3B5LXRy
ZWUKKyAgICAgICAgICAgICAgICAobWFjcm9leHBhbmQtYWxsIGZvcm0gYnl0ZS1jb21waWxlLW1h
Y3JvLWVudmlyb25tZW50KSkpKQogICA7OyBGSVhNRTogV2Ugc2hvdWxkIHJ1biBieXRlLW9wdGlt
aXplLWZvcm0gaGVyZSwgYnV0IGl0IGN1cnJlbnRseSBkb2VzIG5vdAogICA7OyByZWN1cnNlIHRo
cm91Z2ggYWxsIHRoZSBjb2RlLCBzbyB3ZSdkIGhhdmUgdG8gZml4IHRoaXMgZmlyc3QuCiAgIDs7
IE1heWJlIGEgZ29vZCBmaXggd291bGQgYmUgdG8gbWVyZ2UgYnl0ZS1vcHRpbWl6ZS1mb3JtIGlu
dG8K


--=-fEXbxZCsjJhPTCi0JSkv--

--=-cecALFqOIeboHZy/Q1p/
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEftHUjFE8oCS+Onhf4/soy2q1lZgFAmPLCWIACgkQ4/soy2q1
lZirmAf9FW6U0BB3Maojv1E3u4aqaWHpER9jkOpE6dyLOXtske/ybxeQj2kFlaR6
hlgRd3Jv9HG+A2F+o+CWyXte3QnKEiqXJdNzCtH5i4lT3QqsRLfOjGWNWJGZ1pGx
ryeAKAjo8l5gdgj2+c/KFBkL6zePOk9ooKDp0QvIyBe+pb9kX60f/VgRB2khPhQF
Nqxrivqe4h9UrVMx4zTdM9SWD//T28Kjz8pK1hcBkgICM3pwuHXnlg7FwhejZRQT
r5FSdhGvODTp8TzMJqudGf2na1hBRGLltQq81ba7hgHtgX8MAudCPAXhCzQ7S8mx
+VzTEfqvTA20p3/LiD5n64Vrq5PZWA==
=hx6N
-----END PGP SIGNATURE-----

--=-cecALFqOIeboHZy/Q1p/--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#60974: 30.0.50; byte-compile-preprocess mutates self evaluating forms in expanded macro bodies
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 21 Jan 2023 05:44:01 +0000
Resent-Message-ID: <handler.60974.B60974.167427982725937 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60974
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Vibhav Pant <vibhavp@HIDDEN>
Cc: 60974 <at> debbugs.gnu.org, emacs-devel <emacs-devel@HIDDEN>
Received: via spool by 60974-submit <at> debbugs.gnu.org id=B60974.167427982725937
          (code B ref 60974); Sat, 21 Jan 2023 05:44:01 +0000
Received: (at 60974) by debbugs.gnu.org; 21 Jan 2023 05:43:47 +0000
Received: from localhost ([127.0.0.1]:47762 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pJ6fL-0006kG-4r
	for submit <at> debbugs.gnu.org; Sat, 21 Jan 2023 00:43:47 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62524)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1pJ6fI-0006k4-R2
 for 60974 <at> debbugs.gnu.org; Sat, 21 Jan 2023 00:43:45 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6422D1000DA;
 Sat, 21 Jan 2023 00:43:39 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B46121000D1;
 Sat, 21 Jan 2023 00:43:33 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1674279813;
 bh=MHhWUZlRqXViaZ64SsZWUTp1lm+CywRFE35Sbr1EI3E=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=cAux98NKLaaR8aW/ZvxjOs+daVzQwVN9OFtrAoJBMKpXxmPfLArKfS+LQ7LQKfj+7
 RxJcVl4slbHBmVTBT+9reC/tGgkCy51G3QekFa9fkU4VQSa/bB7senPoJx79XWZH6P
 Q2PE30nnjRXFkVzDjvnUxer2cWNe8Zlz9y0beUp/2m0uVe2GqLmjX/gf1jfj75QWdG
 52iuzIqyCGJhDD04TAo0MsRA13xaW/ZDlNNliMqLJwehbVdAt0ckYVXi1rQQQ7RXaP
 pmqLoixSmyDnCuVMJvXd7bqSMUUsg4tIsarYZomDUzigZu/E61/FIFJGS7S0LIm5FP
 PTfyaqZ+6YbwA==
Received: from alfajor (unknown [24.62.78.115])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6F1ED12128F;
 Sat, 21 Jan 2023 00:43:33 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <6eb5f27bf591c3d52766d8b9da46e7301f2ff0ab.camel@HIDDEN>
 (Vibhav Pant's message of "Sat, 21 Jan 2023 03:05:51 +0530")
Message-ID: <jwvlelwbg1e.fsf-monnier+emacs@HIDDEN>
References: <b979003119097f23f6b13d5bc4f561596cdb9704.camel@HIDDEN>
 <6eb5f27bf591c3d52766d8b9da46e7301f2ff0ab.camel@HIDDEN>
Date: Sat, 21 Jan 2023 00:43:31 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.088 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> The attached patch should fix this, thoughts?

It's not really an option:
- it's expensive
- it breaks code when it doesn't form a tree, e.g.

      (list '#1=(a b #1#) 'c 'd)

Instead, we need to find out where in the code we perform the
side effect and change just that part.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#60974: 30.0.50; byte-compile-preprocess mutates self evaluating forms in expanded macro bodies
Resent-From: Vibhav Pant <vibhavp@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 27 Jan 2023 12:45:02 +0000
Resent-Message-ID: <handler.60974.B60974.167482349830737 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 60974
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 60974 <at> debbugs.gnu.org, emacs-devel <emacs-devel@HIDDEN>
Received: via spool by 60974-submit <at> debbugs.gnu.org id=B60974.167482349830737
          (code B ref 60974); Fri, 27 Jan 2023 12:45:02 +0000
Received: (at 60974) by debbugs.gnu.org; 27 Jan 2023 12:44:58 +0000
Received: from localhost ([127.0.0.1]:36887 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pLO6D-0007zg-Rq
	for submit <at> debbugs.gnu.org; Fri, 27 Jan 2023 07:44:58 -0500
Received: from mail-wr1-f41.google.com ([209.85.221.41]:34527)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vibhavp@HIDDEN>) id 1pLO6B-0007zN-3g
 for 60974 <at> debbugs.gnu.org; Fri, 27 Jan 2023 07:44:56 -0500
Received: by mail-wr1-f41.google.com with SMTP id t18so4889564wro.1
 for <60974 <at> debbugs.gnu.org>; Fri, 27 Jan 2023 04:44:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:user-agent:references:in-reply-to:date:cc:to:from
 :subject:message-id:from:to:cc:subject:date:message-id:reply-to;
 bh=8EHWEPoEpRBK7mPFTt0qKDai1VxJMEO9Ux0cWJYGtXM=;
 b=BNE+NseMsas/OpbV2m3QAccJqC3dNY426Dp48kOzHKV5AEb5fu5Ak05W6mkNT9u7CX
 aG38z9fCUzkqMHFhvCQn4rBhOeu37cYc3xPRtBXzk0s8RoGUbP67zh1FA9s1Y/Wz4F4+
 dUSYYSh7CBdsddfRJ9HUz6lR8nr87OcgAYDGKZr3ixEplMdokxrCm7nYsd4Sv2ftchzf
 zdsejB0xsWH28eBPodQS+dSSNP5jDVk0oMsOd4H4s/Xkh/hCU1Hr9ql+LZcMOjAUltcM
 zdRZJlahLcVaxeQaoapPHQ6ZBVA0m06noHNP17xqx6pLH6t3AoLsBA0+B7u+kFRoCuY8
 WvIQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=mime-version:user-agent:references:in-reply-to:date:cc:to:from
 :subject:message-id:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=8EHWEPoEpRBK7mPFTt0qKDai1VxJMEO9Ux0cWJYGtXM=;
 b=VHZEbM6pkgdjuaZb8ECNLNY47PWhU5uv9fRR38mUGpLMg3/Zmk3aTKCqu/vozujckU
 ec/SLCf3+qon0hcIrAtO+o2y1+Tu4P90nu+3YBS9uQWTs58chOhQjV2to761IKhrhVt4
 iFKKRgpbBWVAvdL0wWeMaMPiiSUE7f8vpOIoA1J6NinEVN4a12ZFIMAh8ivopNto1BCN
 nZI5+5UjdeTAFryjtpAtcqr6zA2i5Bql0bJlxnnsfVRTXZvGkkKANV6Tqzz/VrFwo6k0
 3vIbaGmVwUf05SQMJh9FI1TM7V6TSWJj2+i0EiMOJO+KHaj7iKfnyEf4VfDz6klZw9MN
 OAjQ==
X-Gm-Message-State: AO0yUKXS8HnLpTKbAFf0nzRuD3uEqqgWCgqEDAIqU1YZOW8Bzn0Exkks
 B7AOxBm4auklk1YfKHnQcrU=
X-Google-Smtp-Source: AK7set8I+pj5ptMH4Dm9BFUBm2EOA/uxbLdSevQbCIaVIAUnZRKSNCd5gi0KUsQ9+wMKaGEaejW1/Q==
X-Received: by 2002:a05:6000:12cf:b0:2bf:cc40:5fd0 with SMTP id
 l15-20020a05600012cf00b002bfcc405fd0mr3779714wrx.47.1674823488616; 
 Fri, 27 Jan 2023 04:44:48 -0800 (PST)
Received: from vibhavp-mbp.local ([182.69.181.200])
 by smtp.gmail.com with ESMTPSA id
 x3-20020adfec03000000b002bfbf7679absm4064753wrn.107.2023.01.27.04.44.45
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Jan 2023 04:44:47 -0800 (PST)
Message-ID: <5ccd0d1f9f64a5fd20e5403a07b06d6074b6c8f6.camel@HIDDEN>
From: Vibhav Pant <vibhavp@HIDDEN>
Date: Fri, 27 Jan 2023 18:14:39 +0530
In-Reply-To: <jwvlelwbg1e.fsf-monnier+emacs@HIDDEN>
References: <b979003119097f23f6b13d5bc4f561596cdb9704.camel@HIDDEN>
 <6eb5f27bf591c3d52766d8b9da46e7301f2ff0ab.camel@HIDDEN>
 <jwvlelwbg1e.fsf-monnier+emacs@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha256";
 protocol="application/pgp-signature"; boundary="=-xAsm/8RXIzcIyachuYY2"
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-xAsm/8RXIzcIyachuYY2
Content-Type: multipart/mixed; boundary="=-d9FEfZBiaOYaNJRxPaJm"

--=-d9FEfZBiaOYaNJRxPaJm
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 2023-01-21 at 00:43 -0500, Stefan Monnier wrote:
> > The attached patch should fix this, thoughts?
>=20
> It's not really an option:
> - it's expensive
> - it breaks code when it doesn't form a tree, e.g.
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (list '#1=3D(a b #1#) 'c 'd)
>=20
> Instead, we need to find out where in the code we perform the
> side effect and change just that part.
>=20
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Stefan
>=20

Ah, right. Theother way I could think of a fix is setq-ing `form` to a
shallow copy of the original form, with only the place(s) changed. This
patch tries to do that by using `pcase-let` to destructure forms.
=20

--=20
Vibhav Pant
vibhavp@HIDDEN
GPG: 7ED1 D48C 513C A024 BE3A  785F E3FB 28CB 6AB5 9598

--=-d9FEfZBiaOYaNJRxPaJm
Content-Type: text/x-patch; name="60974-2.patch"; charset="UTF-8"
Content-Description: 
Content-Disposition: inline; filename="60974-2.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9jY29udi5lbCBiL2xpc3AvZW1hY3MtbGlzcC9j
Y29udi5lbAppbmRleCBlNzE1YmQ5MGEwMC4uZjYxNjBhMTM1NzkgMTAwNjQ0Ci0tLSBhL2xpc3Av
ZW1hY3MtbGlzcC9jY29udi5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvY2NvbnYuZWwKQEAgLTQ3
NywyMCArNDc3LDM3IEBAIGNjb252LWNvbnZlcnQKICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBicmFuY2gpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29u
ZC1mb3JtcykpKQogCi0gICAgKGAoZnVuY3Rpb24gKGxhbWJkYSAsYXJncyAuICxib2R5KSAuICxf
KQorICAgIChgKGZ1bmN0aW9uIChsYW1iZGEgLGFyZ3MgLiAsYm9keSkgLiAscmVzdCkKICAgICAg
KGxldCogKChkb2NzdHJpbmcgKGlmIChlcSA6ZG9jdW1lbnRhdGlvbiAoY2FyLXNhZmUgKGNhciBi
b2R5KSkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2NvbnYtY29udmVydCAoY2FkciAo
cG9wIGJvZHkpKSBlbnYgZXh0ZW5kKSkpCiAgICAgICAgICAgICAoYmYgKGlmIChzdHJpbmdwIChj
YXIgYm9keSkpIChjZHIgYm9keSkgYm9keSkpCiAgICAgICAgICAgICAoaWYgKHdoZW4gKGVxICdp
bnRlcmFjdGl2ZSAoY2FyLXNhZmUgKGNhciBiZikpKQogICAgICAgICAgICAgICAgICAgKGdldGhh
c2ggZm9ybSBjY29udi0taW50ZXJhY3RpdmUtZm9ybS1mdW5zKSkpCiAgICAgICAgICAgICAoY2lm
ICh3aGVuIGlmIChjY29udi1jb252ZXJ0IGlmIGVudiBleHRlbmQpKSkKLSAgICAgICAgICAgIChf
IChwY2FzZSBjaWYKLSAgICAgICAgICAgICAgICAgKGAjJyhsYW1iZGEgKCkgLGZvcm0pIChzZXRm
IChjYWRyIChjYXIgYmYpKSBmb3JtKSAoc2V0cSBjaWYgbmlsKSkKLSAgICAgICAgICAgICAgICAg
KCduaWwgbmlsKQotICAgICAgICAgICAgICAgICA7OyBUaGUgaW50ZXJhY3RpdmUgZm9ybSBuZWVk
cyBzcGVjaWFsIHRyZWF0bWVudCwgc28gdGhlIGZvcm0KLSAgICAgICAgICAgICAgICAgOzsgaW5z
aWRlIHRoZSBgaW50ZXJhY3RpdmUnIHdvbid0IGJlIHVzZWQgYW55IGZ1cnRoZXIuCi0gICAgICAg
ICAgICAgICAgIChfIChzZXRmIChjYWRyIChjYXIgYmYpKSBuaWwpKSkpCi0gICAgICAgICAgICAo
Y2YgKGNjb252LS1jb252ZXJ0LWZ1bmN0aW9uIGFyZ3MgYm9keSBlbnYgZm9ybSBkb2NzdHJpbmcp
KSkKKyAgICAgICAgICAgIChjZiBuaWwpKQorICAgICAgIChwY2FzZSBjaWYKKyAgICAgICAgIChg
IycobGFtYmRhICgpICxmb3JtKQorICAgICAgICAgIChwY2FzZS1sZXQgKChgKCgsZjEgLiAoLF8g
LiAsZjIpKSAuICxmMykgYmYpKQorICAgICAgICAgICAgKHNldHEgYmYgYCgoLGYxIC4gKCxmb3Jt
IC4gLGYyKSkgLiAsZjMpKSkKKyAgICAgICAgICAoc2V0cSBjaWYgbmlsKSkKKyAgICAgICAgICgn
bmlsIChzZXRxIGJmIG5pbCkpCisgICAgICAgICA7OyBUaGUgaW50ZXJhY3RpdmUgZm9ybSBuZWVk
cyBzcGVjaWFsIHRyZWF0bWVudCwgc28gdGhlIGZvcm0KKyAgICAgICAgIDs7IGluc2lkZSB0aGUg
YGludGVyYWN0aXZlJyB3b24ndCBiZSB1c2VkIGFueSBmdXJ0aGVyLgorICAgICAgICAgKF8gKHBj
YXNlLWxldCAoKGAoKCxmMSAuICgsXyAuICxmMikpIC4gLGYzKSBiZikpCisgICAgICAgICAgICAg
IChzZXRxIGJmIGAoKCxmMSAuIChuaWwgLiAsZjIpKSAuICxmMykpKSkpCisgICAgICAgKHdoZW4g
YmYKKyAgICAgICAgIDs7IElmIHdlIG1vZGlmaWVkIGJmLCByZS1idWlsZCBib2R5IGFuZCBmb3Jt
IGFzCisgICAgICAgICA7OyBjb3BpZXMgd2l0aCB0aGUgbW9kaWZpZWQgYml0cy4KKyAgICAgICAg
IChzZXRxIGJvZHkgKGlmIChzdHJpbmdwIChjYXIgYm9keSkpCisgICAgICAgICAgICAgICAgICAg
ICAgICAoY29ucyAoY2FyIGJvZHkpIGJmKQorICAgICAgICAgICAgICAgICAgICAgIGJmKQorICAg
ICAgICAgICAgICAgZm9ybSBgKGZ1bmN0aW9uIChsYW1iZGEgLGFyZ3MgLiAsYm9keSkgLiAscmVz
dCkpCisgICAgICAgICA7OyBBbHNvLCByZW1vdmUgdGhlIGN1cnJlbnQgb2xkIGVudHJ5IG9uIHRo
ZSBhbGlzdCwgcmVwbGFjaW5nCisgICAgICAgICA7OyBpdCB3aXRoIHRoZSBuZXcgb25lLgorICAg
ICAgICAgKGxldCAoKGVudHJ5IChwb3AgY2NvbnYtZnJlZXZhcnMtYWxpc3QpKSkKKyAgICAgICAg
ICAgKHB1c2ggKGNvbnMgYm9keSAoY2RyIGVudHJ5KSkgY2NvbnYtZnJlZXZhcnMtYWxpc3QpKSkK
KyAgICAgICAoc2V0cSBjZiAoY2NvbnYtLWNvbnZlcnQtZnVuY3Rpb24gYXJncyBib2R5IGVudiBm
b3JtIGRvY3N0cmluZykpCisKICAgICAgICAoaWYgKG5vdCBjaWYpCiAgICAgICAgICAgIDs7IE5v
cm1hbCBjYXNlLCB0aGUgaW50ZXJhY3RpdmUgZm9ybSBuZWVkcyBubyBzcGVjaWFsIHRyZWF0bWVu
dC4KICAgICAgICAgICAgY2YK


--=-d9FEfZBiaOYaNJRxPaJm--

--=-xAsm/8RXIzcIyachuYY2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEftHUjFE8oCS+Onhf4/soy2q1lZgFAmPTxzcACgkQ4/soy2q1
lZgz2Qf/UHy4ffvWBDuyVhlcYthWkvBCwo8x395Mn1rwWs4qA10yLnETish3PX1j
Vp7sQ1K3g9d1+nt1tkwbM1ixAK3dri6xy5fo9QuE2fMos+VUh7JjKiO4OQjpdthI
X0hyltmn3C5YzTQB0PX34hcqugEXS7tp50HfOJPs+hPhNpg4bBSebLUHqe7YKNQm
WnQ/xQIOg/jL388s3s8rPr1c3fmSHaEmBrhAHpudvcmfUEeiD1Xj4tCUqfydgtkL
mzJ47DS+ayppX212PGmMbYOIADraJatdr7r8sAW8YJKKuHbPt+646hhuUMgXI/p/
Q9iZ2OYchZUZMnFFRyQURXIFrvanCg==
=Zhh4
-----END PGP SIGNATURE-----

--=-xAsm/8RXIzcIyachuYY2--

Last modified: Fri, 27 Jan 2023 13:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.