GNU bug report logs - #60977
29.0.60; Dired: invalid face reference with dir symlinks

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: "Basil L. Contovounesios" <contovob@HIDDEN>; Keywords: patch; Done: "Basil L. Contovounesios" <contovob@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 60977-done <at> debbugs.gnu.org:


Received: (at 60977-done) by debbugs.gnu.org; 25 Jan 2023 14:33:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 25 09:33:45 2023
Received: from localhost ([127.0.0.1]:58724 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pKgqP-0001Oz-5H
	for submit <at> debbugs.gnu.org; Wed, 25 Jan 2023 09:33:45 -0500
Received: from mail-wm1-f45.google.com ([209.85.128.45]:35410)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <contovob@HIDDEN>) id 1pKgqJ-0001OD-Mg
 for 60977-done <at> debbugs.gnu.org; Wed, 25 Jan 2023 09:33:40 -0500
Received: by mail-wm1-f45.google.com with SMTP id
 fl11-20020a05600c0b8b00b003daf72fc844so1378244wmb.0
 for <60977-done <at> debbugs.gnu.org>; Wed, 25 Jan 2023 06:33:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=TyS7JImrGPytoGy2p0FTwavJAe4pzY1HdDpXLOgiBJA=;
 b=KUbzFg/8YOp0ylAfR9hrJIti7Mr8x9lSqL8MFxCX0LvrSyGC6QhaMksS/zSPaN3r3A
 JHgJvN2FsIi3zpgEmrxu7sTBTxulSA0/KERb38tO6DPMOGuE5F/wdr32DwJ3pYeg3kmk
 Si5oFQKKWowrO0EPPsaczN+mB4qK9vhwLxcb8nUW931ZXamDKAGfi46r709zNjzGvWG8
 Uzbyt4UfBjOSm6t6h7XdNL5aaOvYFcCKEhGkB/1X5ayVWe4Yj92rB8CbCEXwAxwvvbtm
 MPpJ3bjNIPyOgikndj6yP6VAxOaUKVZVbOXDBJzto4m1JDBEYzGFSHZezg6xmj6RhjxJ
 SwYQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=TyS7JImrGPytoGy2p0FTwavJAe4pzY1HdDpXLOgiBJA=;
 b=drTFkiFcY4QcotshEbH82Vk5srTNVkULV1YP9jRZpP23cQj9PVTLwcuOzztXy2x+Ay
 N4thMbqn1aK7ZI2mf96oHPgVdDVW2H8KsoEC1cshrNC18xyFPubSoHxi+ZU8XGgetDtl
 YHfPQ8Fj+qYns23pu1uczqGUaUsnsHnY8aj1tB5NcAHtBHh4e7H8gCFk19XdHaBqbBNq
 z2bfB7yR9xrLc5tOHpW9OiPRiXxYVAEtK+/5W2OpQ8XGk5p60GCHscDX7wLRrof8qlnU
 /pDkAeTTL8OMcPti7/itVJnK1yj1xADSdM8wOIA53h3b8Ev6trghVYzVPP0aG4qJFsIT
 wF9Q==
X-Gm-Message-State: AFqh2kqLkxOvYv2hMODGINy9vSDlRympikvRfsExLknhi22O/L+z1wuH
 XBPcuw9juX6P5eRCCDR8lBDUxA==
X-Google-Smtp-Source: AMrXdXsPhBlL2Q698aRVVkbisXNOfmdUmLWI4UaF3/G5+MCwXoivEOSPFljYjhznIU3a75l95HU9aA==
X-Received: by 2002:a05:600c:34d1:b0:3db:1637:e415 with SMTP id
 d17-20020a05600c34d100b003db1637e415mr27910752wmq.22.1674657214135; 
 Wed, 25 Jan 2023 06:33:34 -0800 (PST)
Received: from localhost ([109.79.184.182]) by smtp.gmail.com with ESMTPSA id
 r1-20020a05600c424100b003d9a86a13bfsm1930909wmm.28.2023.01.25.06.33.33
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 25 Jan 2023 06:33:33 -0800 (PST)
From: "Basil L. Contovounesios" <contovob@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#60977: 29.0.60; Dired: invalid face reference with dir
 symlinks
In-Reply-To: <835ycuhlev.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 25 Jan
 2023 07:03:14 -0500")
References: <87mt6cdaao.fsf@HIDDEN> <86wn5e7imn.fsf@HIDDEN>
 <87sfg1q7y7.fsf@HIDDEN> <83pmb4giwj.fsf@HIDDEN>
 <87mt67zckn.fsf@HIDDEN> <835ycuhlev.fsf@HIDDEN>
Date: Wed, 25 Jan 2023 14:33:32 +0000
Message-ID: <87cz72r8eb.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 1.5 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: close 60977 29.1 quit Eli Zaretskii [2023-01-25 07:03 -0500]
 wrote: >> From: "Basil L. Contovounesios" <contovob@HIDDEN> >> Cc:
 juri@HIDDEN, 60977 <at> debbugs.gnu.org >> Date: Wed,
 25 Jan 2023 00:23:52 +0000 >> >> My question
 was whether the patch in https://bugs.gnu. [...] 
 Content analysis details:   (1.5 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.5 RCVD_IN_SORBS_WEB      RBL: SORBS: sender is an abusable web server
 [109.79.184.182 listed in dnsbl.sorbs.net]
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
 [209.85.128.45 listed in wl.mailspike.net]
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [209.85.128.45 listed in list.dnswl.org]
 -0.0 SPF_PASS               SPF: sender matches SPF record
X-Debbugs-Envelope-To: 60977-done
Cc: 60977-done <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.5 (/)

close 60977 29.1
quit

Eli Zaretskii [2023-01-25 07:03 -0500] wrote:

>> From: "Basil L. Contovounesios" <contovob@HIDDEN>
>> Cc: juri@HIDDEN,  60977 <at> debbugs.gnu.org
>> Date: Wed, 25 Jan 2023 00:23:52 +0000
>> 
>> My question was whether the patch in https://bugs.gnu.org/60977#5 is
>> efficient and suitable enough for emacs-29, to fix a font lock
>> regression.
>
> Yes, thanks.

Done, thanks.

Fix Dired face for directory symlinks
c6613403e5c 2023-01-25 14:32:42 +0000
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=c6613403e5c

-- 
Basil




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60977; Package emacs. Full text available.
bug marked as fixed in version 29.1, send any further explanations to 60977 <at> debbugs.gnu.org and "Basil L. Contovounesios" <contovob@HIDDEN> Request was from "Basil L. Contovounesios" <contovob@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 60977 <at> debbugs.gnu.org:


Received: (at 60977) by debbugs.gnu.org; 25 Jan 2023 12:03:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 25 07:03:22 2023
Received: from localhost ([127.0.0.1]:58479 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pKeUs-0000iw-HK
	for submit <at> debbugs.gnu.org; Wed, 25 Jan 2023 07:03:22 -0500
Received: from eggs.gnu.org ([209.51.188.92]:45752)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pKeUq-0000id-TB
 for 60977 <at> debbugs.gnu.org; Wed, 25 Jan 2023 07:03:21 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pKeUa-0005Fy-Qa; Wed, 25 Jan 2023 07:03:10 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=fYhMeatlTI2VKxEgmoa2kk0C02NPsvPhuU3QyOcOOpg=; b=izsWCVjK4Nro
 4Xo6dEpOfkQnsuT7ePEqhQlgR5ZKZ/mlrC2AYoJPEJX4A+SyR9ER3MmiAli407YRngd52X8kYzP82
 SwhTLr9HUZUKB5+xwFyOqugRO3D4nk4AoJV1Ndr2h9sg8A1IvkB2Sk9laYOYF7FmZAJV5eMZQL6Cl
 VddXOlzJFbio0qCfh+swPeP3JDZgKoAmL+2xy2xgQAvfFQJd+c+2avLVnHdFlNfe6Jk69nQGJIPCP
 KW+dcG4vkBzZVZf27wX8zrY8bQCBw3SC3XgPi1ruPjrgRVrmMpcDyr5cYidNIDXeiBXn/8vFOPMvy
 t0tP9lfLBqtUkvN3WmmXHQ==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pKeTs-00046s-T5; Wed, 25 Jan 2023 07:02:42 -0500
Date: Wed, 25 Jan 2023 14:02:32 +0200
Message-Id: <835ycuhlev.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: "Basil L. Contovounesios" <contovob@HIDDEN>
In-Reply-To: <87mt67zckn.fsf@HIDDEN> (contovob@HIDDEN)
Subject: Re: bug#60977: 29.0.60; Dired: invalid face reference with dir
 symlinks
References: <87mt6cdaao.fsf@HIDDEN> <86wn5e7imn.fsf@HIDDEN>
 <87sfg1q7y7.fsf@HIDDEN> <83pmb4giwj.fsf@HIDDEN> <87mt67zckn.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60977
Cc: 60977 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: "Basil L. Contovounesios" <contovob@HIDDEN>
> Cc: juri@HIDDEN,  60977 <at> debbugs.gnu.org
> Date: Wed, 25 Jan 2023 00:23:52 +0000
> 
> Eli Zaretskii [2023-01-24 08:29 -0500] wrote:
> 
> > I'm sorry, but I don't see any questions you asked me about this
> > issue, and neither do I see it on debbugs in the discussion of the
> > issue.  What did I miss?
> 
> My question was whether the patch in https://bugs.gnu.org/60977#5 is
> efficient and suitable enough for emacs-29, to fix a font lock
> regression.

Yes, thanks.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60977; Package emacs. Full text available.

Message received at 60977 <at> debbugs.gnu.org:


Received: (at 60977) by debbugs.gnu.org; 25 Jan 2023 00:24:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 24 19:24:02 2023
Received: from localhost ([127.0.0.1]:57859 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pKTa6-0003f5-G8
	for submit <at> debbugs.gnu.org; Tue, 24 Jan 2023 19:24:02 -0500
Received: from mail-wm1-f45.google.com ([209.85.128.45]:42954)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <contovob@HIDDEN>) id 1pKTa4-0003ea-BY
 for 60977 <at> debbugs.gnu.org; Tue, 24 Jan 2023 19:24:01 -0500
Received: by mail-wm1-f45.google.com with SMTP id
 f25-20020a1c6a19000000b003da221fbf48so200001wmc.1
 for <60977 <at> debbugs.gnu.org>; Tue, 24 Jan 2023 16:24:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=jUMq/1o2r6fILPJr33YmU9xqJvqhGb8QwZCpCjgo+DQ=;
 b=Yi7c6gHqfbDzoOpjY1t7RvHQ+f1UZsNrln2BIGV2ugG9cbLuyDVnVR1At1Si8LLSOs
 W5PnqNIHfY8JE0R8pYqg6aB0AjelBBV3THVHuhmCNyurg6YMhMDbO/IEHHUyFkXctZ3i
 Qjj4ehVBn9LoulsQl8e7PcjNucgr8tr5PikoPO2jOlYf1HqTdLLAjIDq1IlKdbr6SP8h
 YdfAOg4347NbHYAggK2OGMYhGeBN3PCQHsRjX9HDrybke0FEvhFMKRmwCXCdjgrUnylA
 HeQMWT9EGWBhPAGQIN7gyIvRyDpmR4/M4kCv3tgpjMmlY4yUbpQbT+a3ncPF7FVkhlH0
 iM9A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=jUMq/1o2r6fILPJr33YmU9xqJvqhGb8QwZCpCjgo+DQ=;
 b=PWkSEqQCi7SmCjwSvL7yVFWWEbSTcJfgNk5dKaVVoD3aZaBmdzYN9qMZ9Sooq/Kbav
 kJV2Yf9FniQ+ePkKWA5qy0KKS+pApssiUlR0bqbriV6dXUVnYDIjLCsioZ6IZVjG9dQv
 bezeKylwXECRtwWOF+fQcav++4WQ1Md8n8fJnbs0/KSgKKCZzUL1xL0cWjcioIvt4Xga
 T/ZqFE87+yWFvET8+wJaNhgljeYUjJJVHcszoGRwhRs1+VsvufgnVFuTsMpuDAcXacFG
 e82Ym6HfSXyIU8C70ExCFMF1cCLgHNWaFnH2zSTK6ucEcbGAcGyFRALpwTT0Ia3FSWMm
 RE0Q==
X-Gm-Message-State: AFqh2kr4HhdbsE3tZxg/6o0EsmDWDkhHFDvUSuMjzBUAFqxZl/xOAev2
 UqLTQa6sT43lGmKU2s2J2tj9fA==
X-Google-Smtp-Source: AMrXdXtq1Vf6f7HF4Nhj11k4dE8+zNvFSBlp3iopdkxf2obT1jgEZIhZLiDmi0C6adKShBpCK1uHiA==
X-Received: by 2002:a05:600c:4191:b0:3d4:5741:af9b with SMTP id
 p17-20020a05600c419100b003d45741af9bmr37531177wmh.0.1674606234329; 
 Tue, 24 Jan 2023 16:23:54 -0800 (PST)
Received: from localhost ([64.43.154.54]) by smtp.gmail.com with ESMTPSA id
 y5-20020a05600c364500b003d9e74dd9b2sm266168wmq.9.2023.01.24.16.23.53
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 24 Jan 2023 16:23:53 -0800 (PST)
From: "Basil L. Contovounesios" <contovob@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#60977: 29.0.60; Dired: invalid face reference with dir
 symlinks
In-Reply-To: <83pmb4giwj.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 24 Jan
 2023 08:29:38 -0500")
References: <87mt6cdaao.fsf@HIDDEN> <86wn5e7imn.fsf@HIDDEN>
 <87sfg1q7y7.fsf@HIDDEN> <83pmb4giwj.fsf@HIDDEN>
Date: Wed, 25 Jan 2023 00:23:52 +0000
Message-ID: <87mt67zckn.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 60977
Cc: 60977 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii [2023-01-24 08:29 -0500] wrote:

>> Cc: 60977 <at> debbugs.gnu.org
>> Date: Mon, 23 Jan 2023 21:04:00 +0000
>> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>> 
>> >> But I don't know whether it's acceptable for emacs-29, or whether it
>> >> conses too much during font lock.  In the latter case, we could evaluate
>> >> dired-directory-face once (when dired-font-lock-keywords is defined), or
>> >> we could use the 'dired-directory' face directly.  WDYT?
>> >
>> > I think the effect of consing is negligible.
>> 
>> Thanks for confirming.
>> I'll install it once we hear from Eli re: emacs-29.
>
> I'm sorry, but I don't see any questions you asked me about this
> issue, and neither do I see it on debbugs in the discussion of the
> issue.  What did I miss?

My question was whether the patch in https://bugs.gnu.org/60977#5 is
efficient and suitable enough for emacs-29, to fix a font lock
regression.

Thanks,

-- 
Basil




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60977; Package emacs. Full text available.

Message received at 60977 <at> debbugs.gnu.org:


Received: (at 60977) by debbugs.gnu.org; 24 Jan 2023 13:29:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 24 08:29:45 2023
Received: from localhost ([127.0.0.1]:56145 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pKJMv-0004jr-GM
	for submit <at> debbugs.gnu.org; Tue, 24 Jan 2023 08:29:45 -0500
Received: from eggs.gnu.org ([209.51.188.92]:34964)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pKJMt-0004jc-FN
 for 60977 <at> debbugs.gnu.org; Tue, 24 Jan 2023 08:29:43 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pKJMn-0007Uf-GS; Tue, 24 Jan 2023 08:29:37 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=4mpvaK/7wuayqppWIYenOJxgQ74+5QkTB9SpAP5nCgA=; b=MriUj6vxwSAK
 iVHNtpCzuOy+0skFB1wtsYKR5iK/2oBshRb23M23LdSh44JP6eSWIO8bXnEav6e5Q9Sz9B4xl4F2F
 nKThotskhSYPrnHWEi4XyfWgHycyKjwqy0Ug/+XfSW9sKt7fsJumTki0C4w2lx6ojYvgrgnuL9wMn
 TfTVMuvzZNlRJ+OxstMJ+oymtuihc4OC+hez+ycWmrgLABf91KZzJyNLgi//64S+MjMp++QQoCu5K
 1J04+I7w1m+vcUbd16twwtUMxV1etg5YopkNnMw5abviveBP1Fi/1gUH777SnSJBkdbGy82DdVWtK
 rXeiOC0/HCKzUMS3jwN8MA==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pKJMm-0008Nt-R5; Tue, 24 Jan 2023 08:29:37 -0500
Date: Tue, 24 Jan 2023 15:29:48 +0200
Message-Id: <83pmb4giwj.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: "Basil L. Contovounesios" <contovob@HIDDEN>
In-Reply-To: <87sfg1q7y7.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#60977: 29.0.60;
 Dired: invalid face reference with dir symlinks
References: <87mt6cdaao.fsf@HIDDEN> <86wn5e7imn.fsf@HIDDEN>
 <87sfg1q7y7.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60977
Cc: 60977 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 60977 <at> debbugs.gnu.org
> Date: Mon, 23 Jan 2023 21:04:00 +0000
> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> >> But I don't know whether it's acceptable for emacs-29, or whether it
> >> conses too much during font lock.  In the latter case, we could evaluate
> >> dired-directory-face once (when dired-font-lock-keywords is defined), or
> >> we could use the 'dired-directory' face directly.  WDYT?
> >
> > I think the effect of consing is negligible.
> 
> Thanks for confirming.
> I'll install it once we hear from Eli re: emacs-29.

I'm sorry, but I don't see any questions you asked me about this
issue, and neither do I see it on debbugs in the discussion of the
issue.  What did I miss?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60977; Package emacs. Full text available.

Message received at 60977 <at> debbugs.gnu.org:


Received: (at 60977) by debbugs.gnu.org; 23 Jan 2023 21:04:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 23 16:04:10 2023
Received: from localhost ([127.0.0.1]:55433 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pK3z8-00079D-HV
	for submit <at> debbugs.gnu.org; Mon, 23 Jan 2023 16:04:10 -0500
Received: from mail-wr1-f54.google.com ([209.85.221.54]:40745)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <contovob@HIDDEN>) id 1pK3z5-00078y-Vc
 for 60977 <at> debbugs.gnu.org; Mon, 23 Jan 2023 16:04:08 -0500
Received: by mail-wr1-f54.google.com with SMTP id r2so12032339wrv.7
 for <60977 <at> debbugs.gnu.org>; Mon, 23 Jan 2023 13:04:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=MRG9Fu+i+sM+iKIQtHr/oUSnhkVSIB93ZIy+Gv6EZt0=;
 b=V/IDurLGCNCdZUyINP2xHMtRHmHoUY0OFUHQgRr72U3QWslJMbanRfoUdKPkxnEAKB
 Aje/9rgjy96+Uq7Nq6NU1RsjdeZtuIg27MsTBe4WOZ3U/Cc0vqIkKzCZnNucI9mARC79
 x+jlcZw5KcJXxb4H7gQrHk9D/+mBaT3XDluDq02/t81VDydROze4b71wOjZvSHPZsZPw
 aMRGPYHe+A/aheZMDorRBGiMKl+kU7M4GFXyvq2c8COoI/QzXn3UHmb2YIdRgoBQw07k
 uxoek/LlKMxBox6uPHBZUZYk7apQ8sC/kXOiGY3TE7T8QnmIZuyf9kKVp2zfCCQF2eeH
 P3Bw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=MRG9Fu+i+sM+iKIQtHr/oUSnhkVSIB93ZIy+Gv6EZt0=;
 b=uYOPKQ36NppThYoasuDcXJF5/AsmxVHJzwXqNiUOaML7gMV4+sB+QAsCZv3Zo+t9p/
 MrA6t70mIOUxXUYqsaGCHfNjvA5Lyx5SPAymgSlKsvLfmVvh5+8iNXUnpwtSbrK0SR1M
 Rf+9KtYBF94auOTIhz60lUbOV25qGlVpVmStjLCTp0UE2+HZXZI/Nwi4NdncEbL57Wxo
 N/v9hQvCmuQkDQIl79OFkGEr3lya/fSyOmlr2r2NZLZlBVkCIOUFPX8wweaLNTyX6ST2
 X3sz6MCE0S7+GeoVNo18d548+7HuY+qDNSPsQ75G8eluHQTitU/Fjh7gYyeuTVyGdvcf
 67pA==
X-Gm-Message-State: AFqh2kr4lw5J12JndF8R8RIhjSewJPZsDFp4lEtazMBP6rEkGk6fI8i/
 KXVCY90k3Gcj83bbkDqxbEqPwQ==
X-Google-Smtp-Source: AMrXdXvHSEWLQvHdH+6wSXB85ddgoPZNR2WmLTuUMxu64KREvEiGPIfl1l4ZwmEx8Nia1HQfq6e9oA==
X-Received: by 2002:adf:b604:0:b0:2bd:f35f:1b5e with SMTP id
 f4-20020adfb604000000b002bdf35f1b5emr22349457wre.4.1674507841903; 
 Mon, 23 Jan 2023 13:04:01 -0800 (PST)
Received: from localhost ([51.37.218.63]) by smtp.gmail.com with ESMTPSA id
 x12-20020adfdccc000000b002bddac15b3dsm288110wrm.33.2023.01.23.13.04.01
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 23 Jan 2023 13:04:01 -0800 (PST)
From: "Basil L. Contovounesios" <contovob@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#60977: 29.0.60; Dired: invalid face reference with dir
 symlinks
In-Reply-To: <86wn5e7imn.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 22 Jan 2023 19:05:44 +0200")
References: <87mt6cdaao.fsf@HIDDEN> <86wn5e7imn.fsf@HIDDEN>
Date: Mon, 23 Jan 2023 21:04:00 +0000
Message-ID: <87sfg1q7y7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 60977
Cc: 60977 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Juri Linkov [2023-01-22 19:05 +0200] wrote:

>> - Link target fontified with undefined 'dired-directory-face' face
>> - *Messages* says 'Invalid face reference: dired-directory-face'
>>
>> This seems to be a regression in Emacs 29 (https://bugs.gnu.org/57293):
>
> Thanks for finding this regression.
>
>> But I don't know whether it's acceptable for emacs-29, or whether it
>> conses too much during font lock.  In the latter case, we could evaluate
>> dired-directory-face once (when dired-font-lock-keywords is defined), or
>> we could use the 'dired-directory' face directly.  WDYT?
>
> I think the effect of consing is negligible.

Thanks for confirming.
I'll install it once we hear from Eli re: emacs-29.

-- 
Basil




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60977; Package emacs. Full text available.

Message received at 60977 <at> debbugs.gnu.org:


Received: (at 60977) by debbugs.gnu.org; 22 Jan 2023 17:13:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 22 12:13:53 2023
Received: from localhost ([127.0.0.1]:52565 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pJduj-0005Yp-0D
	for submit <at> debbugs.gnu.org; Sun, 22 Jan 2023 12:13:53 -0500
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:50527)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1pJduh-0005YU-EX
 for 60977 <at> debbugs.gnu.org; Sun, 22 Jan 2023 12:13:52 -0500
Received: (Authenticated sender: juri@HIDDEN)
 by mail.gandi.net (Postfix) with ESMTPSA id 324A060002;
 Sun, 22 Jan 2023 17:13:44 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: "Basil L. Contovounesios" <contovob@HIDDEN>
Subject: Re: bug#60977: 29.0.60; Dired: invalid face reference with dir
 symlinks
In-Reply-To: <87mt6cdaao.fsf@HIDDEN> (Basil L. Contovounesios's message of
 "Sat, 21 Jan 2023 00:02:39 +0000")
Organization: LINKOV.NET
References: <87mt6cdaao.fsf@HIDDEN>
Date: Sun, 22 Jan 2023 19:05:44 +0200
Message-ID: <86wn5e7imn.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 60977
Cc: 60977 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> - Link target fontified with undefined 'dired-directory-face' face
> - *Messages* says 'Invalid face reference: dired-directory-face'
>
> This seems to be a regression in Emacs 29 (https://bugs.gnu.org/57293):

Thanks for finding this regression.

> But I don't know whether it's acceptable for emacs-29, or whether it
> conses too much during font lock.  In the latter case, we could evaluate
> dired-directory-face once (when dired-font-lock-keywords is defined), or
> we could use the 'dired-directory' face directly.  WDYT?

I think the effect of consing is negligible.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#60977; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 21 Jan 2023 00:02:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 20 19:02:55 2023
Received: from localhost ([127.0.0.1]:47546 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pJ1LS-0006DQ-Jl
	for submit <at> debbugs.gnu.org; Fri, 20 Jan 2023 19:02:55 -0500
Received: from lists.gnu.org ([209.51.188.17]:54966)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <contovob@HIDDEN>) id 1pJ1LN-0006DB-G4
 for submit <at> debbugs.gnu.org; Fri, 20 Jan 2023 19:02:53 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <contovob@HIDDEN>) id 1pJ1LM-0004bC-V3
 for bug-gnu-emacs@HIDDEN; Fri, 20 Jan 2023 19:02:49 -0500
Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <contovob@HIDDEN>) id 1pJ1LJ-0000Ux-Do
 for bug-gnu-emacs@HIDDEN; Fri, 20 Jan 2023 19:02:48 -0500
Received: by mail-wr1-x433.google.com with SMTP id d14so2468969wrr.9
 for <bug-gnu-emacs@HIDDEN>; Fri, 20 Jan 2023 16:02:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21;
 h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=FgvUPGbBnc3/kpazpPuSLmtc2L5XnaqWOYQpY0/vh6g=;
 b=CleBOAyI34CcsCUw5Je6FgQ3JQjafi6rn/ZeDcZrR4FfbEs7K/mBlSsfVWhJs5KSfU
 ieBzIvqgjN86+8h1tsV5bDxykJyqO8hOeItricbQJdis6z32gBHyl0jnfAC/+oakmIfo
 9sjGM4/OEVhR89ALtXEXrbCjPIe5Ic74FW89Dyzc86umr4fp0Ulu4T9Ca0ZdMleQLGAO
 wk+5exbQOJqGk6GJxk4yb4TCxOXPmeP81FgIebNjvYzKdZ7Skdio79QAFVrrgn8bW1bG
 Vn+8o7iIf9qQeZ+KOy12jSJGj3SJRk696q+E4ZwILX2KQUOAEAs0t8bV+Mz3l28Mq4zK
 dfzQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=mime-version:message-id:date:subject:to:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=FgvUPGbBnc3/kpazpPuSLmtc2L5XnaqWOYQpY0/vh6g=;
 b=yXylCF8fLuVC4HhAAUCDoa1h/75ZITT5lw4sin7Yn1Fwv9YQkeBQtFoI1E2NiUNZBb
 5+puzanT9ZxxzzSVkkLVRMQFxMnkI2wf0cdzSS+rEbW4XL/IWbH4O26Pz5uNVYmZlwoC
 Irv8F9giQaqI1LVQEAz2XBM91KjLtWXL7vB4EFj36FGRF4qISrHujXro5L2SS2YZ5+/4
 WlN4LcRg6kCPGGE7pNKJYGZYGTcB5NsJcQLiaERlh431gpNh33FY/y7UGG1CpZ4QEzQU
 Gm3vaXSEy7IXaPfJaOsVWZAyB/LBTtAJaTkfdidhVO3ilp4ARl3jhOTTaEJNAXHHqQWj
 /f0w==
X-Gm-Message-State: AFqh2kpvVESVWfQUOtO0rJ6ggLnrUcw8RvYdOjVOgnvE5qe1LYZUmdnv
 /JXiTxI3Z9qNwpK86Qzsq3B3QyZk6eWA5wKR
X-Google-Smtp-Source: AMrXdXsIet58D2eeuBp2IYbGaaElHZfG1Oj3oT7jGzCVUv2gerbzjuhyEX4PFLTGRaojROf2d0OHVA==
X-Received: by 2002:adf:fa88:0:b0:2bd:feb5:fb7b with SMTP id
 h8-20020adffa88000000b002bdfeb5fb7bmr13308344wrr.33.1674259361422; 
 Fri, 20 Jan 2023 16:02:41 -0800 (PST)
Received: from localhost ([93.107.216.56]) by smtp.gmail.com with ESMTPSA id
 c13-20020adffb0d000000b00241fde8fe04sm36523945wrr.7.2023.01.20.16.02.40
 for <bug-gnu-emacs@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 20 Jan 2023 16:02:40 -0800 (PST)
From: "Basil L. Contovounesios" <contovob@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.60; Dired: invalid face reference with dir symlinks
X-Debbugs-Cc: Juri Linkov <juri@HIDDEN>
Date: Sat, 21 Jan 2023 00:02:39 +0000
Message-ID: <87mt6cdaao.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::433;
 envelope-from=contovob@HIDDEN; helo=mail-wr1-x433.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain

Tags: patch

0. emacs -Q
1. C-h e
2. (let* ((parent (make-temp-file "my-" t))
          (child  (expand-file-name "child" parent))
          (link   (expand-file-name "link" parent)))
     (make-directory child)
     (make-symbolic-link child link)
     (dired parent))
   C-x C-e

Expected:
- Link target fontified with 'dired-directory' face
Result:
- Link target fontified with undefined 'dired-directory-face' face
- *Messages* says 'Invalid face reference: dired-directory-face'

This seems to be a regression in Emacs 29 (https://bugs.gnu.org/57293):

Use a list of text properties to search in symlink filenames in Wdired
0ab49d46ddb 2022-08-27 22:43:40 +0300
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=0ab49d46ddb

Something like this would fix the problem:


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=dired.diff

diff --git a/lisp/dired.el b/lisp/dired.el
index 42d15f27a54..2bcb28a0e00 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -789,7 +789,7 @@ dired-font-lock-keywords
                '(dired-move-to-filename)
                nil
                '(1 dired-symlink-face)
-               '(2 '(face dired-directory-face dired-symlink-filename t))))
+               '(2 `(face ,dired-directory-face dired-symlink-filename t))))
    ;;
    ;; Symbolic link to a non-directory.
    (list dired-re-sym

--=-=-=
Content-Type: text/plain


But I don't know whether it's acceptable for emacs-29, or whether it
conses too much during font lock.  In the latter case, we could evaluate
dired-directory-face once (when dired-font-lock-keywords is defined), or
we could use the 'dired-directory' face directly.  WDYT?

Thanks,

-- 
Basil

In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw3d scroll bars) of 2023-01-20 built on tia
Repository revision: d63e1a89518338bc3450b11d6c2d4644cb0440e1
Repository branch: wt/emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12101006
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure 'CFLAGS=-O0 -ggdb3' --prefix=/home/blc/.local
 --program-suffix=-29 --enable-checking=yes,glyphs
 --enable-check-lisp-object-type --with-file-notification=yes
 --with-native-compilation --with-x-toolkit=lucid --with-x'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM
XINPUT2 XPM LUCID ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Dired by name

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny rfc822
mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util
text-property-search time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils dired-aux cl-loaddefs comp
comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode
bytecomp byte-compile cl-lib dired dired-loaddefs rmc iso-transl tooltip
cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo x-toolkit
xinput2 x multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 83436 6516)
 (symbols 48 7258 0)
 (strings 32 24732 1773)
 (string-bytes 1 750425)
 (vectors 16 18404)
 (vector-slots 8 343752 13751)
 (floats 8 42 33)
 (intervals 56 297 0)
 (buffers 984 12))

--=-=-=--




Acknowledgement sent to "Basil L. Contovounesios" <contovob@HIDDEN>:
New bug report received and forwarded. Copy sent to juri@HIDDEN, bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to juri@HIDDEN, bug-gnu-emacs@HIDDEN:
bug#60977; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 25 Jan 2023 14:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.