GNU bug report logs - #60984
30.0.50; c-ts-mode: indentation styles broken after new brace code

Previous Next

Package: emacs;

Reported by: Theodor Thornhill <theo <at> thornhill.no>

Date: Sat, 21 Jan 2023 12:44:01 UTC

Severity: normal

Found in version 30.0.50

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60984 in the body.
You can then email your comments to 60984 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#60984; Package emacs. (Sat, 21 Jan 2023 12:44:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Theodor Thornhill <theo <at> thornhill.no>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 21 Jan 2023 12:44:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; c-ts-mode: indentation styles broken after new brace code
Date: Sat, 21 Jan 2023 13:43:12 +0100

Hi!

It seems there has been some regressions wrt indentation styles with the
new brace counting code - for example with bsd style:

Previously:

int
main()
{
  if (x)
  {

  }
  else
  {

  }
}

now:

int
main()
{
  if (x)
  {

    }
  else
  {

    }
}

I'll try to tweak the code so that all indentation styles work and add
tests.

Theo
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60984; Package emacs. (Thu, 26 Jan 2023 07:56:02 GMT) Full text and rfc822 format available.

Message #8 received at 60984 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 60984 <at> debbugs.gnu.org
Subject: Re: bug#60984: 30.0.50; c-ts-mode: indentation styles broken after 
 new brace code
Date: Wed, 25 Jan 2023 23:54:49 -0800

Theodor Thornhill <theo <at> thornhill.no> writes:

> Hi!
>
> It seems there has been some regressions wrt indentation styles with the
> new brace counting code - for example with bsd style:
>
> Previously:
>
> int
> main()
> {
>   if (x)
>   {
>
>   }
>   else
>   {
>
>   }
> }
>
> now:
>
> int
> main()
> {
>   if (x)
>   {
>
>     }
>   else
>   {
>
>     }
> }
>
> I'll try to tweak the code so that all indentation styles work and add
> tests.
>
> Theo

Yeah sorry about that, I think this is fixed now.

Yuan
Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Wed, 06 Sep 2023 00:07:02 GMT) Full text and rfc822 format available.
Notification sent to Theodor Thornhill <theo <at> thornhill.no>:
bug acknowledged by developer. (Wed, 06 Sep 2023 00:07:02 GMT) Full text and rfc822 format available.

Message #13 received at 60984-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 60984-done <at> debbugs.gnu.org, Theodor Thornhill <theo <at> thornhill.no>
Subject: Re: bug#60984: 30.0.50; c-ts-mode: indentation styles broken after
 new brace code
Date: Tue, 5 Sep 2023 17:06:44 -0700

Yuan Fu <casouri <at> gmail.com> writes:

> Theodor Thornhill <theo <at> thornhill.no> writes:
>
>> Hi!
>>
>> It seems there has been some regressions wrt indentation styles with the
>> new brace counting code - for example with bsd style:
>>
>> Previously:
>>
>> int
>> main()
>> {
>>   if (x)
>>   {
>>
>>   }
>>   else
>>   {
>>
>>   }
>> }
>>
>> now:
>>
>> int
>> main()
>> {
>>   if (x)
>>   {
>>
>>     }
>>   else
>>   {
>>
>>     }
>> }
>>
>> I'll try to tweak the code so that all indentation styles work and add
>> tests.
>>
>> Theo
>
> Yeah sorry about that, I think this is fixed now.

No further comments within 9 months, so I'm assuming this is fixed.

I'm therefore closing this bug report.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 04 Oct 2023 11:24:41 GMT) Full text and rfc822 format available.
This bug report was last modified 197 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.