GNU bug report logs - #61007
[PATCH] gnu: emacs-origami-el: Fix cl package deprecation.

Previous Next

Package: guix-patches;

Reported by: Nicolas Graves <ngraves <at> ngraves.fr>

Date: Sun, 22 Jan 2023 16:28:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61007 in the body.
You can then email your comments to 61007 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#61007; Package guix-patches. (Sun, 22 Jan 2023 16:28:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Graves <ngraves <at> ngraves.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 22 Jan 2023 16:28:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH] gnu: emacs-origami-el: Fix cl package deprecation.
Date: Sun, 22 Jan 2023 17:27:02 +0100
* gnu/packages/emacs-xyz.scm (emacs-origami-el):
[source] Add patch to fix cl package deprecation.
[propagated-inputs] Formatting.
[home-page] Formatting.
---
 gnu/packages/emacs-xyz.scm | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 41a0ccf09e..ed5c3bd71d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -28753,24 +28753,30 @@ (define-public emacs-rjsx-mode
 (define-public emacs-origami-el
   (let ((commit "1f38085c8f9af7842765ed63f7d6dfe4dab59366")
         (version "1.0")
-        (revision "1"))
+        (revision "1")
+        (url "https://github.com/gregsexton/origami.el")
+        (patch "1d9c4f120c027a5009b0424270e3aae59f1cb128"))
     (package
       (name "emacs-origami-el")
       (version (git-version version revision commit))
       (source
        (origin
          (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/gregsexton/origami.el")
-               (commit commit)))
+         (uri (git-reference (url url) (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32
-           "0ha1qsz2p36pqa0sa2sp83lspbgx5lr7930qxnwd585liajzdd9x"))))
+          (base32 "0ha1qsz2p36pqa0sa2sp83lspbgx5lr7930qxnwd585liajzdd9x"))
+         (patches
+          (list
+           (origin
+             (method url-fetch)
+             (uri (string-append url "/commit/" patch ".patch"))
+             (sha256
+              (base32
+               "0yia4dhqjzdidxd77s2ggg6mmj05jbsnwc35myzzhzh1zbq8mrfy")))))))
       (build-system emacs-build-system)
-      (propagated-inputs
-       (list emacs-dash emacs-s))
-      (home-page "https://github.com/gregsexton/origami.el")
+      (propagated-inputs (list emacs-dash emacs-s))
+      (home-page url)
       (synopsis "Flexible text-folding")
       (description "This package provides a minor mode for collapsing and
 expanding regions of text without modifying the actual contents.")
-- 
2.39.1





Information forwarded to guix-patches <at> gnu.org:
bug#61007; Package guix-patches. (Sun, 22 Jan 2023 16:40:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Cc: 61007 <at> debbugs.gnu.org, Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#61007] [PATCH] gnu: emacs-origami-el: Fix cl package
 deprecation.
Date: Sun, 22 Jan 2023 17:39:27 +0100
Hello,

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-origami-el):
> [source] Add patch to fix cl package deprecation.
> [propagated-inputs] Formatting.
> [home-page] Formatting.
> ---
>  gnu/packages/emacs-xyz.scm | 24 +++++++++++++++---------
>  1 file changed, 15 insertions(+), 9 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 41a0ccf09e..ed5c3bd71d 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -28753,24 +28753,30 @@ (define-public emacs-rjsx-mode
>  (define-public emacs-origami-el
>    (let ((commit "1f38085c8f9af7842765ed63f7d6dfe4dab59366")
>          (version "1.0")
> -        (revision "1"))
> +        (revision "1")
> +        (url "https://github.com/gregsexton/origami.el")

Please don't factor out URL, even if you can.

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#61007; Package guix-patches. (Sun, 22 Jan 2023 16:40:01 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#61007; Package guix-patches. (Tue, 24 Jan 2023 12:55:01 GMT) Full text and rfc822 format available.

Message #14 received at 61007 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 61007 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH v2] gnu: emacs-origami-el: Add patch to fix cl package
 deprecation.
Date: Tue, 24 Jan 2023 13:54:37 +0100
* gnu/packages/emacs-xyz.scm (emacs-origami-el):
[source] Add patch to fix cl package deprecation.
---
 gnu/packages/emacs-xyz.scm | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a5143b13c5..5ebf8f0e1d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -28750,7 +28750,8 @@ (define-public emacs-rjsx-mode
 (define-public emacs-origami-el
   (let ((commit "1f38085c8f9af7842765ed63f7d6dfe4dab59366")
         (version "1.0")
-        (revision "1"))
+        (revision "1")
+        (patch "1d9c4f120c027a5009b0424270e3aae59f1cb128"))
     (package
       (name "emacs-origami-el")
       (version (git-version version revision commit))
@@ -28763,7 +28764,17 @@ (define-public emacs-origami-el
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "0ha1qsz2p36pqa0sa2sp83lspbgx5lr7930qxnwd585liajzdd9x"))))
+           "0ha1qsz2p36pqa0sa2sp83lspbgx5lr7930qxnwd585liajzdd9x"))
+         (patches
+          (list
+           (origin
+             (method url-fetch)
+             (uri (string-append
+                   "https://github.com/gregsexton/origami.el"
+                   "/commit/" patch ".patch"))
+             (sha256
+              (base32
+               "0yia4dhqjzdidxd77s2ggg6mmj05jbsnwc35myzzhzh1zbq8mrfy")))))))
       (build-system emacs-build-system)
       (propagated-inputs
        (list emacs-dash emacs-s))
-- 
2.39.1





Information forwarded to guix-patches <at> gnu.org:
bug#61007; Package guix-patches. (Wed, 25 Jan 2023 17:45:02 GMT) Full text and rfc822 format available.

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Cc: 61007-done <at> debbugs.gnu.org, Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#61007] [PATCH v2] gnu: emacs-origami-el: Add patch to fix
 cl package deprecation.
Date: Wed, 25 Jan 2023 18:44:19 +0100
Hello,

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-origami-el):
> [source] Add patch to fix cl package deprecation.

Applied.

The linter seems unhappy with the patch, but I think the linter is wrong
in this case.

Regards,
-- 
Nicolas Goaziou




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Wed, 25 Jan 2023 17:45:02 GMT) Full text and rfc822 format available.

Notification sent to Nicolas Graves <ngraves <at> ngraves.fr>:
bug acknowledged by developer. (Wed, 25 Jan 2023 17:45:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 23 Feb 2023 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 34 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.