GNU bug report logs - #61008
[PATCH] gnu: emacs-smartparens: Fix package cl deprecation.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61008 in the body.
You can then email your comments to 61008 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH] gnu: emacs-smartparens: Fix package cl deprecation.
Date: Sun, 22 Jan 2023 17:29:13 +0100

* gnu/packages/emacs-xyz.scm (emacs-smartparens):
[arguments] Fix package cl deprecation.
---
 gnu/packages/emacs-xyz.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ed5c3bd71d..8bde2825f1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -10575,6 +10575,17 @@ (define-public emacs-smartparens
        (sha256
         (base32 "0zij2f2rjjym98w68jkp10n1ckpfprlkk217c3fg16hz5nq4vnm6"))))
     (build-system emacs-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'fix-deprecated-cl-warning
+            (lambda _
+              (substitute* "smartparens.el"
+                ((string-append
+                  "\\(eval-when-compile \\(require 'cl\\)\\) "
+                  " ; for `lexical-let'")
+                 "")))))))
     (propagated-inputs
      (list emacs-dash emacs-markdown-mode))
     (home-page "https://github.com/Fuco1/smartparens")
-- 
2.39.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Cc: Nicolas Graves <ngraves <at> ngraves.fr>, 61008 <at> debbugs.gnu.org
Subject: Re: [bug#61008] [PATCH] gnu: emacs-smartparens: Fix package cl
 deprecation.
Date: Sun, 22 Jan 2023 17:34:46 +0100

Hello,

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-smartparens):
> [arguments] Fix package cl deprecation.
> ---
>  gnu/packages/emacs-xyz.scm | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index ed5c3bd71d..8bde2825f1 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -10575,6 +10575,17 @@ (define-public emacs-smartparens
>         (sha256
>          (base32 "0zij2f2rjjym98w68jkp10n1ckpfprlkk217c3fg16hz5nq4vnm6"))))
>      (build-system emacs-build-system)
> +    (arguments
> +     (list
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'fix-deprecated-cl-warning
> +            (lambda _
> +              (substitute* "smartparens.el"
> +                ((string-append
> +                  "\\(eval-when-compile \\(require 'cl\\)\\) "
> +                  " ; for `lexical-let'")
> +                 "")))))))

AFAIU, we're fixing a mere warning. Why do you think it is worth
a patch?

Regards,
-- 
Nicolas Goaziou

Message #14 received at 61008 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, 61008 <at> debbugs.gnu.org
Subject: Re: [bug#61008] [PATCH] gnu: emacs-smartparens: Fix package cl
 deprecation.
Date: Sun, 22 Jan 2023 20:19:50 +0100

> AFAIU, we're fixing a mere warning.
Indeed, it's the case for both patches.

> Why do you think it is worth a patch?

I was just curious about the warning and looked for packages trigerring
it in my config, which are the two packages I sent.

Smartparens is regularly updated but doesn't make new releases, I
hesitated upadting it based on a commit, or use this patch.

Origami's original repo hasn't changed in 5 years, but it had a pull
request waiting for it.

Both are quite used, but still trigger the warning since their codebase
age. Their guix users have the warning and might enquire "for nothing
serious". But all-in-all, it is neither urgent nor important, you can
close both patches if you feel it's better without ;)

-- 
Best regards,
Nicolas Graves

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Cc: Nicolas Graves <ngraves <at> ngraves.fr>, 61008 <at> debbugs.gnu.org
Subject: Re: [bug#61008] [PATCH] gnu: emacs-smartparens: Fix package cl
 deprecation.
Date: Sun, 22 Jan 2023 23:09:01 +0100

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> Smartparens is regularly updated but doesn't make new releases, I
> hesitated upadting it based on a commit, or use this patch.

Note that emacs-smartparens doesn't build with your patch
<https://qa.guix.gnu.org/issue/61008>.

It may be worth updating it to latest commit in that case.

Message #23 received at 61008 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 61008 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH v2] gnu: emacs-smartparens: Update to 1.11.0-0.7afd647.
Date: Tue, 24 Jan 2023 14:08:55 +0100

* gnu/packages/emacs-xyz.scm: Update to 1.11.0-0.7afd647.
---
 gnu/packages/emacs-xyz.scm | 42 ++++++++++++++++++++------------------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5ebf8f0e1d..408ecd77f9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -10562,26 +10562,28 @@ (define-public emacs-marginalia
     (license license:gpl3+)))
 
 (define-public emacs-smartparens
-  (package
-    (name "emacs-smartparens")
-    (version "1.11.0")
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://github.com/Fuco1/smartparens")
-             (commit version)))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "0zij2f2rjjym98w68jkp10n1ckpfprlkk217c3fg16hz5nq4vnm6"))))
-    (build-system emacs-build-system)
-    (propagated-inputs
-     (list emacs-dash emacs-markdown-mode))
-    (home-page "https://github.com/Fuco1/smartparens")
-    (synopsis "Paredit-like insertion, wrapping and navigation with user
+  (let ((commit "7afd647395018a26633673ed92ce7a9cb3ccb8f2")
+        (revision "0"))
+    (package
+      (name "emacs-smartparens")
+      (version (git-version "1.11.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/Fuco1/smartparens")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0ihvz1w2ggjplk604cdd5alxcq2iy3nm95m7wb6vncrbyb6v0ad2"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       (list emacs-dash emacs-markdown-mode))
+      (home-page "https://github.com/Fuco1/smartparens")
+      (synopsis "Paredit-like insertion, wrapping and navigation with user
 defined pairs")
-    (description
-     "Smartparens is a minor mode for Emacs that deals with parens pairs
+      (description
+       "Smartparens is a minor mode for Emacs that deals with parens pairs
 and tries to be smart about it.  It started as a unification effort to
 combine functionality of several existing packages in a single,
 compatible and extensible way to deal with parentheses, delimiters, tags
@@ -10589,7 +10591,7 @@ (define-public emacs-smartparens
 wrap-region, electric-pair-mode, paredit and others.  With the basic
 features found in other packages it also brings many improvements as
 well as completely new features.")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-dumbparens
   ;; There are no releases.
-- 
2.39.1

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: guix-patches <at> gnu.org, 61008-done <at> debbugs.gnu.org
Subject: Re: [bug#61008] [PATCH v2] gnu: emacs-smartparens: Update to
 1.11.0-0.7afd647.
Date: Tue, 07 Feb 2023 09:08:58 +0100

[Message part 1 (text/plain, inline)]

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm: Update to 1.11.0-0.7afd647.
> ---
>  gnu/packages/emacs-xyz.scm | 42 ++++++++++++++++++++------------------
>  1 file changed, 22 insertions(+), 20 deletions(-)

This looks to have been merged as
f6286812ec932e282ef540bab0f614b13218d54b, so marking as done.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.