GNU bug report logs - #61010
[PATCH] gnu: Add icewm

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61010 in the body.
You can then email your comments to 61010 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add icewm
Date: Sun, 22 Jan 2023 12:37:46 -0800

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-icewm.patch (text/x-patch, attachment)]

Message #8 received at 61010 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 61010 <at> debbugs.gnu.org
Date: Mon, 23 Jan 2023 09:33:40 -0800

patch based on email discussions between

白い熊＠相撲道 <help-guix_gnu.org <at> sumou.com>
and
zimoun

in the thread https://mail.gnu.org/archive/html/help-guix/2022-05/msg00098.html

Message #11 received at 61010 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Andy Tai <atai <at> atai.org>, 61010 <at> debbugs.gnu.org
Subject: Re: [bug#61010] [PATCH] gnu: Add icewm
Date: Tue, 24 Jan 2023 13:26:14 +0100

Hi,

Thanks for the follow up. :-)

The patch builds fine and it LTGM except one minor point.


On dim., 22 janv. 2023 at 12:37, Andy Tai <atai <at> atai.org> wrote:

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/ice-wm/icewm/releases/download/"
> +                    version "/icewm-" version ".tar.lz"))

This archive contains generated .gmo which are not in the source code
[1] and I do not know what is the usual Guix policy about that.  Do we
re-generate them?

Other said, these files are in the archive tar.gz [2].

1: <https://github.com/ice-wm/icewm/tree/3.3.1/po>
2: <https://github.com/ice-wm/icewm/archive/refs/tags/3.3.1.tar.gz>


> \ No newline at end of file

This patch does not apply to current master.  From my point of view, it
is worth to provide the base-commit (see --base option of
git-format-patch or git-send-email).

And it helps if the new package is not added to the end of the file.
For instance, I would put it between i3lock-fancy and xmonad-next.


Cheers,
simon

Message #14 received at 61010 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 61010 <at> debbugs.gnu.org
Subject: Re: [bug#61010] [PATCH] gnu: Add icewm
Date: Tue, 24 Jan 2023 23:37:45 -0800

[Message part 1 (text/plain, inline)]

updated patch  attached


On Tue, Jan 24, 2023 at 4:35 AM Simon Tournier <zimon.toutoune <at> gmail.com> wrote:
>
> The patch builds fine and it LTGM except one minor point.
>
> On dim., 22 janv. 2023 at 12:37, Andy Tai <atai <at> atai.org> wrote:
>
> This archive contains generated .gmo which are not in the source code
> [1] and I do not know what is the usual Guix policy about that.  Do we
> re-generate them?
>
> Other said, these files are in the archive tar.gz [2].
>
> 1: <https://github.com/ice-wm/icewm/tree/3.3.1/po>
> 2: <https://github.com/ice-wm/icewm/archive/refs/tags/3.3.1.tar.gz>
>

This I did not address in the revision because the second .tar.gz is
available on the net, satisfying GPL's source requirement... but will
revise if Guix policy demands otherwise
>
> > \ No newline at end of file
>
> This patch does not apply to current master.  From my point of view, it
> is worth to provide the base-commit (see --base option of
> git-format-patch or git-send-email).
>
> And it helps if the new package is not added to the end of the file.
> For instance, I would put it between i3lock-fancy and xmonad-next.
>

addressed as suggested
>
> Cheers,
> simon

[0001-gnu-Add-icewm.patch (text/x-patch, attachment)]

Message #17 received at 61010 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 61010 <at> debbugs.gnu.org
Subject: Re: [bug#61010] [PATCH] gnu: Add icewm
Date: Tue, 24 Jan 2023 23:50:23 -0800

[Message part 1 (text/plain, inline)]

same patch with only difference of label as "v2"

not sure how to make Guix QA rebuild with the new patch

On Tue, Jan 24, 2023 at 11:37 PM Andy Tai <atai <at> atai.org> wrote:
>
> updated patch  attached
>
>
> On Tue, Jan 24, 2023 at 4:35 AM Simon Tournier <zimon.toutoune <at> gmail.com> wrote:
> >
> > The patch builds fine and it LTGM except one minor point.
> >
> > On dim., 22 janv. 2023 at 12:37, Andy Tai <atai <at> atai.org> wrote:
> >
> > This archive contains generated .gmo which are not in the source code
> > [1] and I do not know what is the usual Guix policy about that.  Do we
> > re-generate them?
> >
> > Other said, these files are in the archive tar.gz [2].
> >
> > 1: <https://github.com/ice-wm/icewm/tree/3.3.1/po>
> > 2: <https://github.com/ice-wm/icewm/archive/refs/tags/3.3.1.tar.gz>
> >
>
> This I did not address in the revision because the second .tar.gz is
> available on the net, satisfying GPL's source requirement... but will
> revise if Guix policy demands otherwise
> >
> > > \ No newline at end of file
> >
> > This patch does not apply to current master.  From my point of view, it
> > is worth to provide the base-commit (see --base option of
> > git-format-patch or git-send-email).
> >
> > And it helps if the new package is not added to the end of the file.
> > For instance, I would put it between i3lock-fancy and xmonad-next.
> >
>
> addressed as suggested
> >
> > Cheers,
> > simon



-- 
Andy Tai, atai <at> atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2023 民國112年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能

[v2-0001-gnu-Add-icewm.patch (text/x-patch, attachment)]

Message #20 received at 61010 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Andy Tai <atai <at> atai.org>
Cc: 61010 <at> debbugs.gnu.org
Subject: Re: [bug#61010] [PATCH] gnu: Add icewm
Date: Wed, 25 Jan 2023 10:21:34 +0100

Hi,

On Tue, 24 Jan 2023 at 23:37, Andy Tai <atai <at> atai.org> wrote:

> This I did not address in the revision because the second .tar.gz is
> available on the net, satisfying GPL's source requirement... but will
> revise if Guix policy demands otherwise

I do not understand what you mean.  My point is that these .gmo files
are generated by the author of the release and they are _not_ included in
the upstream source code – the Git repository.

For most of the cases, the Guix project tries hard to package only from
the source code, i.e., build as much as possible from scratch.

Hence, the question: do we re-generate these files?


Cheers,
simon

PS: Indeed, sorry for the typo in my previous message.  I wrote:

    Other said, these files are in the archive tar.gz [2].

when *not* is missing.  I wanted to say:

    Other said, these files are *NOT* in the archive tar.gz [2].

Message #23 received at 61010 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 61010 <at> debbugs.gnu.org
Subject: Re: [bug#61010] [PATCH] gnu: Add icewm
Date: Wed, 25 Jan 2023 22:02:45 -0800

I just untar'd the

 icewm-3.3.0.tar.lz
(from https://github.com/ice-wm/icewm/releases/download/3.3.0/icewm-3.3.0.tar.lz)

file (not tar.gz file, my bad for bad description before), in a clean
directory, and
the .gmo files are there
/share/software/icewm/icewm-3.3.0$ !find
find . -name *.gmo
./po/zh_CN.gmo
./po/pt_BR.gmo
./po/sk.gmo
./po/en.gmo
...

As we are getting the release tarball as the source, the git repo is
immaterial as far as this icewm version is concerned.

On Wed, Jan 25, 2023 at 2:10 AM Simon Tournier <zimon.toutoune <at> gmail.com> wrote:
>
> Hi,
>
> On Tue, 24 Jan 2023 at 23:37, Andy Tai <atai <at> atai.org> wrote:
>
> > This I did not address in the revision because the second .tar.gz is
> > available on the net, satisfying GPL's source requirement... but will
> > revise if Guix policy demands otherwise
>
> I do not understand what you mean.  My point is that these .gmo files
> are generated by the author of the release and they are _not_ included in
> the upstream source code – the Git repository.
>
> For most of the cases, the Guix project tries hard to package only from
> the source code, i.e., build as much as possible from scratch.
>
> Hence, the question: do we re-generate these files?
>
>
> Cheers,
> simon
>
> PS: Indeed, sorry for the typo in my previous message.  I wrote:
>
>     Other said, these files are in the archive tar.gz [2].
>
> when *not* is missing.  I wanted to say:
>
>     Other said, these files are *NOT* in the archive tar.gz [2].



-- 
Andy Tai, atai <at> atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2023 民國112年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能

Message #26 received at 61010 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 61010 <at> debbugs.gnu.org
Subject: Re: [bug#61010] [PATCH] gnu: Add icewm
Date: Fri, 27 Jan 2023 12:42:01 -0800

OK I will make another patch tom re-generate the .gmo files in the
build process, even if that is probably "redundant" but will just run
one more step.   First I need to figure out how these .gmo files are
generated as I don't deal with gettext much.

On Wed, Jan 25, 2023 at 10:02 PM Andy Tai <atai <at> atai.org> wrote:
>
> I just untar'd the
>
>  icewm-3.3.0.tar.lz
> (from https://github.com/ice-wm/icewm/releases/download/3.3.0/icewm-3.3.0.tar.lz)
>
> file (not tar.gz file, my bad for bad description before), in a clean
> directory, and
> the .gmo files are there
> /share/software/icewm/icewm-3.3.0$ !find
> find . -name *.gmo
> ./po/zh_CN.gmo
> ./po/pt_BR.gmo
> ./po/sk.gmo
> ./po/en.gmo
> ...
>
> As we are getting the release tarball as the source, the git repo is
> immaterial as far as this icewm version is concerned.
>
> On Wed, Jan 25, 2023 at 2:10 AM Simon Tournier <zimon.toutoune <at> gmail.com> wrote:
> >
> > Hi,
> >
> > On Tue, 24 Jan 2023 at 23:37, Andy Tai <atai <at> atai.org> wrote:
> >
> > > This I did not address in the revision because the second .tar.gz is
> > > available on the net, satisfying GPL's source requirement... but will
> > > revise if Guix policy demands otherwise
> >
> > I do not understand what you mean.  My point is that these .gmo files
> > are generated by the author of the release and they are _not_ included in
> > the upstream source code – the Git repository.
> >
> > For most of the cases, the Guix project tries hard to package only from
> > the source code, i.e., build as much as possible from scratch.
> >
> > Hence, the question: do we re-generate these files?
> >
> >
> > Cheers,
> > simon
> >
> > PS: Indeed, sorry for the typo in my previous message.  I wrote:
> >
> >     Other said, these files are in the archive tar.gz [2].
> >
> > when *not* is missing.  I wanted to say:
> >
> >     Other said, these files are *NOT* in the archive tar.gz [2].
>
>
>
> --
> Andy Tai, atai <at> atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
> Year 2023 民國112年
> 自動的精神力是信仰與覺悟
> 自動的行為力是勞動與技能



-- 
Andy Tai, atai <at> atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2023 民國112年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能

Message #29 received at 61010 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 61010 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>, zimon.toutoune <at> gmail.com
Subject: [PATCH v3] gnu: Add icewm
Date: Sat, 28 Jan 2023 00:22:21 -0800

* gnu/packages/wm.scm (icewm): New variable
---
 gnu/packages/wm.scm | 66 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 66 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index a860ed1f93..52d2321257 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -100,6 +100,7 @@ (define-module (gnu packages wm)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages build-tools)
   #:use-module (gnu packages calendar)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages check)
   #:use-module (gnu packages datastructures)
   #:use-module (gnu packages docbook)
@@ -763,6 +764,71 @@ (define-public i3lock-fancy
 desktop environment.")
     (license license:expat)))
 
+(define-public icewm
+  (package
+    (name "icewm")
+    (version "3.3.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/ice-wm/icewm/releases/download/"
+                    version "/icewm-" version ".tar.lz"))
+              (sha256
+               (base32
+                "14vkv5r9rvwfj8gmdsrkkq7vxvk2j7z7wfybzc8ywj469yya5ppq"))))
+    (build-system gnu-build-system)
+    (native-inputs (list pkg-config))
+    (inputs (list fontconfig
+                  fribidi
+                  imlib2
+                  libice
+                  libjpeg-turbo
+                  libsm
+                  libxcomposite
+                  libxdamage
+                  libxext
+                  libxfixes
+                  libxft
+                  libxinerama
+                  libxpm
+                  libxrandr
+                  libxrender
+                  libx11
+                  lzip
+                  perl))
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'remove-gmo-files
+                    ;; gmo files are generated from .po files
+                    ;; so remove them before build to make sure
+                    ;; they are re-generated if needed
+                    (lambda _
+                      (for-each delete-file
+                                (find-files "po" "\\.gmo$")) #t))
+                  (add-after 'unpack 'skip-failing-test
+                    ;; strtest.cc tests failing due to $HOME and /etc setup
+                    ;; difference under guix
+                    (lambda _
+                      (substitute* "src/Makefile.in"
+                        (("TESTS = strtest\\$\\(EXEEXT\\)")
+                         "TESTS = ")) #t)))))
+    (home-page "https://ice-wm.org/")
+    (synopsis "Window manager for the X Window System")
+    (description
+     "IceWM is a window manager for the X Window System.  The goal of
+IceWM is speed, simplicity, and not getting in the user’s way.  It comes with a
+taskbar with pager, global and per-window keybindings and a dynamic menu system.
+Application windows can be managed by keyboard and mouse.  Windows
+can be iconified to the taskbar, to the tray, to the desktop or be made
+hidden.  They are controllable by a quick switch window (Alt+Tab) and in a
+window list.  A handful of configurable focus models are
+menu-selectable.  Setups with multiple monitors are supported by RandR and
+Xinerama.  IceWM is very configurable, themeable and well documented.  It
+includes an optional external background wallpaper manager with transparency
+support, a simple session manager and a system tray.")
+    (license license:gpl2)))
+
+
 (define-public xmonad-next
   (package
     (name "xmonad-next")

base-commit: c6ec9c7af9814f84f293f62235eab9d0649751a7
-- 
2.39.1

Message #32 received at 61010 <at> debbugs.gnu.org (full text, mbox):

From: Feng Shu <tumashu <at> 163.com>
To: 61010 <at> debbugs.gnu.org
Subject: lost gtk input
Date: Mon, 06 Feb 2023 19:43:17 +0800

I think we shoud add gtk to input, so icewm-menu-fdo can be build.

Message #37 received at 61010-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Andy Tai <atai <at> atai.org>
Cc: 61010-done <at> debbugs.gnu.org, zimon.toutoune <at> gmail.com
Subject: Re: bug#61010: [PATCH] gnu: Add icewm
Date: Fri, 10 Feb 2023 10:05:13 +0800

Andy Tai <atai <at> atai.org> writes:

> * gnu/packages/wm.scm (icewm): New variable

Pushed with some modifications:
- update to 3.3.1.
- change license to 'lgpl2.0'.
- use gexp for arguments.

Thank you!

Message #40 received at 61010 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Feng Shu <tumashu <at> 163.com>
Cc: 61010 <at> debbugs.gnu.org
Subject: Re: lost gtk input
Date: Fri, 10 Feb 2023 13:48:27 +0800

> I think we shoud add gtk to input, so icewm-menu-fdo can be build.

Done, and add GLIB is enough.

Thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.