GNU bug report logs - #61031
[PATCH] Add emacs-kodi-remote.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61031 in the body.
You can then email your comments to 61031 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matthieu Lemerre <racin <at> free.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add emacs-kodi-remote.
Date: Mon, 23 Jan 2023 23:39:43 +0100

Hi Guix!

This emacs package allows to control Kodi remotely -- I use it every day and it is very handy!
The guix installation works well.

Best regards,
Matthieu

---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c2be7eac57..e2efaaf47d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26708,6 +26708,34 @@ (define-public emacs-mpdel
 stored playlists.")
     (license license:gpl3+)))
 
+
+(define-public emacs-kodi-remote
+  (package
+    (name "emacs-kodi-remote")
+    (version "20190622.1325")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/spiderbit/kodi-remote.el.git")
+                    (commit "f5e932036c16e2b61a63020e006fc601e38d181e")))
+              (sha256
+               (base32
+                "1gck7lvqxcr9ikrzlpvcf4408cq6i4s8ijgb0kdsbkfzv0w86934"))))
+    (build-system emacs-build-system)
+    (propagated-inputs (list emacs-request emacs-let-alist emacs-json-mode emacs-f))
+    (home-page "http://github.com/spiderbit/kodi-remote.el")
+    (synopsis "Remote Control for Kodi")
+    (description
+     "This package provides a major to remote control kodi instances.  First specify
+the hostname/ip of your kodi webserver: (setq kodi-host-name \"my-htpc:8080\")
+Then open the Remote with the command: kodi-remote Also open the current kodi
+Video Playlist with the command: kodi-remote-playlist Start play exercise mode:
+kodi-remote-exercise OPTIONAL: setup settings for deleting files (over tramp)
+(setq kodi-dangerous-options t) (setq kodi-access-host \"my-htpc\") if you don't
+use ssh to access your kodi server / nas: (setq kodi-access-method
+\"smb/ftp/adb...\")")
+    (license gpl3+)))
+
 (define-public emacs-navigel
   (package
     (name "emacs-navigel")

base-commit: 77a34996000acf43b668ebf491afb6d02e85b0ec
-- 
2.38.1

Message #8 received at 61031 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Matthieu Lemerre <racin <at> free.fr>
Cc: 61031 <at> debbugs.gnu.org
Subject: Re: [bug#61031] [PATCH] Add emacs-kodi-remote.
Date: Wed, 25 Jan 2023 18:40:34 +0100

Hello,

Matthieu Lemerre <racin <at> free.fr> writes:

> This emacs package allows to control Kodi remotely -- I use it every day and it is very handy!
> The guix installation works well.

Thank you. Some comments follow.

> +(define-public emacs-kodi-remote
> +  (package
> +    (name "emacs-kodi-remote")
> +    (version "20190622.1325")

According to "kodi-remote.el", version is "0", not this date-based one.

You should also use `git-version' since we're using an unreleased version.

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/spiderbit/kodi-remote.el.git")

You should drop the ".git" suffix from URL.

> +                    (commit "f5e932036c16e2b61a63020e006fc601e38d181e")))

Usually, we let-bind the commit at the beginning of the package
definition and write

  (commit commit)

> +              (sha256
> +               (base32
> +                "1gck7lvqxcr9ikrzlpvcf4408cq6i4s8ijgb0kdsbkfzv0w86934"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs (list emacs-request emacs-let-alist emacs-json-mode emacs-f))

Please order inputs alphabetically.

> +    (home-page "http://github.com/spiderbit/kodi-remote.el")
> +    (synopsis "Remote Control for Kodi")
> +    (description
> +     "This package provides a major to remote control kodi instances.  First specify

kodi -> Kodi

> +the hostname/ip of your kodi webserver: (setq kodi-host-name \"my-htpc:8080\")
> +Then open the Remote with the command: kodi-remote Also open the current kodi
> +Video Playlist with the command: kodi-remote-playlist Start play exercise mode:
> +kodi-remote-exercise OPTIONAL: setup settings for deleting files (over tramp)
> +(setq kodi-dangerous-options t) (setq kodi-access-host \"my-htpc\") if you don't
> +use ssh to access your kodi server / nas: (setq kodi-access-method
> +\"smb/ftp/adb...\")")

This is more a manual excerpt than a proper description. Could you
reword it a bit to describe what the package does, not how to do it?
Note that sentences should be separated with full stops and two spaces,
per Texinfo specification.

> +    (license gpl3+)))

This cannot possibly build: the license above should be license:gpl3+.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 61031 <at> debbugs.gnu.org (full text, mbox):

From: racin <at> free.fr
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 61031 <at> debbugs.gnu.org
Subject: Re: [bug#61031] [PATCH] Add emacs-kodi-remote.
Date: Fri, 27 Jan 2023 13:43:38 +0100 (CET)

Thanks for all the comments! Here is an updated patch addressing everything.

You were right about the problem that it did not compile; I did not understand that I had to to make
before ./pre-inst-env guix build emacs-kodi-remote. I think I properly tested it now.

Matthieu

---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c2be7eac57..0c832110a0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26708,6 +26708,30 @@ (define-public emacs-mpdel
 stored playlists.")
     (license license:gpl3+)))
 
+
+(define-public emacs-kodi-remote
+  (let ((commit "f5e932036c16e2b61a63020e006fc601e38d181e")
+        (revision "0"))
+    (package
+      (name "emacs-kodi-remote")
+      (version (git-version "0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/spiderbit/kodi-remote.el.git")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1gck7lvqxcr9ikrzlpvcf4408cq6i4s8ijgb0kdsbkfzv0w86934"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-f emacs-json-mode emacs-let-alist emacs-request))
+      (home-page "http://github.com/spiderbit/kodi-remote.el")
+      (synopsis "Remote Control for Kodi")
+      (description
+       "This package provides a major mode to remote control Kodi
+instances (play/pause, volume control, media selection, etc.).")
+      (license license:gpl3+))))
+
 (define-public emacs-navigel
   (package
     (name "emacs-navigel")
-- 
2.39.1

Message #16 received at 61031-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: racin <at> free.fr
Cc: 61031-done <at> debbugs.gnu.org
Subject: Re: [bug#61031] [PATCH] Add emacs-kodi-remote.
Date: Fri, 27 Jan 2023 23:04:53 +0100

Hello,

racin <at> free.fr writes:

> You were right about the problem that it did not compile; I did not understand that I had to to make
> before ./pre-inst-env guix build emacs-kodi-remote. I think I properly
> tested it now.

Great. I added a commit message and applied your patch, with the changes below.

> +    (package
> +      (name "emacs-kodi-remote")
> +      (version (git-version "0" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/spiderbit/kodi-remote.el.git")

I removed ".git" suffix
> +                      (commit commit)))

I added

  (file-name (git-file-name name version))

here

> +                (sha256
> +                 (base32
> +                  "1gck7lvqxcr9ikrzlpvcf4408cq6i4s8ijgb0kdsbkfzv0w86934"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs (list emacs-f emacs-json-mode emacs-let-alist emacs-request))

I added a newline character after "propagated-inputs".
> +      (home-page "http://github.com/spiderbit/kodi-remote.el")
> +      (synopsis "Remote Control for Kodi")

Control -> control

Regards,
-- 
Nicolas Goaziou

Message #19 received at 61031-done <at> debbugs.gnu.org (full text, mbox):

From: racin <at> free.fr
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 61031-done <at> debbugs.gnu.org
Subject: Re: [bug#61031] [PATCH] Add emacs-kodi-remote.
Date: Fri, 27 Jan 2023 23:10:54 +0100 (CET)

> Great. I added a commit message and applied your patch, with the changes below.

Great! I'll try to be more careful next time!

> I removed ".git" suffix

You had mentionned it, sorry.

> I added   (file-name (git-file-name name version)) 

This I didn't know.

> Control -> control

Oups.

Regards,

Matthieu

Message #22 received at 61031-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: racin <at> free.fr
Cc: 61031-done <at> debbugs.gnu.org
Subject: Re: [bug#61031] [PATCH] Add emacs-kodi-remote.
Date: Fri, 27 Jan 2023 23:16:22 +0100

racin <at> free.fr writes:

>> I added   (file-name (git-file-name name version)) 

> This I didn't know.

If you run

  ./pre-inst-env guix lint emacs-kodi-remote

you will get something like

  emacs-kodi-remote <at> 0-0.f5e9320: the source file name should contain the package name

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.