GNU bug report logs - #61040
[PATCH] gnu: emacs-ergoemacs-mode: Include keyboard layout SVGs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61040 in the body.
You can then email your comments to 61040 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-ergoemacs-mode: Include keyboard layout SVGs.
Date: Tue, 24 Jan 2023 19:16:00 +0100

[Message part 1 (text/plain, inline)]

A couple of SVG files from the source need to be installed to make
‘ergoemacs-theme-describe’ and ‘ergoemacs-layout-describe’ work.

* gnu/packages/emacs-xyz.scm (emacs-ergoemacs-mode)[arguments]: New field.
---
 gnu/packages/emacs-xyz.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 41a0ccf09e..ec8dffc3e5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -120,6 +120,7 @@
 ;;; Copyright © 2022 Thiago Jung Bauermann <bauermann <at> kolabnow.com>
 ;;; Copyright © 2022 Joeke de Graaf <joeke <at> posteo.net>
 ;;; Copyright © 2023 Simon Streit <simon <at> netpanic.org>
+;;; Copyright © 2023 Ivan Vilata-i-Balaguer <ivan <at> selidor.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -19952,6 +19953,13 @@ (define-public emacs-ergoemacs-mode
         (base32
          "1ipwzl0l26g5qvc1sgmz2ra5vn1j3hl0mnkgzpa3j4p8gsmxdiqr"))))
     (build-system emacs-build-system)
+    (arguments
+     (list #:phases #~(modify-phases %standard-phases
+                        (add-after 'install 'install-kbd-svgs
+                          (lambda _
+                            (let ((dir (elpa-directory #$output)))
+                              (install-file "kbd.svg" dir)
+                              (install-file "kbd-ergo.svg" dir)))))))
     (propagated-inputs
      (list emacs-undo-tree))
     (home-page "https://ergoemacs.github.io/")
-- 
2.38.1


-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 61040 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ivan Vilata i Balaguer <ivan <at> selidor.net>
Cc: 61040 <at> debbugs.gnu.org
Subject: Re: [bug#61040] [PATCH] gnu: emacs-ergoemacs-mode: Include keyboard
 layout SVGs.
Date: Tue, 24 Jan 2023 19:59:20 +0100

Hello,

Ivan Vilata i Balaguer <ivan <at> selidor.net> writes:

> A couple of SVG files from the source need to be installed to make
> ‘ergoemacs-theme-describe’ and ‘ergoemacs-layout-describe’ work.
>
> * gnu/packages/emacs-xyz.scm (emacs-ergoemacs-mode)[arguments]: New
> field.

Thank you.

> +    (arguments
> +     (list #:phases #~(modify-phases %standard-phases
> +                        (add-after 'install 'install-kbd-svgs
> +                          (lambda _
> +                            (let ((dir (elpa-directory #$output)))
> +                              (install-file "kbd.svg" dir)
> +                              (install-file "kbd-ergo.svg" dir)))))))

Please use #:include keyword for these files instead of this
hand-crafted phase.

Regards,
-- 
Nicolas Goaziou

Message #11 received at 61040 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 61040 <at> debbugs.gnu.org, Ivan Vilata i Balaguer <ivan <at> selidor.net>
Subject: Re: [bug#61040] [PATCH] gnu: emacs-ergoemacs-mode: Include keyboard
 layout SVGs.
Date: Wed, 25 Jan 2023 10:33:46 +0100

[Message part 1 (text/plain, inline)]

Nicolas Goaziou (2023-01-24 19:59:20 +0100) wrote:

> Ivan Vilata i Balaguer <ivan <at> selidor.net> writes:
> 
> > +    (arguments
> > +     (list #:phases #~(modify-phases %standard-phases
> > +                        (add-after 'install 'install-kbd-svgs
> > +                          (lambda _
> > +                            (let ((dir (elpa-directory #$output)))
> > +                              (install-file "kbd.svg" dir)
> > +                              (install-file "kbd-ergo.svg" dir)))))))
> 
> Please use #:include keyword for these files instead of this
> hand-crafted phase.

Thanks Nicolas, I didn't know about the keyword.  Attaching the updated patch.
Much simpler! 🙂

Salut !

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[0001-gnu-emacs-ergoemacs-mode-Include-keyboard-layout-SVG.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 61040-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ivan Vilata i Balaguer <ivan <at> selidor.net>
Cc: 61040-done <at> debbugs.gnu.org
Subject: Re: [bug#61040] [PATCH] gnu: emacs-ergoemacs-mode: Include keyboard
 layout SVGs.
Date: Fri, 27 Jan 2023 09:34:44 +0100

Hello,

Ivan Vilata i Balaguer <ivan <at> selidor.net> writes:

> Thanks Nicolas, I didn't know about the keyword.  Attaching the updated patch.
> Much simpler! 🙂

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.