GNU bug report logs - #61065
[PATCH] gnu: Add emacs-ein.

Previous Next

Package: guix-patches;

Reported by: Cayetano Santos <csantosb <at> inventati.org>

Date: Wed, 25 Jan 2023 20:14:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61065 in the body.
You can then email your comments to 61065 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#61065; Package guix-patches. (Wed, 25 Jan 2023 20:14:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Cayetano Santos <csantosb <at> inventati.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 25 Jan 2023 20:14:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: Add emacs-ein.
Date: Wed, 25 Jan 2023 21:12:36 +0100
* gnu/packages/emacs-xyz.scm (emacs-ein): New variable.
---
 gnu/packages/emacs-xyz.scm | 42 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dc378581f5..30633bd52c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34326,6 +34326,48 @@ (define-public emacs-code-cells
 execute code split into cells according to certain magic comments.")
       (license license:gpl3+))))
 
+(define-public emacs-ein
+  (package
+    (name "emacs-ein")
+    (version "20220911")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url "https://github.com/millejoh/emacs-ipython-notebook")
+         (commit "b2410dc96f61aa806a7934099d8f1e40c8f6ca18")))
+       (sha256
+        (base32
+         "02392bxl0msda58cls0i79mzqjs73x39czx0mlb0sg2vxp84gy15"))))
+    (build-system emacs-build-system)
+    (arguments
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'move-source-files
+                 (lambda _
+                   (let ((el-files (find-files "./lisp" ".*\\.el$")))
+                     (for-each (lambda (f)
+                                 (rename-file f (basename f)))
+                               el-files)))))))
+    (propagated-inputs (list emacs-websocket
+                             emacs-anaphora
+                             emacs-request
+                             emacs-deferred
+                             emacs-polymode
+                             emacs-dash
+                             emacs-with-editor))
+    (home-page "https://github.com/millejoh/emacs-ipython-notebook")
+    (synopsis "Jupyter client for all languages")
+    (description
+     "The Emacs IPython Notebook (EIN) package provides a Jupyter Notebook
+client and integrated REPL (like SLIME) in Emacs.  EIN improves notebook
+editing by allowing you to use Emacs.  It also expose IPython features such as
+code evaluation, object inspection and code completion. These features can be
+accessed anywhere in Emacs and improve Python code editing and reading in
+general in Emacs.")
+    (license license:gpl3+)))
+
 (define-public emacs-kibit-helper
   (package
     (name "emacs-kibit-helper")

base-commit: 968b882f55c4d1009e62c603a860edfaee1609ad
-- 
2.39.1





Information forwarded to guix-patches <at> gnu.org:
bug#61065; Package guix-patches. (Fri, 27 Jan 2023 08:48:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: 61065 <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>
Subject: Re: [bug#61065] [PATCH] gnu: Add emacs-ein.
Date: Fri, 27 Jan 2023 09:47:36 +0100
Hello,

Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ein): New variable.

Thank you.

> +    (propagated-inputs (list emacs-websocket
> +                             emacs-anaphora
> +                             emacs-request
> +                             emacs-deferred
> +                             emacs-polymode
> +                             emacs-dash
> +                             emacs-with-editor))

Could you order propagated inputs alphabetically?

Also, upstream provides tests. Is it feasible to run them, too?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#61065; Package guix-patches. (Fri, 27 Jan 2023 08:48:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#61065; Package guix-patches. (Fri, 27 Jan 2023 10:04:01 GMT) Full text and rfc822 format available.

Message #14 received at 61065 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 61065 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v2] gnu: Add emacs-ein.
Date: Fri, 27 Jan 2023 11:02:41 +0100
* gnu/packages/emacs-xyz.scm (emacs-ein): New variable.
---
 gnu/packages/emacs-xyz.scm | 50 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dc378581f5..087087444f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34326,6 +34326,56 @@ (define-public emacs-code-cells
 execute code split into cells according to certain magic comments.")
       (license license:gpl3+))))
 
+(define-public emacs-ein
+  (package
+    (name "emacs-ein")
+    (version "20220911")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url "https://github.com/millejoh/emacs-ipython-notebook")
+         (commit "b2410dc96f61aa806a7934099d8f1e40c8f6ca18")))
+       (sha256
+        (base32
+         "02392bxl0msda58cls0i79mzqjs73x39czx0mlb0sg2vxp84gy15"))))
+    (build-system emacs-build-system)
+    (arguments
+     (list
+      #:tests? #t
+      #:test-command
+      #~(list "emacs" "-Q" "--batch"
+              "-L" "test"
+              "--load" "test/testein-loader.el")
+      #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'move-source-files
+                 (lambda _
+                   (let ((el-files (find-files "./lisp" ".*\\.el$")))
+                     (for-each (lambda (f)
+                                 (rename-file f (basename f)))
+                               el-files)))))))
+    (native-inputs
+     (list emacs-f emacs-mocker))
+    (propagated-inputs (list emacs-anaphora
+                             emacs-dash
+                             emacs-deferred
+                             emacs-polymode
+                             emacs-request
+                             emacs-websocket
+                             emacs-with-editor))
+    (home-page "https://github.com/millejoh/emacs-ipython-notebook")
+    (synopsis "Jupyter client for all languages")
+    (description
+     "The Emacs IPython Notebook (EIN) package provides a Jupyter Notebook
+client and integrated REPL (like SLIME) in Emacs.  EIN improves notebook
+editing by allowing you to use Emacs.  It also expose IPython features such as
+code evaluation, object inspection and code completion. These features can be
+accessed anywhere in Emacs and improve Python code editing and reading in
+general in Emacs.")
+    (license license:gpl3+)))
+
 (define-public emacs-kibit-helper
   (package
     (name "emacs-kibit-helper")

base-commit: 968b882f55c4d1009e62c603a860edfaee1609ad
-- 
2.39.1





Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Fri, 27 Jan 2023 22:09:01 GMT) Full text and rfc822 format available.

Notification sent to Cayetano Santos <csantosb <at> inventati.org>:
bug acknowledged by developer. (Fri, 27 Jan 2023 22:09:01 GMT) Full text and rfc822 format available.

Message #19 received at 61065-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: Cayetano Santos <csantosb <at> inventati.org>, 61065-done <at> debbugs.gnu.org
Subject: Re: [bug#61065] [PATCH v2] gnu: Add emacs-ein.
Date: Fri, 27 Jan 2023 23:08:48 +0100
Hello,

Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ein): New variable.

Thank you. I applied your patch with the following changes.


> +(define-public emacs-ein
> +  (package
> +    (name "emacs-ein")
> +    (version "20220911")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/millejoh/emacs-ipython-notebook")
> +         (commit "b2410dc96f61aa806a7934099d8f1e40c8f6ca18")))

I added

  (file-name (git-file-name name version))

> +       (sha256
> +        (base32
> +         "02392bxl0msda58cls0i79mzqjs73x39czx0mlb0sg2vxp84gy15"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     (list
> +      #:tests? #t
> +      #:test-command
> +      #~(list "emacs" "-Q" "--batch"
> +              "-L" "test"
> +              "--load" "test/testein-loader.el")
> +      #:phases
> +           #~(modify-phases %standard-phases
> +               (add-after 'unpack 'move-source-files
> +                 (lambda _
> +                   (let ((el-files (find-files "./lisp" ".*\\.el$")))
> +                     (for-each (lambda (f)
> +                                 (rename-file f (basename f)))
> +                               el-files)))))))
> +    (native-inputs
> +     (list emacs-f emacs-mocker))
> +    (propagated-inputs (list emacs-anaphora
> +                             emacs-dash
> +                             emacs-deferred
> +                             emacs-polymode
> +                             emacs-request
> +                             emacs-websocket
> +                             emacs-with-editor))

I added a newline character after "propagated-inputs".

> +    (home-page "https://github.com/millejoh/emacs-ipython-notebook")
> +    (synopsis "Jupyter client for all languages")
> +    (description
> +     "The Emacs IPython Notebook (EIN) package provides a Jupyter Notebook
> +client and integrated REPL (like SLIME) in Emacs.  EIN improves notebook
> +editing by allowing you to use Emacs.  It also expose IPython features such as
> +code evaluation, object inspection and code completion. These features can be

I added a missing space before "These features".

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#61065; Package guix-patches. (Fri, 27 Jan 2023 22:10:01 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 25 Feb 2023 12:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 32 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.