GNU bug report logs - #61082
[PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143.

Previous Next

Package: guix-patches;

Reported by: conses <contact <at> conses.eu>

Date: Thu, 26 Jan 2023 19:08:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61082 in the body.
You can then email your comments to 61082 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#61082; Package guix-patches. (Thu, 26 Jan 2023 19:08:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to conses <contact <at> conses.eu>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 26 Jan 2023 19:08:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: conses <contact <at> conses.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143.
Date: Thu, 26 Jan 2023 20:07:25 +0100

* gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to 34a61143.
---
 gnu/packages/emacs-xyz.scm | 35 ++++++++++++-----------------------
 1 file changed, 12 insertions(+), 23 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dc378581f5..7b5888a1d1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -21447,34 +21447,23 @@ (define-public emacs-md4rd
     (license license:gpl3+)))
 
 (define-public emacs-pulseaudio-control
-  (let ((commit "a931533140547510decdc368f39b2d2b97ca725f")
-        (revision "4"))
+  (let ((commit "34a6114357dbbc6b6720aa013e0f8a48f3739403")
+        (revision "5"))
     (package
       (name "emacs-pulseaudio-control")
       (version (git-version "0.0.1" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/flexibeast/pulseaudio-control")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32
-           "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76"))))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://git.sr.ht/~flexibeast/pulseaudio-control")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5"))))
       (build-system emacs-build-system)
-      (arguments
-       '(#:phases (modify-phases %standard-phases
-                    (add-after 'unpack 'patch-file-name
-                      (lambda* (#:key inputs #:allow-other-keys)
-                        (let ((pulseaudio (assoc-ref inputs "pulseaudio")))
-                          (chmod "pulseaudio-control.el" #o600)
-                          (emacs-substitute-variables "pulseaudio-control.el"
-                            ("pulseaudio-control-pactl-path"
-                             (string-append pulseaudio "/bin/pactl")))
-                          #t))))))
       (inputs (list pulseaudio))
-      (home-page "https://github.com/flexibeast/pulseaudio-control")
+      (home-page "https://git.sr.ht/~flexibeast/pulseaudio-control")
       (synopsis "Control @code{pulseaudio} from Emacs")
       (description
        "This package allows controlling @code{pulseaudio} from Emacs.")
-- 
2.38.1



-- 
Best regards,
conses
Information forwarded to guix-patches <at> gnu.org:
bug#61082; Package guix-patches. (Fri, 27 Jan 2023 08:53:01 GMT) Full text and rfc822 format available.

Message #8 received at 61082 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: conses <contact <at> conses.eu>
Cc: 61082 <at> debbugs.gnu.org
Subject: Re: [bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to
 34a61143.
Date: Fri, 27 Jan 2023 09:52:20 +0100

Hello,

conses <contact <at> conses.eu> writes:

> * gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to
> 34a61143.

Thank you.

The commit message is incomplete: you modified pointer to upstream,
you need to write it here.

> ---
>  gnu/packages/emacs-xyz.scm | 35 ++++++++++++-----------------------
>  1 file changed, 12 insertions(+), 23 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index dc378581f5..7b5888a1d1 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -21447,34 +21447,23 @@ (define-public emacs-md4rd
>      (license license:gpl3+)))
>  
>  (define-public emacs-pulseaudio-control
> -  (let ((commit "a931533140547510decdc368f39b2d2b97ca725f")
> -        (revision "4"))
> +  (let ((commit "34a6114357dbbc6b6720aa013e0f8a48f3739403")
> +        (revision "5"))
>      (package
>        (name "emacs-pulseaudio-control")
>        (version (git-version "0.0.1" revision commit))

Base version seems to be "0.1", according to puleseaudio-control.el. In
this case, you can restart revision to "1" (or "0").

> -      (source
> -       (origin
> -         (method git-fetch)
> -         (uri (git-reference
> -               (url "https://github.com/flexibeast/pulseaudio-control")
> -               (commit commit)))
> -         (file-name (git-file-name name version))
> -         (sha256
> -          (base32
> -           "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76"))))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://git.sr.ht/~flexibeast/pulseaudio-control")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5"))))
>        (build-system emacs-build-system)
> -      (arguments
> -       '(#:phases (modify-phases %standard-phases
> -                    (add-after 'unpack 'patch-file-name
> -                      (lambda* (#:key inputs #:allow-other-keys)
> -                        (let ((pulseaudio (assoc-ref inputs "pulseaudio")))
> -                          (chmod "pulseaudio-control.el" #o600)
> -                          (emacs-substitute-variables "pulseaudio-control.el"
> -                            ("pulseaudio-control-pactl-path"
> -                             (string-append pulseaudio "/bin/pactl")))
> -                          #t))))))

Why did you remove this phase? AFAICT, pulseaudio-control-pactl-path
still exists.


>        (inputs (list pulseaudio))
> -      (home-page "https://github.com/flexibeast/pulseaudio-control")
> +      (home-page "https://git.sr.ht/~flexibeast/pulseaudio-control")

This also need to be specified in the commit message.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou
Information forwarded to guix-patches <at> gnu.org:
bug#61082; Package guix-patches. (Sat, 28 Jan 2023 12:52:02 GMT) Full text and rfc822 format available.

Message #11 received at 61082 <at> debbugs.gnu.org (full text, mbox):

From: conses <contact <at> conses.eu>
To: 61082 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: emacs-pulseaudio-control: Update to 34a61143.
Date: Sat, 28 Jan 2023 13:51:14 +0100

* gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to 34a61143.
[home-page]: Change upstream URL to new sourcehut repository.
---
 gnu/packages/emacs-xyz.scm | 37 +++++++++++++------------------------
 1 file changed, 13 insertions(+), 24 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dc378581f5..f4898e04e4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -21447,34 +21447,23 @@ (define-public emacs-md4rd
     (license license:gpl3+)))
 
 (define-public emacs-pulseaudio-control
-  (let ((commit "a931533140547510decdc368f39b2d2b97ca725f")
-        (revision "4"))
+  (let ((commit "34a6114357dbbc6b6720aa013e0f8a48f3739403")
+        (revision "0"))
     (package
       (name "emacs-pulseaudio-control")
-      (version (git-version "0.0.1" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/flexibeast/pulseaudio-control")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32
-           "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76"))))
+      (version (git-version "0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://git.sr.ht/~flexibeast/pulseaudio-control")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5"))))
       (build-system emacs-build-system)
-      (arguments
-       '(#:phases (modify-phases %standard-phases
-                    (add-after 'unpack 'patch-file-name
-                      (lambda* (#:key inputs #:allow-other-keys)
-                        (let ((pulseaudio (assoc-ref inputs "pulseaudio")))
-                          (chmod "pulseaudio-control.el" #o600)
-                          (emacs-substitute-variables "pulseaudio-control.el"
-                            ("pulseaudio-control-pactl-path"
-                             (string-append pulseaudio "/bin/pactl")))
-                          #t))))))
       (inputs (list pulseaudio))
-      (home-page "https://github.com/flexibeast/pulseaudio-control")
+      (home-page "https://git.sr.ht/~flexibeast/pulseaudio-control")
       (synopsis "Control @code{pulseaudio} from Emacs")
       (description
        "This package allows controlling @code{pulseaudio} from Emacs.")
-- 
2.38.1



-- 
Best regards,
conses
Information forwarded to guix-patches <at> gnu.org:
bug#61082; Package guix-patches. (Sat, 28 Jan 2023 13:00:02 GMT) Full text and rfc822 format available.

Message #14 received at 61082 <at> debbugs.gnu.org (full text, mbox):

From: conses <contact <at> conses.eu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 61082 <at> debbugs.gnu.org
Subject: Re: bug#61082: [PATCH] gnu: emacs-pulseaudio-control: Update to
 34a61143.
Date: Sat, 28 Jan 2023 13:59:48 +0100

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,

Hi Nicolas,

>> -      (source
>> -       (origin
>> -         (method git-fetch)
>> -         (uri (git-reference
>> -               (url "https://github.com/flexibeast/pulseaudio-control")
>> -               (commit commit)))
>> -         (file-name (git-file-name name version))
>> -         (sha256
>> -          (base32
>> -           "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76"))))
>> +      (source (origin
>> +                (method git-fetch)
>> +                (uri (git-reference
>> +                      (url "https://git.sr.ht/~flexibeast/pulseaudio-control")
>> +                      (commit commit)))
>> +                (file-name (git-file-name name version))
>> +                (sha256
>> +                 (base32
>> +                  "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5"))))
>>        (build-system emacs-build-system)
>> -      (arguments
>> -       '(#:phases (modify-phases %standard-phases
>> -                    (add-after 'unpack 'patch-file-name
>> -                      (lambda* (#:key inputs #:allow-other-keys)
>> -                        (let ((pulseaudio (assoc-ref inputs "pulseaudio")))
>> -                          (chmod "pulseaudio-control.el" #o600)
>> -                          (emacs-substitute-variables "pulseaudio-control.el"
>> -                            ("pulseaudio-control-pactl-path"
>> -                             (string-append pulseaudio "/bin/pactl")))
>> -                          #t))))))
>
> Why did you remove this phase? AFAICT, pulseaudio-control-pactl-path
> still exists.
>
>

Because this might have been needed when the package didn't allow
the pactl executable path to be found dynamically, but as per
https://github.com/flexibeast/pulseaudio-control/commit/c8640fceb530ab7a1aa551d70f7ee222147d95cf
this is no longer needed.

-- 
Best regards,
conses
Information forwarded to guix-patches <at> gnu.org:
bug#61082; Package guix-patches. (Sat, 28 Jan 2023 16:31:01 GMT) Full text and rfc822 format available.

Message #17 received at 61082 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: conses <contact <at> conses.eu>
Cc: 61082 <at> debbugs.gnu.org
Subject: Re: [bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to
 34a61143.
Date: Sat, 28 Jan 2023 17:30:06 +0100

Hello,

conses <contact <at> conses.eu> writes:

> Because this might have been needed when the package didn't allow
> the pactl executable path to be found dynamically, but as per
> https://github.com/flexibeast/pulseaudio-control/commit/c8640fceb530ab7a1aa551d70f7ee222147d95cf
> this is no longer needed.

I don't think

  (or (executable-find "pactl") "/usr/bin/pactl")

is equivalent to

  (search-input-file inputs "/bin/pactl")

Some Emacs packages remove those `executable-find' calls, e.g.,
emacs-nov-el, emacs-emacsql-sqlite3, emacs-telega, etc.

It does make sense to keep this phase (but you can remove the initial
chmod call and the final #T), unless I'm missing something. We want the
Emacs package to always refer to its own Pulseaudio input, don't we?

Regards,
-- 
Nicolas Goaziou
Information forwarded to guix-patches <at> gnu.org:
bug#61082; Package guix-patches. (Sat, 28 Jan 2023 19:07:02 GMT) Full text and rfc822 format available.

Message #20 received at 61082 <at> debbugs.gnu.org (full text, mbox):

From: conses <contact <at> conses.eu>
To: 61082 <at> debbugs.gnu.org
Subject: [PATCH v3] gnu: emacs-pulseaudio-control: Update to 34a61143.
Date: Sat, 28 Jan 2023 20:05:59 +0100

* gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to 34a61143.
[home-page]: Change upstream URL to new sourcehut repository.
[arguments]: Clean up patch-file-name phase.
---
 gnu/packages/emacs-xyz.scm | 31 ++++++++++++++-----------------
 1 file changed, 14 insertions(+), 17 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dc378581f5..bfad151e18 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -21447,34 +21447,31 @@ (define-public emacs-md4rd
     (license license:gpl3+)))
 
 (define-public emacs-pulseaudio-control
-  (let ((commit "a931533140547510decdc368f39b2d2b97ca725f")
-        (revision "4"))
+  (let ((commit "34a6114357dbbc6b6720aa013e0f8a48f3739403")
+        (revision "0"))
     (package
       (name "emacs-pulseaudio-control")
-      (version (git-version "0.0.1" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/flexibeast/pulseaudio-control")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32
-           "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76"))))
+      (version (git-version "0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://git.sr.ht/~flexibeast/pulseaudio-control")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5"))))
       (build-system emacs-build-system)
       (arguments
        '(#:phases (modify-phases %standard-phases
                     (add-after 'unpack 'patch-file-name
                       (lambda* (#:key inputs #:allow-other-keys)
                         (let ((pulseaudio (assoc-ref inputs "pulseaudio")))
-                          (chmod "pulseaudio-control.el" #o600)
                           (emacs-substitute-variables "pulseaudio-control.el"
                             ("pulseaudio-control-pactl-path"
-                             (string-append pulseaudio "/bin/pactl")))
-                          #t))))))
+                             (string-append pulseaudio "/bin/pactl")))))))))
       (inputs (list pulseaudio))
-      (home-page "https://github.com/flexibeast/pulseaudio-control")
+      (home-page "https://git.sr.ht/~flexibeast/pulseaudio-control")
       (synopsis "Control @code{pulseaudio} from Emacs")
       (description
        "This package allows controlling @code{pulseaudio} from Emacs.")
-- 
2.38.1



-- 
Best regards,
conses
Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Sun, 29 Jan 2023 14:46:02 GMT) Full text and rfc822 format available.
Notification sent to conses <contact <at> conses.eu>:
bug acknowledged by developer. (Sun, 29 Jan 2023 14:46:02 GMT) Full text and rfc822 format available.

Message #25 received at 61082-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: conses <contact <at> conses.eu>
Cc: 61082-done <at> debbugs.gnu.org
Subject: Re: [bug#61082] [PATCH v3] gnu: emacs-pulseaudio-control: Update to
 34a61143.
Date: Sun, 29 Jan 2023 15:45:26 +0100

Hello,

conses <contact <at> conses.eu> writes:

> * gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to 34a61143.
> [home-page]: Change upstream URL to new sourcehut repository.
> [arguments]: Clean up patch-file-name phase.

Neat. Thank you.

I added a reference to source update in the commit message and applied
your patch.

Regards,
-- 
Nicolas Goaziou
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 27 Feb 2023 12:24:11 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 53 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.