GNU bug report logs - #61126
[patch] fix: tcsh fails to build if guix builders have niceness 5 or more

Previous Next

To reply to this bug, email your comments to 61126 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Dr. Arne Babenhauserheide" <arne_bab <at> web.de>
To: bug-guix <at> gnu.org
Subject: [patch] fix: tcsh fails to build if guix builders have niceness 5
 or more
Date: Sat, 28 Jan 2023 23:14:03 +0100

[Message part 1 (text/plain, inline)]

Hi,

guix build tcsh failed in my guix build when running
guix build --check tcsh

The attached patch disables the test that fails when the niceness of
guix builders is 5 or more.

[0001-gnu-tcsh-comment-out-test-of-nice-with-nice-guix-bui.patch (text/x-patch, inline)]

From 193dca1b55b68aa883c3ed8b28bf19e9527fa065 Mon Sep 17 00:00:00 2001
From: Arne Babenhauserheide <arne_bab <at> web.de>
Date: Sat, 28 Jan 2023 22:29:39 +0100
Subject: [PATCH] gnu: tcsh: comment out test of nice with nice guix builder

* gnu/packages/patches/tcsh-fix-autotest.patch: comment out test of nice. To
  reproduce:
  guix shell tcsh -- nice -n 4 tcsh -c "nice echo 1" # works
  guix shell tcsh -- nice -n 5 tcsh -c "nice echo 1" # breaks
---
 gnu/packages/patches/tcsh-fix-autotest.patch | 29 ++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/patches/tcsh-fix-autotest.patch b/gnu/packages/patches/tcsh-fix-autotest.patch
index 9f5790641b..252560dbb2 100644
--- a/gnu/packages/patches/tcsh-fix-autotest.patch
+++ b/gnu/packages/patches/tcsh-fix-autotest.patch
@@ -1,3 +1,32 @@
+--- tests/commands.at
++++ tests/commands.at
+@@ -890,15 +890,16 @@
+ TCSH_UNTESTED([newgrp])
+ 
+ 
+-AT_SETUP([nice])
+-
+-# Nothing really tested
+-AT_CHECK([tcsh -f -c 'nice set var=1; echo $?var'], ,
+-[0
+-])
+-
+-
+-AT_CLEANUP
++# XXX This test fails if the Guix worker has a nice value >= 5
++# AT_SETUP([nice])
++# 
++# # Nothing really tested
++# AT_CHECK([tcsh -f -c 'nice -n +1 set var=1; echo $?var'], ,
++# [0
++# ])
++# 
++# 
++# AT_CLEANUP
+ 
+ 
+ AT_SETUP([nohup])
+
 --- tests/commands.at
 +++ tests/commands.at
 @@ -921,26 +921,27 @@ AT_CLEANUP
-- 
2.39.1

[Message part 3 (text/plain, inline)]

Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.