GNU bug report logs - #61157
gnu: Add uwufetch.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61157 in the body.
You can then email your comments to 61157 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "J. Sims" <jtsims <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: gnu: Add uwufetch.
Date: Sun, 29 Jan 2023 21:59:23 +0000

[Message part 1 (text/plain, inline)]

Hello,

This is a fun little fetch utility and I thought it might enjoy inclusion in Guix.

Thanks,
Juli

[Message part 2 (text/html, inline)]

[0001-gnu-Add-uwufetch.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: "J. Sims via Guix-patches" via <guix-patches <at> gnu.org>
Cc: "J. Sims" <jtsims <at> protonmail.com>, 61157 <at> debbugs.gnu.org
Subject: Re: [bug#61157] gnu: Add uwufetch.
Date: Tue, 31 Jan 2023 15:19:45 +0100

Hello,

"J. Sims via Guix-patches" via <guix-patches <at> gnu.org> writes:

> This is a fun little fetch utility and I thought it might enjoy
> inclusion in Guix.

Thank you. Some comments follow.

> +    (build-system gnu-build-system)
> +    (arguments
> +     (list #:tests? #f ;no tests

Please add a newline character after "list".

> +           #:make-flags #~(list (string-append "DESTDIR="
> +                                               #$output)
> +                                (string-append "ETC_DIR="
> +                                               #$output "/etc")
> +                                (string-append "CC="
> +                                               #$(cc-for-target)))

Please also add a newline character after "flags". Every flag should fit
into a single line.

> +           #:phases (with-imported-modules '((guix build utils))

I don'tthink you need to import modules.

> +                                           #~(modify-phases %standard-phases
> +                                               (delete 'configure)
> +                                               (add-before 'build 'path-source-paths
> +                                                 (lambda _
> +                                                   (substitute* "uwufetch.c"
> +                                                     (("(/usr(/local)?)(.*;)"
> +                                                       all _ _ rest)
> +                                                      (string-append #$output
> +                                                                     rest)))))))))

You can move this below "#:phases" to drastically improve indentation.

> +    (native-inputs (list git))

Are you sure git is required as a native input? If it is, then this
should be `git-minimal' instead.


> +    (synopsis "Cutesie *fetch utility")

I think we should provide better than this synopsis. Maybe, according
to upstream's About,

  Meme system info tool based on Nyan/UwU trend 

> +    (description
> +     "UwUFetch is a system information tool in the lineage of @code{neofetch},
> +@code{pfetch}, @{hyfetch}, and the like. It prints ASCII art of your system's

I suggest to use Neofetch instead of @code{neofetch}, Pfetch instead of
@code{pfetch} and HyFetch instead of (mind the typo!) @code{hyfetch}.

> +logo as well as a summary of system information. UwUFetch's unique contribution
> +is the uwu-ification of various words used in the description. For example, Guix
> +become gUwUix.")

Sentences should be separated with two spaces.

> +    (license license:gpl3)))

License is actually GPL3+.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #14 received at 61157 <at> debbugs.gnu.org (full text, mbox):

From: "J. Sims" <jtsims <at> protonmail.com>
To: 61157 <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#61157] gnu: Add uwufetch.
Date: Tue, 31 Jan 2023 18:49:29 +0000

[Message part 1 (text/plain, inline)]

Hello,

I believe this version of the patch should address all the concerns you raised.

On Tuesday, January 31st, 2023 at 08:19, Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:

> > + (license license:gpl3)))
> 
> License is actually GPL3+.

For future reference, where do I look to differentiate GPLv3 from GPLv3+? I do check that, but obviously I sometimes miss it.

Thanks,
Juli

[0001-gnu-Add-uwufetch.patch (text/x-patch, attachment)]

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: "J. Sims via Guix-patches" via <guix-patches <at> gnu.org>
Cc: 61157-done <at> debbugs.gnu.org, "J. Sims" <jtsims <at> protonmail.com>
Subject: Re: [bug#61157] gnu: Add uwufetch.
Date: Wed, 01 Feb 2023 22:21:27 +0100

Hello,

"J. Sims via Guix-patches" via <guix-patches <at> gnu.org> writes:

> I believe this version of the patch should address all the concerns
> you raised.

It does. Thank you.

> For future reference, where do I look to differentiate GPLv3 from GPLv3+? I do check that, but obviously I sometimes miss it.

If you look into any ".c" source file, you will read:

  either version 3 of the License, or (at your option) any later version.

which basically means GPL3+.

> Subject: [PATCH] gnu: Add uwufetch.
>
> * gnu/packages/admin.scm (uwufetch): Add uwufetch.

Applied!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.