GNU bug report logs - #61163
[PATCH] gnu: emacs-pretty-speedbar: New package.

Previous Next

Package: guix-patches;

Reported by: Martin Marshall <law <at> martinmarshall.com>

Date: Mon, 30 Jan 2023 06:38:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61163 in the body.
You can then email your comments to 61163 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#61163; Package guix-patches. (Mon, 30 Jan 2023 06:38:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Martin Marshall <law <at> martinmarshall.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 30 Jan 2023 06:38:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Martin Marshall <law <at> martinmarshall.com>
To: guix-patches <at> gnu.org
Cc: Martin Marshall <law <at> martinmarshall.com>
Subject: [PATCH] gnu: emacs-pretty-speedbar: New package.
Date: Mon, 30 Jan 2023 01:36:35 -0500
* gnu/packages/emacs-xyz.scm (emacs-pretty-speedbar): New package.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ad3603b205..e1dd10fe9c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6952,6 +6952,31 @@ (define-public emacs-sqlite3-api
 SQLite C interface, but should satisfy most user's needs.")
     (license license:gpl3+)))
 
+(define-public emacs-pretty-speedbar
+  (let ((commit "56dc9f114fcc55843e182cde1fc9d7a14c261c6a")
+        (revision "0"))
+    (package
+      (name "emacs-pretty-speedbar")
+      (version "0.2")
+      (source (origin
+                (uri (git-reference
+                      (url "https://github.com/kcyarn/pretty-speedbar")
+                      (commit commit)))
+                (method git-fetch)
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1hz67jhvg9n9d07lil6zqciqhh512k0fv54dl605p7vi704ma2ir"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list font-awesome))
+      (home-page "https://github.com/kcyarn/pretty-speedbar")
+      (synopsis "SVG icons for Emacs Speedbar")
+      (description
+       "Generate and implement appealing SVG icons for the Emacs Speedbar.  By
+default, it generates icons from the Font Awesome fontset but can use
+alternative fonts.  The color of the icons may also be customized.")
+      (license license:gpl3+))))
+
 (define-public emacs-sr-speedbar
   (let ((commit "77a83fb50f763a465c021eca7343243f465b4a47")
         (revision "0"))

base-commit: 1bed1d848166a4081051b4e87a5ec4942ddb3397
-- 
2.39.1





Information forwarded to guix-patches <at> gnu.org:
bug#61163; Package guix-patches. (Tue, 31 Jan 2023 14:06:01 GMT) Full text and rfc822 format available.

Message #8 received at 61163 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Martin Marshall <law <at> martinmarshall.com>
Cc: 61163 <at> debbugs.gnu.org
Subject: Re: [bug#61163] [PATCH] gnu: emacs-pretty-speedbar: New package.
Date: Tue, 31 Jan 2023 15:05:14 +0100
Hello,

Martin Marshall <law <at> martinmarshall.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-pretty-speedbar): New package.

Thank you. Some comments follow.

> +(define-public emacs-pretty-speedbar
> +  (let ((commit "56dc9f114fcc55843e182cde1fc9d7a14c261c6a")
> +        (revision "0"))
> +    (package
> +      (name "emacs-pretty-speedbar")
> +      (version "0.2")

This should be (git-version "0.2" revision commit) since you're not
using the exact commit where the version bump happened.

> +      (source (origin
> +                (uri (git-reference
> +                      (url "https://github.com/kcyarn/pretty-speedbar")
> +                      (commit commit)))
> +                (method git-fetch)
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "1hz67jhvg9n9d07lil6zqciqhh512k0fv54dl605p7vi704ma2ir"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs (list font-awesome))

It seems the project requires Font Awesome 6, but Guix only provides
version 4. Is it an issue?

It may be worth considering updating font-awesome in Guix first, but
I don't know what its freedom status is nowadays (as a data point,
Parabola provides it, tho).

> +      (description
> +       "Generate and implement appealing SVG icons for the Emacs
> Speedbar.  

This is not a complete sentence.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#61163; Package guix-patches. (Tue, 31 Jan 2023 17:55:01 GMT) Full text and rfc822 format available.

Message #11 received at 61163 <at> debbugs.gnu.org (full text, mbox):

From: Martin Marshall <law <at> martinmarshall.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 61163 <at> debbugs.gnu.org
Subject: Re: [bug#61163] [PATCH] gnu: emacs-pretty-speedbar: New package.
Date: Tue, 31 Jan 2023 12:53:59 -0500
[Message part 1 (text/plain, inline)]
Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

>> +      (propagated-inputs (list font-awesome))
>
> It seems the project requires Font Awesome 6, but Guix only provides
> version 4. Is it an issue?

I don't think so.  While the default value of the `pretty-speedbar-font'
user-setting is "Font Awesome 6 Free Solid", the setting is
customizable, and any icon font may be used with the package.

Even with the default value of `pretty-speedbar-font' unchanged, my
system automatically uses the Font Awesome 4 fonts provided by Guix's
font-awesome package.

> It may be worth considering updating font-awesome in Guix first, but
> I don't know what its freedom status is nowadays (as a data point,
> Parabola provides it, tho).

There is a comment to its package definition stating this:

   ;; XXX The build scripts of version 5 are not freely licensed and
   ;; so we have to stick with version 4 for now:
   ;; <https://bugs.gnu.org/32916>

The linked discussion from 2018 concluded with all participants agreeing
that distribution of version 5 or higher would violate the Gnu FSDG.

I reviewed the Font Awesome GitHub Issues, and it seems they remain
unwilling to change the licensing terms for the build scripts, the matter
having been raised as late as March 2022.

There is a fork of Font Awesome whose stated goals are "to continue
building the amazing resource in a fully free, libre and open-source
fashion" (https://github.com/ForkAwesome/Fork-Awesome).  I haven't
used it though.

>> +      (description
>> +       "Generate and implement appealing SVG icons for the Emacs
>> Speedbar.  
>
> This is not a complete sentence.
>
> Could you send an updated patch?

Thank you for this and the other feedback provided.

I've rewritten the description along with the other suggested changes.

An updated patch is attached.

Warm regards,

-- 
Martin Marshall
law <at> martinmarshall.com
[~/Projects/guix/patches/0001-gnu-Add-emacs-pretty-speedbar.patch (message/external-body, inline)]

[Message part 3 (text/x-patch, inline)]


Information forwarded to guix-patches <at> gnu.org:
bug#61163; Package guix-patches. (Tue, 31 Jan 2023 18:17:02 GMT) Full text and rfc822 format available.

Message #14 received at 61163 <at> debbugs.gnu.org (full text, mbox):

From: Martin Marshall <law <at> martinmarshall.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 61163 <at> debbugs.gnu.org
Subject: Re: [bug#61163] [PATCH] gnu: emacs-pretty-speedbar: New package.
Date: Tue, 31 Jan 2023 13:16:25 -0500
[Message part 1 (text/plain, inline)]
> An updated patch is attached.

I believe something happened to the attachment in my reply,
either in transit or before sending.  (I'm new to sending
attachments with Gnus.)

Hopefully this time will work better.

-- 
Martin Marshall
law <at> martinmarshall.com

On Tue, Jan 31, 2023 at 12:54 PM Martin Marshall <law <at> martinmarshall.com>
wrote:

> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
>
> >> +      (propagated-inputs (list font-awesome))
> >
> > It seems the project requires Font Awesome 6, but Guix only provides
> > version 4. Is it an issue?
>
> I don't think so.  While the default value of the `pretty-speedbar-font'
> user-setting is "Font Awesome 6 Free Solid", the setting is
> customizable, and any icon font may be used with the package.
>
> Even with the default value of `pretty-speedbar-font' unchanged, my
> system automatically uses the Font Awesome 4 fonts provided by Guix's
> font-awesome package.
>
> > It may be worth considering updating font-awesome in Guix first, but
> > I don't know what its freedom status is nowadays (as a data point,
> > Parabola provides it, tho).
>
> There is a comment to its package definition stating this:
>
>    ;; XXX The build scripts of version 5 are not freely licensed and
>    ;; so we have to stick with version 4 for now:
>    ;; <https://bugs.gnu.org/32916>
>
> The linked discussion from 2018 concluded with all participants agreeing
> that distribution of version 5 or higher would violate the Gnu FSDG.
>
> I reviewed the Font Awesome GitHub Issues, and it seems they remain
> unwilling to change the licensing terms for the build scripts, the matter
> having been raised as late as March 2022.
>
> There is a fork of Font Awesome whose stated goals are "to continue
> building the amazing resource in a fully free, libre and open-source
> fashion" (https://github.com/ForkAwesome/Fork-Awesome).  I haven't
> used it though.
>
> >> +      (description
> >> +       "Generate and implement appealing SVG icons for the Emacs
> >> Speedbar.
> >
> > This is not a complete sentence.
> >
> > Could you send an updated patch?
>
> Thank you for this and the other feedback provided.
>
> I've rewritten the description along with the other suggested changes.
>
> An updated patch is attached.
>
> Warm regards,
>
> --
> Martin Marshall
> law <at> martinmarshall.com
>
[Message part 2 (text/html, inline)]
[0001-gnu-Add-emacs-pretty-speedbar.patch (text/x-patch, attachment)]

Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Wed, 01 Feb 2023 21:20:03 GMT) Full text and rfc822 format available.

Notification sent to Martin Marshall <law <at> martinmarshall.com>:
bug acknowledged by developer. (Wed, 01 Feb 2023 21:20:03 GMT) Full text and rfc822 format available.

Message #19 received at 61163-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Martin Marshall <law <at> martinmarshall.com>
Cc: 61163-done <at> debbugs.gnu.org
Subject: Re: [bug#61163] [PATCH] gnu: emacs-pretty-speedbar: New package.
Date: Wed, 01 Feb 2023 22:19:32 +0100
Hello,

> Hopefully this time will work better.

It does. Applied, thank you!

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 02 Mar 2023 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 27 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.