GNU logs - #61188, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
Resent-From: "Mark Bestley" <gnu@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 30 Jan 2023 21:49:02 +0000
Resent-Message-ID: <handler.61188.B.167511532831125 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 61188 <at> debbugs.gnu.org
Feedback-ID: i4629427b:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-106-gfe3ab13a96-fm-20230124.001-gfe3ab13a
Mime-Version: 1.0
Message-Id: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
Date: Mon, 30 Jan 2023 21:48:20 +0000
From: "Mark Bestley" <gnu@HIDDEN>
Content-Type: multipart/alternative; boundary=0da3468e8eea41babbb42a1c1fac88bb
Received-SPF: pass client-ip=66.111.4.28; envelope-from=gnu@HIDDEN;
 helo=out4-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

--0da3468e8eea41babbb42a1c1fac88bb
Content-Type: text/plain


Look at the results of

(require 'color)
(message "reduce by 100 = %s" (color-lighten-name "Black" 100))
(message "reduce by 0 = %s" (color-lighten-name "Black" 0))

In emacs 28.2 they give "#ffffffffffff" and 0 as expected.
In emacs 30.0.50 they give 0 and 0

In GNU Emacs 30.0.50 (build 1, aarch64-apple-darwin22.2.0, NS appkit-2299.30
Version 13.1 (Build 22C65)) of 2023-01-02 built on mini20.local
Windowing system distributor 'Apple', version 10.3.2299
System Description:  macOS 13.1

Configured using:
'configure --prefix=/opt/local --disable-silent-rules --without-dubs
--without-gconf --without-libotf --without-m17n-flt --with-libgmp
--with-gnutls --with-json --with-xml2 --with-modules --infodir
/opt/local/share/info/emacs --with-sqlite3 --with-webp --with-ns
--with-lcms2 --without-harfbuzz --without-imagemagick --without-xaw3d
--with-tree-sitter --with-rsvg --with-xwidgets
--with-native-compilation=aot 'CFLAGS=-pipe -Os -Wno-attributes
-isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -arch arm64'
'CPPFLAGS=-I/opt/local/include
-isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk'
'LDFLAGS=-L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-rpath
/opt/local/lib/gcc12 -Wl,-no_pie
-Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -arch
arm64''

Configured features:
ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY
KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER WEBP XIM XWIDGETS ZLIB

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8

Major mode: ELisp/d
--0da3468e8eea41babbb42a1c1fac88bb
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>=
Look at the results of<br></div><div><br></div><div>(require 'color)<br>=
</div><div>(message "reduce by 100 =3D %s" (color-lighten-name "Black" 1=
00))<br></div><div>(message "reduce by 0 =3D %s" (color-lighten-name "Bl=
ack" 0))<br></div><div><br></div><div>In emacs 28.2 they give "#ffffffff=
ffff" and 0 as expected.<br></div><div>In emacs 30.0.50 they give 0 and =
0<br></div><div><br></div><div>In GNU Emacs 30.0.50 (build 1, aarch64-ap=
ple-darwin22.2.0, NS appkit-2299.30<br></div><div> Version 13.1 (Build 2=
2C65)) of 2023-01-02 built on mini20.local<br></div><div>Windowing syste=
m distributor 'Apple', version 10.3.2299<br></div><div>System Descriptio=
n:<span class=3D"Apple-converted-space">&nbsp;</span> macOS 13.1<br></di=
v><div><br></div><div>Configured using:<br></div><div> 'configure --pref=
ix=3D/opt/local --disable-silent-rules --without-dubs<br></div><div> --w=
ithout-gconf --without-libotf --without-m17n-flt --with-libgmp<br></div>=
<div> --with-gnutls --with-json --with-xml2 --with-modules --infodir<br>=
</div><div> /opt/local/share/info/emacs --with-sqlite3 --with-webp --wit=
h-ns<br></div><div> --with-lcms2 --without-harfbuzz --without-imagemagic=
k --without-xaw3d<br></div><div> --with-tree-sitter --with-rsvg --with-x=
widgets<br></div><div> --with-native-compilation=3Daot 'CFLAGS=3D-pipe -=
Os -Wno-attributes<br></div><div> -isysroot/Library/Developer/CommandLin=
eTools/SDKs/MacOSX13.sdk -arch arm64'<br></div><div> 'CPPFLAGS=3D-I/opt/=
local/include<br></div><div> -isysroot/Library/Developer/CommandLineTool=
s/SDKs/MacOSX13.sdk'<br></div><div> 'LDFLAGS=3D-L/opt/local/lib -Wl,-hea=
derpad_max_install_names -Wl,-rpath<br></div><div> /opt/local/lib/gcc12 =
-Wl,-no_pie<br></div><div> -Wl,-syslibroot,/Library/Developer/CommandLin=
eTools/SDKs/MacOSX13.sdk -arch<br></div><div> arm64''<br></div><div><br>=
</div><div>Configured features:<br></div><div>ACL GIF GLIB GMP GNUTLS JP=
EG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY<br></div><div>KQUEUE NS=
 PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS<br></div><div=
>TREE_SITTER WEBP XIM XWIDGETS ZLIB<br></div><div><br></div><div>Importa=
nt settings:<br></div><div><span class=3D"Apple-converted-space">&nbsp;<=
/span> value of $LANG: en_GB.UTF-8<br></div><div><span class=3D"Apple-co=
nverted-space">&nbsp;</span> locale-coding-system: utf-8<br></div><div><=
br></div><div>Major mode: ELisp/d<br></div></body></html>
--0da3468e8eea41babbb42a1c1fac88bb--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: "Mark Bestley" <gnu@HIDDEN>
Subject: bug#61188: Acknowledgement (30.0.50; color-lighten-name seems not
 to work)
Message-ID: <handler.61188.B.167511532831125.ack <at> debbugs.gnu.org>
References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
X-Gnu-PR-Message: ack 61188
X-Gnu-PR-Package: emacs
Reply-To: 61188 <at> debbugs.gnu.org
Date: Mon, 30 Jan 2023 21:49:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 61188 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
61188: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61188
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
Resent-From: Stephen Berman <stephen.berman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 30 Jan 2023 22:59:01 +0000
Resent-Message-ID: <handler.61188.B61188.16751195186053 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: "Mark Bestley" <gnu@HIDDEN>
Cc: 61188 <at> debbugs.gnu.org
From: Stephen Berman <stephen.berman@HIDDEN>
In-Reply-To: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN> (Mark
 Bestley's message of "Mon, 30 Jan 2023 21:48:20 +0000")
References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
Date: Mon, 30 Jan 2023 23:58:26 +0100
Message-ID: <87wn53iq99.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
UI-OutboundReport: notjunk:1;M01:P0:rvGmY7jR/YU=;2QlI36yylFc3jq7s86KIfwHI1Mq
 pClobiWOldW2vn7zhF3V3+6CHVRW88yXsuKWyl5qN9/kcA5RxfoqwGkAr2UIuZ97JxqKbI+/y
 fVmYqVFOSTB4vuoo85SruYf7C23a9Yn6WzUOGR7v4tDdlnWVJ+g0dnHn8Y9m4q9yPVTy/JRd0
 4+C36/S0OQdYh7pDF921hvENJkdHKblDmPB1g1OUQltFJUj7zjxaqdGC0kf6sHnD8jwrMiN4f
 ykJVfops3LQbQFb/rStn5NZGz9abHv/5xoYUhkTauxFhzY8E+85ahEN9sOsaEEVObjJm5dZEj
 YjLLpySCTwKWnXFWSJw5jDt3jxrChMolvK03nnkkJ04byaD2dMJsiAVK7uwSnxTS5rEfPec0n
 48gd4/Kdx43m9nrI+MNJBFWe/tE2L6++jtndLhAMuE5SLlrWfmPAFOLjhYiRjUNTSL0xi9Urs
 1EEdemjzYRKecfX3PBmo3O9pMkGQtl7kWl2HPtVZyxx3Th1E8+NqLEJCV4pXqRVWsgQ4jGkXI
 9PzQQ1JGvzJJEAChTHmGZh653QMFCBygkCfSwlnW3FgGItOT5+Q+3S4uh1CHBgmxW3bl+7/Uf
 w4WKEdsCLnXsUorcXpu4OwaY0Gy0bfj9O2mRBR9pxbnbvWjz6aHRdfEmwq0qLDKahAI+weaNh
 k1vGNUeKuK4G40u3ihGtKNedg4CAFQd2f79sZjknKJouZHPpvbQz+omF1hWCnaNGyQpmv/mrQ
 rGfDUV+wAxyInYz/R8FJQ/OngYMQaDc71DIVoKtnlMb6iM2w8L1ou9FSx/67ja7cZcAvl1K1z
 Lt+9GOeZf7VmHcnLHk1CB8t/RgcJqFx7bjccd229m8UEJoh4F0SCaWPB7yfqw2Ov6SAYriDbg
 7QWLIg/NFzjWnPdpXkacxbMbbMSWD2ZrBqHRdQQC9nsRty8uwrZMdCXIY6gubHxp7CPSErSRJ
 xuNLB3tiWGZW7y939YTdJWvSBx0=
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, 30 Jan 2023 21:48:20 +0000 "Mark Bestley" <gnu@HIDDEN> wrot=
e:

> Look at the results of
>
> (require 'color)
> (message "reduce by 100 =3D %s" (color-lighten-name "Black" 100))
> (message "reduce by 0 =3D %s" (color-lighten-name "Black" 0))
>
> In emacs 28.2 they give "#ffffffffffff" and 0 as expected.
> In emacs 30.0.50 they give 0 and 0

This difference is due to this commit:

commit 656c2dd66e77a5fbeb99d358017e8327401fae05
Author:     Lars Ingebrigtsen <larsi@HIDDEN>
Commit:     Lars Ingebrigtsen <larsi@HIDDEN>
CommitDate: Tue Mar 22 15:28:02 2022 +0100

    Fix color-lighten-hsl logic

    * lisp/color.el (color-lighten-hsl): Lighten by percentage,
    instead of just adding the specified number to the luminance
    element (bug#54514).

The patch below restores the Emacs 28 result for the above examples
while keeping the desired result for the example in bug#54514, but I
have no idea if it yields undesirable results in other cases.

Steve Berman


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline
Content-Description: color-lighten-hsl patch
Content-Transfer-Encoding: quoted-printable

diff --git a/lisp/color.el b/lisp/color.el
index f68cf5e6b17..a251b1a24a0 100644
=2D-- a/lisp/color.el
+++ b/lisp/color.el
@@ -407,7 +407,7 @@ color-lighten-hsl
 Given a color defined in terms of hue, saturation, and luminance
 \(arguments H, S, and L), return a color that is PERCENT lighter.
 Returns a list (HUE SATURATION LUMINANCE)."
-  (list H S (color-clamp (+ L (* L (/ percent 100.0))))))
+  (list H S (color-clamp (+ L (* (if (> L 0) L 1) (/ percent 100.0))))))

 (defun color-lighten-name (name percent)
   "Make a color with a specified NAME lighter by PERCENT.

--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 31 Jan 2023 18:41:02 +0000
Resent-Message-ID: <handler.61188.B61188.167519040230268 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Stephen Berman <stephen.berman@HIDDEN>
Cc: 61188 <at> debbugs.gnu.org, gnu@HIDDEN
Date: Tue, 31 Jan 2023 20:39:45 +0200
Message-Id: <83o7qe1rbi.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87wn53iq99.fsf@HIDDEN> (message from Stephen Berman on Mon, 30
 Jan 2023 23:58:26 +0100)
References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
 <87wn53iq99.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Cc: 61188 <at> debbugs.gnu.org
> From: Stephen Berman <stephen.berman@HIDDEN>
> Date: Mon, 30 Jan 2023 23:58:26 +0100
> 
> On Mon, 30 Jan 2023 21:48:20 +0000 "Mark Bestley" <gnu@HIDDEN> wrote:
> 
> > Look at the results of
> >
> > (require 'color)
> > (message "reduce by 100 = %s" (color-lighten-name "Black" 100))
> > (message "reduce by 0 = %s" (color-lighten-name "Black" 0))
> >
> > In emacs 28.2 they give "#ffffffffffff" and 0 as expected.
> > In emacs 30.0.50 they give 0 and 0
> 
> This difference is due to this commit:
> 
> commit 656c2dd66e77a5fbeb99d358017e8327401fae05
> Author:     Lars Ingebrigtsen <larsi@HIDDEN>
> Commit:     Lars Ingebrigtsen <larsi@HIDDEN>
> CommitDate: Tue Mar 22 15:28:02 2022 +0100
> 
>     Fix color-lighten-hsl logic
> 
>     * lisp/color.el (color-lighten-hsl): Lighten by percentage,
>     instead of just adding the specified number to the luminance
>     element (bug#54514).
> 
> The patch below restores the Emacs 28 result for the above examples
> while keeping the desired result for the example in bug#54514, but I
> have no idea if it yields undesirable results in other cases.

If all the tests in color-tests.el pass after the change, please
install on the release branch.

Thanks.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
Resent-From: Stephen Berman <stephen.berman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 31 Jan 2023 20:35:01 +0000
Resent-Message-ID: <handler.61188.B61188.16751972789423 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 61188
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 61188 <at> debbugs.gnu.org, gnu@HIDDEN
Received: via spool by 61188-submit <at> debbugs.gnu.org id=B61188.16751972789423
          (code B ref 61188); Tue, 31 Jan 2023 20:35:01 +0000
Received: (at 61188) by debbugs.gnu.org; 31 Jan 2023 20:34:38 +0000
Received: from localhost ([127.0.0.1]:55125 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pMxKv-0002Ru-UV
	for submit <at> debbugs.gnu.org; Tue, 31 Jan 2023 15:34:38 -0500
Received: from mout.gmx.net ([212.227.17.22]:50855)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1pMxKs-0002Rc-E9
 for 61188 <at> debbugs.gnu.org; Tue, 31 Jan 2023 15:34:36 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417;
 t=1675197265; bh=YHArr5kxlFMVmciluA0EwLxpWJXOcNkGbumnx/lQXWs=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
 b=szzbzFR9R0TGqFGJgBQDbPelPi50nUdqxTIgjBl8Gr264xOifswNBCn3e/xi19+Cs
 0OiZEHrQyLOn8jAepgsyM0FoeQk8lGinqVPbIdQjo7R7guIU9p9OtzmeM6Dp8D61Qk
 loZK4Vpj+N88GQowNHeLQclmsjT5WChOxXJEW/YQnsB8GPDbbHoLSkRvwwuXIsAHaD
 Xn+PLhDrx2GZ84layehQyG62vdeopnkPaiLt8n9Bhj4qjILq/+jfNSTSBz27iFtIWH
 CC5Bh+b3dm/+YlkJf2ZuQeYLzFTnsLXBBYjBa2hU1DfokPXA3vzHyUCqeu6c3VKWGF
 1MnCOmWw2ZeVA==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from strobelfs ([89.246.36.69]) by mail.gmx.net (mrgmx105
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MgesG-1oiNJt0ln2-00h3Sc; Tue, 31
 Jan 2023 21:34:25 +0100
From: Stephen Berman <stephen.berman@HIDDEN>
In-Reply-To: <83o7qe1rbi.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 31 Jan
 2023 20:39:45 +0200")
References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
 <87wn53iq99.fsf@HIDDEN> <83o7qe1rbi.fsf@HIDDEN>
Date: Tue, 31 Jan 2023 21:34:24 +0100
Message-ID: <87ilgmmoj3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:JHVqqL7rpBemA6uio6mNfCD0QAKhd1aqTp+nCLkE8HIcewIxyKM
 73PvB8T4IzgxLYczXvGLW05TZz+v8jZrZs5FjvWFrgmsVXf85RVg5MuO5EJfRNZ5yMczRNa
 0sKb2QIiTeGoc84R3jKmgPrJ2i4uGWOg35kgXbJLna3pnR9+dlGyJQ93cmX7XnPM6rZBXaJ
 XncCKWhEbPpq12tBWitSA==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:j7MFSCEcgMM=;7536G9z8PgjAdPMh3IQnS+IqecP
 Mw636+En88P48NF8HIGeIm1s83daBZftaqVG0leJuXTetgTpuaz2kMlk8l4S0c1Lsh3sBgrFk
 qge3banehCY5btNaYpYriCHbqeuuz/x7xPTnyblbanjcVdwpTua3xoyxys0TTF4Vj6v+pFe8i
 PWuAWH9vIgl18O2eaaH6LsRMoM/StpNCPE9bqhvnfcnmx0uPvoFxnXxqllne3kBZV0ayh3pkt
 YlaY+cLj8VvYx2D4/1bt39d6DcnSrKQxyDEaESgFFqIyjEyXBR3aNo/bQdahMW/Lw4QgpVwAl
 BOIn71A33yOIwOd7xhuxp53ookNtAYpkQPisLQ1Ncq5XkypmpZMFUN2MGaxrktY1sg/R6KeCc
 TOvMAyKifv7trkbHDe3VRehePCqtzMmSA+mv9nyMPz2H7rnRuIuLr9uUo7C7VSw24SnadLNBo
 hFHR/Tg4PkNgy8TMCrkWlXpPQYqx1uLcPC5KDytvz+27qgQ4jUGd0B/gvfGkqykgDfiPD6sN8
 ghAgnkzWAaYOx3UZezfY+nOAtfDU9qY1aAia1yJ637cGHUeDSkYULy11gHeaRIDsP4ogiSgwx
 chnH1JORab/EDXFlu82s5PwFviw+I1/+nBF0PG7pf4zeopR1VHeMVvJboK8tzzilwwWSaFPpa
 xIXpL07/O/ntfLPqMCeVATQgrLytakrUG3f/jbMg28XgbiqoXotOup73Wf1i5EN7OK3Xx0qQF
 nY1boUj6pPLp9VXRJW0QKwog2rp9R9bBfEVICmQRUgOTcMpUfKlpEnWW8AcZWQaqensC4hF+j
 ZNxs3pTJpmtagTgvYglE1Xto/HRfVV17FgUL4xR43HgnviRgC7zIY4DV8qPuqQg0AzlcdMvS3
 aUqPp55iVVyZ1XpRNiS3sh3sXloXyl3SFiUN18xQmKZYe79aceigeKTfoVGLkyvuYlBciOUGQ
 Dd4y1gyASy8G3UcL+t4t+iT7/Q0=
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Tue, 31 Jan 2023 20:39:45 +0200 Eli Zaretskii <eliz@HIDDEN> wrote:

>> Cc: 61188 <at> debbugs.gnu.org
>> From: Stephen Berman <stephen.berman@HIDDEN>
>> Date: Mon, 30 Jan 2023 23:58:26 +0100
>>
>> On Mon, 30 Jan 2023 21:48:20 +0000 "Mark Bestley" <gnu@HIDDEN> w=
rote:
>>
>> > Look at the results of
>> >
>> > (require 'color)
>> > (message "reduce by 100 =3D %s" (color-lighten-name "Black" 100))
>> > (message "reduce by 0 =3D %s" (color-lighten-name "Black" 0))
>> >
>> > In emacs 28.2 they give "#ffffffffffff" and 0 as expected.
>> > In emacs 30.0.50 they give 0 and 0
>>
>> This difference is due to this commit:
>>
>> commit 656c2dd66e77a5fbeb99d358017e8327401fae05
>> Author:     Lars Ingebrigtsen <larsi@HIDDEN>
>> Commit:     Lars Ingebrigtsen <larsi@HIDDEN>
>> CommitDate: Tue Mar 22 15:28:02 2022 +0100
>>
>>     Fix color-lighten-hsl logic
>>
>>     * lisp/color.el (color-lighten-hsl): Lighten by percentage,
>>     instead of just adding the specified number to the luminance
>>     element (bug#54514).
>>
>> The patch below restores the Emacs 28 result for the above examples
>> while keeping the desired result for the example in bug#54514, but I
>> have no idea if it yields undesirable results in other cases.
>
> If all the tests in color-tests.el pass after the change, please
> install on the release branch.

With that patch one test now fails: the one testing (color-lighten-name
"Black" 100).  This is because the tests were changed to conform to the
code change made in response to bug#54514.  So it seems there is
disagreement about what the result of (color-lighten-name "Black" 100)
should be.

Steve Berman

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 01 Feb 2023 13:22:02 +0000
Resent-Message-ID: <handler.61188.B61188.167525771923183 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 61188
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stephen Berman <stephen.berman@HIDDEN>
Cc: 61188 <at> debbugs.gnu.org, gnu@HIDDEN
Received: via spool by 61188-submit <at> debbugs.gnu.org id=B61188.167525771923183
          (code B ref 61188); Wed, 01 Feb 2023 13:22:02 +0000
Received: (at 61188) by debbugs.gnu.org; 1 Feb 2023 13:21:59 +0000
Received: from localhost ([127.0.0.1]:56853 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pND3n-00061q-74
	for submit <at> debbugs.gnu.org; Wed, 01 Feb 2023 08:21:59 -0500
Received: from eggs.gnu.org ([209.51.188.92]:40220)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pND3l-00061c-2q
 for 61188 <at> debbugs.gnu.org; Wed, 01 Feb 2023 08:21:57 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pND3f-0004E3-DN; Wed, 01 Feb 2023 08:21:51 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=F39tecQN7RcpMU0bv6k4OrzL+5lMUUD/+fsCECF1UnQ=; b=SgGelMKe6GVl
 AEahl9vxOGGLg1UJDOjBSXQQQV8n+F0pb8G3sxK/h4zj/V4kAaAVfZwlDpSE5CKbFu4ALj+S5qtwy
 rEtYO0DDcvR2VYoxNBXgoPiPXMYagX6mvELY54poX7zF9jPfdscS6ttQxYvyoq07oIrhJz2ZyqsLS
 JviBGC9rhzNTueom2mxCPBybgBnm4l31s9DxKBZ9drDVJxa7EhrUzdplaBPI56MGFFT7OBgjsvheq
 h+rg1dyzT97YOnQT9UuGBPx6bLC3hLn87dz+eqIU7OlcGYrelCSeVE8AHTqRkTzvMTMiPXR7XdAXG
 rtOmENyfjRY3DjTW8vJA/Q==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pND3e-0005Yn-IC; Wed, 01 Feb 2023 08:21:50 -0500
Date: Wed, 01 Feb 2023 15:21:50 +0200
Message-Id: <83wn51zfkh.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87ilgmmoj3.fsf@HIDDEN> (message from Stephen Berman on Tue, 31
 Jan 2023 21:34:24 +0100)
References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
 <87wn53iq99.fsf@HIDDEN> <83o7qe1rbi.fsf@HIDDEN> <87ilgmmoj3.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stephen Berman <stephen.berman@HIDDEN>
> Cc: gnu@HIDDEN,  61188 <at> debbugs.gnu.org
> Date: Tue, 31 Jan 2023 21:34:24 +0100
> 
> On Tue, 31 Jan 2023 20:39:45 +0200 Eli Zaretskii <eliz@HIDDEN> wrote:
> 
> > If all the tests in color-tests.el pass after the change, please
> > install on the release branch.
> 
> With that patch one test now fails: the one testing (color-lighten-name
> "Black" 100).  This is because the tests were changed to conform to the
> code change made in response to bug#54514.  So it seems there is
> disagreement about what the result of (color-lighten-name "Black" 100)
> should be.

So I guess the current behavior is the intended one, and we should
close this bug as wontfix?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
Resent-From: "Mark Bestley" <gnu@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 01 Feb 2023 14:12:02 +0000
Resent-Message-ID: <handler.61188.B61188.167526070128191 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 61188
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: "Eli Zaretskii" <eliz@HIDDEN>, "Stephen Berman" <stephen.berman@HIDDEN>
Cc: 61188 <at> debbugs.gnu.org
Received: via spool by 61188-submit <at> debbugs.gnu.org id=B61188.167526070128191
          (code B ref 61188); Wed, 01 Feb 2023 14:12:02 +0000
Received: (at 61188) by debbugs.gnu.org; 1 Feb 2023 14:11:41 +0000
Received: from localhost ([127.0.0.1]:56909 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pNDps-0007Kc-TZ
	for submit <at> debbugs.gnu.org; Wed, 01 Feb 2023 09:11:41 -0500
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34305)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gnu@HIDDEN>) id 1pNDpq-0007KM-SL
 for 61188 <at> debbugs.gnu.org; Wed, 01 Feb 2023 09:11:40 -0500
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id CF07E5C0089;
 Wed,  1 Feb 2023 09:11:33 -0500 (EST)
Received: from imap43 ([10.202.2.93])
 by compute3.internal (MEProxy); Wed, 01 Feb 2023 09:11:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bestley.co.uk;
 h=cc:cc:content-type:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to; s=fm2; t=1675260693; x=1675347093; bh=AQ
 n0CHsqQY3reni8PTsnzTi5B3FKnfEtzDWatMPEKdo=; b=eQTZyq60GyjYwXBB+y
 0ZCKW/Dztv+btsyiCN4jBfwJheO/JGV7/6FwEO4VbwxvZp+s59wHqTGrHB+iAmQV
 iD9RDZWfHd87ZKY54UDAPoozL/Pz3T2o0zwaoP7dkYjbb64JxWcaLU6Nu6wlo+ec
 cXgsJCEx8geiQ6m1xkTe5Zjce+JT1uvHPyyFojZChBbHK57oJE6ImXcmDL37nFGm
 sQaTtmepe9u+30U17qOUx3KKt/G+iHBz3teRjstRVEs/6MLhkQk0R1/r9a4sPrmd
 o4Q30ZIAVm2/PzfyNeUFo85zHK3qDFNEOrm+D5IVl5fUg9Kd6bPuog6J3X9Ky8Tb
 WubQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
 :feedback-id:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:sender:subject:subject:to:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm3; t=1675260693; x=1675347093; bh=AQn0CHsqQY3reni8PTsnzTi5B3FK
 nfEtzDWatMPEKdo=; b=Bgb4MxKKlcUo4gxpAzScFdCr8Vpq3BGYjWaQP2Cs8PkZ
 riEZSEiohE/Wwv1WMtX++brUtTrHdfLXJJTELoAPFZi6k5yDTlBgJOfmG9KLJog+
 Dj5F5NQpuJ8SmflbCVo4/M3W6JaLBIChpluXHQNs//5nufCBwOuKgRDPrAgZMMKo
 uNJNxhwh8Y7sOXA8IR7U5KT+GZ4CDTkqj8DUujdZLFl/wUWO2HI1NNbLiiNMY/UN
 K+OdKPrTUAL+8rB5dn/01PxohqXiSEjxzntUpKPDbvS2T13E3VnOxScoxuj7d9eu
 Dxgb0Tkhb08v6U9mD0WTnbx/4udRo3A74D6gQ5QXMg==
X-ME-Sender: <xms:FXPaY3iAe-ap6ymzgRdNl26Gm07JEsoVXKb7mU0FeQG-BtsGrati6Q>
 <xme:FXPaY0Cfl97Fba9_0_9ulKnidKCC55wJrvkIt3L58dUzgwSYqRHo-OLiUwF8ABkr-
 txMXL_n8rMYwFzQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefiedgiedvucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedfofgr
 rhhkuceuvghsthhlvgihfdcuoehgnhhusegsvghsthhlvgihrdgtohdruhhkqeenucggtf
 frrghtthgvrhhnpefgleetvdefleehvddvheefkeefgfeiffeludefheeufedvffethfei
 leejhfduvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh
 hmpehgnhhusegsvghsthhlvgihrdgtohdruhhk
X-ME-Proxy: <xmx:FXPaY3GmAkanrn5XUcziTTaatHgU62oiNzE_lE-0a8AQjfaJGWbK4w>
 <xmx:FXPaY0TQueOYLjfo1tF-N9YI7ArfGkg9PGgsRosjLzkNoR9n6GQ97g>
 <xmx:FXPaY0yJLhoTxwzA4oRHlHFYaBuwPJUUurmteAMJaMwmedoZ-0jCbQ>
 <xmx:FXPaY6bAWRGG6k0MFmLPBQYs3-ilvgYsCc1F_WAnMxMAaODP-uc9tQ>
Feedback-ID: i4629427b:Fastmail
Received: by mailuser.nyi.internal (Postfix, from userid 501)
 id 6B2EF2D40074; Wed,  1 Feb 2023 09:11:33 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.9.0-alpha0-107-g82c3c54364-fm-20230131.002-g82c3c543
Mime-Version: 1.0
Message-Id: <180e1ab1-287c-451b-bd43-6b858638df2f@HIDDEN>
In-Reply-To: <83wn51zfkh.fsf@HIDDEN>
References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
 <87wn53iq99.fsf@HIDDEN> <83o7qe1rbi.fsf@HIDDEN> <87ilgmmoj3.fsf@HIDDEN>
 <83wn51zfkh.fsf@HIDDEN>
Date: Wed, 01 Feb 2023 14:11:13 +0000
From: "Mark Bestley" <gnu@HIDDEN>
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)



On Wed, 1 Feb 2023, at 13:21, Eli Zaretskii wrote:
>> From: Stephen Berman <stephen.berman@HIDDEN>
>> Cc: gnu@HIDDEN,  61188 <at> debbugs.gnu.org
>> Date: Tue, 31 Jan 2023 21:34:24 +0100
>> 
>> On Tue, 31 Jan 2023 20:39:45 +0200 Eli Zaretskii <eliz@HIDDEN> wrote:
>> 
>> > If all the tests in color-tests.el pass after the change, please
>> > install on the release branch.
>> 
>> With that patch one test now fails: the one testing (color-lighten-name
>> "Black" 100).  This is because the tests were changed to conform to the
>> code change made in response to bug#54514.  So it seems there is
>> disagreement about what the result of (color-lighten-name "Black" 100)
>> should be.
>
> So I guess the current behavior is the intended one, and we should
> close this bug as wontfix?


No - I think the way 28.2 worked was correct. (for impact see highlight-indent.el which now does not work with a black background )

What is the expected value of (color-lighten-name  "Black" 100) as I don't know where that test is. I would think the test is wrong. Did it run for 28.2?

Surely lightening Black fully should give white

Also look at color-lighten-name  "Black" 50) in 28.2 it is a gray.

In 30 olor-lighten-name  "Black" of any positive value gives Black - surely this cannot be correct.

-- 
Mark

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 01 Feb 2023 17:19:01 +0000
Resent-Message-ID: <handler.61188.B61188.167527194117923 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 61188
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: "Mark Bestley" <gnu@HIDDEN>
Cc: stephen.berman@HIDDEN, 61188 <at> debbugs.gnu.org
Received: via spool by 61188-submit <at> debbugs.gnu.org id=B61188.167527194117923
          (code B ref 61188); Wed, 01 Feb 2023 17:19:01 +0000
Received: (at 61188) by debbugs.gnu.org; 1 Feb 2023 17:19:01 +0000
Received: from localhost ([127.0.0.1]:59744 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pNGlA-0004f1-LT
	for submit <at> debbugs.gnu.org; Wed, 01 Feb 2023 12:19:00 -0500
Received: from eggs.gnu.org ([209.51.188.92]:49604)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pNGl6-0004em-VM
 for 61188 <at> debbugs.gnu.org; Wed, 01 Feb 2023 12:18:59 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pNGl1-0005yr-6N; Wed, 01 Feb 2023 12:18:51 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=EYg+WPeQ610Cm0v3FJCwjRmtbrWdSMldi738ra2rdFg=; b=Upy7wNWqcrpb
 2s7phJjn7aAEJOM5qWl+5Q+J9F4pr76EHxSWqcOW5l/n6Jpiw705eoABO3IoPNXajlGIFhJUUjjlt
 MUzYLePBWGtebWIAVUP2dYK3I/sr5+SLKCNny1G85sVIClwc4Ob3qfSeXkiM191x/mponNPNba/7z
 FcHoWvjY7ajjdqnpt/gTCKcQMkFjQI8uGGEkhCgsX835w0NbB8nIyVYTp3u6W++Gwaj8CHcT4AecM
 S2KrjtEF6z3Rl/8XO3x83Z/Lh6wMDhdzHbhh52D6mBTO4rTYdcO6iZPORzsTPmw2ircsvqndLRD/B
 /R+OCrrvyztdwzTB/kUpSg==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pNGl0-0007q7-L5; Wed, 01 Feb 2023 12:18:50 -0500
Date: Wed, 01 Feb 2023 19:18:50 +0200
Message-Id: <83o7qdz4lh.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <180e1ab1-287c-451b-bd43-6b858638df2f@HIDDEN>
 (gnu@HIDDEN)
References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
 <87wn53iq99.fsf@HIDDEN> <83o7qe1rbi.fsf@HIDDEN> <87ilgmmoj3.fsf@HIDDEN>
 <83wn51zfkh.fsf@HIDDEN>
 <180e1ab1-287c-451b-bd43-6b858638df2f@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Wed, 01 Feb 2023 14:11:13 +0000
> From: "Mark Bestley" <gnu@HIDDEN>
> Cc: 61188 <at> debbugs.gnu.org
> 
> > So I guess the current behavior is the intended one, and we should
> > close this bug as wontfix?
> 
> No - I think the way 28.2 worked was correct. (for impact see highlight-indent.el which now does not work with a black background )

But by changing the tests to match what Emacs does now we explicitly
said that we disagree, and that the current behavior is the correct
one.

> What is the expected value of (color-lighten-name  "Black" 100) as I don't know where that test is. I would think the test is wrong. Did it run for 28.2?

The test is in test/lisp/color-tests.el.  The expected value is
exactly what you said is wrong.

> Surely lightening Black fully should give white

How so?  The 100 is the percentage of the present luminance, and if
that is zero, why do you expect it to become lighter?

See also the discussion in bug#54514, which was exactly about that.

> In 30 olor-lighten-name  "Black" of any positive value gives Black - surely this cannot be correct.

A zero multiplied by any percentage stays zero, no?  If you want a
non-zero result, start with something close to black, but not actually
black.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
Resent-From: "Mark Bestley" <gnu@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 02 Feb 2023 15:47:02 +0000
Resent-Message-ID: <handler.61188.B61188.167535280324855 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 61188
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: "Eli Zaretskii" <eliz@HIDDEN>
Cc: stephen.berman@HIDDEN, 61188 <at> debbugs.gnu.org
Received: via spool by 61188-submit <at> debbugs.gnu.org id=B61188.167535280324855
          (code B ref 61188); Thu, 02 Feb 2023 15:47:02 +0000
Received: (at 61188) by debbugs.gnu.org; 2 Feb 2023 15:46:43 +0000
Received: from localhost ([127.0.0.1]:35541 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pNbnO-0006So-PW
	for submit <at> debbugs.gnu.org; Thu, 02 Feb 2023 10:46:43 -0500
Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:42055)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gnu@HIDDEN>) id 1pNbnM-0006Sb-Jr
 for 61188 <at> debbugs.gnu.org; Thu, 02 Feb 2023 10:46:41 -0500
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id E6C5132007F9;
 Thu,  2 Feb 2023 10:46:31 -0500 (EST)
Received: from imap43 ([10.202.2.93])
 by compute3.internal (MEProxy); Thu, 02 Feb 2023 10:46:32 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bestley.co.uk;
 h=cc:cc:content-type:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to; s=fm2; t=1675352791; x=1675439191; bh=BC
 xGWORdBf31RMPHq437Q+wADGIuDFZkyoPOJMQFGO8=; b=QZH3YVW4tND3KPlQ5Q
 OWcQZWcfyrKBEtrHS615wmDlqo+er+OpH+axjQ3rNaKc6JEpYjVRY3+vv8AWC8L7
 Yi3fCseQHFMNwkrbel6GW350RbbQiEgmCEmk8Rekpn51OhfGdFQOkWl76zrrjdY8
 nXEX2YfUpVp+oWdy5BNT6/T7dBlzPHYk4nvKdenkXYLoUVpgYOjuAjdouuNeM85R
 Sr01C15PrZ1ElduuVMxciDDqXT6fwuZBvTvAG4ReIetyTLdLUBfTy1S+GTTvYElu
 naJroaisU3ld4C3aIabJ4iS1ai6y5hJJ7UDEq1MYjIBwefp4QKsc4BL22bWYNInW
 t+2Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
 :feedback-id:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:sender:subject:subject:to:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm3; t=1675352791; x=1675439191; bh=BCxGWORdBf31RMPHq437Q+wADGIu
 DFZkyoPOJMQFGO8=; b=aeUvErlyB/g27jAXrZLKjEH1teGJMAuoVXZvy9MYk6Gq
 3HM3UIepdcj+nTmbvvbd/18y0akX3ZbY9eZq/DS4tW4wSNhZdNLCaOgGRW8UZ0+0
 uFmdB+faOUqjZ4RxxpvsoCIDlQGPRZKSpRkli3VCbOKrNF2mpX4zzfPhMFZ9qQW6
 gY4BHDr34DoD6YM2X1dTFKBF6EGKxUiyYYhxbyqlnRJJrFgv5kophrLSEFqLwMBz
 cNXkae67b1YHodzmbXa9xWlU86WdKLlMcjj1zXVUt9k48W3TQmHI2kKl0aWIkDHA
 pSRU1MVuHPwsSFxrmGppHNPKCvR5s0BoKi/VVNql4Q==
X-ME-Sender: <xms:19rbY7JFftaFCb68FBQgb0NNAGPIRg8jyuUDQMDeyOrEtuGy0fVKAQ>
 <xme:19rbY_K0b6rDwvMgkz5DwK3Gs1YFEZhr3q1Q8DAdOR_gG0_Fz4FORxUSjVXhxc4sA
 ryXZF0xL3fBhzjp>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedgjeeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepofgfggfkjghffffhvfevufgtsegrtdhmreerredtnecuhfhrohhmpedfofgr
 rhhkuceuvghsthhlvgihfdcuoehgnhhusegsvghsthhlvgihrdgtohdruhhkqeenucggtf
 frrghtthgvrhhnpeeuieegleeugfejvefhlefhgfejfeelffdvvdfhfeeuhfdvffeiueei
 hfelieffhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh
 hmpehgnhhusegsvghsthhlvgihrdgtohdruhhk
X-ME-Proxy: <xmx:19rbYzvPmZD6OD5eQXkk3wt-mplbN8LqWKscmoDFogDOGz1OispThg>
 <xmx:19rbY0aq8zqqtka-7kiTHrJ44p__-GLVD9BPg7KtQWcqPoEqc0gUtg>
 <xmx:19rbYyYohu3RT26eAzaU-gUC3yC_gRxIYfnmOoEtWIm156qtgWFMew>
 <xmx:19rbY7B4Xez7n8EuVpi7Ezc-UQRQXk_yOIMVshdx79DRgLQJ8-vpdw>
Feedback-ID: i4629427b:Fastmail
Received: by mailuser.nyi.internal (Postfix, from userid 501)
 id 3D2AF2D40074; Thu,  2 Feb 2023 10:46:31 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.9.0-alpha0-107-g82c3c54364-fm-20230131.002-g82c3c543
Mime-Version: 1.0
Message-Id: <81E109CF-91D3-412A-87FC-2839ABFF4788@HIDDEN>
In-Reply-To: <83o7qdz4lh.fsf@HIDDEN>
References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
 <87wn53iq99.fsf@HIDDEN> <83o7qe1rbi.fsf@HIDDEN> <87ilgmmoj3.fsf@HIDDEN>
 <83wn51zfkh.fsf@HIDDEN>
 <180e1ab1-287c-451b-bd43-6b858638df2f@HIDDEN>
 <83o7qdz4lh.fsf@HIDDEN>
Date: Thu, 02 Feb 2023 15:46:09 +0000
From: "Mark Bestley" <gnu@HIDDEN>
Content-Type: multipart/alternative; boundary=c5a1985d9225444190cdb22a8fb32c52
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--c5a1985d9225444190cdb22a8fb32c52
Content-Type: text/plain

 * 

> On 1 Feb 2023, at 17:18, Eli Zaretskii <eliz@HIDDEN> wrote:
> 
>> Date: Wed, 01 Feb 2023 14:11:13 +0000
>> From: "Mark Bestley" <gnu@HIDDEN>
>> Cc: 61188 <at> debbugs.gnu.org
>> 
>>> So I guess the current behavior is the intended one, and we should
>>> close this bug as wontfix?
>> 
>> No - I think the way 28.2 worked was correct. (for impact see highlight-indent.el which now does not work with a black background )
> 
> But by changing the tests to match what Emacs does now we explicitly
> said that we disagree, and that the current behavior is the correct
> one.
> 
>> What is the expected value of (color-lighten-name  "Black" 100) as I don't know where that test is. I would think the test is wrong. Did it run for 28.2?
> 
> The test is in test/lisp/color-tests.el.  The expected value is
> exactly what you said is wrong.
> 
>> Surely lightening Black fully should give white
> 
> How so?  The 100 is the percentage of the present luminance, and if
> that is zero, why do you expect it to become lighter?
> 
> See also the discussion in bug#54514, which was exactly about that.

I don't see a discussion there.
But I do understand and accept the rationale for changing * color-lighten-hsl*



> 
>> In 30 olor-lighten-name  "Black" of any positive value gives Black - surely this cannot be correct.
> 
> A zero multiplied by any percentage stays zero, no?  If you want a
> non-zero result, start with something close to black, but not actually
> black.
The issue is more with color-lighten-name and the use it has in highlight-indent.el
Here the background colour is increased or darkened so that a new background is  distinguishable from the original and it does that via varying the hue. In those terms increasing the hue from black to shades of grey and 100% takes you to white makes sense.

So just multiplying hue may not give the expected result here, The old reasoning for color-by-name might make some sense but I don't think we have the rationale why that was chosen.

So I understand why then change was made but I think that there will be broken code around which used color-lighten-name when emacs 29 is released.

Basically manipulation of coper values is more complex than at first thought.

I'll report this issue to highlight-indent.el and I think this bug can be closed,
--c5a1985d9225444190cdb22a8fb32c52
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><ul><li style=3D"fon=
t-family:georgia, serif;font-size:1.266em;"><br></li></ul><div class=3D"=
AppleOriginalContents" style=3D"direction:ltr;"><div><br></div><blockquo=
te type=3D"cite"><div>On 1 Feb 2023, at 17:18, Eli Zaretskii &lt;eliz@gn=
u.org&gt; wrote:<br></div><div><br></div><div><div><blockquote type=3D"c=
ite"><div>Date: Wed, 01 Feb 2023 14:11:13 +0000<br></div><div>From: "Mar=
k Bestley" &lt;gnu@HIDDEN&gt;<br></div><div>Cc: 61188@HIDDEN=
.org<br></div><div><br></div><blockquote type=3D"cite"><div>So I guess t=
he current behavior is the intended one, and we should<br></div><div>clo=
se this bug as wontfix?<br></div></blockquote><div><br></div><div>No - I=
 think the way 28.2 worked was correct. (for impact see highlight-indent=
.el which now does not work with a black background )<br></div></blockqu=
ote><div><br></div><div>But by changing the tests to match what Emacs do=
es now we explicitly<br></div><div>said that we disagree, and that the c=
urrent behavior is the correct<br></div><div>one.<br></div><div><br></di=
v><blockquote type=3D"cite">What is the expected value of (color-lighten=
-name &nbsp;"Black" 100) as I don't know where that test is. I would thi=
nk the test is wrong. Did it run for 28.2?<br></blockquote><div><br></di=
v><div>The test is in test/lisp/color-tests.el. &nbsp;The expected value=
 is<br></div><div>exactly what you said is wrong.<br></div><div><br></di=
v><blockquote type=3D"cite">Surely lightening Black fully should give wh=
ite<br></blockquote><div><br></div><div>How so? &nbsp;The 100 is the per=
centage of the present luminance, and if<br></div><div>that is zero, why=
 do you expect it to become lighter?<br></div><div><br></div><div>See al=
so the discussion in bug#54514, which was exactly about that.<br></div><=
/div></div></blockquote><div class=3D"AppleOriginalContents" style=3D"di=
rection:ltr;"><br></div><div class=3D"AppleOriginalContents" style=3D"di=
rection:ltr;">I don't see a discussion there.<br></div><div class=3D"App=
leOriginalContents" style=3D"direction:ltr;">But I do understand and acc=
ept the rationale for changing&nbsp;<i style=3D"color:#000000;"> color-l=
ighten-hsl</i><br></div><div class=3D"AppleOriginalContents" style=3D"di=
rection:ltr;"><br></div><div class=3D"AppleOriginalContents" style=3D"di=
rection:ltr;"><br></div><div><br></div><blockquote type=3D"cite"><div><d=
iv><div><br></div><blockquote type=3D"cite">In 30 olor-lighten-name &nbs=
p;"Black" of any positive value gives Black - surely this cannot be corr=
ect.<br></blockquote><div><br></div><div>A zero multiplied by any percen=
tage stays zero, no? &nbsp;If you want a<br></div><div>non-zero result, =
start with something close to black, but not actually<br></div><div>blac=
k.<br></div></div></div></blockquote></div><div class=3D"AppleOriginalCo=
ntents" style=3D"direction:ltr;">The issue is more with color-lighten-na=
me and the use it has in highlight-indent.el<br></div><div class=3D"Appl=
eOriginalContents" style=3D"direction:ltr;">Here the background colour i=
s increased or darkened so that a new background is &nbsp;distinguishabl=
e from the original and it does that via varying the hue. In those terms=
 increasing the hue from black to shades of grey and 100% takes you to w=
hite makes sense.<br></div><div class=3D"AppleOriginalContents" style=3D=
"direction:ltr;"><br></div><div class=3D"AppleOriginalContents" style=3D=
"direction:ltr;">So just multiplying hue may not give the expected resul=
t here, The old reasoning for color-by-name might make some sense but I =
don't think we have the rationale why that was chosen.<br></div><div cla=
ss=3D"AppleOriginalContents" style=3D"direction:ltr;"><br></div><div cla=
ss=3D"AppleOriginalContents" style=3D"direction:ltr;">So I understand wh=
y then change was made but I think that there will be broken code around=
 which used&nbsp;<span style=3D"color:#000000;">color-lighten-name when =
emacs 29 is released.</span><br></div><div class=3D"AppleOriginalContent=
s" style=3D"direction:ltr;"><span style=3D"color:#000000;"></span><br></=
div><div class=3D"AppleOriginalContents" style=3D"direction:ltr;"><span =
class=3D"color" style=3D"color:#000000;"><span style=3D"">Basically mani=
pulation of&nbsp;coper values is more complex than at first thought.</sp=
an></span><br></div><div class=3D"AppleOriginalContents" style=3D"direct=
ion:ltr;"><span class=3D"color" style=3D"color:#000000;"><span style=3D"=
"></span></span><br></div><div class=3D"AppleOriginalContents" style=3D"=
direction:ltr;"><span class=3D"color" style=3D"color:#000000;"><span sty=
le=3D"">I'll report this issue to highlight-indent.el and I think this b=
ug can be closed,</span></span><br></div></body></html>
--c5a1985d9225444190cdb22a8fb32c52--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
Resent-From: "Mark Bestley" <gnu@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 02 Feb 2023 18:34:01 +0000
Resent-Message-ID: <handler.61188.B61188.167536280119395 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 61188
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: "Eli Zaretskii" <eliz@HIDDEN>
Cc: Stephen Berman <stephen.berman@HIDDEN>, 61188 <at> debbugs.gnu.org
Received: via spool by 61188-submit <at> debbugs.gnu.org id=B61188.167536280119395
          (code B ref 61188); Thu, 02 Feb 2023 18:34:01 +0000
Received: (at 61188) by debbugs.gnu.org; 2 Feb 2023 18:33:21 +0000
Received: from localhost ([127.0.0.1]:35803 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pNeOe-00052l-TL
	for submit <at> debbugs.gnu.org; Thu, 02 Feb 2023 13:33:21 -0500
Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:46021)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gnu@HIDDEN>) id 1pNeOc-00052P-Eh
 for 61188 <at> debbugs.gnu.org; Thu, 02 Feb 2023 13:33:19 -0500
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id 9DA10320090F;
 Thu,  2 Feb 2023 13:33:11 -0500 (EST)
Received: from imap43 ([10.202.2.93])
 by compute3.internal (MEProxy); Thu, 02 Feb 2023 13:33:11 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bestley.co.uk;
 h=cc:cc:content-type:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to; s=fm2; t=1675362791; x=1675449191; bh=TG
 kNwq/Q8i6HP1IgnVelWBKhGHmaSpCJ/YAH+VQvkhw=; b=IMQSGrNtb2OXcmBK7F
 UbcgNQDoU/5wZoMLJLbUB5l5YSEgocUpO9l3FflE2YFf9vlI1K6oeQ2es7tb2bpa
 djEHZSesBJllHGUklKXQTi4laVDLi2+t7ffO+UIvWzY0jAdvKgOxZQo2YubvNVVD
 +eAPtA5/DH7TShn9bNybmDI0jer4sHJZqIbVQaPMUtEU3kKZqFqgirFrLxIC7H7Z
 DPyC10itReKGYpJ7rZFv5EHgmkqa3cjG+btVCXFyZKWhvWW9q7dC9/Op/efKULCi
 0qD5Iey1fZUvIwlGMkF3koCawFXXqCBJbBxOTVG8zRWuZE84WYaFetiHLtxBO7YJ
 WyRQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
 :feedback-id:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:sender:subject:subject:to:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm3; t=1675362791; x=1675449191; bh=TGkNwq/Q8i6HP1IgnVelWBKhGHma
 SpCJ/YAH+VQvkhw=; b=OztlVvjYJ4bjBp1WBLhL3Xw+AdZGq9idi7aTFlVb+T2f
 6khBlWUobwCc/evD2NPKFKrpjB3NzXF0S/MilYzdmVBHgVTCCULYQWPQaJMV/xgq
 El8a+BEWsQOBj3+9ulepJOI2DxF+xGOD6W9QzhW1lLmVlXWKR1NIuz1DfPeTYyKJ
 ZYsRDnFkM+YsSfcHRDfRVRImtHbtC9INAyMPF4Vrk1T729cqh6u/pFsHyJ3c7Pgv
 IewDyNAR0LZwt4lZIb3C9lIFSwX8jqGo055311fdfCmjZ94llrbyYmPSKcwXaUe4
 GxevLqGEkYMVM7UPDHThwO47vfcvnVMharvc0q9uOA==
X-ME-Sender: <xms:5wHcY2Jk6QHMgkKWYlal9pBa99iHa4MDNzIQa1q7h0Cqdl3k2dSH0Q>
 <xme:5wHcY-Ll3U5hB1JtnwQwsU86Ph1oFzaydbpD-7GI-CgMh0btx1ogafhB-j6d5dMsZ
 oZpCtnb7wAzG2YL>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedguddutdcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enhdfknhhvihhsihgslhgvucifohhrughsucdlhedtmdenucfjughrpefofgggkfgjfhff
 hffvvefutgesrgdtreerreertdenucfhrhhomhepfdforghrkhcuuegvshhtlhgvhidfuc
 eoghhnuhessggvshhtlhgvhidrtghordhukheqnecuggftrfgrthhtvghrnhepudejkeel
 jeethfejteffleegteevleejieeluefhueeileehvdffgfefheelgfeknecuvehluhhsth
 gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhnuhessggvshhtlhgv
 hidrtghordhukh
X-ME-Proxy: <xmx:5wHcY2tFvNA6t3qslXGnvZ7T3QwQCr4C752g4glKAm1-yaOxr0nKqg>
 <xmx:5wHcY7YcDxRLc-qRjgOZ60_TZFmtp3PAGvE_N7ygXCyyWYahGdM2CA>
 <xmx:5wHcY9aBRqYGfC0i6tAPOAoiruZMu1sh3vJvlEZ8Mw8_eG--HFN8Ow>
 <xmx:5wHcY-CEJn0t98NR7Y9819YZPQbYx3cF_-RzRiZLF49oFwcxt5SOjg>
Feedback-ID: i4629427b:Fastmail
Received: by mailuser.nyi.internal (Postfix, from userid 501)
 id F27352D40074; Thu,  2 Feb 2023 13:33:10 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.9.0-alpha0-107-g82c3c54364-fm-20230131.002-g82c3c543
Mime-Version: 1.0
Message-Id: <d2bb2995-2acf-4701-884e-58fecd3d347b@HIDDEN>
In-Reply-To: <81E109CF-91D3-412A-87FC-2839ABFF4788@HIDDEN>
References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
 <87wn53iq99.fsf@HIDDEN> <83o7qe1rbi.fsf@HIDDEN> <87ilgmmoj3.fsf@HIDDEN>
 <83wn51zfkh.fsf@HIDDEN>
 <180e1ab1-287c-451b-bd43-6b858638df2f@HIDDEN>
 <83o7qdz4lh.fsf@HIDDEN>
 <81E109CF-91D3-412A-87FC-2839ABFF4788@HIDDEN>
Date: Thu, 02 Feb 2023 18:32:50 +0000
From: "Mark Bestley" <gnu@HIDDEN>
Content-Type: multipart/alternative; boundary=d41d5634d4c6475fab3c23861bfab159
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--d41d5634d4c6475fab3c23861bfab159
Content-Type: text/plain



On Thu, 2 Feb 2023, at 15:46, Mark Bestley wrote:
>  * 
> 
>> On 1 Feb 2023, at 17:18, Eli Zaretskii <eliz@HIDDEN> wrote:
>> 
>>> Date: Wed, 01 Feb 2023 14:11:13 +0000
>>> From: "Mark Bestley" <gnu@HIDDEN>
>>> Cc: 61188 <at> debbugs.gnu.org
>>> 
>>>> So I guess the current behavior is the intended one, and we should
>>>> close this bug as wontfix?
>>> 
>>> No - I think the way 28.2 worked was correct. (for impact see highlight-indent.el which now does not work with a black background )
>> 
>> But by changing the tests to match what Emacs does now we explicitly
>> said that we disagree, and that the current behavior is the correct
>> one.
>> 
>>> What is the expected value of (color-lighten-name  "Black" 100) as I don't know where that test is. I would think the test is wrong. Did it run for 28.2?
>> 
>> The test is in test/lisp/color-tests.el.  The expected value is
>> exactly what you said is wrong.
>> 
>>> Surely lightening Black fully should give white
>> 
>> How so?  The 100 is the percentage of the present luminance, and if
>> that is zero, why do you expect it to become lighter?
>> 
>> See also the discussion in bug#54514, which was exactly about that.
> 
> I don't see a discussion there.
> But I do understand and accept the rationale for changing * color-lighten-hsl*
> 
> 
> 
>> 
>>> In 30 olor-lighten-name  "Black" of any positive value gives Black - surely this cannot be correct.
>> 
>> A zero multiplied by any percentage stays zero, no?  If you want a
>> non-zero result, start with something close to black, but not actually
>> black.
> The issue is more with color-lighten-name and the use it has in highlight-indent.el
> Here the background colour is increased or darkened so that a new background is  distinguishable from the original and it does that via varying the hue. In those terms increasing the hue from black to shades of grey and 100% takes you to white makes sense.
> 
> So just multiplying hue may not give the expected result here, The old reasoning for color-by-name might make some sense but I don't think we have the rationale why that was chosen.
> 
> So I understand why then change was made but I think that there will be broken code around which used color-lighten-name when emacs 29 is released.
> 
> Basically manipulation of coper values is more complex than at first thought.
> 
> I'll report this issue to highlight-indent.el and I think this bug can be closed,
Sorry for the further post 

I looked at the old tests for color-lighten-hsl and see their rationale.

The old code added the percentage change to the hue the new code multiplies by the change.
So their is rationale to that but the comment for the function is not exact enough.
--
Mark



--d41d5634d4c6475fab3c23861bfab159
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div style=3D"f=
ont-family:georgia, serif;font-size:1.266em;"><br></div><div style=3D"fo=
nt-family:georgia, serif;font-size:1.266em;"><br></div><div>On Thu, 2 Fe=
b 2023, at 15:46, Mark Bestley wrote:<br></div><blockquote type=3D"cite"=
 id=3D"qt" style=3D""><ul><li style=3D"font-family:georgia, serif;font-s=
ize:1.266em;"><br></li></ul><div class=3D"qt-AppleOriginalContents" styl=
e=3D"direction:ltr;"><div><br></div><blockquote type=3D"cite"><div>On 1 =
Feb 2023, at 17:18, Eli Zaretskii &lt;eliz@HIDDEN&gt; wrote:<br></div><=
div><br></div><div><div><blockquote type=3D"cite"><div>Date: Wed, 01 Feb=
 2023 14:11:13 +0000<br></div><div>From: "Mark Bestley" &lt;gnu@bestley.=
co.uk&gt;<br></div><div>Cc: 61188 <at> debbugs.gnu.org<br></div><div><br></di=
v><blockquote type=3D"cite"><div>So I guess the current behavior is the =
intended one, and we should<br></div><div>close this bug as wontfix?<br>=
</div></blockquote><div><br></div><div>No - I think the way 28.2 worked =
was correct. (for impact see highlight-indent.el which now does not work=
 with a black background )<br></div></blockquote><div><br></div><div>But=
 by changing the tests to match what Emacs does now we explicitly<br></d=
iv><div>said that we disagree, and that the current behavior is the corr=
ect<br></div><div>one.<br></div><div><br></div><blockquote type=3D"cite"=
>What is the expected value of (color-lighten-name &nbsp;"Black" 100) as=
 I don't know where that test is. I would think the test is wrong. Did i=
t run for 28.2?<br></blockquote><div><br></div><div>The test is in test/=
lisp/color-tests.el. &nbsp;The expected value is<br></div><div>exactly w=
hat you said is wrong.<br></div><div><br></div><blockquote type=3D"cite"=
>Surely lightening Black fully should give white<br></blockquote><div><b=
r></div><div>How so? &nbsp;The 100 is the percentage of the present lumi=
nance, and if<br></div><div>that is zero, why do you expect it to become=
 lighter?<br></div><div><br></div><div>See also the discussion in bug#54=
514, which was exactly about that.<br></div></div></div></blockquote><di=
v class=3D"qt-AppleOriginalContents" style=3D"direction:ltr;"><br></div>=
<div class=3D"qt-AppleOriginalContents" style=3D"direction:ltr;">I don't=
 see a discussion there.<br></div><div class=3D"qt-AppleOriginalContents=
" style=3D"direction:ltr;">But I do understand and accept the rationale =
for changing&nbsp;<i style=3D"color:rgb(0, 0, 0);"> color-lighten-hsl</i=
><br></div><div class=3D"qt-AppleOriginalContents" style=3D"direction:lt=
r;"><br></div><div class=3D"qt-AppleOriginalContents" style=3D"direction=
:ltr;"><br></div><div><br></div><blockquote type=3D"cite"><div><div><div=
><br></div><blockquote type=3D"cite">In 30 olor-lighten-name &nbsp;"Blac=
k" of any positive value gives Black - surely this cannot be correct.<br=
></blockquote><div><br></div><div>A zero multiplied by any percentage st=
ays zero, no? &nbsp;If you want a<br></div><div>non-zero result, start w=
ith something close to black, but not actually<br></div><div>black.<br><=
/div></div></div></blockquote></div><div class=3D"qt-AppleOriginalConten=
ts" style=3D"direction:ltr;">The issue is more with color-lighten-name a=
nd the use it has in highlight-indent.el<br></div><div class=3D"qt-Apple=
OriginalContents" style=3D"direction:ltr;">Here the background colour is=
 increased or darkened so that a new background is &nbsp;distinguishable=
 from the original and it does that via varying the hue. In those terms =
increasing the hue from black to shades of grey and 100% takes you to wh=
ite makes sense.<br></div><div class=3D"qt-AppleOriginalContents" style=3D=
"direction:ltr;"><br></div><div class=3D"qt-AppleOriginalContents" style=
=3D"direction:ltr;">So just multiplying hue may not give the expected re=
sult here, The old reasoning for color-by-name might make some sense but=
 I don't think we have the rationale why that was chosen.<br></div><div =
class=3D"qt-AppleOriginalContents" style=3D"direction:ltr;"><br></div><d=
iv class=3D"qt-AppleOriginalContents" style=3D"direction:ltr;">So I unde=
rstand why then change was made but I think that there will be broken co=
de around which used&nbsp;<span style=3D"color:rgb(0, 0, 0);">color-ligh=
ten-name when emacs 29 is released.</span><br></div><div class=3D"qt-App=
leOriginalContents" style=3D"direction:ltr;"><span style=3D"color:rgb(0,=
 0, 0);"></span><br></div><div class=3D"qt-AppleOriginalContents" style=3D=
"direction:ltr;"><span class=3D"qt-color" style=3D"color:rgb(0, 0, 0);">=
<span style=3D"">Basically manipulation of&nbsp;coper values is more com=
plex than at first thought.</span></span><br></div><div class=3D"qt-Appl=
eOriginalContents" style=3D"direction:ltr;"><span class=3D"qt-color" sty=
le=3D"color:rgb(0, 0, 0);"><span style=3D""></span></span><br></div><div=
 class=3D"qt-AppleOriginalContents" style=3D"direction:ltr;"><span class=
=3D"qt-color" style=3D"color:rgb(0, 0, 0);"><span style=3D"">I'll report=
 this issue to highlight-indent.el and I think this bug can be closed,</=
span></span><br></div></blockquote><div style=3D"font-style:normal;font-=
variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:sta=
rt;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0=
px;-webkit-text-stroke-width:0px;text-decoration-line:none;color:rgb(255=
, 255, 255);font-family:Helvetica;font-size:12px;">Sorry for the further=
 post&nbsp;<br></div><div style=3D"font-style:normal;font-variant-caps:n=
ormal;font-weight:400;letter-spacing:normal;text-align:start;text-indent=
:0px;text-transform:none;white-space:normal;word-spacing:0px;-webkit-tex=
t-stroke-width:0px;text-decoration-line:none;color:rgb(255, 255, 255);fo=
nt-family:Helvetica;font-size:12px;"><br></div><div style=3D"font-style:=
normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;te=
xt-align:start;text-indent:0px;text-transform:none;white-space:normal;wo=
rd-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;c=
olor:rgb(255, 255, 255);font-family:Helvetica;font-size:12px;">I looked =
at the old tests for&nbsp;color-lighten-hsl and see their rationale.<br>=
</div><div style=3D"font-style:normal;font-variant-caps:normal;font-weig=
ht:400;letter-spacing:normal;text-align:start;text-indent:0px;text-trans=
form:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:=
0px;text-decoration-line:none;color:rgb(255, 255, 255);font-family:Helve=
tica;font-size:12px;"><br></div><div style=3D"font-style:normal;font-var=
iant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;=
text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;=
-webkit-text-stroke-width:0px;text-decoration-line:none;color:rgb(255, 2=
55, 255);font-family:Helvetica;font-size:12px;">The old code added the p=
ercentage change to the hue the new code multiplies by the change.<br></=
div><div style=3D"font-style:normal;font-variant-caps:normal;font-weight=
:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transfo=
rm:none;white-space:normal;word-spacing:0px;-webkit-text-stroke-width:0p=
x;text-decoration-line:none;color:rgb(255, 255, 255);font-family:Helveti=
ca;font-size:12px;">So their is rationale to that but the comment for th=
e function is not exact enough.<br></div><div id=3D"sig64320496"><div cl=
ass=3D"signature">--<br></div><div class=3D"signature">Mark<br></div><di=
v class=3D"signature"><br></div><div class=3D"signature"><br></div></div=
><div style=3D"font-family:georgia, serif;font-size:1.266em;"><br></div>=
</body></html>
--d41d5634d4c6475fab3c23861bfab159--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
In-Reply-To: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@HIDDEN>
Resent-From: Bernd Rellermeyer <bernd.rellermeyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 21 Feb 2023 13:38:02 +0000
Resent-Message-ID: <handler.61188.B61188.167698664019526 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 61188
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: 61188 <at> debbugs.gnu.org
Received: via spool by 61188-submit <at> debbugs.gnu.org id=B61188.167698664019526
          (code B ref 61188); Tue, 21 Feb 2023 13:38:02 +0000
Received: (at 61188) by debbugs.gnu.org; 21 Feb 2023 13:37:20 +0000
Received: from localhost ([127.0.0.1]:55023 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pUSpb-00054l-K0
	for submit <at> debbugs.gnu.org; Tue, 21 Feb 2023 08:37:20 -0500
Received: from mailout03.t-online.de ([194.25.134.81]:57062)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bernd.rellermeyer@HIDDEN>) id 1pUSNu-0003gA-L7
 for 61188 <at> debbugs.gnu.org; Tue, 21 Feb 2023 08:08:43 -0500
Received: from fwd84.dcpf.telekom.de (fwd84.aul.t-online.de [10.223.144.110])
 by mailout03.t-online.de (Postfix) with SMTP id 25F881C8F0
 for <61188 <at> debbugs.gnu.org>; Tue, 21 Feb 2023 14:08:41 +0100 (CET)
Received: from smtpclient.apple ([62.216.210.159]) by fwd84.t-online.de
 with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted)
 esmtp id 1pUSNs-1WS1Wz0; Tue, 21 Feb 2023 14:08:40 +0100
From: Bernd Rellermeyer <bernd.rellermeyer@HIDDEN>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\))
Message-Id: <287452D8-472C-49A3-8253-BAD01119C3E3@HIDDEN>
Date: Tue, 21 Feb 2023 14:08:29 +0100
X-Mailer: Apple Mail (2.3731.400.51.1.1)
X-TOI-EXPURGATEID: 150726::1676984920-511B9A0B-8AFA4725/0/0 CLEAN NORMAL
X-TOI-MSGID: 7693a2cc-fe59-490e-ab91-e17e3709f779
X-Spam-Score: -0.7 (/)
X-Mailman-Approved-At: Tue, 21 Feb 2023 08:37:15 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

I am not happy with the new implementation of color-lighten-hsl. I think =
the old implementation was correc. In my opinion there is a =
misunderstanding about the argument percent. The value L itself is a =
percentage, ranging from 0.0 to 1.0, and the argument percent is a =
percentage point to add to the percentage L (divided by 100). E.g. if L =
is 0.5 and percent is 10, the result should be 0.6 and not 0.5 * 1.1 =3D =
0.55. In the case of the black color, the result should be 0.0 + 0.1 =3D =
0.1. That is because percent is a percentage point and not a percentage.

I would suggest to switch back to the old implementation.=

Last modified: Tue, 21 Feb 2023 13:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.