GNU bug report logs - #61223
29.0.60; treesit--install-language-grammar-build-recipe refers github

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61223 in the body.
You can then email your comments to 61223 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.60; treesit--install-language-grammar-build-recipe refers github
Date: Wed, 1 Feb 2023 22:17:56 -0800

X-Debbugs-CC: eliz <at> gnu.org, dgutov <at> yandex.ru
--text follows this line--
I noticed that treesit-install-language-grammar now automatically builds
the repository url from github:

(let ((repo-default (format "https://github.com/tree-sitter/tree-sitter-%s" lang)))
         (read-string
          "Enter the URL of the Git repository of the language grammar: "
          (and (treesit--check-repo-url repo-default) repo-default)))


AFAICT GNU don’t want to promote/refer to github, that’s why I didn’t
include “official” grammar repositories in
treesit-language-source-alist. Was there a discussion that I missed?

This is a nice feature, but I’d hate having to remove it later, after
users have noticed it and started using/depending on it, due to some GNU
policy.

Yuan

Message #8 received at 61223 <at> debbugs.gnu.org (full text, mbox):

From: Ruijie Yu <ruijie <at> netyu.xyz>
To: Yuan Fu <casouri <at> gmail.com>
Cc: eliz <at> gnu.org, 61223 <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#61223: 29.0.60;
 treesit--install-language-grammar-build-recipe refers github
Date: Thu, 2 Feb 2023 16:41:10 +0800

On Feb 2, 2023, at 14:19, Yuan Fu <casouri <at> gmail.com> wrote:
> 
> X-Debbugs-CC: eliz <at> gnu.org, dgutov <at> yandex.ru
> --text follows this line--
> I noticed that treesit-install-language-grammar now automatically builds
> the repository url from github:
> 
> (let ((repo-default (format "https://github.com/tree-sitter/tree-sitter-%s" lang)))
>      (read-string
>       "Enter the URL of the Git repository of the language grammar: "
>       (and (treesit--check-repo-url repo-default) repo-default)))
> 
> 
> AFAICT GNU don’t want to promote/refer to github, that’s why I didn’t
> include “official” grammar repositories in
> treesit-language-source-alist. Was there a discussion that I missed?
> 
> This is a nice feature, but I’d hate having to remove it later, after
> users have noticed it and started using/depending on it, due to some GNU
> policy.
> 
> Yuan

Hello Yuan, 

I think this is the result of installing the proposed patch from bug#61051, which Eli approved and Dmitry installed.  I had my doubts on the github reference but didn’t ask back then. 

Best, 


RY

Message #11 received at 61223 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 61223 <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#61223: 29.0.60;
 treesit--install-language-grammar-build-recipe refers github
Date: Thu, 02 Feb 2023 11:03:05 +0200

> Cc: eliz <at> gnu.org, dgutov <at> yandex.ru
> From: Yuan Fu <casouri <at> gmail.com>
> Date: Wed, 1 Feb 2023 22:17:56 -0800
> 
> I noticed that treesit-install-language-grammar now automatically builds
> the repository url from github:
> 
> (let ((repo-default (format "https://github.com/tree-sitter/tree-sitter-%s" lang)))
>          (read-string
>           "Enter the URL of the Git repository of the language grammar: "
>           (and (treesit--check-repo-url repo-default) repo-default)))
> 
> 
> AFAICT GNU don’t want to promote/refer to github, that’s why I didn’t
> include “official” grammar repositories in
> treesit-language-source-alist. Was there a discussion that I missed?
> 
> This is a nice feature, but I’d hate having to remove it later, after
> users have noticed it and started using/depending on it, due to some GNU
> policy.

I don't see a problem here: it's just the default we offer when a
grammar is available from the Tree-sitter site.  It's a far cry from
having a database full of GitHub URLs that we'd need to maintain and
keep up to date.

Message #14 received at 61223 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61223-done <at> debbugs.gnu.org, 61223 <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#61223: 29.0.60;
 treesit--install-language-grammar-build-recipe refers github
Date: Thu, 2 Feb 2023 18:40:21 -0800

> Hello Yuan, 
> 
> I think this is the result of installing the proposed patch from bug#61051, which Eli approved and Dmitry installed.  I had my doubts on the github reference but didn’t ask back then. 
> 
> Best, 
> 
> 
> RY

> On Feb 2, 2023, at 1:03 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> I don't see a problem here: it's just the default we offer when a
> grammar is available from the Tree-sitter site.  It's a far cry from
> having a database full of GitHub URLs that we'd need to maintain and
> keep up to date.

That’s very good news :-) Closing.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.