GNU bug report logs - #61231
30.0.50; treesit-induce-sparse-tree: rename LIMIT to DEPTH

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61231 in the body.
You can then email your comments to 61231 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mickey Petersen <mickey <at> masteringemacs.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; treesit-induce-sparse-tree: rename LIMIT to DEPTH
Date: Thu, 02 Feb 2023 16:02:48 +0000

Minor thing, really, but I think we should rename LIMIT to DEPTH.

LIMIT has a rather specific meaning to me when it comes to graph
theory. It implies a stop search after a certain number is reached.

Here, it really means *depth*; that is, the tree will cease to scan
once it has reached a certain depth in the node tree, as opposed to
having reached its limit on matches.




In GNU Emacs 30.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version
 3.24.20, cairo version 1.16.0) of 2023-01-25 built on mickey-work
Repository revision: 8b87d095acfb23b527f955873a59dd9c13ffc9b4
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Ubuntu 20.04.3 LTS

Configured using:
 'configure --with-native-compilation --with-json --with-mailutils
 --without-compress-install --with-imagemagick CC=gcc-10'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ
IMAGEMAGICK JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2
M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP
SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE
XIM XINPUT2 XPM GTK3 ZLIB

Message #8 received at 61231 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Mickey Petersen <mickey <at> masteringemacs.org>
Cc: 61231 <at> debbugs.gnu.org
Subject: Re: bug#61231: 30.0.50; treesit-induce-sparse-tree: rename LIMIT to 
 DEPTH
Date: Sun, 5 Feb 2023 20:43:39 -0800

Mickey Petersen <mickey <at> masteringemacs.org> writes:

> Minor thing, really, but I think we should rename LIMIT to DEPTH.
>
> LIMIT has a rather specific meaning to me when it comes to graph
> theory. It implies a stop search after a certain number is reached.

I’ll take your word for it ;-)

> Here, it really means *depth*; that is, the tree will cease to scan
> once it has reached a certain depth in the node tree, as opposed to
> having reached its limit on matches.

Sure, I can change LIMIT to DEPTH.

Yuan

Message #13 received at 61231-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Mickey Petersen <mickey <at> masteringemacs.org>
Cc: 61231-done <at> debbugs.gnu.org
Subject: Re: bug#61231: 30.0.50; treesit-induce-sparse-tree: rename LIMIT to 
 DEPTH
Date: Thu, 9 Feb 2023 23:29:21 -0800

Yuan Fu <casouri <at> gmail.com> writes:

> Mickey Petersen <mickey <at> masteringemacs.org> writes:
>
>> Minor thing, really, but I think we should rename LIMIT to DEPTH.
>>
>> LIMIT has a rather specific meaning to me when it comes to graph
>> theory. It implies a stop search after a certain number is reached.
>
> I’ll take your word for it ;-)
>
>> Here, it really means *depth*; that is, the tree will cease to scan
>> once it has reached a certain depth in the node tree, as opposed to
>> having reached its limit on matches.
>
> Sure, I can change LIMIT to DEPTH.
>
> Yuan

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.