GNU bug report logs - #61245
29.0.60; Should c-ts-mode-set-style be local by default?

Previous Next

Package: emacs;

Reported by: Yuan Fu <casouri <at> gmail.com>

Date: Fri, 3 Feb 2023 02:46:02 UTC

Severity: normal

Found in version 29.0.60

Fixed in version 29.1

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61245 in the body.
You can then email your comments to 61245 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#61245; Package emacs. (Fri, 03 Feb 2023 02:46:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Yuan Fu <casouri <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 03 Feb 2023 02:46:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.60; Should c-ts-mode-set-style be local by default?
Date: Thu, 2 Feb 2023 18:45:31 -0800


Normally this sort of function only affect the current buffer.
c-set-style only sets the style for the current buffer, too. I wonder if
we should make c-ts-mode-set-style default to local, too?

Yuan
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61245; Package emacs. (Fri, 03 Feb 2023 07:42:01 GMT) Full text and rfc822 format available.

Message #8 received at 61245 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 61245 <at> debbugs.gnu.org
Subject: Re: bug#61245: 29.0.60;
 Should c-ts-mode-set-style be local by default?
Date: Fri, 03 Feb 2023 09:41:16 +0200

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Thu, 2 Feb 2023 18:45:31 -0800
> 
> Normally this sort of function only affect the current buffer.
> c-set-style only sets the style for the current buffer, too. I wonder if
> we should make c-ts-mode-set-style default to local, too?

Yes, the style is a buffer-local setting.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61245; Package emacs. (Sat, 04 Feb 2023 23:35:02 GMT) Full text and rfc822 format available.

Message #11 received at 61245 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61245 <at> debbugs.gnu.org
Subject: Re: bug#61245: 29.0.60; Should c-ts-mode-set-style be local by
 default?
Date: Sat, 4 Feb 2023 15:34:14 -0800


> On Feb 2, 2023, at 11:41 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Thu, 2 Feb 2023 18:45:31 -0800
>> 
>> Normally this sort of function only affect the current buffer.
>> c-set-style only sets the style for the current buffer, too. I wonder if
>> we should make c-ts-mode-set-style default to local, too?
> 
> Yes, the style is a buffer-local setting.

Ok, I pushed a change that made c-ts-mode-set-style buffer-local, and added c-ts-mode-set-global-style.

Yuan
bug marked as fixed in version 29.1, send any further explanations to 61245 <at> debbugs.gnu.org and Yuan Fu <casouri <at> gmail.com> Request was from Yuan Fu <casouri <at> gmail.com> to control <at> debbugs.gnu.org. (Mon, 06 Feb 2023 00:11:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 06 Mar 2023 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 51 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.