GNU bug report logs - #61256
master; Function `vc-find-revision-no-save' leaks buffers in case of errors

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61256 in the body.
You can then email your comments to 61256 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Farblos" <AKFKQU.9DF7RP <at> vodafonemail.de>
To: bug-gnu-emacs <at> gnu.org
Subject: master;
 Function `vc-find-revision-no-save' leaks buffers in case of errors
Date: Fri, 03 Feb 2023 17:24:45 +0100

I haven't actually a test case for this issue but found it by
re-indenting function `vc-find-revision-no-save'.  When doing so you
will notice that the following sexps (indented as in the original code)
are actually both UNWINDFORMS:

		(setq failed nil)
	    (when (and failed (unless buffer (get-file-buffer filename)))
	      (with-current-buffer (get-file-buffer filename)
		(set-buffer-modified-p nil))
	      (kill-buffer (get-file-buffer filename)))

Meaning that the failure-handling `when' will never be eval'ed.  I guess
this is a copy-and-paste error and the (setq failed nil) should be
rather placed in the preceeding (with-current-buffer ...).

Probably not a big deal but not hard to fix, either...

Message #8 received at 61256 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: "Farblos" <AKFKQU.9DF7RP <at> vodafonemail.de>
Cc: 61256 <at> debbugs.gnu.org
Subject: Re: bug#61256: master; Function `vc-find-revision-no-save' leaks
 buffers in case of errors
Date: Sun, 05 Feb 2023 20:24:35 +0200

close 61256 29.0.60
thanks

> I haven't actually a test case for this issue but found it by
> re-indenting function `vc-find-revision-no-save'.  When doing so you
> will notice that the following sexps (indented as in the original code)
> are actually both UNWINDFORMS:
>
> 		(setq failed nil)
> 	    (when (and failed (unless buffer (get-file-buffer filename)))
> 	      (with-current-buffer (get-file-buffer filename)
> 		(set-buffer-modified-p nil))
> 	      (kill-buffer (get-file-buffer filename)))
>
> Meaning that the failure-handling `when' will never be eval'ed.  I guess
> this is a copy-and-paste error and the (setq failed nil) should be
> rather placed in the preceeding (with-current-buffer ...).
>
> Probably not a big deal but not hard to fix, either...

Good catch, thanks.  Now fixed in emacs-29.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.