GNU bug report logs - #61292
define-public fontconfig vs. fontconfig-minimal as its name

Previous Next

To reply to this bug, email your comments to 61292 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Attila Lendvai <attila <at> lendvai.name>
To: "bug-guix <at> gnu.org" <bug-guix <at> gnu.org>
Subject: define-public fontconfig vs. fontconfig-minimal as its name
Date: Sun, 05 Feb 2023 11:43:27 +0000

(define-public fontconfig
[...]
     (name "fontconfig-minimal")

this tripped me up. is this a mistake?

if not, then please add a comment that explains this anomaly.

-- 
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“We're all going to die, all of us, what a circus! That alone should make us love each other but it doesn't. We are terrorized and flattened by trivialities, we are eaten up by nothing.”
	— Charles Bukowski (1920–1994)

Message #8 received at 61292 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Attila Lendvai <attila <at> lendvai.name>
Cc: 61292 <at> debbugs.gnu.org
Subject: Re: bug#61292: define-public fontconfig vs. fontconfig-minimal as
 its name
Date: Wed, 15 Feb 2023 22:24:48 -0500

Hi,

Attila Lendvai <attila <at> lendvai.name> writes:

> (define-public fontconfig
> [...]
>      (name "fontconfig-minimal")
>
> this tripped me up. is this a mistake?
>
> if not, then please add a comment that explains this anomaly.

There's already a comment above fontconfig-with-documentation that
reads:

  This is intentionally named 'fontconfig', as it's intended as the
  user-facing fontconfig package

The original fontconfig was renamed fontconfig-minimal but the variable
was not renamed to avoid having to adjust the rest of the code base.  It
could be done, and then the fontconfig-with-documentation *variable*
could be renamed to simply fontconfig.

That'd be more conventional.

Would you like to give it a try?  It shouldn't cause any rebuild, I
think.

-- 
Thanks,
Maxim

Message #11 received at 61292 <at> debbugs.gnu.org (full text, mbox):

From: Attila Lendvai <attila <at> lendvai.name>
To: "61292 <at> debbugs.gnu.org" <61292 <at> debbugs.gnu.org>
Subject: fontconfig -> fontconfig-minimal
Date: Thu, 03 Aug 2023 15:32:44 +0000

close 61292
stop

i started doing the rename of the variable, but the change quickly grew extensive, so i gave up. it's probably not worth the trouble.

there are 332 grep matches, and the majority requries a change.

-- 
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“Beware the stories you read or tell; subtly, at night, beneath the waters of consciousness, they are altering your world.”
	— Ben Okri (1959–)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.