GNU bug report logs - #61305
[PATCH 0/2] Rewrite ast->string

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: skribilo; Reported by: Arun Isaac <arunisaac@HIDDEN>; Keywords: patch; dated Mon, 6 Feb 2023 00:02:01 UTC; Maintainer for skribilo is skribilo-bugs@HIDDEN.

Message received at 61305 <at> debbugs.gnu.org:


Received: (at 61305) by debbugs.gnu.org; 6 Feb 2023 00:03:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 05 19:03:20 2023
Received: from localhost ([127.0.0.1]:46729 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pOoye-0006oC-Dn
	for submit <at> debbugs.gnu.org; Sun, 05 Feb 2023 19:03:20 -0500
Received: from mugam.systemreboot.net ([139.59.75.54]:44866)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arunisaac@HIDDEN>) id 1pOoyc-0006ns-D0
 for 61305 <at> debbugs.gnu.org; Sun, 05 Feb 2023 19:03:19 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type:
 MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
 :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:
 Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:
 List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=JvJmc9BzUHJLvCLI0oVreFbplSlHyShmdnw9bs/oOrg=; b=Q4bSDL3DgCiVze4sZiwYEB0tY7
 1+QnEWUdAkwPNHp1GmpeffLOS/LTAC7lz2AEdEpgXKJas93tc9Q6JVvPqEXEHA5vxedpKCH8Hx0+R
 qKaeVsu4W1FwuZ7HNAHDwh1m9hXZWxHWCxjXrHAyjoBrl881kyTeozDeXJy3gLthalXkSMkAjoqXZ
 Par/yOs0E12otMRjB+LKZMjyFiRRKbEYAp+/0nk5gCo3/v2ksRr3kocZfxZsuxfYRxch1bYScImsJ
 WiKXAPl6wypnjGLzvjYajuEL0x27I5wVmkKU01HNjsaGaDoZGbPQuPlfVvlEJvikXk9Nly6AccKS2
 ycX/WsQg==;
Received: from [192.168.2.1] (port=58014 helo=steel.lan)
 by systemreboot.net with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <arunisaac@HIDDEN>) id 1pOoya-0004Aw-0Q;
 Mon, 06 Feb 2023 05:33:16 +0530
From: Arun Isaac <arunisaac@HIDDEN>
To: 61305 <at> debbugs.gnu.org
Subject: [PATCH 2/2] ast: Rewrite ast->string using string-join.
Date: Mon,  6 Feb 2023 00:03:09 +0000
Message-Id: <20230206000309.31293-2-arunisaac@HIDDEN>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20230206000309.31293-1-arunisaac@HIDDEN>
References: <20230206000309.31293-1-arunisaac@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 61305
Cc: Arun Isaac <arunisaac@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* src/guile/skribilo/ast.scm (ast->string): Rewrite using string-join.
---
 src/guile/skribilo/ast.scm | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/src/guile/skribilo/ast.scm b/src/guile/skribilo/ast.scm
index 4a39ebf..003619f 100644
--- a/src/guile/skribilo/ast.scm
+++ b/src/guile/skribilo/ast.scm
@@ -3,6 +3,7 @@
 ;;; Copyright 2003, 2004, 2009  Erick Gallesio - I3S-CNRS/ESSI <eg@HIDDEN>
 ;;; Copyright 2003, 2004  Manuel Serrano
 ;;; Copyright 2005, 2006, 2007, 2012, 2013, 2015, 2018  Ludovic Courtès <ludo@HIDDEN>
+;;; Copyright 2023 Arun Isaac <arunisaac@HIDDEN>
 ;;;
 ;;;
 ;;; This file is part of Skribilo.
@@ -206,16 +207,7 @@
 (define-method (ast->string (ast <number>))  (number->string ast))
 
 (define-method (ast->string (ast <pair>))
-  (let ((out (open-output-string)))
-    (let Loop ((lst ast))
-      (cond
-	((null? lst)
-	   (get-output-string out))
-	(else
-	   (display (ast->string (car lst)) out)
-	   (unless (null? (cdr lst))
-	     (display #\space out))
-	   (Loop (cdr lst)))))))
+  (string-join (map ast->string ast)))
 
 
 
-- 
2.38.1
Information forwarded to skribilo-bugs@HIDDEN:
bug#61305; Package skribilo. Full text available.

Message received at 61305 <at> debbugs.gnu.org:


Received: (at 61305) by debbugs.gnu.org; 6 Feb 2023 00:03:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 05 19:03:19 2023
Received: from localhost ([127.0.0.1]:46727 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pOoyc-0006nz-U1
	for submit <at> debbugs.gnu.org; Sun, 05 Feb 2023 19:03:19 -0500
Received: from mugam.systemreboot.net ([139.59.75.54]:46322)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arunisaac@HIDDEN>) id 1pOoyb-0006np-1u
 for 61305 <at> debbugs.gnu.org; Sun, 05 Feb 2023 19:03:18 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type:
 MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=ZQOv88Eq6ENtMr33R+dFs5EUidYsffN1eZSyhgjs/K0=; b=aiYrVL41VFxHGTe4cBfOFBaCFl
 jDXwUH5vaM+NHgww0co7FrqaRvCCDDOL7dOwVq0MJKP96M+wn4Op+b9PYqEeSAvzNwoJYynd2Fv60
 ThUY0K07o44sSFeTAalnxCUCVLl2qwiDYNbnaqwWxu486iVav9dpASwJXSq7Oy4HrUuLa9g8Xj/jf
 VmH/EPcaz2u6TWmYpPZ9HvGpVudwamDitly0czW7PzYQcZjBpsGcoC09R2EMu/EiVRHUaXOxDLFYW
 KeuXCL0uYiLpJo+gI8+3i32d3rx3gaxhO3UJdtSIbzT5VTfpU8R2UmsQnz3rAxmpwYeFz1J2J4MdP
 7JTt3TZQ==;
Received: from [192.168.2.1] (port=58014 helo=steel.lan)
 by systemreboot.net with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <arunisaac@HIDDEN>) id 1pOoyX-0004Aw-2K;
 Mon, 06 Feb 2023 05:33:14 +0530
From: Arun Isaac <arunisaac@HIDDEN>
To: 61305 <at> debbugs.gnu.org
Subject: [PATCH 1/2] tests: Test ast->string.
Date: Mon,  6 Feb 2023 00:03:08 +0000
Message-Id: <20230206000309.31293-1-arunisaac@HIDDEN>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 61305
Cc: Arun Isaac <arunisaac@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* tests/ast.test ("ast->string"): New test.
---
 tests/ast.test | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/ast.test b/tests/ast.test
index 1110faf..ed09bb0 100644
--- a/tests/ast.test
+++ b/tests/ast.test
@@ -1,6 +1,7 @@
 ;;; Excercise the AST routines.                  -*- Scheme -*-
 ;;;
 ;;; Copyright (C) 2009, 2012, 2021  Ludovic Courtès <ludo@HIDDEN>
+;;; Copyright (C) 2023 Arun Isaac <arunisaac@HIDDEN>
 ;;;
 ;;; This file is part of Skribilo.
 ;;;
@@ -64,6 +65,10 @@
                        (null? (cdr body))))))
          (null? (cdr body)))))
 
+(test-equal "ast->string"
+  "Blah."
+  (ast->string (document #:title "Foo" (chapter #:title "Bar" "Blah."))))
+
 (test-assert "`find-down' returns the empty list"
   (let* ((doc (document (chapter (section)) (chapter (section))))
          (lst (find-down (lambda (n) (is-markup? n 'chapter)) doc)))
-- 
2.38.1
Information forwarded to skribilo-bugs@HIDDEN:
bug#61305; Package skribilo. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 6 Feb 2023 00:01:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 05 19:01:14 2023
Received: from localhost ([127.0.0.1]:46721 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pOowc-0006kk-Fl
	for submit <at> debbugs.gnu.org; Sun, 05 Feb 2023 19:01:14 -0500
Received: from lists.gnu.org ([209.51.188.17]:52818)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arunisaac@HIDDEN>) id 1pOowb-0006kd-Dw
 for submit <at> debbugs.gnu.org; Sun, 05 Feb 2023 19:01:13 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <arunisaac@HIDDEN>)
 id 1pOowa-0001jt-Ho
 for skribilo-bugs@HIDDEN; Sun, 05 Feb 2023 19:01:13 -0500
Received: from mugam.systemreboot.net ([139.59.75.54])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <arunisaac@HIDDEN>)
 id 1pOowU-0005Q6-VM
 for skribilo-bugs@HIDDEN; Sun, 05 Feb 2023 19:01:11 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version:
 Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=M0QJ1UvIk3qIqrYtkaXonshYeg3nhWgm3oobdl6oLjo=; b=h9VuZ3xYch+iqVIONZ+zLPHtCd
 58PS9D6tuuBqZyChVsN8PxGb64T7QLwk9UIsFkYnBj7JZyObkJHS6CSJpPPst3AUSGq2mAZyBKfbo
 kSVGymkogv+ZFOjZ61f6FUAcOgCxgWXVIOYwi0cFCjqOifB8pryovvG9VmDdKPMrTs1dTRr8vo/JN
 q0wDOQeRqal6Bc8o7sdb5qcaqkLh4Bqcw6JHdgEjaePHZM1POt9dgru355gRV9j/h1xzac0o0a4mY
 Qckvli0eTplZqfAmZBswye5SsmXNvYm6L0H2ZH1bfGZF6JzxRs5EXDS1HmrL5e4BWMSqu6am5aDP+
 yKIaOnEA==;
Received: from [192.168.2.1] (port=45130 helo=steel.lan)
 by systemreboot.net with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <arunisaac@HIDDEN>) id 1pOowM-0004Ab-0U;
 Mon, 06 Feb 2023 05:30:58 +0530
From: Arun Isaac <arunisaac@HIDDEN>
To: skribilo-bugs@HIDDEN
Subject: [PATCH 0/2] Rewrite ast->string
Date: Mon,  6 Feb 2023 00:00:49 +0000
Message-Id: <20230206000049.30724-1-arunisaac@HIDDEN>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=139.59.75.54;
 envelope-from=arunisaac@HIDDEN; helo=mugam.systemreboot.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: Arun Isaac <arunisaac@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

This patchset adds a test for ast->string and rewrites it as a
one-liner using string-join.

Arun Isaac (2):
  tests: Test ast->string.
  ast: Rewrite ast->string using string-join.

 src/guile/skribilo/ast.scm | 12 ++----------
 tests/ast.test             |  5 +++++
 2 files changed, 7 insertions(+), 10 deletions(-)

-- 
2.38.1
Acknowledgement sent to Arun Isaac <arunisaac@HIDDEN>:
New bug report received and forwarded. Copy sent to skribilo-bugs@HIDDEN. Full text available.
Report forwarded to skribilo-bugs@HIDDEN:
bug#61305; Package skribilo. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 6 Feb 2023 00:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.