GNU bug report logs - #61320
28.2; `vc-cvs-parse-root' returns wrong results

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61320 in the body.
You can then email your comments to 61320 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Farblos" <AKFKQU.9DF7RP <at> vodafonemail.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.2; `vc-cvs-parse-root' returns wrong results
Date: Mon, 06 Feb 2023 13:43:44 +0100

This reproduces also in master.

Not sure why nobody has reported this.  Most likely because the current
callers of `vc-cvs-parse-root' care only about some aspects of the
actual result of `vc-cvs-parse-root'.

$ emacs -Q

In scratch buffer evaluate the following (specification of Ctrl-J
omitted for clarity):

(load-library "vc-cvs")
t

;; this one is correct in the sense that 3rd element of the list is nil
;; (making it a local root for `vc-cvs-repository-hostname'), but
;; probably is not what the author has intended:
(vc-cvs-parse-root ":local:/var/lib/cvs")
("local" nil nil "var:/lib/cvs")

;; but this one is completely broken:
(vc-cvs-parse-root "/var/lib/cvs")
("ext" nil "var" "/lib/cvs")

There might be different fixes, but IMHO the regexp used in function
`vc-cvs-parse-uhp' should be anchored to beginning of line or string:

  "\\`\\([^/]+\\)\\(/.*\\)"

Message #8 received at 61320 <at> debbugs.gnu.org (full text, mbox):

From: Farblos <akfkqu.9df7rp <at> vodafonemail.de>
To: 61320 <at> debbugs.gnu.org
Subject: `vc-cvs-parse-root' returns wrong results
Date: Fri, 12 May 2023 22:48:46 +0200

Fixed in master:

M-x emacs-version RET

GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, 
cairo version 1.16.0) of 2023-05-12

(vc-cvs-parse-root ":local:/var/lib/cvs")
("local" nil nil "/var/lib/cvs")

(vc-cvs-parse-root "/var/lib/cvs")
("local" nil nil "/var/lib/cvs")

Feel free to close this issue.

Message #13 received at 61320-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Farblos <akfkqu.9df7rp <at> vodafonemail.de>
Cc: 61320-done <at> debbugs.gnu.org
Subject: Re: bug#61320: `vc-cvs-parse-root' returns wrong results
Date: Sat, 13 May 2023 09:04:22 +0300

> Date: Fri, 12 May 2023 22:48:46 +0200
> From:  Farblos via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Fixed in master:
> 
> M-x emacs-version RET
> 
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, 
> cairo version 1.16.0) of 2023-05-12
> 
> (vc-cvs-parse-root ":local:/var/lib/cvs")
> ("local" nil nil "/var/lib/cvs")
> 
> (vc-cvs-parse-root "/var/lib/cvs")
> ("local" nil nil "/var/lib/cvs")
> 
> Feel free to close this issue.

Thanks, done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.