GNU bug report logs - #61360
[PATCH] gnu: gimp: Don't retain reference on GCC.

Previous Next

Package: guix-patches;

Reported by: iyzsong <at> envs.net

Date: Wed, 8 Feb 2023 07:10:02 UTC

Severity: normal

Tags: patch

Done: 宋文武 <iyzsong <at> envs.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61360 in the body.
You can then email your comments to 61360 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#61360; Package guix-patches. (Wed, 08 Feb 2023 07:10:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to iyzsong <at> envs.net:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 08 Feb 2023 07:10:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> envs.net
To: guix-patches <at> gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH] gnu: gimp: Don't retain reference on GCC.
Date: Wed,  8 Feb 2023 15:09:30 +0800
From: 宋文武 <iyzsong <at> member.fsf.org>

Partly fixes <https://issues.guix.gnu.org/57677>.

* gnu/packages/gimp.scm (gimp)[arguments]: Add #:modules and #:phases.
---
 gnu/packages/gimp.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/gimp.scm b/gnu/packages/gimp.scm
index beb43f0ae2..69281f98e9 100644
--- a/gnu/packages/gimp.scm
+++ b/gnu/packages/gimp.scm
@@ -302,6 +302,19 @@ (define-public gimp
                "doc"))                  ; 9 MiB of gtk-doc HTML
     (arguments
      (list
+      #:modules `((ice-9 popen)
+                  (ice-9 rdelim)
+                  ,@%gnu-build-system-modules)
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'remove-gcc-reference
+            ;; Avoid reference to GCC.
+            (lambda _
+              (let* ((port (open-input-pipe "gcc -v 2>&1 | tail -n 1"))
+                     (cc-version (read-line port)))
+                (close-pipe port)
+                (substitute* "app/gimp-version.c"
+                  (("CC_VERSION") (string-append "\"" cc-version "\"")))))))
       #:configure-flags
       #~(list (string-append "--with-html-dir=" #$output "/share/gtk-doc/html")
 
-- 
2.39.1





Information forwarded to guix-patches <at> gnu.org:
bug#61360; Package guix-patches. (Wed, 01 Mar 2023 09:49:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: iyzsong <at> envs.net
Cc: 宋文武 <iyzsong <at> member.fsf.org>, guix-patches <at> gnu.org,
 61360 <at> debbugs.gnu.org
Subject: Re: [bug#61360] [PATCH] gnu: gimp: Don't retain reference on GCC.
Date: Wed, 01 Mar 2023 09:48:05 +0000
[Message part 1 (text/plain, inline)]
iyzsong--- via Guix-patches via <guix-patches <at> gnu.org> writes:

> From: 宋文武 <iyzsong <at> member.fsf.org>
>
> Partly fixes <https://issues.guix.gnu.org/57677>.
>
> * gnu/packages/gimp.scm (gimp)[arguments]: Add #:modules and #:phases.
> ---
>  gnu/packages/gimp.scm | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

I don't quite get what's going on here, but it seems good to push.

Thanks,

Chris
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#61360; Package guix-patches. (Wed, 01 Mar 2023 09:49:02 GMT) Full text and rfc822 format available.

Reply sent to 宋文武 <iyzsong <at> envs.net>:
You have taken responsibility. (Thu, 02 Mar 2023 03:45:01 GMT) Full text and rfc822 format available.

Notification sent to iyzsong <at> envs.net:
bug acknowledged by developer. (Thu, 02 Mar 2023 03:45:02 GMT) Full text and rfc822 format available.

Message #16 received at 61360-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 61360-done <at> debbugs.gnu.org, iyzsong <at> member.fsf.org
Subject: Re: bug#61360: [PATCH] gnu: gimp: Don't retain reference on GCC.
Date: Thu, 02 Mar 2023 11:44:39 +0800
Christopher Baines <mail <at> cbaines.net> writes:

> iyzsong--- via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> From: 宋文武 <iyzsong <at> member.fsf.org>
>>
>> Partly fixes <https://issues.guix.gnu.org/57677>.
>>
>> * gnu/packages/gimp.scm (gimp)[arguments]: Add #:modules and #:phases.
>> ---
>>  gnu/packages/gimp.scm | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>
> I don't quite get what's going on here, but it seems good to push.
>

Pushed, thank you!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 30 Mar 2023 11:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 364 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.