GNU bug report logs - #61366
[PATCH] ; Add usage, will not continue if no parameters are provided.

Previous Next

Package: emacs;

Reported by: Xi Lu <lx <at> shellcodes.org>

Date: Wed, 8 Feb 2023 10:02:02 UTC

Severity: normal

Tags: patch

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61366 in the body.
You can then email your comments to 61366 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#61366; Package emacs. (Wed, 08 Feb 2023 10:02:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Xi Lu <lx <at> shellcodes.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 08 Feb 2023 10:02:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xi Lu <lx <at> shellcodes.org>
To: bug-gnu-emacs <at> gnu.org
Cc: Xi Lu <lx <at> shellcodes.org>
Subject: [PATCH] ; Add usage, will not continue if no parameters are provided.
Date: Wed,  8 Feb 2023 18:00:49 +0800
---
 admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/admin/notes/tree-sitter/build-module/build.sh b/admin/notes/tree-sitter/build-module/build.sh
index 9dc674237ca..08a71c1dde1 100755
--- a/admin/notes/tree-sitter/build-module/build.sh
+++ b/admin/notes/tree-sitter/build-module/build.sh
@@ -3,6 +3,12 @@
 lang=$1
 topdir="$PWD"
 
+if [ $# -lt 1 ]
+then
+    echo "Usage: $0 <language>"
+    exit
+fi
+
 case $(uname) in
     "Darwin")
         soext="dylib"
-- 
2.39.1





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61366; Package emacs. (Sat, 18 Feb 2023 15:28:02 GMT) Full text and rfc822 format available.

Message #8 received at 61366 <at> debbugs.gnu.org (full text, mbox):

From: lux <lx <at> shellcodes.org>
To: 61366 <at> debbugs.gnu.org
Subject: Re: bug#61366: [PATCH] ; Add usage, will not continue if no
 parameters are provided.
Date: Sat, 18 Feb 2023 23:27:34 +0800
Xi Lu <lx <at> shellcodes.org> writes:

> ---
>  admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/admin/notes/tree-sitter/build-module/build.sh b/admin/notes/tree-sitter/build-module/build.sh
> index 9dc674237ca..08a71c1dde1 100755
> --- a/admin/notes/tree-sitter/build-module/build.sh
> +++ b/admin/notes/tree-sitter/build-module/build.sh
> @@ -3,6 +3,12 @@
>  lang=$1
>  topdir="$PWD"
>  
> +if [ $# -lt 1 ]
> +then
> +    echo "Usage: $0 <language>"
> +    exit
> +fi
> +
>  case $(uname) in
>      "Darwin")
>          soext="dylib"

This patch need to review. If not give the `language' paramter, some
errors will be printed.

IMHO, Can the batch.sh and build.sh merge to one shell file?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61366; Package emacs. (Sun, 19 Mar 2023 03:58:02 GMT) Full text and rfc822 format available.

Message #11 received at 61366 <at> debbugs.gnu.org (full text, mbox):

From: lux <lx <at> shellcodes.org>
To: 61366 <at> debbugs.gnu.org
Cc: casouri <at> gmail.com
Subject: Re: bug#61366: [PATCH] ; Add usage, will not continue if no
 parameters are provided.
Date: Sun, 19 Mar 2023 11:57:06 +0800
On Sat, 2023-02-18 at 23:27 +0800, lux wrote:
> Xi Lu <lx <at> shellcodes.org> writes:
> 
> > ---
> >  admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/admin/notes/tree-sitter/build-module/build.sh
> > b/admin/notes/tree-sitter/build-module/build.sh
> > index 9dc674237ca..08a71c1dde1 100755
> > --- a/admin/notes/tree-sitter/build-module/build.sh
> > +++ b/admin/notes/tree-sitter/build-module/build.sh
> > @@ -3,6 +3,12 @@
> >  lang=$1
> >  topdir="$PWD"
> >  
> > +if [ $# -lt 1 ]
> > +then
> > +    echo "Usage: $0 <language>"
> > +    exit
> > +fi
> > +
> >  case $(uname) in
> >      "Darwin")
> >          soext="dylib"
> 
> This patch need to review. If not give the `language' paramter, some
> errors will be printed.
> 
> IMHO, Can the batch.sh and build.sh merge to one shell file?

Hi, Yuan Fu, Can you help to look this issue?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61366; Package emacs. (Sun, 19 Mar 2023 06:06:02 GMT) Full text and rfc822 format available.

Message #14 received at 61366 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: lux <lx <at> shellcodes.org>
Cc: 61366 <at> debbugs.gnu.org, casouri <at> gmail.com
Subject: Re: bug#61366: [PATCH] ;
 Add usage, will not continue if no parameters are provided.
Date: Sun, 19 Mar 2023 08:05:46 +0200
> Cc: casouri <at> gmail.com
> From: lux <lx <at> shellcodes.org>
> Date: Sun, 19 Mar 2023 11:57:06 +0800
> 
> On Sat, 2023-02-18 at 23:27 +0800, lux wrote:
> > Xi Lu <lx <at> shellcodes.org> writes:
> > 
> > > ---
> > >  admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/admin/notes/tree-sitter/build-module/build.sh
> > > b/admin/notes/tree-sitter/build-module/build.sh
> > > index 9dc674237ca..08a71c1dde1 100755
> > > --- a/admin/notes/tree-sitter/build-module/build.sh
> > > +++ b/admin/notes/tree-sitter/build-module/build.sh
> > > @@ -3,6 +3,12 @@
> > >  lang=$1
> > >  topdir="$PWD"
> > >  
> > > +if [ $# -lt 1 ]
> > > +then
> > > +    echo "Usage: $0 <language>"
> > > +    exit
> > > +fi
> > > +
> > >  case $(uname) in
> > >      "Darwin")
> > >          soext="dylib"
> > 
> > This patch need to review. If not give the `language' paramter, some
> > errors will be printed.
> > 
> > IMHO, Can the batch.sh and build.sh merge to one shell file?
> 
> Hi, Yuan Fu, Can you help to look this issue?

I don't see a point, as I'm going to delete these scripts very soon.
They did their job and are no longer needed in our repository.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61366; Package emacs. (Sun, 19 Mar 2023 06:14:01 GMT) Full text and rfc822 format available.

Message #17 received at 61366 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: lx <at> shellcodes.org
Cc: 61366 <at> debbugs.gnu.org, casouri <at> gmail.com
Subject: Re: bug#61366: [PATCH] ;
 Add usage, will not continue if no parameters are provided.
Date: Sun, 19 Mar 2023 08:13:53 +0200
> Cc: 61366 <at> debbugs.gnu.org, casouri <at> gmail.com
> Date: Sun, 19 Mar 2023 08:05:46 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > Hi, Yuan Fu, Can you help to look this issue?
> 
> I don't see a point, as I'm going to delete these scripts very soon.

Now done.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61366; Package emacs. (Sun, 19 Mar 2023 07:13:02 GMT) Full text and rfc822 format available.

Message #20 received at 61366 <at> debbugs.gnu.org (full text, mbox):

From: lux <lx <at> shellcodes.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61366 <at> debbugs.gnu.org, casouri <at> gmail.com
Subject: Re: bug#61366: [PATCH] ; Add usage, will not continue if no
 parameters are provided.
Date: Sun, 19 Mar 2023 15:11:49 +0800
On Sun, 2023-03-19 at 08:13 +0200, Eli Zaretskii wrote:
> > Cc: 61366 <at> debbugs.gnu.org, casouri <at> gmail.com
> > Date: Sun, 19 Mar 2023 08:05:46 +0200
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > 
> > > Hi, Yuan Fu, Can you help to look this issue?
> > 
> > I don't see a point, as I'm going to delete these scripts very
> > soon.
> 
> Now done.
> 
> 
> 

Ok, thank you.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61366; Package emacs. (Sun, 19 Mar 2023 07:54:02 GMT) Full text and rfc822 format available.

Message #23 received at 61366 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: lux <lx <at> shellcodes.org>
Cc: 61366 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: Re: bug#61366: [PATCH] ; Add usage, will not continue if no 
 parameters are provided.
Date: Sun, 19 Mar 2023 00:53:08 -0700
lux <lx <at> shellcodes.org> writes:

> On Sun, 2023-03-19 at 08:13 +0200, Eli Zaretskii wrote:
>> > Cc: 61366 <at> debbugs.gnu.org, casouri <at> gmail.com
>> > Date: Sun, 19 Mar 2023 08:05:46 +0200
>> > From: Eli Zaretskii <eliz <at> gnu.org>
>> > 
>> > > Hi, Yuan Fu, Can you help to look this issue?
>> > 
>> > I don't see a point, as I'm going to delete these scripts very
>> > soon.
>> 
>> Now done.
>> 
>> 
>> 
>
> Ok, thank you.

Sorry, I didn’t see this until now. If you have suggestions for the
build script, you can report those at

https://github.com/casouri/tree-sitter-module

Yuan




Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Fri, 01 Sep 2023 19:52:02 GMT) Full text and rfc822 format available.

Notification sent to Xi Lu <lx <at> shellcodes.org>:
bug acknowledged by developer. (Fri, 01 Sep 2023 19:52:02 GMT) Full text and rfc822 format available.

Message #28 received at 61366-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: lx <at> shellcodes.org, casouri <at> gmail.com, 61366-done <at> debbugs.gnu.org
Subject: Re: bug#61366: [PATCH] ; Add usage, will not continue if no
 parameters are provided.
Date: Fri, 1 Sep 2023 21:51:01 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

> > Cc: 61366 <at> debbugs.gnu.org, casouri <at> gmail.com
> > Date: Sun, 19 Mar 2023 08:05:46 +0200
> > From: Eli Zaretskii <eliz <at> gnu.org>
> >
> > > Hi, Yuan Fu, Can you help to look this issue?
> >
> > I don't see a point, as I'm going to delete these scripts very soon.
>
> Now done.

This bug was left open by accident, so I'm closing it now.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 30 Sep 2023 11:24:24 GMT) Full text and rfc822 format available.

This bug report was last modified 180 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.