GNU bug report logs - #61371
30.0.50; Adding support for jdt:// file scheme in eglot

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61371 in the body.
You can then email your comments to 61371 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Adding support for jdt:// file scheme in eglot
Date: Wed, 08 Feb 2023 20:09:40 +0100

Hi!

When using Eglot along with Java there are some hacks that needs to be
made to make things functional.  One of the more important things is to
add support for the jdt:// file scheme that is sent when you try to
go-to-definition on a system or third party lib.

For completeness sake - consider:

```
import java.util.Li|st;

public Foo {
  void foo() {
    List foo;
  }
}
```

Cursor is now where | is, and if you try to M-., you won't get far.
This is because jdtls uses a convoluted way to retrieve this information
on demand, see [0].  Now the client has to query the language server an
additional time to get the actual content, load it somewhere, _then_
goto-def.  I've created one such hack for my own config, but maybe this
is something that could be mainlined, even though eglot itself is trying
hard to be language agnostic?  I'm not sure the code needs to live in
eglot, it could live some place other file-handlers live, if such a
place exists.  Anyway, the code I use to fix this now looks like this:

```
(defclass eglot-java (eglot-lsp-server) ()
  :documentation "A custom class for Java")

(cl-defmethod eglot-execute-command
  ((_server eglot-java) (_cmd (eql java.apply.workspaceEdit)) arguments)
  "Eclipse JDT breaks spec and replies with edits as arguments."
  (mapc #'eglot--apply-workspace-edit arguments))

(cl-defmethod eglot-initialization-options ((server eglot-java))
  "Passes through required java initialization options"
  `( :settings ,eglot-java-config
     :workspaceFolders [,(eglot--path-to-uri (project-root (project-current)))]
     :extendedClientCapabilities (:classFileContentsSupport t)))

(defun jdt-file-name-handler (operation &rest args)
  "Support Eclipse jdtls `jdt://' uri scheme."
  (let* ((uri (car args))
         (cache-dir "/tmp/.eglot")
         (source-file
          (expand-file-name
           (file-name-concat
            cache-dir
            (save-match-data
              (when (string-match "jdt://contents/\\(.*?\\)/\\(.*\\)\.class\\?" uri)
                (format "%s.java" (replace-regexp-in-string "/" "." (match-string 2 uri) t t))))))))
    (unless (file-readable-p source-file)
      (let ((content (jsonrpc-request (eglot-current-server) :java/classFileContents (list :uri uri)))
            (metadata-file (format "%s.%s.metadata"
                                   (file-name-directory source-file)
                                   (file-name-base source-file))))
        (unless (file-directory-p cache-dir) (make-directory cache-dir t))
        (with-temp-file source-file (insert content))
        (with-temp-file metadata-file (insert uri))))
    source-file))

(add-to-list
 'eglot-server-programs
 `(java-mode . (eglot-java . ("jdtls"))))

(add-to-list
 'eglot-server-programs
 `(java-ts-mode . (eglot-java . ("jdtls"))))
```

As you can see, we need to query the server with
:java/classFileContents, and also register with the server to send it
with the :extendedClientCapabilities on initialization.

Is there a place this code could live? Maybe in the new java-ts-mode?

Theo

[0]: https://github.com/eclipse/eclipse.jdt.ls/issues/2322#issuecomment-1313953316

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife
 of text editors" <bug-gnu-emacs <at> gnu.org>
Cc: Theodor Thornhill <theo <at> thornhill.no>, 61371 <at> debbugs.gnu.org,
 Danny Freeman <danny <at> dfreeman.email>, joaotavora <at> gmail.com
Subject: Re: bug#61371: 30.0.50; Adding support for jdt:// file scheme in eglot
Date: Thu, 09 Feb 2023 10:47:17 +0100

Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife
of text editors" <bug-gnu-emacs <at> gnu.org> writes:

> Hi!

Hi Theo,

> When using Eglot along with Java there are some hacks that needs to be
> made to make things functional.  One of the more important things is to
> add support for the jdt:// file scheme that is sent when you try to
> go-to-definition on a system or third party lib.
>
> As you can see, we need to query the server with
> :java/classFileContents, and also register with the server to send it
> with the :extendedClientCapabilities on initialization.
>
> Is there a place this code could live? Maybe in the new java-ts-mode?

There is the jarchive package on GNU ELPA. Could this be used, perhaps extended?

> Theo

Best regards, Michael.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Michael Albinus <michael.albinus <at> gmx.de>, "Theodor Thornhill via Bug
 reports for GNU Emacs, the Swiss army knife
 of text editors" <bug-gnu-emacs <at> gnu.org>
Cc: 61371 <at> debbugs.gnu.org, Danny Freeman <danny <at> dfreeman.email>,
 joaotavora <at> gmail.com
Subject: Re: bug#61371: 30.0.50; Adding support for jdt:// file scheme in eglot
Date: Thu, 09 Feb 2023 11:42:37 +0100

Michael Albinus <michael.albinus <at> gmx.de> writes:

> Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife
> of text editors" <bug-gnu-emacs <at> gnu.org> writes:
>
>> Hi!
>
> Hi Theo,
>
>> When using Eglot along with Java there are some hacks that needs to be
>> made to make things functional.  One of the more important things is to
>> add support for the jdt:// file scheme that is sent when you try to
>> go-to-definition on a system or third party lib.
>>
>> As you can see, we need to query the server with
>> :java/classFileContents, and also register with the server to send it
>> with the :extendedClientCapabilities on initialization.
>>
>> Is there a place this code could live? Maybe in the new java-ts-mode?
>
> There is the jarchive package on GNU ELPA. Could this be used, perhaps extended?
>
>> Theo
>
> Best regards, Michael.

Maybe! Don't know what it does, but I'll check it out - thanks!

Theo

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Freeman <danny <at> dfreeman.email>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: "Theodor Thornhill via Bug reports for GNU Emacs,
 the Swiss army knife  of text editors" <bug-gnu-emacs <at> gnu.org>,
 Michael Albinus <michael.albinus <at> gmx.de>, 61371 <at> debbugs.gnu.org,
 joaotavora <at> gmail.com
Subject: Re: bug#61371: 30.0.50; Adding support for jdt:// file scheme in eglot
Date: Fri, 10 Feb 2023 15:32:30 -0500

Theodor Thornhill <theo <at> thornhill.no> writes:

> Michael Albinus <michael.albinus <at> gmx.de> writes:
>
>> Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife
>> of text editors" <bug-gnu-emacs <at> gnu.org> writes:
>>
>>> Hi!
>>
>> Hi Theo,
>>
>>> When using Eglot along with Java there are some hacks that needs to be
>>> made to make things functional.  One of the more important things is to
>>> add support for the jdt:// file scheme that is sent when you try to
>>> go-to-definition on a system or third party lib.
>>>
>>> As you can see, we need to query the server with
>>> :java/classFileContents, and also register with the server to send it
>>> with the :extendedClientCapabilities on initialization.
>>>
>>> Is there a place this code could live? Maybe in the new java-ts-mode?
>>
>> There is the jarchive package on GNU ELPA. Could this be used, perhaps extended?
>>
>>> Theo
>>
>> Best regards, Michael.
>
> Maybe! Don't know what it does, but I'll check it out - thanks!
>
> Theo

JDT urls are outside the scope of jarchive. I would think of them less
as URLs and more as tokens to be decoded by the LSP server that provides
them. JDT urls are intended to be sent back to the LSP server using a
special extension method.

There is an issue open in the eglot-java repo to implement this but I
have been too busy to get around to it
https://github.com/yveszoundi/eglot-java/issues/6

Someone has responded there with some code similar to jarchive that will
parse the JDT urls and try to open them, but I wouldn't consider that a
permanent solution. JDT urls are not standardized and subject to change
by the JDT LSP maintainers.

-- 
Danny Freeman

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Freeman <danny <at> dfreeman.email>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: "Theodor Thornhill via Bug reports for GNU Emacs,
 the Swiss army knife  of text editors" <bug-gnu-emacs <at> gnu.org>,
 Michael Albinus <michael.albinus <at> gmx.de>, 61371 <at> debbugs.gnu.org,
 joaotavora <at> gmail.com
Subject: Re: bug#61371: 30.0.50; Adding support for jdt:// file scheme in eglot
Date: Wed, 15 Feb 2023 13:05:30 -0500

Danny Freeman <danny <at> dfreeman.email> writes:

> Theodor Thornhill <theo <at> thornhill.no> writes:
>
>> Michael Albinus <michael.albinus <at> gmx.de> writes:
>>
>>> Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife
>>> of text editors" <bug-gnu-emacs <at> gnu.org> writes:
>>>
>>>> Hi!
>>>
>>> Hi Theo,
>>>
>>>> When using Eglot along with Java there are some hacks that needs to be
>>>> made to make things functional.  One of the more important things is to
>>>> add support for the jdt:// file scheme that is sent when you try to
>>>> go-to-definition on a system or third party lib.
>>>>
>>>> As you can see, we need to query the server with
>>>> :java/classFileContents, and also register with the server to send it
>>>> with the :extendedClientCapabilities on initialization.
>>>>
>>>> Is there a place this code could live? Maybe in the new java-ts-mode?
>>>
>>> There is the jarchive package on GNU ELPA. Could this be used, perhaps extended?
>>>
>>>> Theo
>>>
>>> Best regards, Michael.
>>
>> Maybe! Don't know what it does, but I'll check it out - thanks!
>>
>> Theo
>
> JDT urls are outside the scope of jarchive. I would think of them less
> as URLs and more as tokens to be decoded by the LSP server that provides
> them. JDT urls are intended to be sent back to the LSP server using a
> special extension method.
>
> There is an issue open in the eglot-java repo to implement this but I
> have been too busy to get around to it
> https://github.com/yveszoundi/eglot-java/issues/6
>
> Someone has responded there with some code similar to jarchive that will
> parse the JDT urls and try to open them, but I wouldn't consider that a
> permanent solution. JDT urls are not standardized and subject to change
> by the JDT LSP maintainers.

I think this bug can be closed now, it was fixed in the eglot-java
package. See: https://github.com/yveszoundi/eglot-java/issues/6

Thank you,
-- 
Danny Freeman

Message #32 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Danny Freeman <danny <at> dfreeman.email>
Cc: "Theodor Thornhill via Bug reports for GNU Emacs,
 the Swiss army knife  of text editors" <bug-gnu-emacs <at> gnu.org>,
 Michael Albinus <michael.albinus <at> gmx.de>, 61371 <at> debbugs.gnu.org,
 joaotavora <at> gmail.com
Subject: Re: bug#61371: 30.0.50; Adding support for jdt:// file scheme in eglot
Date: Wed, 15 Feb 2023 19:09:56 +0100

Danny Freeman <danny <at> dfreeman.email> writes:

> Danny Freeman <danny <at> dfreeman.email> writes:
>
>> Theodor Thornhill <theo <at> thornhill.no> writes:
>>
>>> Michael Albinus <michael.albinus <at> gmx.de> writes:
>>>
>>>> Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife
>>>> of text editors" <bug-gnu-emacs <at> gnu.org> writes:
>>>>
>>>>> Hi!
>>>>
>>>> Hi Theo,
>>>>
>>>>> When using Eglot along with Java there are some hacks that needs to be
>>>>> made to make things functional.  One of the more important things is to
>>>>> add support for the jdt:// file scheme that is sent when you try to
>>>>> go-to-definition on a system or third party lib.
>>>>>
>>>>> As you can see, we need to query the server with
>>>>> :java/classFileContents, and also register with the server to send it
>>>>> with the :extendedClientCapabilities on initialization.
>>>>>
>>>>> Is there a place this code could live? Maybe in the new java-ts-mode?
>>>>
>>>> There is the jarchive package on GNU ELPA. Could this be used, perhaps extended?
>>>>
>>>>> Theo
>>>>
>>>> Best regards, Michael.
>>>
>>> Maybe! Don't know what it does, but I'll check it out - thanks!
>>>
>>> Theo
>>
>> JDT urls are outside the scope of jarchive. I would think of them less
>> as URLs and more as tokens to be decoded by the LSP server that provides
>> them. JDT urls are intended to be sent back to the LSP server using a
>> special extension method.
>>
>> There is an issue open in the eglot-java repo to implement this but I
>> have been too busy to get around to it
>> https://github.com/yveszoundi/eglot-java/issues/6
>>
>> Someone has responded there with some code similar to jarchive that will
>> parse the JDT urls and try to open them, but I wouldn't consider that a
>> permanent solution. JDT urls are not standardized and subject to change
>> by the JDT LSP maintainers.
>
> I think this bug can be closed now, it was fixed in the eglot-java
> package. See: https://github.com/yveszoundi/eglot-java/issues/6
>
> Thank you,
> -- 
> Danny Freeman

I agree :-)

Message #40 received at 61371-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: michael.albinus <at> gmx.de, joaotavora <at> gmail.com,
 Danny Freeman <danny <at> dfreeman.email>, 61371-done <at> debbugs.gnu.org
Subject: Re: bug#61371: 30.0.50; Adding support for jdt:// file scheme in eglot
Date: Tue, 5 Sep 2023 17:05:01 -0700

Theodor Thornhill <theo <at> thornhill.no> writes:

>> I think this bug can be closed now, it was fixed in the eglot-java
>> package. See: https://github.com/yveszoundi/eglot-java/issues/6
>>
>> Thank you,
>> --
>> Danny Freeman
>
> I agree :-)

Thanks, closed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.